- Devel - libvirt List Archives

[PATCH] qemu: monitor: Remove disabled debug infrastructure
by Peter Krempa 03 Jan '22

03 Jan '22

Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_monitor.c | 44 ----------------------------------------- 1 file changed, 44 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index dda6ae9796..32e4ff1191 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -56,9 +56,6 @@ VIR_LOG_INIT("qemu.qemu_monitor"); -#define DEBUG_IO 0 -#define DEBUG_RAW_IO 0 - /* We read from QEMU until seeing a \r\n pair to indicate a * completed reply or event. To avoid memory denial-of-service * though, we must have a size limit on amount of data we @@ -210,25 +207,6 @@ VIR_ENUM_IMPL(qemuMonitorMemoryFailureAction, "ignore", "inject", "fatal", "reset"); -#if DEBUG_RAW_IO -static char * -qemuMonitorEscapeNonPrintable(const char *text) -{ - size_t i; - g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; - for (i = 0; text[i] != '\0'; i++) { - if (g_ascii_isprint(text[i]) || - text[i] == '\n' || - (text[i] == '\r' && text[i + 1] == '\n')) - virBufferAddChar(&buf, text[i]); - else - virBufferAsprintf(&buf, "0x%02x", text[i]); - } - return virBufferContentAndReset(&buf); -} -#endif - - static void qemuMonitorDispose(void *obj) { @@ -329,17 +307,6 @@ qemuMonitorIOProcess(qemuMonitor *mon) if (mon->msg && mon->msg->txOffset == mon->msg->txLength) msg = mon->msg; -#if DEBUG_IO -# if DEBUG_RAW_IO - char *str1 = qemuMonitorEscapeNonPrintable(msg ? msg->txBuffer : ""); - char *str2 = qemuMonitorEscapeNonPrintable(mon->buffer); - VIR_ERROR(_("Process %d %p %p [[[[%s]]][[[%s]]]"), (int)mon->bufferOffset, mon->msg, msg, str1, str2); - VIR_FREE(str1); - VIR_FREE(str2); -# else - VIR_DEBUG("Process %d", (int)mon->bufferOffset); -# endif -#endif PROBE_QUIET(QEMU_MONITOR_IO_PROCESS, "mon=%p buf=%s len=%zu", mon, mon->buffer, mon->bufferOffset); @@ -360,10 +327,6 @@ qemuMonitorIOProcess(qemuMonitor *mon) VIR_FREE(mon->buffer); mon->bufferOffset = mon->bufferLength = 0; } -#if DEBUG_IO - VIR_DEBUG("Process done %d used %d", (int)mon->bufferOffset, len); -#endif - /* As the monitor mutex was unlocked in qemuMonitorJSONIOProcess() * while dealing with qemu event, mon->msg could be changed which * means the above 'msg' may be invalid, thus we use 'mon->msg' here */ @@ -505,10 +468,6 @@ qemuMonitorIORead(qemuMonitor *mon) mon->buffer[mon->bufferOffset] = '\0'; } -#if DEBUG_IO - VIR_DEBUG("Now read %d bytes of data", (int)mon->bufferOffset); -#endif - return ret; } @@ -535,9 +494,6 @@ qemuMonitorIO(GSocket *socket G_GNUC_UNUSED, /* lock access to the monitor and protect fd */ virObjectLock(mon); -#if DEBUG_IO - VIR_DEBUG("Monitor %p I/O on socket %p cond %d", mon, socket, cond); -#endif if (mon->fd == -1 || !mon->watch) { virObjectUnlock(mon); virObjectUnref(mon); -- 2.31.1

2 1

CDROM hotplug not supported even with usb bus
by Tianren Zhang 03 Jan '22

03 Jan '22

Hi, I am using libvirt-4.5.0 + qemu-kvm-ev-2.12.0 and I have a question about the cdrom function of libvirt. When I tried to attach a CD ROM, it rejected the operation showing "cdrom/floppy device hotplug isn't supported". I understand that it should be rejected when the IDE bus is used, but the hotplug with USB bus is totally feasible, as it's also supported in qemu, in this case, should it be allowed for hotplug? I have not tried the newest version of libvirt yet, but looking at the upstream source code it seems that there is no change regarding this issue. Thank you, Tianren Zhang

2 1

[PATCH] virnettlscontext: Generate longer DH keys
by Michal Privoznik 03 Jan '22

03 Jan '22

Currently, we generate 2048 bits long DH keys. This may look enough, but it's not very future proof. When system crypto policy is tightened only 3072 or longer keys are valid. From CRYPTO-POLICIES(7): FUTURE A conservative security policy that is believed to withstand any near-term future attacks. ... • DH params size: >= 3072 • RSA keys size: >= 3072 This policy corresponds to GNUTLS_SEC_PARAM_HIGH parameters. Therefore, pass that to gnutls_sec_param_to_pk_bits() to get longer key. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Technically, this is a v2 of: https://listman.redhat.com/archives/libvir-list/2021-December/msg00827.html and was already reviewed. I'm sending it here because I've split the original patch into two. The first one, which switches to gnutls_sec_param_to_pk_bits() usage is merged. The second one (this one) which lengthens the key is not. src/rpc/virnettlscontext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rpc/virnettlscontext.c b/src/rpc/virnettlscontext.c index 55da485f96..f0b1e8f9c1 100644 --- a/src/rpc/virnettlscontext.c +++ b/src/rpc/virnettlscontext.c @@ -718,7 +718,7 @@ static virNetTLSContext *virNetTLSContextNew(const char *cacert, if (isServer) { unsigned int bits = 0; - bits = gnutls_sec_param_to_pk_bits(GNUTLS_PK_DH, GNUTLS_SEC_PARAM_MEDIUM); + bits = gnutls_sec_param_to_pk_bits(GNUTLS_PK_DH, GNUTLS_SEC_PARAM_HIGH); if (bits == 0) { virReportError(VIR_ERR_SYSTEM_ERROR, "%s", _("Unable to get key length for diffie-hellman parameters")); -- 2.34.1

2 1

[libvirt PATCH 0/3] tests: virtimetest: Skip more tests near year's end
by Andrea Bolognani 03 Jan '22

03 Jan '22

Failed pipeline: https://gitlab.com/libvirt/libvirt/-/pipelines/439750804 Fixed pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/439847251 Andrea Bolognani (3): tests: virtimetest: Move comment tests: virtimetest: Skip more tests near year's end tests: virtimetest: Mention GLib version containing fix tests/virtimetest.c | 58 ++++++++++++++++++++++----------------------- 1 file changed, 28 insertions(+), 30 deletions(-) -- 2.31.1

2 5

[libvirt PATCH] spec: Drop BuildRequires on ZFS
by Andrea Bolognani 03 Jan '22

03 Jan '22

We're no longer performing build time detection. Fixes: 506c3a39d6e645c8414c278ceaba97935f90cb95 Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- libvirt.spec.in | 6 ------ 1 file changed, 6 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 7bd74da2c9..9e24ba92ff 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -320,12 +320,6 @@ BuildRequires: glusterfs-devel >= 3.4.1 %if %{with_storage_sheepdog} BuildRequires: sheepdog %endif -%if %{with_storage_zfs} -# Support any conforming implementation of zfs. On stock Fedora -# this is zfs-fuse, but could be zfsonlinux upstream RPMs -BuildRequires: /sbin/zfs -BuildRequires: /sbin/zpool -%endif %if %{with_numactl} # For QEMU/LXC numa info BuildRequires: numactl-devel -- 2.31.1

2 1

[libvirt PATCH] meson: Don't require the parted command at build time
by Andrea Bolognani 03 Jan '22

03 Jan '22

We need libparted to be available at build time otherwise we can't link against it; we don't, however, need the parted command to be present until runtime and, just as is the case for other commands, we already perform a lookup through the virCommand API so making sure it's available at build time is unnecessary. This doesn't make any difference for platform such as Fedora and CentOS, where both the library and the command are in the same package, but others like Debian, Ubuntu and openSUSE have separate packages for the two components and this change means that we can install one less package at build time. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/437853370 meson.build | 8 -------- src/storage/storage_backend_disk.c | 2 ++ src/storage/storage_util.c | 2 ++ 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/meson.build b/meson.build index 57561adf51..be51af1934 100644 --- a/meson.build +++ b/meson.build @@ -1043,14 +1043,6 @@ endif libparted_version = '1.8.0' libparted_dep = dependency('libparted', version: '>=' + libparted_version, required: false) -if libparted_dep.found() - parted_prog = find_program('parted', required: false, dirs: libvirt_sbin_path) - if parted_prog.found() - conf.set_quoted('PARTED', parted_prog.path()) - else - libparted_dep = dependency('', required: false) - endif -endif libpcap_version = '1.5.0' if not get_option('libpcap').disabled() diff --git a/src/storage/storage_backend_disk.c b/src/storage/storage_backend_disk.c index 97554e2576..be8a535570 100644 --- a/src/storage/storage_backend_disk.c +++ b/src/storage/storage_backend_disk.c @@ -40,6 +40,8 @@ VIR_LOG_INIT("storage.storage_backend_disk"); #define SECTOR_SIZE 512 +#define PARTED "parted" + static bool virStorageVolPartFindExtended(virStorageVolDef *def, const void *opaque G_GNUC_UNUSED) diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c index 03874d6ca3..728710153e 100644 --- a/src/storage/storage_util.c +++ b/src/storage/storage_util.c @@ -85,6 +85,8 @@ VIR_LOG_INIT("storage.storage_util"); # define S_IRWXUGO (S_IRWXU | S_IRWXG | S_IRWXO) #endif +#define PARTED "parted" + /* virStorageBackendNamespaceInit: * @poolType: virStoragePoolType * @xmlns: Storage Pool specific namespace callback methods -- 2.31.1

2 1

how to change nic's tx/rx ring size inside vm
by longguang.yue 31 Dec '21

31 Dec '21

Hi, all: my environment is qemu-kvm-6.0.0, 4.18.0-240, libvirt 7.4.0. vm is configured like this queues='4' rx_queue_size='1024' tx_queue_size='1024'. inside vm i can not change nic's ring size. changing tx leads to error 'Cannot set device ring parameters: Operation not supported'. changing rx leads to error 'rx unmodified, ignoring. no ring parameters changed, aborting' how to make it work and confirm what current value is? thanks

1 1

[libvirt PATCH] spec: Demote netcat to Recommends
by Andrea Bolognani 24 Dec '21

24 Dec '21

It is only needed if compatibility with clients using libvirt 6.9.0 is required, and can be uninstalled otherwise. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- libvirt.spec.in | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 7bd74da2c9..0180b4200c 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -402,8 +402,12 @@ Summary: Server side daemon and supporting files for libvirt library # The client side, i.e. shared libs are in a subpackage Requires: %{name}-libs = %{version}-%{release} -# (client invokes 'nc' against the UNIX socket on the server) -Requires: /usr/bin/nc +# netcat is needed on the server side so that clients that have +# libvirt < 6.9.0 can connect, but newer versions will prefer +# virt-ssh-helper. Making this a Recommends means that it gets +# installed by default, but can still be removed if compatibility +# with old clients is not required +Recommends: /usr/bin/nc # for modprobe of pci devices Requires: module-init-tools -- 2.31.1

2 1

[PATCH] docs: Fix indentation in shell snippet
by Andrea Bolognani 24 Dec '21

24 Dec '21

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. docs/daemons.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/daemons.rst b/docs/daemons.rst index 8a05ee77a7..c8ae3b0cef 100644 --- a/docs/daemons.rst +++ b/docs/daemons.rst @@ -402,7 +402,7 @@ host first. systemctl unmask virt${drv}d{,-ro,-admin}.socket systemctl enable virt${drv}d.service systemctl enable virt${drv}d{,-ro,-admin}.socket - done + done #. Start the sockets for the same set of daemons. There is no need to start the services as they will get started when the first socket connection is @@ -413,7 +413,7 @@ host first. $ for drv in qemu network nodedev nwfilter secret storage do systemctl start virt${drv}d{,-ro,-admin}.socket - done + done #. If connections from remote hosts need to be supported the proxy daemon must be enabled and started -- 2.31.1

1 0

[PATCH 0/5] tests: Tool for programatic modification of qemucapabilitiesdata/*.replies
by Peter Krempa 23 Dec '21

23 Dec '21

I was asked multiple times how to automate modification of the qemu capability dumps. I wrote a tool [1] that allowed doing that. Unfortunately as it wasn't in the repo it was not avalilable. Now I've finally set out to finish it. It masquerades as a test in default mode checking the ordering and numbering of the caps dump files as in the past there were few cases where manual edits broke it. In update mode it allows modification of the replies and gives few examples to do so. There's a lot of possible things users would want to do so there's no way around actually writing some code but it should be easier this way. Since this now does also numbering, the AWK/shell script 'qemucapsfixreplies' can be removed. [1]: Okay, okay. Copy&paste'd few bits from various places into one messy C file and didn't bother with memory cleanup. But it worked. Peter Krempa (5): util: json: Introduce virJSONValueObjectReplaceValue tests: qemumonitortestutils.h: Reformat header file qemumonitortestutils: Extract parser for the monitor conversation dump file tests: Tool for programatic modification of qemucapabilitiesdata/*.replies tests: Remove 'qemucapsfixreplies' src/libvirt_private.syms | 1 + src/util/virjson.c | 20 +++ src/util/virjson.h | 6 + tests/domaincapstest.c | 3 +- tests/meson.build | 1 + tests/qemucapabilitiesnumbering.c | 242 ++++++++++++++++++++++++++++++ tests/qemucapabilitiestest.c | 4 +- tests/qemucapsfixreplies | 26 ---- tests/qemumonitortestutils.c | 123 ++++++++++----- tests/qemumonitortestutils.h | 149 +++++++++++------- 10 files changed, 453 insertions(+), 122 deletions(-) create mode 100644 tests/qemucapabilitiesnumbering.c delete mode 100755 tests/qemucapsfixreplies -- 2.31.1

2 6