- Devel - libvirt List Archives

[libvirt PATCH 0/6] qemu: s390x: retire some CCW capabilites
by Ján Tomko 03 Oct '22

03 Oct '22

Now that we bumped the minimum QEMU version to 4.2.0, we can stop probing some capabilities. Ján Tomko (6): tests: qemuxml2argvdata: switch zpci address generation to real caps qemu: convert some s390x tests to use real capability data qemu: Assume QEMU_CAPS_CCW_CSSID_UNRESTRICTED qemu: Assume QEMU_CAPS_CCW qemu: retire QEMU_CAPS_CCW_CSSID_UNRESTRICTED qemu: retire QEMU_CAPS_CCW src/qemu/qemu_capabilities.c | 21 +--- src/qemu/qemu_capabilities.h | 4 +- src/qemu/qemu_domain_address.c | 7 +- src/qemu/qemu_hotplug.c | 6 +- src/qemu/qemu_validate.c | 6 - .../caps_4.2.0.s390x.replies | 71 ++++------- .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 2 - .../caps_5.2.0.s390x.replies | 76 ++++-------- .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 2 - .../caps_6.0.0.s390x.replies | 76 ++++-------- .../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 2 - tests/qemuhotplugtest.c | 1 - ... => balloon-ccw-deflate.s390x-latest.args} | 7 +- ...s => console-virtio-ccw.s390x-latest.args} | 7 +- ...ev-subsys-mdev-vfio-ccw.s390x-latest.args} | 7 +- ...-zpci-autogenerate-fids.s390x-latest.args} | 10 +- ...-zpci-autogenerate-uids.s390x-latest.args} | 10 +- ...-vfio-zpci-autogenerate.s390x-latest.args} | 10 +- .../hostdev-vfio-zpci-boundaries.args | 5 +- ...fio-zpci-ccw-memballoon.s390x-latest.args} | 7 +- ...ci-invalid-uid-valid-fid.s390x-latest.err} | 0 ...o-zpci-multidomain-many.s390x-latest.args} | 10 +- tests/qemuxml2argvdata/hostdev-vfio-zpci.args | 3 +- ...othreads-disk-virtio-ccw.s390x-4.2.0.args} | 8 +- ....args => net-virtio-ccw.s390x-latest.args} | 7 +- ...> non-x86_64-timer-error.s390x-latest.err} | 0 ....args => virtio-rng-ccw.s390x-latest.args} | 9 +- tests/qemuxml2argvtest.c | 112 ++++++------------ .../hostdev-vfio-zpci-autogenerate-fids.xml | 4 +- .../hostdev-vfio-zpci-autogenerate-uids.xml | 4 +- .../hostdev-vfio-zpci-autogenerate.xml | 4 +- .../hostdev-vfio-zpci-boundaries.xml | 4 +- .../hostdev-vfio-zpci-multidomain-many.xml | 4 +- tests/qemuxml2xmltest.c | 41 +++---- 34 files changed, 199 insertions(+), 348 deletions(-) rename tests/qemuxml2argvdata/{balloon-ccw-deflate.args => balloon-ccw-deflate.s390x-latest.args} (68%) rename tests/qemuxml2argvdata/{console-virtio-ccw.args => console-virtio-ccw.s390x-latest.args} (77%) rename tests/qemuxml2argvdata/{hostdev-subsys-mdev-vfio-ccw.args => hostdev-subsys-mdev-vfio-ccw.s390x-latest.args} (70%) rename tests/qemuxml2argvdata/{hostdev-vfio-zpci-autogenerate-fids.args => hostdev-vfio-zpci-autogenerate-fids.s390x-latest.args} (69%) rename tests/qemuxml2argvdata/{hostdev-vfio-zpci-autogenerate-uids.args => hostdev-vfio-zpci-autogenerate-uids.s390x-latest.args} (69%) rename tests/qemuxml2argvdata/{hostdev-vfio-zpci-autogenerate.args => hostdev-vfio-zpci-autogenerate.s390x-latest.args} (66%) rename tests/qemuxml2argvdata/{hostdev-vfio-zpci-ccw-memballoon.args => hostdev-vfio-zpci-ccw-memballoon.s390x-latest.args} (54%) rename tests/qemuxml2argvdata/{hostdev-vfio-zpci-invalid-uid-valid-fid.err => hostdev-vfio-zpci-invalid-uid-valid-fid.s390x-latest.err} (100%) rename tests/qemuxml2argvdata/{hostdev-vfio-zpci-multidomain-many.args => hostdev-vfio-zpci-multidomain-many.s390x-latest.args} (79%) rename tests/qemuxml2argvdata/{iothreads-disk-virtio-ccw.args => iothreads-disk-virtio-ccw.s390x-4.2.0.args} (79%) rename tests/qemuxml2argvdata/{net-virtio-ccw.args => net-virtio-ccw.s390x-latest.args} (73%) rename tests/qemuxml2argvdata/{non-x86_64-timer-error.err => non-x86_64-timer-error.s390x-latest.err} (100%) rename tests/qemuxml2argvdata/{virtio-rng-ccw.args => virtio-rng-ccw.s390x-latest.args} (74%) -- 2.37.3

2 7

[PATCH 0/2] util: xml: Clean up other instances of problems pointed out in review
by Peter Krempa 03 Oct '22

03 Oct '22

In review of my series which was adding new XML Property fetching helpers I was asked to change few things which were also present in other instances in existing code. Fix those too. Peter Krempa (2): util: xml: Fix declararation of 'const char *' parameters in virXMLProp* helpers util: xml: Use common formatting of 'Bitwise-OR' in function param description src/util/virxml.c | 34 +++++++++++++++++----------------- src/util/virxml.h | 12 ++++++------ 2 files changed, 23 insertions(+), 23 deletions(-) -- 2.37.3

2 3

[RFC PATCH 0/2] logging: add service to cleanup internal log files
by aleksandr.leskin 03 Oct '22

03 Oct '22

Hi, all. I kindly want to ask you to review our patch from Nikolay Shirokovskiy: https://listman.redhat.com/archives/libvir-list/2022-February/msg00865.html There is no answer or discussion since February and we really need it to be done. It would be very good to apply patch in libvirt. This patch is very necessary for Virtuozzo, and we are waiting for your feedback. With regards, Aleksand Leskin Virtuozzo Inc.

1 0

Release of libvirt-8.8.0
by Jiri Denemark 03 Oct '22

03 Oct '22

The 8.8.0 release of both libvirt and libvirt-python is tagged and signed tarballs and source RPMs are available at https://libvirt.org/sources/ https://libvirt.org/sources/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is greatly appreciated. * Removed features * storage: Remove 'sheepdog' storage driver backend The 'sheepdog' project is no longer maintained and upstream bug reports are unaddressed. Libvirt thus removed the support for the sheepdog storage driver backend, following qemu's removal of sheepdog support in qemu-6.1. * Improvements * qemu: Implement VIR_DOMAIN_STATS_CPU_TOTAL for qemu:///session Users can now query VIR_DOMAIN_STATS_CPU_TOTAL (also known as cpu.time) statistics for session domains. * Bug fixes * qemu: Fix non-shared storage migration setup This release fixes a bug in setup of a migration with non-shared storage ( ``virsh migrate --copy-storage-all``) which was broken by a refactor of the code in libvirt-8.7. * selinux: Don't ignore NVMe disks when setting image label Libvirt did not set any SELinux label on NVMe disks and relied only on the default SELinux policy. This turned out to cause problem when using namespace or altered policy and thus is fixed now. * qemu: Fix a deadlock when setting up namespace When starting a domain, libvirt creates a mount namespace and manages private /dev with only a handful nodes exposed. But when creating those a deadlock inside glib might have occurred. The code was changed so that libvirt does not tickle the glib bug. * qemu: Don't build memory paths on daemon restart When the daemon is restarted it tried to create domain private paths for each mounted hugetlbfs. When this failed, the corresponding domain was killed. This operation is now performed during domain startup and memory hotplug and no longer leads to sudden kill of the domain. Enjoy. Jirka

1 0

[PATCH v2] docs: add firmware feature flags
by Gerd Hoffmann 30 Sep '22

30 Sep '22

Add new firmware feature flags for the recently added confidential computing operating modes by amd and intel. While being at it also fix the path to the amd sev documentation. Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com> Reviewed-by: Kashyap Chamarthy <kchamart(a)redhat.com> --- docs/interop/firmware.json | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/docs/interop/firmware.json b/docs/interop/firmware.json index 4e049b1c7ca0..56814f02b3c0 100644 --- a/docs/interop/firmware.json +++ b/docs/interop/firmware.json @@ -113,13 +113,22 @@ # Virtualization, as specified in the AMD64 Architecture # Programmer's Manual. QEMU command line options related to # this feature are documented in -# "docs/amd-memory-encryption.txt". +# "docs/system/i386/amd-memory-encryption.rst". # # @amd-sev-es: The firmware supports running under AMD Secure Encrypted # Virtualization - Encrypted State, as specified in the AMD64 # Architecture Programmer's Manual. QEMU command line options # related to this feature are documented in -# "docs/amd-memory-encryption.txt". +# "docs/system/i386/amd-memory-encryption.rst". +# +# @amd-sev-snp: The firmware supports running under AMD Secure Encrypted +# Virtualization - Secure Nested Paging, as specified in the +# AMD64 Architecture Programmer's Manual. QEMU command line +# options related to this feature are documented in +# "docs/system/i386/amd-memory-encryption.rst". +# +# @intel-tdx: The firmware supports running under Intel Trust Domain +# Extensions (TDX). # # @enrolled-keys: The variable store (NVRAM) template associated with # the firmware binary has the UEFI Secure Boot @@ -185,9 +194,11 @@ # Since: 3.0 ## { 'enum' : 'FirmwareFeature', - 'data' : [ 'acpi-s3', 'acpi-s4', 'amd-sev', 'amd-sev-es', 'enrolled-keys', - 'requires-smm', 'secure-boot', 'verbose-dynamic', - 'verbose-static' ] } + 'data' : [ 'acpi-s3', 'acpi-s4', + 'amd-sev', 'amd-sev-es', 'amd-sev-snp', + 'intel-tdx', + 'enrolled-keys', 'requires-smm', 'secure-boot', + 'verbose-dynamic', 'verbose-static' ] } ## # @FirmwareFlashFile: -- 2.37.3

1 0

[PATCH] virgdbusmock: Mock g_dbus_connection_call_with_unix_fd_list_sync() only on UNIX-like systems
by Michal Privoznik 30 Sep '22

30 Sep '22

The g_dbus_connection_call_with_unix_fd_list_sync() function is not defined always, only when G_OS_UNIX condition is set. This is also the reason why our virGDBusCallMethodWithFD() function is guarded with that macro. But virgdbusmock is compiled always, even on !UNIX systems, e.g. mingw. Therefore, we need to use the same macro to condition compile its mock. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tests/virgdbusmock.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/virgdbusmock.c b/tests/virgdbusmock.c index 7a378a616a..8f5cc97911 100644 --- a/tests/virgdbusmock.c +++ b/tests/virgdbusmock.c @@ -68,6 +68,7 @@ VIR_MOCK_LINK_RET_ARGS(g_dbus_connection_call_sync, GCancellable *, cancellable, GError **, error) +#ifdef G_OS_UNIX VIR_MOCK_LINK_RET_ARGS(g_dbus_connection_call_with_unix_fd_list_sync, GVariant *, GDBusConnection *, connection, @@ -83,3 +84,4 @@ VIR_MOCK_LINK_RET_ARGS(g_dbus_connection_call_with_unix_fd_list_sync, GUnixFDList **, out_fd_list, GCancellable *, cancellable, GError **, error) +#endif /* G_OS_UNIX */ -- 2.35.1

2 1

[PATCH] virdomainjob: check if cb is not NULL before dereferencing
by Kristina Hanicova 30 Sep '22

30 Sep '22

The callback struct does not always have to be set which could cause a dereferencing of a NULL pointer. This patch adds check against NULL in missing places before dereferencing. Signed-off-by: Kristina Hanicova <khanicov(a)redhat.com> --- src/conf/virdomainjob.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/virdomainjob.c b/src/conf/virdomainjob.c index 0c67e84ef1..ca0215bc23 100644 --- a/src/conf/virdomainjob.c +++ b/src/conf/virdomainjob.c @@ -626,7 +626,7 @@ virDomainObjEndJob(virDomainObj *obj) virDomainObjResetJob(obj->job); - if (virDomainTrackJob(job) && + if (virDomainTrackJob(job) && obj->job->cb && obj->job->cb->saveStatusPrivate) obj->job->cb->saveStatusPrivate(obj); /* We indeed need to wake up ALL threads waiting because @@ -662,7 +662,7 @@ virDomainObjEndAsyncJob(virDomainObj *obj) obj, obj->def->name); virDomainObjResetAsyncJob(obj->job); - if (obj->job->cb->saveStatusPrivate) + if (obj->job->cb && obj->job->cb->saveStatusPrivate) obj->job->cb->saveStatusPrivate(obj); virCondBroadcast(&obj->job->asyncCond); } -- 2.37.3

2 1

[PATCH] NEWS: Document my contributions for upcoming release
by Michal Privoznik 30 Sep '22

30 Sep '22

Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- NEWS.rst | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 69c5b70c2f..81c95859ff 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -25,6 +25,11 @@ v8.8.0 (unreleased) * **Improvements** + * qemu: Implement VIR_DOMAIN_STATS_CPU_TOTAL for qemu:///session + + Users can now query VIR_DOMAIN_STATS_CPU_TOTAL (also known as cpu.time) + statistics for session domains. + * **Bug fixes** * qemu: Fix non-shared storage migration setup @@ -33,6 +38,26 @@ v8.8.0 (unreleased) ( ``virsh migrate --copy-storage-all``) which was broken by a refactor of the code in libvirt-8.7. + * selinux: Don't ignore NVMe disks when setting image label + + Libvirt did not set any SELinux label on NVMe disks and relied only on the + default SELinux policy. This turned out to cause problem when using + namespace or altered policy and thus is fixed now. + + * qemu: Fix a deadlock when setting up namespace + + When starting a domain, libvirt creates a mount namespace and manages + private /dev with only a handful nodes exposed. But when creating those a + deadlock inside glib might have occurred. The code was changed so that + libvirt does not tickle the glib bug. + + * qemu: Don't build memory paths on daemon restart + + When the daemon is restarted it tried to create domain private paths for + each mounted hugetlbfs. When this failed, the corresponding domain was + killed. This operation is now performed during domain startup and memory + hotplug and no longer leads to sudden kill of the domain. + v8.7.0 (2022-09-01) =================== -- 2.35.1

2 1

[PATCH] docs: add firmware feature flags
by Gerd Hoffmann 30 Sep '22

30 Sep '22

Add new firmware feature flags for the recently added confidential computing operating modes by amd and intel. Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com> --- docs/interop/firmware.json | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/docs/interop/firmware.json b/docs/interop/firmware.json index 4e049b1c7ca0..657082b78b83 100644 --- a/docs/interop/firmware.json +++ b/docs/interop/firmware.json @@ -121,6 +121,15 @@ # related to this feature are documented in # "docs/amd-memory-encryption.txt". # +# @amd-sev-snp: The firmware supports running under AMD Secure Encrypted +# Virtualization - Secure Nested Paging, as specified in the +# AMD64 Architecture Programmer's Manual. QEMU command line +# options related to this feature are documented in +# "docs/amd-memory-encryption.txt". +# +# @intel-tdx: The firmware supports running under Intel Trust Domain +# Extensions (TDX). +# # @enrolled-keys: The variable store (NVRAM) template associated with # the firmware binary has the UEFI Secure Boot # operational mode turned on, with certificates @@ -185,9 +194,11 @@ # Since: 3.0 ## { 'enum' : 'FirmwareFeature', - 'data' : [ 'acpi-s3', 'acpi-s4', 'amd-sev', 'amd-sev-es', 'enrolled-keys', - 'requires-smm', 'secure-boot', 'verbose-dynamic', - 'verbose-static' ] } + 'data' : [ 'acpi-s3', 'acpi-s4', + 'amd-sev', 'amd-sev-es', 'amd-sev-snp', + 'intel-tdx', + 'enrolled-keys', 'requires-smm', 'secure-boot', + 'verbose-dynamic', 'verbose-static' ] } ## # @FirmwareFlashFile: -- 2.37.3

2 1

Entering freeze for libvirt-8.8.0
by Jiri Denemark 30 Sep '22

30 Sep '22

I have just tagged v8.8.0-rc1 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue is more visible. If you have not done so yet, please update NEWS.rst to document any significant change you made since the last release. Thanks, Jirka

1 1