- Devel - libvirt List Archives

KubeVirt with libvirt 9.0.0: Requested operation is not valid: The tap0 interface already exists
by Vasily Ulyanov 23 Jan '23

23 Jan '23

Hi All, I am now trying to run our downstream KubeVirt build with a recent libvirt 9.0.0 and I see a problem that libvirt refuses to start a VM if it is configured to use a pre-created tap device: virError(Code=55, Domain=0, Message='Requested operation is not valid: The tap0 interface already exists') After looking at the git history I found the bellow commit [1] which explicitly forbids such a usecase. This basically breaks KubeVirt since libvirt there runs unprivileged and can only use the existing tap's. I haven't yet look deeper into the original issue linked to the commit. Just wanted to raise this here first. Perhaps someone can provide feedback on that. What about some alternative approach instead? Or maybe it was discussed already... BTW, I tested with the reverted commit and it was successful. [1] https://gitlab.com/libvirt/libvirt/-/commit/a2ae3d299cf9c5ada8aa42ec4271748… -- Vasily Ulyanov <vulyanov(a)suse.de> Software Engineer, SUSE Labs Core

3 3

[libvirt PATCH] conf: clarify some external TPM error messages
by Ján Tomko 23 Jan '23

23 Jan '23

Two of the messages referred to 'backend type' when dealing with the source type and one mentioned the 'client' attribute from an earlier iteration of the patches, even though the attribute was later changed to 'connect'. https://bugzilla.redhat.com/show_bug.cgi?id=2063723 Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/conf/domain_conf.c | 4 ++-- src/conf/domain_validate.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 45965fa0fa..733399e6da 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -10545,7 +10545,7 @@ virDomainTPMDefParseXML(virDomainXMLOption *xmlopt, case VIR_DOMAIN_TPM_TYPE_EXTERNAL: if (!(type = virXPathString("string(./backend/source/@type)", ctxt))) { virReportError(VIR_ERR_XML_ERROR, "%s", - _("missing external TPM backend type")); + _("missing external TPM backend source type")); goto error; } @@ -10555,7 +10555,7 @@ virDomainTPMDefParseXML(virDomainXMLOption *xmlopt, def->data.external.source->type = virDomainChrTypeFromString(type); if (def->data.external.source->type < 0) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("unknown backend type '%s' for external TPM"), + _("unknown backend source type '%s' for external TPM"), type); goto error; } diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index 39d924d4ed..1c13929281 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -2757,7 +2757,7 @@ virDomainTPMDevValidate(const virDomainTPMDef *tpm) } if (tpm->data.external.source->data.nix.listen) { virReportError(VIR_ERR_XML_ERROR, "%s", - _("only 'client' mode is supported for external TPM device")); + _("only 'connect' mode is supported for external TPM device")); return -1; } if (tpm->data.external.source->data.nix.path == NULL) { -- 2.39.0

2 1

[PATCH] docs: fix passt example
by Laine Stump 20 Jan '23

20 Jan '23

Somehow I neglected to fully update the example for the interface passt backend when the design changed during development. This fixes the example to reflect what is in the code. Signed-off-by: Laine Stump <laine(a)redhat.com> --- docs/formatdomain.rst | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index f76c7c3d81..9c6843e082 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -4858,18 +4858,18 @@ ports **with the exception of some subset**. <backend type='passt' logFile='/var/log/passt.log'/> <mac address="00:11:22:33:44:55"/> <source dev='eth0'/> - <ip family='ipv4' address='172.17.2.0' prefix='24'/> - <ip family='ipv6' address='2001:db8:ac10:fd01::' prefix='64'/> - <portForward proto='tcp' address='2001:db8:ac10:fd01::1:10' start='2022'> - <port start='22'/> + <ip family='ipv4' address='172.17.2.4' prefix='24'/> + <ip family='ipv6' address='2001:db8:ac10:fd01::20'/> + <portForward proto='tcp'> + <range start='2022' to='22'/> </portForward> - <portForward proto='udp' address='1.2.3.4' start='5000' end='5020'> - <port start='6000' end='6020'/> + <portForward proto='udp' address='1.2.3.4'> + <range start='5000' end='5020' to='6000'/> + <range start='5010' end='5015' exclude='yes'/> </portForward> - <portForward exclude='yes' proto='tcp' address='1.2.3.4' start='5010' end='5015'/> - <portForward proto='tcp' start='80'/> - <portForward proto='tcp' start='443'> - <port start='344'/> + <portForward proto='tcp' address='2001:db8:ac10:fd01::1:10'>> + <range start='80'/> + <range start='443' to='344'/> </portForward> </interface> </devices> -- 2.38.1

2 1

[PATCH 0/3] migration: add qemu multifd migration options
by Jiang Jiacheng 19 Jan '23

19 Jan '23

Add qemu multifd migration options to set multifd-compression multifd-zlib-level and multifd-zstd-level. Jiang Jiacheng (3): Add public API for parallel compression method qemu: Add qemu parallel migration parameters virsh: Add options for multifd migration compression docs/manpages/virsh.rst | 11 +++++++-- include/libvirt/libvirt-domain.h | 30 ++++++++++++++++++++++++ src/qemu/qemu_migration.h | 3 +++ src/qemu/qemu_migration_params.c | 29 +++++++++++++++++++++++- src/qemu/qemu_migration_params.h | 3 +++ tools/virsh-domain.c | 39 ++++++++++++++++++++++++++++++++ 6 files changed, 112 insertions(+), 3 deletions(-) -- 2.33.0

3 10

[libvirt PATCH 0/2] ci: address more failing CI jobs
by Daniel P. Berrangé 19 Jan '23

19 Jan '23

Daniel P. Berrangé (2): ci: treat centos-stream9 as non-gating job ci: remove non-existant 'containers: false' key usage ci/gitlab/builds.yml | 64 ++++++++++++++++++++-------------------- ci/gitlab/containers.yml | 32 ++++++++++---------- ci/manifest.yml | 31 +++++++++---------- 3 files changed, 64 insertions(+), 63 deletions(-) -- 2.39.0

2 3

[libvirt PATCH 0/1] apparmor: Allow umount(/dev)
by Andrea Bolognani 18 Jan '23

18 Jan '23

CC'ing AppArmor experts to get their input :) This is a farily big hammer, but unfortunately I don't think it's possible to tell AppArmor "let the driver use umount, but only if it's running inside a namespace". Andrea Bolognani (1): apparmor: Allow umount(/dev) src/security/apparmor/usr.sbin.libvirtd.in | 1 + src/security/apparmor/usr.sbin.virtqemud.in | 1 + 2 files changed, 2 insertions(+) -- 2.39.0

3 7

[PATCH] remote: add missing lock guard for secret value API
by Daniel P. Berrangé 18 Jan '23

18 Jan '23

This fixes a bug in commit fda53ab3a536647192dd088672dcb6f4a6820e51 Author: Daniel P. Berrangé <berrange(a)redhat.com> Date: Thu Dec 22 10:29:32 2022 -0500 remote: use VIR_LOCK_GUARD in client code Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/remote/remote_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 206a3829e2..a1e08bcfe2 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -5088,6 +5088,7 @@ remoteSecretGetValue(virSecretPtr secret, size_t *value_size, remote_secret_get_value_args args; remote_secret_get_value_ret ret = {0}; struct private_data *priv = secret->conn->privateData; + VIR_LOCK_GUARD lock = remoteDriverLock(priv); make_nonnull_secret(&args.secret, secret); args.flags = flags; -- 2.39.0

2 1

[libvirt PATCH] remote: remoteDomainCreate: Add missing struct initializer for 'ret2'
by Erik Skultety 18 Jan '23

18 Jan '23

Fixes: 62448c1a4927682f999fecf55e896de4625e46f6 Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- The commit in question broke many integration tests: https://gitlab.com/libvirt/libvirt/-/jobs/3620679044 src/remote/remote_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 206a3829e2..33eff0fe12 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -2428,7 +2428,7 @@ remoteDomainCreate(virDomainPtr domain) { remote_domain_create_args args; remote_domain_lookup_by_uuid_args args2; - remote_domain_lookup_by_uuid_ret ret2; + remote_domain_lookup_by_uuid_ret ret2 = {0}; struct private_data *priv = domain->conn->privateData; VIR_LOCK_GUARD lock = remoteDriverLock(priv); -- 2.39.0

2 1

[libvirt PATCH] ch: use CURLOPT_UPLOAD instead of CURLOPT_PUT
by Daniel P. Berrangé 18 Jan '23

18 Jan '23

The CURLOPT_PUT constant causes a deprecation warning when compiling on Alpine Edge. The docs indicate it is deprecated since 7.2.1 https://curl.se/libcurl/c/CURLOPT_PUT.html We already use CURLOPT_UPLOAD in the ESX driver, so this brings the CH driver into line. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/ch/ch_monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ch/ch_monitor.c b/src/ch/ch_monitor.c index 8d8654332f..7b8f0a8077 100644 --- a/src/ch/ch_monitor.c +++ b/src/ch/ch_monitor.c @@ -660,7 +660,7 @@ virCHMonitorPutNoContent(virCHMonitor *mon, const char *endpoint) curl_easy_setopt(mon->handle, CURLOPT_UNIX_SOCKET_PATH, mon->socketpath); curl_easy_setopt(mon->handle, CURLOPT_URL, url); - curl_easy_setopt(mon->handle, CURLOPT_PUT, true); + curl_easy_setopt(mon->handle, CURLOPT_UPLOAD, 1L); curl_easy_setopt(mon->handle, CURLOPT_HTTPHEADER, NULL); responseCode = virCHMonitorCurlPerform(mon->handle); -- 2.39.0

2 2

[PATCH V9 00/14] spec: Decompose the daemon subpackage
by Jim Fehlig 18 Jan '23

18 Jan '23

This is V9 of https://listman.redhat.com/archives/libvir-list/2023-January/237006.html The end goal is to remove the libvirt-dameon dependency on the various libvirt-daemon-driver-foo subpackages, allowing installation of a modular daemon configuration without the traditional monolithic libvirtd. Changes from V8: * Move adjustments to systemd service files to a new patch * Address more review comments Jim Fehlig (14): spec: Move virtlockd to a new subpackage libvirt-daemon-lock spec: Move virtlogd to a new subpackage libvirt-daemon-log spec: Move virtproxyd to a new subpackage libvirt-daemon-proxy spec: Move lockd plugin to a new subpackage spec: Rename the libvirt-lock-sanlock subpackage spec: Move common files and dependencies to libvirt-daemon-common spec: Add module-init-tools dependency to nodedev and lxc drivers spec: Add numad dependency to qemu and lxc drivers spec: Remove libvirt-daemon dependency from secondary drivers services: Weaken systemd dependency on virtlockd spec: Remove libvirt-daemon dependency from primary drivers spec: Remove libvirt-daemon dependency from hypervisor subpackages kbase: Update rpm-deployment.rst with new subpackages NEWS: Mention split of libvirt-daemon subpackage NEWS.rst | 6 + docs/kbase/rpm-deployment.rst | 48 +++-- libvirt.spec.in | 332 +++++++++++++++++++++++---------- src/libxl/virtxend.service.in | 2 +- src/qemu/virtqemud.service.in | 2 +- src/remote/libvirtd.service.in | 2 +- 6 files changed, 281 insertions(+), 111 deletions(-) -- 2.38.1

3 24