- Devel - libvirt List Archives

[PATCH 0/8] vbox: Report VirtualBox exceptions too
by Michal Privoznik 24 Jan '23

24 Jan '23

See 5/8 for motivation. Michal Prívozník (8): vbox: Introduce VBOX_QUERY_INTERFACE() vbox: Introduce IVirtualBoxErrorInfo interface vbox: Introduce vboxUniformedPFN::GetException() vbox: Introduce vboxUniformedPFN::ClearException() vbox: Introduce vboxReportError() vbox: Replace virReportError() with vboxReportError() vbox: Move error messages onto a single line vbox: Stop reporting RC in error messages src/vbox/vbox_common.c | 1223 +++++++++++++++++---------------- src/vbox/vbox_common.h | 6 + src/vbox/vbox_tmpl.c | 52 ++ src/vbox/vbox_uniformed_api.h | 11 + 4 files changed, 712 insertions(+), 580 deletions(-) -- 2.39.1

2 12

[PATCH 0/3] qemu: Fix alias generation for 'dimm' devices
by Peter Krempa 24 Jan '23

24 Jan '23

Peter Krempa (3): qemu: hotplug: Remove legacy quirk for 'dimm' address generation qemu: alias: Remove 'oldAlias' argument of qemuAssignDeviceMemoryAlias qemu: Remove 'memAliasOrderMismatch' field from VM private data src/qemu/qemu_alias.c | 13 ++++--------- src/qemu/qemu_alias.h | 3 +-- src/qemu/qemu_domain.h | 3 --- src/qemu/qemu_hotplug.c | 4 +--- src/qemu/qemu_process.c | 24 ------------------------ 5 files changed, 6 insertions(+), 41 deletions(-) -- 2.38.1

2 4

[PATCH 00/15] vbox: Add support for version 7.0 SDK and drop old
by Michal Privoznik 24 Jan '23

24 Jan '23

For full experience you'll need to apply these on top of: https://listman.redhat.com/archives/libvir-list/2023-January/237248.html Michal Prívozník (15): vbox: Drop misleading G_GNUC_UNUSED annotation vbox: Drop @mediaChangeOnly from vboxDomainAttachDeviceImpl() vbox: Drop @iid from UIMachine::LaunchVMProcess() vbox: Drop @iid from UISession::Open() vbox: Drop @iid from UISession::OpenExisting() vbox: Drop @data and @name from UIHost::CreateHostOnlyNetworkInterface() vbox: Drop UIUSBCommon::Enable() vbox: Drop UIUSBCommon::GetEnabled() vbox: Drop support for virtualbox-5.2.0 vbox: Drop support for virtualbox-6.0.0 vbox: Drop @networkName from UIDHCPServer::Start() vbox: Rename #include guard macro in header files vbox: add version 7.0 CAPI header vbox: Add support for version 7.0 SDK NEWS: Document recent vbox changes NEWS.rst | 11 + docs/drvvbox.rst | 2 +- src/vbox/meson.build | 3 +- src/vbox/vbox_CAPI_v5_2.h | 26870 ---------------- src/vbox/vbox_CAPI_v6_1.h | 6 +- .../{vbox_CAPI_v6_0.h => vbox_CAPI_v7_0.h} | 9280 +++++- src/vbox/vbox_V6_0.c | 13 - src/vbox/{vbox_V5_2.c => vbox_V7_0.c} | 6 +- src/vbox/vbox_XPCOMCGlue.h | 2 +- src/vbox/vbox_common.c | 65 +- src/vbox/vbox_common.h | 8 +- src/vbox/vbox_network.c | 5 +- src/vbox/vbox_storage.c | 10 +- src/vbox/vbox_tmpl.c | 204 +- src/vbox/vbox_uniformed_api.h | 15 +- 15 files changed, 8713 insertions(+), 27787 deletions(-) delete mode 100644 src/vbox/vbox_CAPI_v5_2.h rename src/vbox/{vbox_CAPI_v6_0.h => vbox_CAPI_v7_0.h} (75%) delete mode 100644 src/vbox/vbox_V6_0.c rename src/vbox/{vbox_V5_2.c => vbox_V7_0.c} (68%) -- 2.39.1

3 19

[PATCH] network: Increase max route size when checking IPv6 forwarding
by Brooks Swinnerton 24 Jan '23

24 Jan '23

In d9ee51e, virNetDevIPCheckIPv6Forwarding was updated to walk the contents of /proc/net/ipv6_route so that it could check to see if the RTF_ADDRCONF was set on any IPv6 routes to ultimately determine if enabling forwarding would result in an error due to accept_ra=1 being set on the interface. The implementation added in that commit limited the number of routes that could be read from /proc/net/ipv6_route to 100_000, each with 150 characters. This is problematic for machines that have a full IPv6 routing table, as the IPv6 routing table has now grown to over 160_000 (it was closer to 100_000 at the time of that commit). This patch increases the maximum route size from 100_000 to 1_000_000. While a million routes is somewhat arbitrary, it's meant to be a value that can be supported for the forseeable future. APNIC, one of the five regional internet registries, recently published a forecast of IPv6 table growth which anticipates a worst-case growth to 1_000_000 in January of 2029. Signed-off-by: Brooks Swinnerton <bswinnerton(a)gmail.com> --- src/util/virnetdevip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virnetdevip.c b/src/util/virnetdevip.c index 2eacb64ebe..034b392ee7 100644 --- a/src/util/virnetdevip.c +++ b/src/util/virnetdevip.c @@ -529,7 +529,7 @@ virNetDevIPCheckIPv6Forwarding(void) char *cur; g_autofree char *buf = NULL; /* lines are 150 chars */ - enum {MAX_ROUTE_SIZE = 150*100000}; + enum {MAX_ROUTE_SIZE = 150*1000000}; /* This is /proc/sys/net/ipv6/conf/all/accept_ra */ int all_accept_ra = virNetDevIPGetAcceptRA(NULL); -- 2.39.1

2 1

[PATCH V2 1/1] qemuProcessEventSubmit : rename vm to event->vm
by Shaleen Bathla 24 Jan '23

24 Jan '23

In error case, free event->vm instead of vm. This makes it easier for the reader to understand what we should free. Signed-off-by: Shaleen Bathla <shaleen.bathla(a)oracle.com> --- src/qemu/qemu_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index ee9f0784d3a3..83b553418068 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -287,7 +287,7 @@ qemuProcessEventSubmit(virDomainObj *vm, event->data = data; if (virThreadPoolSendJob(driver->workerPool, 0, event) < 0) { - virObjectUnref(vm); + virObjectUnref(event->vm); qemuProcessEventFree(event); } } -- 2.31.1

2 2

[PATCH V2 0/2] define g_autoptr for virNWFilterDef and virNWFilterRuleDef
by Jiang Jiacheng 24 Jan '23

24 Jan '23

Define and use g_autoptr() for virNWFilterDef and virNWFilterRuleDef, and remove unnecessary label/variable. Those patches are followup with: https://gitlab.com/libvirt/libvirt/-/commit/a9027d447be789cd11c0aa18ceb83ed… diff to v1: * drop two changes that may cause memory leaks in 'nwfilterDefineXMLFlags' and 'virNWFilterObjListLoadConfig' Jiang Jiacheng (2): conf: define g_autoptr for virNWFilterDef and virNWFilterRuleDef src/tests: use g_autoptr for virNWFilterDef and virNWFilterRuleDef src/conf/nwfilter_conf.c | 44 +++++++++++++++---------------------- src/conf/nwfilter_conf.h | 2 ++ tests/nwfilterxml2xmltest.c | 22 +++++++------------ 3 files changed, 28 insertions(+), 40 deletions(-) -- 2.33.0

3 5

[PATCH 0/5] Credential asking cleanup follow-up
by Peter Krempa 23 Jan '23

23 Jan '23

Few things noticed during review and during fixing of the original patches after review. Peter Krempa (5): util: authconfig: Don't check return value of 'g_key_file_new()' virNetSSHSessionAuthAddPasswordAuth: Don't access unlocked 'sess' virnetsshsession: Don't check return value of 'virNetSSHSessionAuthMethodNew' virNetLibsshSessionAuthAddPasswordAuth: Don't access unlocked 'sess' virnetlibsshsession: Don't check return value of 'virNetLibsshSessionAuthMethodNew' src/rpc/virnetlibsshsession.c | 50 ++++++++--------------------------- src/rpc/virnetsshsession.c | 41 +++++++--------------------- src/util/virauthconfig.c | 8 ++---- 3 files changed, 23 insertions(+), 76 deletions(-) -- 2.38.1

2 6

[PATCH 0/2] vbox: Two simple fixes
by Michal Privoznik 23 Jan '23

23 Jan '23

I've notice these while working on adding support for 7.0 API. Michal Prívozník (2): vbox: Fix memleak in _virtualboxCreateMachine() vbox: Fix starting domains src/vbox/vbox_common.c | 13 ++++++------- src/vbox/vbox_tmpl.c | 1 + 2 files changed, 7 insertions(+), 7 deletions(-) -- 2.39.1

3 9

[PATCH v2 0/3] qemu: Provide virDomainGetCPUStats() implementation for session connection
by Michal Privoznik 23 Jan '23

23 Jan '23

v2 of: https://listman.redhat.com/archives/libvir-list/2023-January/237113.html diff to v1: - Make virProcessGetStatInfo() return an error, per Martin's review Michal Prívozník (3): src: Don't use virReportSystemError() on virProcessGetStatInfo() failure virprocess: Make virProcessGetStatInfo() fail if unable to parse data qemu: Provide virDomainGetCPUStats() implementation for session connection src/ch/ch_driver.c | 4 +-- src/qemu/qemu_driver.c | 67 +++++++++++++++++++++++++++++++++++------- src/util/virprocess.c | 28 +++++------------- 3 files changed, 65 insertions(+), 34 deletions(-) -- 2.38.2

3 9

[PATCH 0/2] qemu_interface: Fix managed='no' case when creating an ethernet interface
by Michal Privoznik 23 Jan '23

23 Jan '23

*** BLURB HERE *** Michal Prívozník (2): virnetdevtap: Clarify virNetDevTapCreate() behavior wrt VIR_NETDEV_TAP_CREATE_ALLOW_EXISTING qemu_interface: Fix managed='no' case when creating an ethernet interface src/qemu/qemu_interface.c | 5 +++-- src/util/virnetdevtap.c | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) -- 2.39.1

2 3