- Devel - libvirt List Archives

[PATCH] NEWS: strongly suggest that <backend type='passt'/> not yet be used in production
by Laine Stump 28 Feb '23

28 Feb '23

Based on Stefano's suggestion that the NEWS should not seem to encourage disabling SELinux or AppArmor (which is a valid point) this replaces the "you need to disable SELinux/AppArmor" note with a "please do not use in production because that will require disabling SELinux/AppArmor". Signed-off-by: Laine Stump <laine(a)redhat.com> --- If this change seems okay, anyone who ACKs please push it so that it's in place before Jiri cuts the release (I may not yet be awake at that time of day). NEWS.rst | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/NEWS.rst b/NEWS.rst index af7a3b2c76..b9fe73a747 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -78,8 +78,10 @@ v9.1.0 (unreleased) start the guest; this led to a running guest with no network connectivity. - (NB: On systems that use them, it is still necessary to disable - SELinux/AppArmor to start passt.) + (NB: Please do not use <backend type='passt'/> on production + systems with Linux Security Modules as it currently requires + setting SELinux to permissive mode or disabling selected AppArmor + profiles) v9.0.0 (2023-01-16) -- 2.39.2

1 0

[PATCH] NEWS: Mention two user-visible bug fixes
by Peter Krempa 28 Feb '23

28 Feb '23

Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index d1f88b3d59..ca93c24150 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -80,6 +80,18 @@ v9.1.0 (unreleased) (NB: it is still necessary to disable SELinux to start passt.) + * qemu: Fix error when attempting to change media in a CDROM drive + + Due to a logic bug introduced in libvirt-9.0 attempts to change media in a + CDROM would previously fail with an error stating that the tray isn't open. + + * qemu: Properly handle block job transitions + + Starting with libvirt-9.0 the block job state machine improperly handled + some job transitions which resulted into some block jobs not being properly + terminated. This could cause problems such as errors when detaching a disk + after snapshot. + v9.0.0 (2023-01-16) =================== -- 2.39.2

2 1

[PATCH 0/4] qemu: Fix regression wrt virtio-pmem
by Michal Privoznik 28 Feb '23

28 Feb '23

The first one fixes a regression in which we're unable to start a domain with a virtio-pmem device. It should go into the release. The rest is just a cleanup because the function in question started looking disarranged. Michal Prívozník (4): qemu: Don't error out on 'unknown' memory model in qemuMonitorJSONGetMemoryDeviceInfo() libvirt_private.syms: Export virDomainMemoryModelTypeFromString() qemu_monitor: Switch to virDomainMemoryModel enum in qemuMonitorJSONGetMemoryDeviceInfo() qemu_monitor: Decouple switch()-es in qemuMonitorJSONGetMemoryDeviceInfo() src/libvirt_private.syms | 1 + src/qemu/qemu_monitor_json.c | 124 +++++++++++++++++++---------------- 2 files changed, 67 insertions(+), 58 deletions(-) -- 2.39.2

3 9

Re: [PATCH v2 06.5/18] hw/ide/piix: Allow using PIIX3-IDE as standalone PCI function
by Philippe Mathieu-Daudé 27 Feb '23

27 Feb '23

On 20/2/23 10:10, Gerd Hoffmann wrote: > On Mon, Feb 20, 2023 at 09:00:44AM +0100, Philippe Mathieu-Daudé wrote: >> In order to allow Frankenstein uses such plugging a PIIX3 >> IDE function on a ICH9 chipset (which already exposes AHCI >> ports...) as: >> >> $ qemu-system-x86_64 -M q35 -device piix3-ide >> >> add a kludge to automatically wires the IDE IRQs on an ISA >> bus exposed by a PCI-to-ISA bridge (usually function #0). >> Restrict this kludge to the PIIX3. > > Well. On physical hardware you have a config switch in the bios > setup which turns off sata and enables ide instead (i.e. the > chipset implements both and can be configured to expose the one > or the other). > > If we want support ide for q35 we should IMHO do something simliar > instead of making piix-ide user-pluggable. We already have -machine > q35,sata={on,off}. We could extend that somehow, by adding > ide={on,off}, or by using storage={sata,ide,off} instead. > > This has been discussed now and then in the past and the usual > conclusion was that there is little reason to implement that given > that you can just use the 'pc' machine type. For guests that old > that they can't handle sata storage this is usually the better fit > anyway ... I think we might not using the same words, but agree on the goal :) Since this has been discussed in the past, I suppose some users want this config available. Why are they using this convoluted config? Could it be due to lack of good documentation? Do we really need a storage={sata,ide,off} flag? I don't see its value. Help cloud users to have a sane config? (old) boards exist with both IDE/SATA and we might want to emulate some of them, but IMO such boards should be well modeled (Either in C or later in declarative language) but not automagically created from CLI. IOW: - using PIIX on Q35 (or any machine exposing a PCI bus) is acceptable, but the chipset should be instantiated as a whole. So to be clear I'm not against "-M q35 -device piix3", we should keep that working. - we shouldn't try to maintain such Frankenstein corner cases which force us to add complex hacks, hard to remove, which limit us in implementing new features and cost us a lot of maintenance / testing time. So I propose we deprecate this config so we can keep going forward. (More generally I'd like to not allow instantiating part of chipset).

1 1

EPERM when hot plugging passthrough device to guest after having rebooted libvirt
by Thanos Makatos 27 Feb '23

27 Feb '23

On an older, patched libvirt version (8.0.0), I've run into an issue when attempting to hot plug a PCI device via virsh attach-device --live. To repro: 1. start a guest and hot plug a device (works fine), 2. hot unplug the device 3. restart libvirt 4. attempt to hot plug the same device, it fails with EPERM, e.g. error: internal error: unable to execute QEMU command 'device_add': vfio 0000:86:01.2: failed to open /dev/vfio/165: Operation not permitted I'm not yet able to _attempt_ to reproduce on latest master (still working on that), however I've looked at the relevant piece of code and it looks the same so I would expect it to fail the same way. I've tried to debug this (on libvirt 8.0.0) and see that In qemuSetupHostdevCgroup(), virCgroupHasController() returns 0 since priv->cgroup is NULL. This prevents it from calling virCgroupAllowDevicePath(), hence the failure. priv->cgroup is NULL because it doesn't get initialized in virCgroupV1ValidateMachineGroup(): for (i = 0; i < VIR_CGROUP_CONTROLLER_LAST; i++) { if (STRNEQ(tmp, name) && ... ) { VIR_DEBUG("Name '%s' for controller '%s' does not match " "'%s', '%s', '%s', '%s' or '%s'", tmp, virCgroupV1ControllerTypeToString(i), name, machinename, partname, scopename_old, scopename_new); return false; } I've experimented replacing return false with continue and it works, however I don't know anything about this code so my hack might be completely wrong. Is this behaviour expected or is it a bug?

1 0

Entering freeze for libvirt-9.1.0
by Jiri Denemark 27 Feb '23

27 Feb '23

I have just tagged v9.1.0-rc1 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue is more visible. If you have not done so yet, please update NEWS.rst to document any significant change you made since the last release. Thanks, Jirka

2 4

[PATCH 0/1] CI: Add scheduled job for container update and regenerate with new lcitool
by Peter Krempa 27 Feb '23

27 Feb '23

As it was intended and discussed before I've added a scheduled job named 'Weekly CI container rebuild' which will run the pipeline with RUN_CONTAINER_BUILDS variable set to 1 to update the containers regularly rather than doing it manually and very infrequently. The job will run every Monday at 5AM UTC. I'll trigger it manually tomorrow if there are no objections. Note that gitlabs scheduled job permissions are weird so I'm not sure who will be able to edit or delete the job in the future. I can't do that for the daily build with coverity. The patch also regenerates the CI files with latest lcitool Peter Krempa (1): ci: Regenerate gitlab config with latest lcitool ci/gitlab/build-templates.yml | 2 +- ci/gitlab/sanity-checks.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 2.39.2

2 3

[PATCH] kbase: virtiofs: Add a note that virtiofs is not migratable
by Peter Krempa 27 Feb '23

27 Feb '23

Note that certain operations will not work. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/452 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- docs/kbase/virtiofs.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs/kbase/virtiofs.rst b/docs/kbase/virtiofs.rst index 10d1e1d79c..5940092db5 100644 --- a/docs/kbase/virtiofs.rst +++ b/docs/kbase/virtiofs.rst @@ -13,6 +13,10 @@ is designed to offer local file system semantics and performance. See https://virtio-fs.gitlab.io/ +*Note:* virtiofs currently does not support migration so operations such as +migration, save/managed-save, or snapshots with memory are not supported if +a VM has a virtiofs filesystem connected. + Sharing a host directory with a guest ===================================== -- 2.39.2

2 1

[GSOC 2023] Contribution Request
by dihia bendjenahi 26 Feb '23

26 Feb '23

Hello, I am Dihia Bendjenahi, a 4th year computer science student at The Higher National School of Computer Science of Algiers, Algeria. I am specialized in computer systems. I came across Libvirt's projects list for GSOC and I was really interested by the "Metadata Support For All Object Schemas" project. I have worked on multiple projects throughout my studies and I used different data structures, datatypes, programming languages and data formats to deal with data. I have been working with C language since I was in high school (for around 6 years now) and I wrote tens of projects ranging from simple small projects to complex programs. I would love to know whether I can start working on my proposal for this particular project, and I would also love to get your thoughts about what to do next and how to get started with Libvirt. I would really appreciate your help. I'm sorry to disturb you and thank you for your time. Looking forward to hearing from you soon. Cordially

1 0

help regarding gsoc 2023
by Kshitiz Mhto 24 Feb '23

24 Feb '23

hello, i am 1st year student with good understanding of C programming along with pythan and java. i would love to contribute to project "libvirt" and interested in gsoc 2023 regardung the project [Metadata support for all object schemas -- Suggested by: Daniel Berrange]. could anyone help on this?

1 0