- Devel - libvirt List Archives

[libvirt PATCH 0/5] meson: Introduce initconfdir option
by Andrea Bolognani 05 May '23

05 May '23

Makes things nicer for those using distros that are not derived from RHEL or SUSE. Andrea Bolognani (5): meson: Introduce initconfdir option meson: Use initconfdir rpm: Set initconfdir explicitly meson: Move definition of os_release meson: Improve initconfdir defaults docs/manpages/libvirt-guests.rst | 2 +- docs/manpages/meson.build | 1 + libvirt.spec.in | 1 + meson.build | 20 +++++++++++++++++++- meson_options.txt | 1 + src/ch/virtchd.service.in | 2 +- src/interface/virtinterfaced.service.in | 2 +- src/libxl/virtxend.service.in | 2 +- src/locking/virtlockd.service.in | 2 +- src/logging/virtlogd.service.in | 2 +- src/lxc/virtlxcd.service.in | 2 +- src/meson.build | 1 + src/network/virtnetworkd.service.in | 2 +- src/node_device/virtnodedevd.service.in | 2 +- src/nwfilter/virtnwfilterd.service.in | 2 +- src/qemu/virtqemud.service.in | 2 +- src/remote/libvirtd.service.in | 2 +- src/remote/virtproxyd.service.in | 2 +- src/secret/virtsecretd.service.in | 2 +- src/storage/virtstoraged.service.in | 2 +- src/vbox/virtvboxd.service.in | 2 +- src/vz/virtvzd.service.in | 2 +- tools/libvirt-guests.service.in | 2 +- tools/libvirt-guests.sh.in | 5 +++-- tools/meson.build | 1 + tools/virt-pki-validate.in | 13 +++++++------ 26 files changed, 52 insertions(+), 27 deletions(-) -- 2.40.1

2 12

[libvirt PATCH] util: Improve comment for workaround
by Andrea Bolognani 04 May '23

04 May '23

Now that a version of GLib that contains the fix has been released, it's more useful to record that information. Adding a TODO annotation makes the whole thing easily greppable. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- src/util/virfile.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index 657e74e026..228482e8f8 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -1747,8 +1747,7 @@ virFindFileInPath(const char *file) return NULL; /* Workaround for a bug in g_find_program_in_path() not returning absolute - * path as documented. This has been fixed in - * https://gitlab.gnome.org/GNOME/glib/-/merge_requests/2127 + * path as documented. TODO drop it once we require GLib >= 2.69.0 */ return g_canonicalize_filename(path, NULL); } -- 2.40.1

2 1

[PATCH] qemu: Fix error message
by Andrea Bolognani 04 May '23

04 May '23

The spelling is slightly different from another otherwise identical error message in the same file. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. src/qemu/qemu_dbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_dbus.c b/src/qemu/qemu_dbus.c index db47e4b5ba..7a7af2850e 100644 --- a/src/qemu/qemu_dbus.c +++ b/src/qemu/qemu_dbus.c @@ -252,7 +252,7 @@ qemuDBusStart(virQEMUDriver *driver, if (!virFileExists(sockpath)) { virReportError(VIR_ERR_OPERATION_TIMEOUT, - _("DBus daemon %1$s didn't show up"), + _("dbus-daemon %1$s didn't show up"), cfg->dbusDaemonName); goto cleanup; } -- 2.40.1

1 0

[PATCH v2 0/1] allow risc-v domains to use CPU definitions
by Daniel Henrique Barboza 04 May '23

04 May '23

Hi, The bulk of the changes from v1 is in the commit message. See version 1 [1] for more details. Changes from v1: - rewrote the commit message to reflect the actual problem - changed virCPUriscvUpdate() to virCPURiscv64Update() to be in line with the name convention of the driver - v1 link: https://listman.redhat.com/archives/libvir-list/2023-April/239687.html [1] https://listman.redhat.com/archives/libvir-list/2023-April/239687.html Daniel Henrique Barboza (1): cpu_riscv64.c: add update() implementation po/POTFILES | 1 + src/cpu/cpu_riscv64.c | 28 +++++++++++++++++++++++++++- 2 files changed, 28 insertions(+), 1 deletion(-) -- 2.40.0

2 2

[PATCH 0/2] gitlab: Adapt name of CI job building the web page to 'pages'
by Peter Krempa 04 May '23

04 May '23

The subject is deliberately chosen so that it does not imply that we actually want to host libvirt.org via gitlab pages at this time. It's not possible as gitlab pages don't allow redirects to different domains: https://gitlab.com/gitlab-org/gitlab-pages/-/issues/601 The merit of this change was discussed here: https://gitlab.com/libvirt/libvirt-ocaml/-/merge_requests/23#note_1360494690 Along with this patch, a change to to the job deploying the page on libvirt.org will be needed. Peter Krempa (2): gitlab-ci: Configure website build to be published via gitlab pages docs: Add redirects configuration for gitlab pages .gitlab-ci.yml | 70 ++++++++++++++++++++++++++++++++++++------ docs/.gitlab_redirects | 38 +++++++++++++++++++++++ 2 files changed, 99 insertions(+), 9 deletions(-) create mode 100644 docs/.gitlab_redirects -- 2.40.0

1 2

[PATCH 0/1] fix risc-v QEMU domains in non-RISC-V hosts
by Daniel Henrique Barboza 03 May '23

03 May '23

Hi, For some reason didn't notice this was broken until recently. We're missing an API in the RISC-V CPU driver to allow QEMU TCG risc-v domains to run in non-native hosts. Daniel Henrique Barboza (1): cpu_riscv64.c: add update() implementation src/cpu/cpu_riscv64.c | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) -- 2.40.0

2 5

[libvirt PATCH] meson: Fix qemu_{user,group} defaults for Arch
by Andrea Bolognani 03 May '23

03 May '23

The current values might have been accurate at the time when the logic was introduced, but these days Arch is using the same ones as Debian. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Proof that I'm not making this up: https://github.com/archlinux/svntogit-community/blob/83e66277ba6e08968496c8… meson.build | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/meson.build b/meson.build index bad13c0c9d..09c3ab00f4 100644 --- a/meson.build +++ b/meson.build @@ -1614,20 +1614,18 @@ if not get_option('driver_qemu').disabled() qemu_group = 'wheel' else os_release = run_command('grep', '-E', '^ID(_LIKE)*=', '/etc/os-release', check: false).stdout() - if os_release.contains('arch') - qemu_user = 'nobody' - qemu_group = 'nobody' # RHEL and CentOS both have ID_LIKE=fedora, SLES has ID_LIKE=suse - elif (os_release.contains('fedora') or - os_release.contains('gentoo') or - os_release.contains('suse')) + if (os_release.contains('fedora') or + os_release.contains('gentoo') or + os_release.contains('suse')) qemu_user = 'qemu' qemu_group = 'qemu' # Ubuntu has ID_LIKE=debian so we need to handle it first elif os_release.contains('ubuntu') qemu_user = 'libvirt-qemu' qemu_group = 'kvm' - elif os_release.contains('debian') + elif (os_release.contains('arch') or + os_release.contains('debian')) qemu_user = 'libvirt-qemu' qemu_group = 'libvirt-qemu' else -- 2.40.1

2 1

[PATCH v1] use libexecdir as location for qemu-bridge-helper
by Olaf Hering 02 May '23

02 May '23

The current logic in meson.build assumes a fixed runtime path for qemu-bridge-helper in case this binary is not available during build. Since qemu-bridge-helper is not used during build it is not required to have it installed at build time. It is likely that both qemu and libvirt are built with the same --libexecdir option. So use this as the expected location for qemu-bridge-helper. Signed-off-by: Olaf Hering <olaf(a)aepfle.de> --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index c2a2f306c1..6ca05e2f69 100644 --- a/meson.build +++ b/meson.build @@ -1653,7 +1653,7 @@ if not get_option('driver_qemu').disabled() if qemu_bridge_prog.found() qemu_bridge_path = qemu_bridge_prog.full_path() else - qemu_bridge_path = '/usr/libexec/qemu-bridge-helper' + qemu_bridge_path = libexecdir / 'qemu-bridge-helper' endif conf.set_quoted('QEMU_BRIDGE_HELPER', qemu_bridge_path)

2 2

Release of libvirt-9.3.0
by Jiri Denemark 02 May '23

02 May '23

The 9.3.0 release of both libvirt and libvirt-python is tagged and signed tarballs and source RPMs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is greatly appreciated. * New features * qemu: Introduce support for ``igb`` network interface model ``igb`` is a successor to the ``e1000e`` network device using PCIe interface. It was introduced in QEMU 8.0 * qemu: Improve handling of maximum physical address configuration * Improvements * qemu: Change default machine type for ARM and RISC-V ARM and RISC-V architectures now use the ``virt`` machine type by default. The previous defaults were nearly unusable and had to be overridden in most cases. * Improve translatable strings format substitutions All translatable error messages with substitution strings were converted to use positional modifiers to allow translators to shuffle around words in the translation. The translations in Weblate were also updated to match. * qemu: Improve validation of ``watchdog`` devices Certain invalid configurations of ``watchdog`` device are now properly detected: - hotplug of always-present platform watchdogs is forbidden - ``iTCO`` watchdog can be configured only once - ``ib700`` watchdog is allowed only on ``i440fx`` machines * Improved output of ``virt-host-validate`` on ARM Our validation tool now parses the ``IORT`` data on ARM to properly detect presence of SMMU and other features. * Bug fixes * qemu: Fix inactive internal snapshots of VM with UEFI firmware Recent changes to UEFI firmware handling resulted into breaking support for inactive internal snapshots of VMs with UEFI which historically worked. (Although the intention was to disallow them together with active ones, but the check did not work properly.) Preserve existing functionality by allowing such snapshots explicitly. * qemu: Properly configure locked memory limit for VMs with ``<disk type='nvme'`` The NVMe driver in qemu requires some memory to be locked. This was not taken into account in the code which calculates the memory limits based on devices present in the configuration * Fix native build on win32 Various improvements to the build system now allow users to build the client library of libvirt on win32 natively. * qemu: Properly detect tray of hotplugged CD-ROM devices Media in a CD-ROM device which was hotplugged could not be changed as the presence of the tray was not detected properly on hotplug. Enjoy. Jirka

1 0

[PATCH] NEWS: Update news for the 9.3.0 release
by Peter Krempa 02 May '23

02 May '23

Update the news file mentioning important changes such as the change of translatable strings or the fix of inactive snapshots of VMs using uefi. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 53 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 2a844ce40c..d0d78e2127 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,13 @@ v9.3.0 (unreleased) * **New features** + * qemu: Introduce support for ``igb`` network interface model + + ``igb`` is a successor to the ``e1000e`` network device using PCIe interface. + It was introduced in QEMU 8.0 + + * qemu: Improve handling of maximum physical address configuration + * **Improvements** * qemu: Change default machine type for ARM and RISC-V @@ -25,8 +32,54 @@ v9.3.0 (unreleased) The previous defaults were nearly unusable and had to be overridden in most cases. + * Improve translatable strings format substitutions + + All translatable error message with substitution strings were converted to + use positional modifiers to allow translators to shuffle around the + translated message. The translations pulled from Weblate were also updated to + match. + + * qemu: Improve validation of ``watchdog`` devices + + Certain invalid configurations of ``watchdog`` device are now properly + detected: + + - hotplug of always-present platform watchdogs is forbidden + - ``iTCO`` watchdog can be configured only once + - ``ib700`` watchdog is allowed only on ``i440fx`` machines + + * Improved output of ``virt-host-validate`` on ARM + + Our validation tool now parses the ``IORT`` data on ARM to properly detect + presence of SMMU and other features. + * **Bug fixes** + * qemu: Fix inactive internal snapshots of VM with UEFI firmware + + Recent changes to UEFI firmware handling resulted into breaking support + for inactive internal snapshots of VMs with UEFI which historically worked. + (Although the intention was to disallow them together with active ones, but + the check did not work properly.) + + Preserve existing functionality by allowing such snapshots explicitly. + + * qemu: Properly configure locked memory limit for VMs with ``<disk type='nvme'`` + + The NVMe driver in qemu requires some memory to be locked. This was not + taken into account in the code which calculates the memory limits based + on devices present in the configuration + + * Fix native build on win32 + + Various improvements to the build system now allow users to build the client + library of libvirt on win32 natively. + + * qemu: Properly detect tray of hotplugged CD-ROM devices + + Media in a CD-ROM device which was hotplugged could not be changed as the + presence of the tray was not detected properly on hotplug. + v9.2.0 (2023-04-01) =================== -- 2.40.0

2 1