- Devel - libvirt List Archives

[PATCH 00/12] docs: Finish conversion of non-generated docs to rST and fix and cleanup CSS
by Peter Krempa 17 May '23

17 May '23

Browse the results at: https://pipo.sk.gitlab.io/-/libvirt/-/jobs/4294950526/artifacts/website/ind… Peter Krempa (12): css: Drop styles for '#projects' id css: Drop style for '#changelog' id css: Drop style for 'p.image' selector css: Drop styles for '.mail' class css: Drop styles for '.gitmirror' class css: mobile: Replace tabs with spaces css: mobile: Fix responsive design of 'docs' and 'knowledgebase' pages css: mobile: Fix hiding of big logo in mobile layout css: mobile: Make colums in "3 column" mobile layout wider css: Fix styling of the "3 panel" pages docs: acl: Convert to 'rst' docs: index: Convert to 'rst' docs/acl.html.in | 101 ------------------------------ docs/acl.rst | 76 +++++++++++++++++++++++ docs/aclpolkit.rst | 2 +- docs/css/libvirt.css | 143 ++++++++----------------------------------- docs/css/mobile.css | 136 ++++++++++++++++++++-------------------- docs/index.html.in | 87 -------------------------- docs/index.rst | 70 +++++++++++++++++++++ docs/meson.build | 15 +---- 8 files changed, 245 insertions(+), 385 deletions(-) delete mode 100644 docs/acl.html.in create mode 100644 docs/acl.rst delete mode 100644 docs/index.html.in create mode 100644 docs/index.rst -- 2.40.1

2 15

[PATCH 0/3] qemu: Introduce pipewire audio backend
by Michal Privoznik 16 May '23

16 May '23

You'd expect to see src/qemu/qemu_capabilities.c changed, wouldn't you. Well, there's no way to query for supported audio backends, see: https://gitlab.com/libvirt/libvirt/-/issues/473 Michal Prívozník (3): conf: Introduce pipewire audio backend qemu: Generate cmd line for pipewire audio backend NEWS: Document pipewire audio backend NEWS.rst | 10 +++ docs/formatdomain.rst | 35 +++++++++- src/conf/domain_conf.c | 70 +++++++++++++++++++ src/conf/domain_conf.h | 12 ++++ src/conf/schemas/domaincommon.rng | 37 ++++++++++ src/qemu/qemu_command.c | 63 +++++++++++++++++ src/qemu/qemu_validate.c | 1 + .../audio-many-backends.x86_64-latest.args | 2 + .../qemuxml2argvdata/audio-many-backends.xml | 1 + .../audio-pipewire-best.x86_64-latest.args | 36 ++++++++++ .../qemuxml2argvdata/audio-pipewire-best.xml | 43 ++++++++++++ .../audio-pipewire-full.x86_64-latest.args | 36 ++++++++++ .../qemuxml2argvdata/audio-pipewire-full.xml | 43 ++++++++++++ .../audio-pipewire-minimal.x86_64-latest.args | 36 ++++++++++ .../audio-pipewire-minimal.xml | 36 ++++++++++ tests/qemuxml2argvtest.c | 12 ++++ .../audio-pipewire-best.xml | 43 ++++++++++++ .../audio-pipewire-full.xml | 43 ++++++++++++ .../audio-pipewire-minimal.xml | 36 ++++++++++ tests/qemuxml2xmltest.c | 3 + 20 files changed, 596 insertions(+), 2 deletions(-) create mode 100644 tests/qemuxml2argvdata/audio-pipewire-best.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-pipewire-best.xml create mode 100644 tests/qemuxml2argvdata/audio-pipewire-full.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-pipewire-full.xml create mode 100644 tests/qemuxml2argvdata/audio-pipewire-minimal.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-pipewire-minimal.xml create mode 100644 tests/qemuxml2xmloutdata/audio-pipewire-best.xml create mode 100644 tests/qemuxml2xmloutdata/audio-pipewire-full.xml create mode 100644 tests/qemuxml2xmloutdata/audio-pipewire-minimal.xml -- 2.39.3

4 7

[PATCH 0/2] qemu_domin: Account for NVMe disks when calculating memlock limit on hotplug
by Michal Privoznik 16 May '23

16 May '23

*** BLURB HERE *** Michal Prívozník (2): qemu_domin: Account for NVMe disks when calculating memlock limit on hotplug qemu: Drop @forceVFIO argument of qemuDomainGetMemLockLimitBytes() and qemuDomainAdjustMaxMemLock() src/qemu/qemu_domain.c | 75 +++++++++++++++++++++++++++-------------- src/qemu/qemu_domain.h | 9 ++--- src/qemu/qemu_hotplug.c | 16 ++++----- src/qemu/qemu_process.c | 2 +- tests/qemumemlocktest.c | 2 +- 5 files changed, 64 insertions(+), 40 deletions(-) -- 2.39.3

2 4

[PATCH 0/2] conf: Fix formatting of 'associativity' and 'policy' cache attributes
by Peter Krempa 16 May '23

16 May '23

Peter Krempa (2): virDomainNumaDefNodeCacheParseXML: Refactor parsing of cache XML conf: numa: Allow formatting 'none' values for 'associativity' and 'policy' of cache src/conf/numa_conf.c | 73 +++++-------------- .../numatune-hmat-none.x86_64-latest.args | 49 +++++++++++++ tests/qemuxml2argvdata/numatune-hmat-none.xml | 54 ++++++++++++++ tests/qemuxml2argvtest.c | 1 + .../numatune-hmat-none.x86_64-latest.xml | 55 ++++++++++++++ tests/qemuxml2xmltest.c | 1 + 6 files changed, 178 insertions(+), 55 deletions(-) create mode 100644 tests/qemuxml2argvdata/numatune-hmat-none.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/numatune-hmat-none.xml create mode 100644 tests/qemuxml2xmloutdata/numatune-hmat-none.x86_64-latest.xml -- 2.40.1

2 3

[libvirt PATCH] docs: Fix broken link to Windows MSI downloads
by Kashyap Chamarthy 16 May '23

16 May '23

Right now the URL is 404 due to missing .html. Reported by: Sebastien Wains <swains(a)redhat.com> Signed-off-by: Kashyap Chamarthy <kchamart(a)redhat.com> --- docs/windows.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/windows.html.in b/docs/windows.html.in index 0f2d9061c4..561c08cfa1 100644 --- a/docs/windows.html.in +++ b/docs/windows.html.in @@ -17,7 +17,7 @@ <p> Users who need pre-built Windows DLLs of libvirt are advised to use the <a href="https://virt-manager.org">Virt Viewer</a> - pre-compiled <a href="https://virt-manager.org/download/">Windows MSI packages</a> + pre-compiled <a href="https://virt-manager.org/download.html">Windows MSI packages</a> </p> <p> -- 2.40.0

2 3

[PATCH] virmockstathelpers: Adapt to musl-1.2.4
by Michal Privoznik 15 May '23

15 May '23

With musl-1.2.3: I get the following macros defined (from $builddir/meson-config.h): #define WITH_LSTAT 1 #define WITH_LSTAT64 1 #define WITH_LSTAT_DECL 1 #define WITH_STAT 1 #define WITH_STAT64 1 #define WITH_STAT_DECL 1 #define WITH___LXSTAT 1 #define WITH___LXSTAT64 1 #define WITH___XSTAT 1 #define WITH___XSTAT64 1 which in turn means the virmockstathelpers.c ends up defining: MOCK_STAT64 MOCK_LSTAT64 But with musl-1.2.4 everything changes and the set of defined macros gets simplified to: #define WITH_LSTAT 1 #define WITH_LSTAT_DECL 1 #define WITH_STAT 1 #define WITH_STAT_DECL 1 #define WITH___LXSTAT 1 #define WITH___XSTAT 1 which results in no MOCK_* macros defined in virmockstathelpers.c, i.e. no stat() mocking, nada. The reason for this simplification are thess musl commits [1][2] which removed all 64 bit aliases. And that's not what our logic for deciding what flavor of stat() to mock counted with. Nevertheless, we do build with Alpine Linux in our CI, so how come we don't see this problem there? Well, simply because Alpine Linux maintainers decided to revert the commits [3][4]. But on distributions that use vanilla musl, this problem can be seen easily. 1: https://git.musl-libc.org/cgit/musl/commit/?id=246f1c811448f37a44b41cd8df8d… 2: https://git.musl-libc.org/cgit/musl/commit/?id=25e6fee27f4a293728dd15b65917… 3: https://git.alpinelinux.org/aports/commit/main/musl?id=6a5563fbb45b3d9d6067… 4: https://git.alpinelinux.org/aports/commit/main/musl?id=a089bd852f8983623fa8… Resolves: https://bugs.gentoo.org/906167 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tests/virmockstathelpers.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/tests/virmockstathelpers.c b/tests/virmockstathelpers.c index 5b1f3b08a7..a02ee04503 100644 --- a/tests/virmockstathelpers.c +++ b/tests/virmockstathelpers.c @@ -64,6 +64,10 @@ * building on Apple Silicon (aarch64) those functions are missing * from the header altogether and should not be mocked. * + * Starting from 1.2.4, the musl library dropped 64-bit aliases, i.e. there's + * no stat64() only stat(). BTW: while musl implements __xstat(), it's never + * declared. And even the implementation is but a direct call to stat(). + * * With all this in mind the list of functions we have to mock will depend * on several factors * @@ -82,7 +86,9 @@ #if !defined(__APPLE__) # if !defined(WITH___XSTAT_DECL) # if defined(WITH_STAT) -# if !defined(WITH___XSTAT) && !defined(WITH_STAT64) +# if (!defined(WITH___XSTAT) && !defined(WITH_STAT64)) || \ + (defined(WITH_STAT) && defined(WITH_STAT_DECL) && !defined(WITH_STAT64) && \ + !defined(WITH___XSTAT64)) /* glibc || musl */ # define MOCK_STAT # endif # endif @@ -99,7 +105,9 @@ # endif /* WITH___XSTAT_DECL */ # if !defined(WITH___LXSTAT_DECL) # if defined(WITH_LSTAT) -# if !defined(WITH___LXSTAT) && !defined(WITH_LSTAT64) +# if (!defined(WITH___LXSTAT) && !defined(WITH_LSTAT64)) || \ + (defined(WITH_LSTAT) && defined(WITH_LSTAT_DECL) && !defined(WITH_LSTAT64) \ + && !defined(WITH___LXSTAT64)) /* glibc || musl */ # define MOCK_LSTAT # endif # endif -- 2.39.3

3 2

[PATCH 0/3] backup: Fix schema and default filename filling logic
by Peter Krempa 15 May '23

15 May '23

Reported by 'philipp' on OFTC. Peter Krempa (3): virDomainBackupDefAssignStore: Restructure control flow conf: backup: Fix logic for generating default backup filenames schemas: backup: Allow missing 'type' attribute for backup disk src/conf/backup_conf.c | 17 +++++++++++------ src/conf/schemas/domainbackup.rng | 4 ++++ tests/domainbackupxml2xmlin/backup-push.xml | 3 +++ tests/domainbackupxml2xmlout/backup-push.xml | 9 +++++++++ 4 files changed, 27 insertions(+), 6 deletions(-) -- 2.40.1

2 4

[libvirt PATCH 0/3] qemu: Find dbus-daemon at runtime
by Andrea Bolognani 11 May '23

11 May '23

Same as the changes made recently for QEMU helpers, except even more straightforward. Andrea Bolognani (3): qemu: Find dbus-daemon at runtime meson: Stop looking for dbus-daemon qemu: Update documentation for dbus_daemon qemu.conf key meson.build | 12 ------------ src/qemu/qemu.conf.in | 4 +++- src/qemu/qemu_conf.c | 1 + src/qemu/qemu_dbus.c | 14 +++++++++----- src/qemu/test_libvirtd_qemu.aug.in | 2 +- 5 files changed, 14 insertions(+), 19 deletions(-) -- 2.40.1

2 4

[libvirt PATCH] rpm: Don't require qemu-img at build time
by Andrea Bolognani 10 May '23

10 May '23

It's not used as part of the build process or even searched for at build time. The QEMU driver detects its path at runtime. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- libvirt.spec.in | 2 -- 1 file changed, 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index c542ec3b2b..69cafc8b91 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -310,8 +310,6 @@ BuildRequires: util-linux %if %{with_qemu} # For managing ACLs BuildRequires: libacl-devel -# From QEMU RPMs -BuildRequires: /usr/bin/qemu-img %endif # For LVM drivers BuildRequires: lvm2 -- 2.40.1

4 6

[PATCH 0/2] Fix mocking around networkxml2firewalltest
by Michal Privoznik 10 May '23

10 May '23

*** BLURB HERE *** Michal Prívozník (2): util: include virfirewall.h in virfirewalld.h virfirewallmock: Replace virFindFileInPath() with virFirewallDIsRegistered() src/util/virfirewalld.h | 2 ++ tests/virfirewallmock.c | 16 ++++------------ 2 files changed, 6 insertions(+), 12 deletions(-) -- 2.39.2

3 5