- Devel - libvirt List Archives

[PATCH v2 0/2] qemu: generate shorter channel target paths
by Michal Privoznik 24 Jul '23

24 Jul '23

v2 of: https://listman.redhat.com/archives/libvir-list/2023-July/240680.html diff to v1: - Squashed some patches together - Updated comment in qemuDomainChrDefDropDefaultPath() - fixed more XMLs Michal Prívozník (2): qemu: Generate shorter channel target paths qemu: Move channelTargetDir into stateDir libvirt.spec.in | 2 - src/qemu/qemu_conf.c | 9 +-- src/qemu/qemu_domain.c | 65 ++++++++++++++++--- .../qemuhotplug-qemu-agent-detach.xml | 2 +- .../qemuhotplug-base+qemu-agent-detach.xml | 2 +- .../qemuhotplug-base+qemu-agent.xml | 2 +- ...emuhotplug-base-live+qemu-agent-detach.xml | 2 +- .../qemuhotplug-base-live+qemu-agent.xml | 2 +- .../channel-unix-source-path.xml | 8 +++ .../channel-unix-source-path-active.xml | 10 +++ .../channel-unix-source-path-inactive.xml | 8 +++ tests/testutilsqemu.c | 2 +- 12 files changed, 90 insertions(+), 24 deletions(-) -- 2.41.0

1 2

[PATCH 0/4] qemu: generate shorter channel target paths
by Michal Privoznik 24 Jul '23

24 Jul '23

*** BLURB HERE *** Michal Prívozník (4): qemu: Generate shorter channel target paths tests: Reflect changed channelTargetDir qemu: Move channelTargetDir into stateDir tests: Reflect changed channelTargetDir libvirt.spec.in | 2 - src/qemu/qemu_conf.c | 9 +-- src/qemu/qemu_domain.c | 59 ++++++++++++++++--- .../qemuhotplug-qemu-agent-detach.xml | 2 +- ...emuhotplug-base-live+qemu-agent-detach.xml | 2 +- .../qemuhotplug-base-live+qemu-agent.xml | 2 +- .../channel-unix-source-path.xml | 8 +++ .../channel-unix-source-path-active.xml | 10 ++++ .../channel-unix-source-path-inactive.xml | 8 +++ tests/testutilsqemu.c | 2 +- 10 files changed, 85 insertions(+), 19 deletions(-) -- 2.41.0

3 7

[libvirt] [PATCH RESEND 0/4] Introduce Notification VM exit feature (kvm x86 only)
by Lin Ma 24 Jul '23

24 Jul '23

Kernel supports Notification VM exit feature since v6.0 under commit 2f4073e0. QEMU supports it as well since v7.2 under commit e2e69f6b. Lin Ma (4): conf: Introduce notify VM exit feature qemu: Validate notify VM exit feature is available only on x86 qemu: Generate command line for notify VM exit feature NEWS: Document notify VM exit feature NEWS.rst | 8 ++++++ docs/formatdomain.rst | 4 +++ src/conf/domain_conf.c | 32 +++++++++++++++++++++ src/conf/domain_conf.h | 7 +++++ src/conf/schemas/domaincommon.rng | 17 +++++++++++ src/qemu/qemu_command.c | 23 +++++++++++++-- src/qemu/qemu_validate.c | 12 +++++++- tests/qemuxml2argvdata/kvm-features-off.xml | 1 + tests/qemuxml2argvdata/kvm-features.args | 2 +- tests/qemuxml2argvdata/kvm-features.xml | 1 + 10 files changed, 102 insertions(+), 5 deletions(-) -- 2.41.0

4 8

[PATCH] docs: Mention vhostuser for queues and queue_size
by Han Han 24 Jul '23

24 Jul '23

These two attributes are supported for vhost-user-blk as well. Signed-off-by: Han Han <hhan(a)redhat.com> --- docs/formatdomain.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 4af0b82569..447ab32c01 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -3275,9 +3275,9 @@ paravirtualized driver is specified via the ``disk`` element. "virtio" ``bus`` and "pci" or "ccw" ``address`` types. :since:`Since 1.2.8 (QEMU 2.1)` - The optional ``queues`` attribute specifies the number of virt queues for - virtio-blk. ( :since:`Since 3.9.0` ) + virtio-blk or vhost-user-blk. ( :since:`Since 3.9.0` ) - The optional ``queue_size`` attribute specifies the size of each virt - queue for virtio-blk. ( :since:`Since 7.8.0` ) + queue for virtio-blk or vhost-user-blk. ( :since:`Since 7.8.0` ) - For virtio disks, `Virtio-related options`_ can also be set. ( :since:`Since 3.5.0` ) - The optional ``metadata_cache`` subelement controls aspects related to the -- 2.41.0

2 4

Plans for 9.6.0 release (freeze on Wednesday 26 Jul)
by Jiri Denemark 21 Jul '23

21 Jul '23

We are getting close to 9.6.0 release of libvirt. To aim for the release on Tuesday 01 Aug I suggest entering the freeze on Wednesday 26 Jul and tagging RC2 on Friday 28 Jul. I hope this works for everyone. Jirka

1 0

[PATCH 0/2] qemu_tpm: Try harder to create emulator state
by Michal Privoznik 21 Jul '23

21 Jul '23

*** BLURB HERE *** Michal Prívozník (2): virfile: Introduce virDirIsEmpty() qemu_tpm: Try harder to create emulator state src/libvirt_private.syms | 1 + src/qemu/qemu_tpm.c | 3 ++- src/util/virfile.c | 39 +++++++++++++++++++++++++++++++++++++++ src/util/virfile.h | 3 +++ 4 files changed, 45 insertions(+), 1 deletion(-) -- 2.41.0

2 4

[PATCH 0/2] Improve the validation for queues and queue_size
by Han Han 21 Jul '23

21 Jul '23

Han Han (2): conf/domain_validate.c: Improve the err for queue validation conf/domain_validate: Validate the disk queue_size src/conf/domain_validate.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) -- 2.41.0

2 3

Plans for the next release
by Jiri Denemark 21 Jul '23

21 Jul '23

We are getting close to the next release of libvirt. To aim for the release on Aug 01 I suggest entering the freeze on Wednesday Jul 26 and tagging RC2 on Friday Jul 28. I hope this works for everyone. Jirka

1 0

[PATCH RFC 0/4] rely on QEMU provided macros for some QEMU feature selection
by Daniel P. Berrangé 20 Jul '23

20 Jul '23

We currently have various features in the RPMs selected based on what the QEMU RPM has built. If the QEMU RPM changes, then libvirt needs to change to match which is an undesirable situation. Forthcoming upstream QEMU changes will involve corresponding Fedora downstream changes. eg removal of i386 host support for system emulators. I would like to make it so that we don't change libvirt RPM spec when these changes happen, merely rebuild libvirt and it "does the right thing". To that end I've proposed some QEMU macros for Fedora: https://src.fedoraproject.org/rpms/qemu/pull-request/43 with intention they would also go into future RHEL-10. This series illustrates what libvirt RPM spec changes would be to adapt to this. I'm not proposing to merge this libvirt series. Rather looking for whether I've missed anything in the design from te QEMU side that could be done better for libvirt. Daniel P. Berrangé (4): rpm: boilerplate to pull in qemu-srpm-macros rpm: use %{qemu_sysemu_host_arches} rpm: use %{qemu_sysemu_kvm_arches} rpm: use %{qemu_sysemu_tcg_non_native} libvirt.spec.in | 49 ++++++++++++++++++++++++++++++++----------------- 1 file changed, 32 insertions(+), 17 deletions(-) -- 2.41.0

1 4

[PATCH] storage: zfs: Use 'zfs list' to check pool status
by Matt Low 20 Jul '23

20 Jul '23

The current virtStorageBackendZFSCheckPool checks for the existence of a path under /dev/zvol/ to determine if the pool is active. ZFS does not create a path under /dev/zvol/ if no ZFS volumes have been created under a particular dataset, thus, empty ZFS storage pools are deactivated whenever checkPool is called on them (as noted in referenced issue). This commit changes virStorageBackendZFSCheckPool so that the 'zfs list' command is used to explicitly check for the existence a dataset specified by the pool's def->source.name. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/221 Signed-off-by: Matt Low <matt(a)mlow.ca> --- src/storage/storage_backend_zfs.c | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/src/storage/storage_backend_zfs.c b/src/storage/storage_backend_zfs.c index 2a5d74357d..4e243a738a 100644 --- a/src/storage/storage_backend_zfs.c +++ b/src/storage/storage_backend_zfs.c @@ -85,10 +85,24 @@ virStorageBackendZFSCheckPool(virStoragePoolObj *pool G_GNUC_UNUSED, bool *isActive) { virStoragePoolDef *def = virStoragePoolObjGetDef(pool); - g_autofree char *devpath = NULL; + g_autoptr(virCommand) cmd = NULL; + int exit_code = -1; + + /* Check for an existing dataset of type 'filesystem' by the name of our + * pool->source.name. */ + cmd = virCommandNewArgList(ZFS, + "list", "-H", + "-t", "filesystem", + "-o", "name", + def->source.name, + NULL); + + + if (virCommandRun(cmd, &exit_code) < 0) + return -1; - devpath = g_strdup_printf("/dev/zvol/%s", def->source.name); - *isActive = virFileIsDir(devpath); + /* zfs list exits with 0 if the dataset exists, 1 if it doesn't */ + *isActive = exit_code == 0; return 0; } -- 2.39.2

3 2