- Devel - libvirt List Archives

[RFC] Adding timestamp to guest's serial console log
by Shaleen Bathla 29 Aug '23

29 Aug '23

Hi, Need some comments regarding the following feature : Addition of timestamp support for serial console logs of a guest. We can implement it as a configurable attribute in xml. For example : <serial type='pty'> <log file='$PATH/$GUESTNAME-serial0.log' append='on' timestamp="on/off"/> <target type='isa-serial' port='0'> <model name='isa-serial'/> </target> </serial> We can add a timestamp after every '\n' character received from qemu. Can I have some comments regarding this change like what I should keep in mind while implementing, whether it is a welcome addition or not, issues I might face, any qemu changes required. Thanks and Regards, Shaleen Bathla

4 5

[libvirt PATCH 0/2] tools: some fixes to VMSA construction when validating SEV boot
by Daniel P. Berrangé 29 Aug '23

29 Aug '23

Daniel P. Berrangé (2): tools: fix handling of CPU family/model/stepping in SEV validation tools: fix VMSA construction with explicit CPU family/model/stepping tools/virt-qemu-sev-validate | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) -- 2.41.0

3 7

CPU pinning implementation through libvirt
by xtec＠trimaso.com.mx 28 Aug '23

28 Aug '23

I'll be direct. After learning that QEMU itself has never officially implemented options such as "-vcpu", "-vcpupin", or similar, remaining only as unimplemented commits at their mailing lists, I felt the need of asking here once and for all: How does libvirt actually implements CPU pinning under the hood? There's the xml with the cputune section and all the vcpupins, but does libvirt translates this to QEMU native commands, or what else does it do? Thanks.

2 1

[libvirt PATCH v2 0/7] Introduce new Metadata fields for Network object with corresponding APIs
by K Shiva Kiran 25 Aug '23

25 Aug '23

This commit adds the following: - Introduction of <title> and <description> fields to the Network Object. - Introduction of Get and Set Public APIs for the aforementioned fields. - virsh exposure of the aforementioned Public APIs. - Adds implementation in test driver along with a testcase. - Implementation in bridge driver. This is a v2 of: https://listman.redhat.com/archives/libvir-list/2023-July/240828.html Diff to v1: - Corrected placement of structs in remote_protocol-structs. - Removed redundant call to virNetworkObjSetDefTransient() in virNetworkConfigChangeSetup(). - Removed redundant logic in networkUpdate(), substituted by call to newly introduced virNetworkObjUpdateModificationImpact(). - Added virsh exposure of the APIs. - Added bridge driver implementation. Signed-off-by: K Shiva Kiran <shiva_kr(a)riseup.net> K Shiva Kiran (7): Add <title> and <description> for Network Objects Adding Public Get and Set APIs for Network Metadata Implementing Remote Protocol for Network Metadata virsh exposure of Network Metadata APIs Add virNetworkObj Get and Set Methods for Metadata Add Test driver and testcase for Network Metadata change APIs Added bridge driver implementation docs/formatnetwork.rst | 11 + docs/manpages/virsh.rst | 77 ++++++ include/libvirt/libvirt-network.h | 29 +++ include/libvirt/virterror.h | 1 + src/conf/network_conf.c | 21 ++ src/conf/network_conf.h | 2 + src/conf/schemas/basictypes.rng | 15 ++ src/conf/schemas/domaincommon.rng | 15 -- src/conf/schemas/network.rng | 10 + src/conf/virnetworkobj.c | 329 +++++++++++++++++++++++- src/conf/virnetworkobj.h | 21 ++ src/driver-network.h | 16 ++ src/libvirt-network.c | 167 ++++++++++++ src/libvirt_private.syms | 3 + src/libvirt_public.syms | 6 + src/network/bridge_driver.c | 78 +++++- src/remote/remote_driver.c | 2 + src/remote/remote_protocol.x | 36 ++- src/remote_protocol-structs | 19 ++ src/test/test_driver.c | 83 +++++- src/util/virerror.c | 3 + tests/meson.build | 1 + tests/networkmetadatatest.c | 297 +++++++++++++++++++++ tools/virsh-network.c | 411 +++++++++++++++++++++++++++++- tools/virsh-util.c | 25 ++ tools/virsh-util.h | 9 + 26 files changed, 1624 insertions(+), 63 deletions(-) create mode 100644 tests/networkmetadatatest.c -- 2.41.0

3 11

[PATCH v3 0/2] add support for discard_granularity
by Kristina Hanicova 25 Aug '23

25 Aug '23

v3 of: https://listman.redhat.com/archives/libvir-list/2023-August/241452.html diff to v2 (suggested by Peter): * added note to the first commit * enabled qemuxml2xmltest for blockio * moved one hunk to the first commit Kristina Hanicova (2): conf: add support for discard_granularity qemu: add support for discard_granularity docs/formatdomain.rst | 6 ++- src/conf/domain_conf.c | 19 +++++++- src/conf/domain_conf.h | 1 + src/conf/domain_validate.c | 3 +- src/conf/schemas/domaincommon.rng | 5 ++ src/qemu/qemu_command.c | 2 + src/qemu/qemu_domain.c | 2 + src/vz/vz_utils.c | 3 +- .../disk-blockio.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-blockio.xml | 2 +- .../disk-blockio.x86_64-latest.xml | 48 +++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 12 files changed, 88 insertions(+), 6 deletions(-) create mode 100644 tests/qemuxml2xmloutdata/disk-blockio.x86_64-latest.xml -- 2.41.0

2 3

[PATCH] docs: Improve documentation of <disk type='dir'>
by Peter Krempa 25 Aug '23

25 Aug '23

Note the implications and caveats of <disk type='dir'>. Closes: https://gitlab.com/libvirt/libvirt/-/issues/519 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- docs/formatdomain.rst | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index cd9cb02bf8..9787933d4d 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -2634,6 +2634,12 @@ paravirtualized driver is specified via the ``disk`` element. </source> <target dev='sdb' bus='scsi'/> </disk> + <disk type='dir' device='floppy'> + <driver name='qemu' type='fat'/> + <source dir='/var/somefiles'> + <target dev='fda'/> + <readonly/> + </disk> <disk type='volume' device='disk'> <driver name='qemu' type='raw'/> <source pool='iscsi-pool' volume='unit:0:0:1' mode='host'/> @@ -2757,6 +2763,18 @@ paravirtualized driver is specified via the ``disk`` element. ``dir`` The ``dir`` attribute specifies the fully-qualified path to the directory to use as the disk. :since:`Since 0.7.5` + + Note that most hypervisors that support ``dir`` disks do that by exposing + an emulated block device with an emulated filesystem populated with + contents of the configured directory. As guest operating system may cache + the filesystem metadata, outside changes to the directory may not appear + in the guest and/or may result in corrupted data being observable from + the VM. + + The format of the emulated filesystem is controlled by the ``format`` + attribute of the ``<driver>`` driver element. Currently only the ``fat`` + format is supported. Hypervisors may only support ``<readonly/>`` mode. + ``network`` The ``protocol`` attribute specifies the protocol to access to the requested image. Possible values are "nbd", "iscsi", "rbd", "sheepdog", -- 2.41.0

3 2

[PATCH (pushed)] qemucapabilitiesdata: Final update of capability test data for qemu-8.1.0 release
by Peter Krempa 25 Aug '23

25 Aug '23

Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- Pushed as trivial. tests/qemucapabilitiesdata/caps_8.1.0_x86_64.replies | 6 +++--- tests/qemucapabilitiesdata/caps_8.1.0_x86_64.xml | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/qemucapabilitiesdata/caps_8.1.0_x86_64.replies b/tests/qemucapabilitiesdata/caps_8.1.0_x86_64.replies index e6cc5da1c4..c28073c16c 100644 --- a/tests/qemucapabilitiesdata/caps_8.1.0_x86_64.replies +++ b/tests/qemucapabilitiesdata/caps_8.1.0_x86_64.replies @@ -17,11 +17,11 @@ { "return": { "qemu": { - "micro": 94, - "minor": 0, + "micro": 0, + "minor": 1, "major": 8 }, - "package": "v8.1.0-rc4" + "package": "v8.1.0" }, "id": "libvirt-2" } diff --git a/tests/qemucapabilitiesdata/caps_8.1.0_x86_64.xml b/tests/qemucapabilitiesdata/caps_8.1.0_x86_64.xml index 313af6a00e..0a9b5d3b46 100644 --- a/tests/qemucapabilitiesdata/caps_8.1.0_x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_8.1.0_x86_64.xml @@ -204,9 +204,9 @@ <flag name='rbd-encryption-luks-any'/> <flag name='qcow2-discard-no-unref'/> <flag name='run-with.async-teardown'/> - <version>8000094</version> + <version>8001000</version> <microcodeVersion>43100245</microcodeVersion> - <package>v8.1.0-rc4</package> + <package>v8.1.0</package> <arch>x86_64</arch> <hostCPU type='kvm' model='base' migratability='yes'> <property name='avx-ne-convert' type='boolean' value='false'/> -- 2.41.0

1 0

[PATCH v2 0/2] add support for discard_granularity
by Kristina Hanicova 25 Aug '23

25 Aug '23

This is v2 (or rather the first 2 patches) of: https://listman.redhat.com/archives/libvir-list/2023-August/241076.html diff to v1: * added ABI stability check (noticed by Peter) * splitting the series into two parts Kristina Hanicova (2): conf: add support for discard_granularity qemu: add support for discard_granularity docs/formatdomain.rst | 6 +++++- src/conf/domain_conf.c | 19 ++++++++++++++++++- src/conf/domain_conf.h | 1 + src/conf/domain_validate.c | 3 ++- src/conf/schemas/domaincommon.rng | 5 +++++ src/qemu/qemu_command.c | 2 ++ src/qemu/qemu_domain.c | 2 ++ src/vz/vz_utils.c | 3 ++- .../disk-blockio.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-blockio.xml | 2 +- 10 files changed, 39 insertions(+), 6 deletions(-) -- 2.41.0

2 4

[PATCH] virsh-network: Drop unused variables in cmdNetworkMetadata()
by Michal Privoznik 25 Aug '23

25 Aug '23

In one of recent commits two variable were introduced (@ctxt and @doc) that are not used. This breaks a build with clang who's able to identify that. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed under trivial and build breaker rules. tools/virsh-network.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/virsh-network.c b/tools/virsh-network.c index f9fea0a126..5655254699 100644 --- a/tools/virsh-network.c +++ b/tools/virsh-network.c @@ -597,7 +597,6 @@ static bool cmdNetworkMetadata(vshControl *ctl, const vshCmd *cmd) { g_autoptr(virshNetwork) net = NULL; - g_autoptr(xmlXPathContext) ctxt = NULL; bool config = vshCommandOptBool(cmd, "config"); bool live = vshCommandOptBool(cmd, "live"); bool current = vshCommandOptBool(cmd, "current"); @@ -661,7 +660,7 @@ cmdNetworkMetadata(vshControl *ctl, const vshCmd *cmd) vshPrintExtra(ctl, "%s\n", _("Metadata modified")); } else { g_autofree char *data = NULL; - g_autoptr(xmlDoc) doc = NULL; + /* get */ if (!(data = virNetworkGetMetadata(net, VIR_NETWORK_METADATA_ELEMENT, uri, flags))) -- 2.41.0

1 0

[PATCH 00/27] Move error messages onto a single line
by Michal Privoznik 25 Aug '23

25 Aug '23

This is inspired by the following discussion: https://listman.redhat.com/archives/libvir-list/2023-August/241361.html And ideally I'd present a green pipeline but for some reason, I can't: https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/981105262 But the problem is not with my code rather than our CI. Michal Prívozník (27): bhyve: Move error messages onto a single line ch: Move error messages onto a single line conf: Move error messages onto a single line cpu: Move error messages onto a single line esx: Move error messages onto a single line hypervisor: Move error messages onto a single line libxl: Move error messages onto a single line locking: Move error messages onto a single line lxc: Move error messages onto a single line network: Move error messages onto a single line node_device: Move error messages onto a single line nwfilter: Move error messages onto a single line openvz: Move error messages onto a single line qemu: Move error messages onto a single line remote: Move error messages onto a single line rpc: Move error messages onto a single line security: Move error messages onto a single line storage: Move error messages onto a single line storage_file: Move error messages onto a single line test: Move error messages onto a single line util: Move error messages onto a single line vbox: Move error messages onto a single line vmware: Move error messages onto a single line vmx: Move error messages onto a single line vz: Move error messages onto a single line src: Move error messages onto a single line tools: Move error messages onto a single line src/bhyve/bhyve_command.c | 31 +-- src/bhyve/bhyve_domain.c | 3 +- src/bhyve/bhyve_driver.c | 3 +- src/ch/ch_driver.c | 3 +- src/ch/ch_monitor.c | 3 +- src/conf/cpu_conf.c | 9 +- src/conf/domain_addr.c | 3 +- src/conf/domain_conf.c | 138 ++++-------- src/conf/domain_validate.c | 54 ++--- src/conf/netdev_bandwidth_conf.c | 3 +- src/conf/netdev_vlan_conf.c | 6 +- src/conf/network_conf.c | 27 +-- src/conf/node_device_conf.c | 3 +- src/conf/node_device_util.c | 3 +- src/conf/numa_conf.c | 25 +-- src/conf/nwfilter_params.c | 6 +- src/conf/snapshot_conf.c | 3 +- src/conf/storage_adapter_conf.c | 18 +- src/conf/virdomainjob.c | 3 +- src/conf/virnetworkobj.c | 3 +- src/cpu/cpu_x86.c | 6 +- src/esx/esx_driver.c | 21 +- src/esx/esx_network_driver.c | 3 +- src/esx/esx_storage_backend_vmfs.c | 3 +- src/esx/esx_util.c | 3 +- src/esx/esx_vi.c | 19 +- src/esx/esx_vi_types.c | 3 +- src/hypervisor/domain_cgroup.c | 3 +- src/hypervisor/virhostdev.c | 9 +- src/libvirt-domain.c | 54 ++--- src/libxl/libxl_conf.c | 12 +- src/libxl/libxl_driver.c | 6 +- src/libxl/libxl_migration.c | 11 +- src/locking/lock_driver_sanlock.c | 3 +- src/lxc/lxc_container.c | 3 +- src/lxc/lxc_driver.c | 3 +- src/lxc/lxc_native.c | 3 +- src/lxc/lxc_process.c | 3 +- src/network/bridge_driver.c | 14 +- src/network/bridge_driver_linux.c | 10 +- src/node_device/node_device_udev.c | 3 +- src/nwfilter/nwfilter_dhcpsnoop.c | 12 +- src/nwfilter/nwfilter_learnipaddr.c | 8 +- src/openvz/openvz_driver.c | 3 +- src/qemu/qemu_agent.c | 18 +- src/qemu/qemu_capabilities.c | 45 ++-- src/qemu/qemu_command.c | 42 ++-- src/qemu/qemu_conf.c | 5 +- src/qemu/qemu_domain.c | 51 ++--- src/qemu/qemu_domain_address.c | 15 +- src/qemu/qemu_driver.c | 120 ++++------ src/qemu/qemu_hostdev.c | 3 +- src/qemu/qemu_hotplug.c | 18 +- src/qemu/qemu_migration.c | 48 ++-- src/qemu/qemu_migration_params.c | 6 +- src/qemu/qemu_monitor.c | 3 +- src/qemu/qemu_monitor_json.c | 102 +++------ src/qemu/qemu_process.c | 20 +- src/qemu/qemu_snapshot.c | 27 +-- src/qemu/qemu_tpm.c | 4 +- src/qemu/qemu_validate.c | 209 ++++++------------ src/remote/remote_daemon.c | 3 +- src/remote/remote_driver.c | 27 +-- src/remote/remote_sockets.c | 3 +- src/rpc/virnetclient.c | 9 +- src/rpc/virnetlibsshsession.c | 28 +-- src/rpc/virnetserver.c | 9 +- src/rpc/virnetserverclient.c | 3 +- src/rpc/virnetsshsession.c | 45 ++-- src/rpc/virnettlscontext.c | 6 +- src/security/security_dac.c | 3 +- src/storage/storage_backend_disk.c | 3 +- src/storage/storage_backend_fs.c | 3 +- src/storage/storage_backend_zfs.c | 3 +- src/storage/storage_driver.c | 21 +- src/storage/storage_util.c | 48 ++-- src/storage_file/storage_source.c | 3 +- .../storage_source_backingstore.c | 36 +-- src/test/test_driver.c | 39 ++-- src/util/vircgroupv2devices.c | 13 +- src/util/vircommand.c | 3 +- src/util/virfile.c | 3 +- src/util/virhostcpu.c | 3 +- src/util/virhostmem.c | 6 +- src/util/virjson.c | 3 +- src/util/virmdev.c | 3 +- src/util/virnetdev.c | 12 +- src/util/virnetdevbandwidth.c | 6 +- src/util/virnetdevopenvswitch.c | 6 +- src/util/virnetdevvportprofile.c | 6 +- src/util/virnetlink.c | 3 +- src/util/virnuma.c | 6 +- src/util/virpci.c | 3 +- src/util/virprocess.c | 9 +- src/util/virqemu.c | 3 +- src/util/virresctrl.c | 9 +- src/util/virthreadpool.c | 3 +- src/vbox/vbox_snapshot_conf.c | 6 +- src/vmware/vmware_conf.c | 9 +- src/vmware/vmware_driver.c | 6 +- src/vmx/vmx.c | 21 +- src/vz/vz_driver.c | 15 +- src/vz/vz_sdk.c | 135 ++++------- src/vz/vz_utils.c | 66 ++---- tools/virsh-domain-event.c | 15 +- tools/virsh-domain.c | 36 +-- tools/virsh-host.c | 9 +- tools/virsh-network.c | 6 +- tools/virsh-nodedev.c | 3 +- tools/virsh-pool.c | 3 +- tools/virsh.c | 9 +- tools/virt-admin.c | 21 +- tools/virt-host-validate-ch.c | 12 +- tools/virt-host-validate-qemu.c | 15 +- tools/vsh.c | 12 +- 115 files changed, 689 insertions(+), 1403 deletions(-) -- 2.41.0

3 29