- Devel - libvirt List Archives

[libvirt PATCH] meson: Improve nbdkit configurability
by Andrea Bolognani 05 Oct '23

05 Oct '23

Currently, nbdkit support will automatically be enabled as long as the pidfd_open(2) syscall is available. Optionally, libnbd is used to generate more user-friendly error messages. In theory this is all good, since use of nbdkit is supposed to be transparent to the user. In practice, however, there is a problem: if support for it is enabled at build time and the necessary runtime components are installed, nbdkit will always be preferred, with no way for the user to opt out. This will arguably be fine in the long run, but right now none of the platforms that we target ships with a SELinux policy that allows libvirt to launch nbdkit, and the AppArmor policy that we maintain ourselves hasn't been updated either. So, in practice, as of today having nbdkit installed on the host makes network disks completely unusable unless you're willing to compromise the overall security of the system by disabling SELinux/AppArmor. In order to make the transition smoother, provide a convenient way for users and distro packagers to disable nbdkit support at compile time until SELinux and AppArmor are ready. In the process, detection is completely overhauled. libnbd is made mandatory when nbdkit support is enabled, since availability across operating systems is comparable and offering users the option to make error messages worse doesn't make a lot of sense; we also make sure that an explicit request from the user to enable/disable nbdkit support is either complied with, or results in a build failure when that's not possible. Last but not least, we avoid linking against libnbd when nbdkit support is disabled. At the RPM level, we disable the feature when building against RHEL 8, which doesn't have pidfd_open(2), and also allow it to be disabled at build time the same as other optional features, that is, by passing "--define '_without_nbdkit 1'" to rpmbuild. Finally, if nbdkit support has been disabled, installing libvirt will no longer drag it in as a (weak) dependency. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- libvirt.spec.in | 23 ++++++++++++++++++++--- meson.build | 29 +++++++++++++++++++++-------- meson_options.txt | 2 +- src/qemu/qemu_nbdkit.c | 6 +++--- 4 files changed, 45 insertions(+), 15 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index f3d21ccc8f..2ea465348c 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -95,6 +95,7 @@ %define with_fuse 0 %define with_sanlock 0 %define with_numad 0 +%define with_nbdkit 0 %define with_firewalld_zone 0 %define with_netcf 0 %define with_libssh2 0 @@ -173,6 +174,13 @@ %endif %endif +# nbdkit support requires pidfd_open(2), which is not in RHEL 8 +%if %{with_qemu} + %if 0%{?fedora} || 0%{?rhel} >= 9 + %define with_nbdkit 0%{!?_without_nbdkit:1} + %endif +%endif + %ifarch %{arches_dmidecode} %define with_dmidecode 0%{!?_without_dmidecode:1} %endif @@ -312,6 +320,9 @@ BuildRequires: util-linux BuildRequires: libacl-devel # From QEMU RPMs, used by virstoragetest BuildRequires: /usr/bin/qemu-img +%endif +# nbdkit support requires libnbd +%if %{with_nbdkit} BuildRequires: libnbd-devel %endif # For LVM drivers @@ -769,9 +780,11 @@ Requires: numad Recommends: passt Recommends: passt-selinux %endif + %if %{with_nbdkit} Recommends: nbdkit Recommends: nbdkit-curl-plugin Recommends: nbdkit-ssh-plugin + %endif %description daemon-driver-qemu The qemu driver plugin for the libvirtd daemon, providing @@ -1078,10 +1091,8 @@ exit 1 %if %{with_qemu} %define arg_qemu -Ddriver_qemu=enabled - %define arg_libnbd -Dlibnbd=enabled %else %define arg_qemu -Ddriver_qemu=disabled - %define arg_libnbd -Dlibnbd=disabled %endif %if %{with_openvz} @@ -1158,6 +1169,12 @@ exit 1 %define arg_numad -Dnumad=disabled %endif +%if %{with_nbdkit} + %define arg_nbdkit -Dnbdkit=enabled +%else + %define arg_nbdkit -Dnbdkit=disabled +%endif + %if %{with_fuse} %define arg_fuse -Dfuse=enabled %else @@ -1270,7 +1287,7 @@ export SOURCE_DATE_EPOCH=$(stat --printf='%Y' %{_specdir}/libvirt.spec) -Dyajl=enabled \ %{?arg_sanlock} \ -Dlibpcap=enabled \ - %{?arg_libnbd} \ + %{?arg_nbdkit} \ -Dlibnl=enabled \ -Daudit=enabled \ -Ddtrace=enabled \ diff --git a/meson.build b/meson.build index 6fa1f74670..de23fbda1e 100644 --- a/meson.build +++ b/meson.build @@ -1011,10 +1011,27 @@ endif libiscsi_version = '1.18.0' libiscsi_dep = dependency('libiscsi', version: '>=' + libiscsi_version, required: get_option('libiscsi')) -libnbd_version = '1.0' -libnbd_dep = dependency('libnbd', version: '>=' + libnbd_version, required: get_option('libnbd')) -if libnbd_dep.found() - conf.set('WITH_LIBNBD', 1) +if not get_option('nbdkit').disabled() + libnbd_version = '1.0' + libnbd_dep = dependency('libnbd', version: '>=' + libnbd_version, required: false) + + nbdkit_requested = get_option('nbdkit').enabled() + nbdkit_syscall_ok = conf.has('WITH_DECL_SYS_PIDFD_OPEN') + nbdkit_libnbd_ok = libnbd_dep.found() + + if not nbdkit_syscall_ok and nbdkit_requested + error('nbdkit support requires pidfd_open(2)') + endif + if not nbdkit_libnbd_ok and nbdkit_requested + error('nbdkit support requires libnbd') + endif + + if nbdkit_syscall_ok and nbdkit_libnbd_ok + conf.set('WITH_NBDKIT', 1) + endif +endif +if not conf.has('WITH_NBDKIT') + libnbd_dep = dependency('', required: false) endif libnl_version = '3.0' @@ -2024,10 +2041,6 @@ endif conf.set_quoted('TLS_PRIORITY', get_option('tls_priority')) -if conf.has('WITH_DECL_SYS_PIDFD_OPEN') - conf.set('WITH_NBDKIT', 1) -endif - # Various definitions # Python3 < 3.7 treats the C locale as 7-bit only. We must force env vars so diff --git a/meson_options.txt b/meson_options.txt index ba6e49afc5..7c428a9eb0 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -25,7 +25,6 @@ option('curl', type: 'feature', value: 'auto', description: 'curl support') option('fuse', type: 'feature', value: 'auto', description: 'fuse support') option('glusterfs', type: 'feature', value: 'auto', description: 'glusterfs support') option('libiscsi', type: 'feature', value: 'auto', description: 'libiscsi support') -option('libnbd', type: 'feature', value: 'auto', description: 'libnbd support') option('libnl', type: 'feature', value: 'auto', description: 'libnl support') option('libpcap', type: 'feature', value: 'auto', description: 'libpcap support') option('libssh', type: 'feature', value: 'auto', description: 'libssh support') @@ -105,6 +104,7 @@ option('loader_nvram', type: 'string', value: '', description: 'Pass list of pai option('login_shell', type: 'feature', value: 'auto', description: 'build virt-login-shell') option('nss', type: 'feature', value: 'auto', description: 'enable Name Service Switch plugin for resolving guest IP addresses') option('numad', type: 'feature', value: 'auto', description: 'use numad to manage CPU placement dynamically') +option('nbdkit', type: 'feature', value: 'auto', description: 'use nbdkit to access network disks') option('pm_utils', type: 'feature', value: 'auto', description: 'use pm-utils for power management') option('sysctl_config', type: 'feature', value: 'auto', description: 'Whether to install sysctl configs') option('tls_priority', type: 'string', value: 'NORMAL', description: 'set the default TLS session priority string') diff --git a/src/qemu/qemu_nbdkit.c b/src/qemu/qemu_nbdkit.c index 17819ca992..3ad63cfaa0 100644 --- a/src/qemu/qemu_nbdkit.c +++ b/src/qemu/qemu_nbdkit.c @@ -19,7 +19,7 @@ #include <config.h> #include <glib.h> -#if WITH_LIBNBD +#if WITH_NBDKIT # include <libnbd.h> #endif #include <sys/syscall.h> @@ -1159,7 +1159,7 @@ qemuNbdkitProcessStart(qemuNbdkitProcess *proc, g_autofree char *basename = g_strdup_printf("%s-nbdkit-%i", vm->def->name, proc->source->id); int logfd = -1; g_autoptr(qemuLogContext) logContext = NULL; -#if WITH_LIBNBD +#if WITH_NBDKIT struct nbd_handle *nbd = NULL; #endif @@ -1214,7 +1214,7 @@ qemuNbdkitProcessStart(qemuNbdkitProcess *proc, while (virTimeBackOffWait(&timebackoff)) { if (virFileExists(proc->socketfile)) { -#if WITH_LIBNBD +#if WITH_NBDKIT /* if the disk source was misconfigured, nbdkit will not produce an error * until somebody connects to the socket and tries to access the nbd * export. This results in poor user experience because the only error we -- 2.41.0

1 0

Release of libvirt-9.8.0
by Jiri Denemark 02 Oct '23

02 Oct '23

The 9.8.0 release of both libvirt and libvirt-python is tagged and signed tarballs and source RPMs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is greatly appreciated. * New features * network: New metadata change event The network object now has a new event ID ``VIR_NETWORK_EVENT_ID_METADATA_CHANGE`` that can be used to get notifications upon changes in any of ``<title>``, ``<description>`` or ``<metadata>``. * qemu: Add support for vDPA block devices With a new enough version of qemu, libvirt will allow you to assign vDPA block devices to a domain. This is configured with:: <disk type='vhostvdpa'> <source dev='/dev/vhost-vdpa-0'> ... * Improvements * qemu: add nbdkit backend for network disks Up until now, libvirt supported network disks (http, ftp, ssh) by passing the URL to qemu and having the appropriate qemu block drivers handle the disk I/O. However, by handling the network I/O outside of the qemu process, we get several advantages, such as reduced attack surface and improved stability of qemu. Therefore, when available, libvirt will use nbdkit as a backend for these network disks and export an NBD disk to qemu. * virnetdevopenvswitch: Propagate OVS error messages When configuring OVS interfaces/bridges libvirt used to report its own error messages instead of passing (more accurate) error messages from `ovs-vsctl`. This is now changed. * Various virtio-mem/virtio-pmem fixes Now libvirt validates more values of virtio-mem and virtio-pmem devices, e.g. overlapping memory addresses or alignment. Enjoy. Jirka

1 0

The attached virtio disk is not recognized by libvirt but it is recognized by qemu
by Mario Marietto 30 Sep '23

30 Sep '23

Hello. I'm trying to virtualize FreeBSD 13.2 for arm 32 bit on my laptop ARM Chromebook where qemu is version 5.1,KVM is enabled,libvirt and virt-manager are installed from the source code and everything works great. The host OS is Devuan 5. Infact,using these parameters,FreeBSD is able to boot entirely : UEFICODE=/usr/share/AAVMF/AAVMF32_CODE.fd UEFIVARS=/usr/share/AAVMF/AAVMF32_VARS.fd DISK=/Dati/img/FreeBSD-13.2-RELEASE-arm-armv7-GENERICSD.img qemu-system-arm -enable-kvm -serial stdio -m 1024 -M virt -cpu cortex-a15 -drive if=pflash,format=raw,unit=0,file=$UEFICODE -drive if=pflash,format=raw,unit=1,file=$UEFIVARS -drive file=$DISK,media=disk,format=raw -device i82559b,netdev=net0,mac="52:54:00:12:34:55" -netdev type=user,id=net0 -device virtio-gpu-pci -usb -device nec-usb-xhci -device usb-kbd -device usb-mouse -device vmware-svga,id=video0,vgamem_mb=16 As you can see from this boot log messages : https://pastebin.ubuntu.com/p/VBtJ5bTTCz/ So,this argument is good because qemu recognizes the virtio disk : -drive file=$DISK,media=disk,format=raw \ but these arguments used by libvirt aren't able to boot FreeBSD because the virtio disk attached is not recognized (I also tried with a SATA disk and it is not recognized as well) : <disk type="file" device="disk"> <driver name="qemu" type="raw"/> <source file="/Dati/img/FreeBSD-13.2-RELEASE-arm-armv7-GENERICSD.img"/> <target dev="vda" bus="virtio"/> <address type="pci" domain="0x0000" bus="0x04" slot="0x00" function="0x0"/> </disk> Here you can see what are the full XML code used by libirt : https://pastebin.ubuntu.com/p/hpGmgp2773/ this is the portion of code that correspond with the virtio disk (the FreeBSD image file) [image: 1] <https://i.stack.imgur.com/NUWg7.png> What's the difference between the qemu and the libvirt parameters ? Do you have some vague idea about the reason ? I think the problem is caused by qemu and/or libvirt. I tried to boot the image going inside the bios settings and trying to boot directly the image disk,but I saw this error : [image: 2] <https://i.stack.imgur.com/rdYGs.png> If you want to see the whole boot sequence,you can give a look at this short video that I have recorded : https://drive.google.com/file/d/1kRoAFH_6DH-vNEmNmg4PEQ8lQmKZnUi2/view -- Mario.

1 0

[libvirt PATCH] qemu: DomainGetGuestVcpusParams: reduce scope of tmp
by Ján Tomko 29 Sep '23

29 Sep '23

Wrap the macro body in a new block and move the declaration of 'tmp' into it, to avoid the need to mix g_autofree with manual freeing. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/qemu/qemu_driver.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 056b5cec98..f3c9730cd8 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -18396,7 +18396,6 @@ qemuDomainGetGuestVcpusParams(virTypedParameterPtr *params, g_autoptr(virBitmap) vcpus = virBitmapNew(QEMU_GUEST_VCPU_MAX_ID); g_autoptr(virBitmap) online = virBitmapNew(QEMU_GUEST_VCPU_MAX_ID); g_autoptr(virBitmap) offlinable = virBitmapNew(QEMU_GUEST_VCPU_MAX_ID); - g_autofree char *tmp = NULL; size_t i; int ret = -1; @@ -18416,11 +18415,13 @@ qemuDomainGetGuestVcpusParams(virTypedParameterPtr *params, } #define ADD_BITMAP(name) \ - if (!(tmp = virBitmapFormat(name))) \ - goto cleanup; \ - if (virTypedParamsAddString(&par, &npar, &maxpar, #name, tmp) < 0) \ - goto cleanup; \ - VIR_FREE(tmp) + do { \ + g_autofree char *tmp = NULL; \ + if (!(tmp = virBitmapFormat(name))) \ + goto cleanup; \ + if (virTypedParamsAddString(&par, &npar, &maxpar, #name, tmp) < 0) \ + goto cleanup; \ + } while (0) ADD_BITMAP(vcpus); ADD_BITMAP(online); -- 2.41.0

2 1

Fwd: Hexdump0815 support for kvm and an important question (Was: Re: New thread...)
by Mario Marietto 29 Sep '23

29 Sep '23

Hello to everyone. I'm trying to virtualize FreeBSD 13.2 for arm 32 bit on my laptop ARM Chromebook where KVM is enabled,libvirt and virt-manager are installed from the source code and everything work great. The Host OS is Devuan 5. Infact , using these qemu parameters,FreeBSD is able to boot entirely : DISK=/Dati/img/FreeBSD-13.2-RELEASE-arm-armv7-GENERICSD.img qemu-system-arm \ -enable-kvm -serial stdio \ -m 1024 -M virt -cpu cortex-a15 \ -drive if=pflash,format=raw,unit=0,file=$UEFICODE \ -drive if=pflash,format=raw,unit=1,file=$UEFIVARS \ -drive file=$DISK,media=disk,format=raw \ -device i82559b,netdev=net0,mac="52:54:00:12:34:55" \ -netdev type=user,id=net0 \ -device virtio-gpu-pci \ -usb -device nec-usb-xhci \ -device usb-kbd -device usb-mouse \ -device vmware-svga,id=video0,vgamem_mb=16 *As you can see from this boot log messages :* https://pastebin.ubuntu.com/p/DWggdRRxVv/ *So,this argument is good :* -drive file=$DISK,media=disk,format=raw \ *but these arguments used by libvirt aren't able to boot FreeBSD because the virtio disk attached is not recognized (I also tried with a SATA disk and it is not regognized as well) :* <disk type="file" device="disk"> <driver name="qemu" type="raw"/> <source file="/Dati/img/FreeBSD-13.2-RELEASE-arm-armv7-GENERICSD.img"/> <target dev="vda" bus="virtio"/> <address type="pci" domain="0x0000" bus="0x04" slot="0x00" function="0x0"/> </disk> *as you can see :* [image: Screenshot_2023-09-29_10-44-06.png] What's the difference ? Do you have some vague idea about the reason ? I don't know if the cause is related to libvirt or to FreeBSD,so I'm trying to exclude one of these. -- Mario.

1 1

[PATCH] qemu: Add VIR_FREE in ADD_BITMAP
by Anastasia Belova 29 Sep '23

29 Sep '23

virBitmapFormat returns the string that should be freed. All strings in three ADD_BITMAP calls in qemuDomainGetGuestVcpusParams are contained in tmp. So memory leak is possible here without VIR_FREE. Fixes: 3e7db8d3e8 ("Remove backslash alignment attempts") Signed-off-by: Anastasia Belova <abelova(a)astralinux.ru> --- src/qemu/qemu_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 9e0f204e44..a70bfb6450 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -18420,6 +18420,7 @@ qemuDomainGetGuestVcpusParams(virTypedParameterPtr *params, goto cleanup; \ if (virTypedParamsAddString(&par, &npar, &maxpar, #name, tmp) < 0) \ goto cleanup; \ + VIR_FREE(tmp); \ ADD_BITMAP(vcpus); ADD_BITMAP(online); -- 2.30.2

3 2

[PATCH] NEWS: Document my contributions for upcoming release
by Michal Privoznik 29 Sep '23

29 Sep '23

Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- NEWS.rst | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index c17a1d002d..6f46e86ba8 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -43,8 +43,20 @@ v9.8.0 (unreleased) stability of qemu. Therefore, when available, libvirt will use nbdkit as a backend for these network disks and export an NBD disk to qemu. + * virnetdevopenvswitch: Propagate OVS error messages + + When configuring OVS interfaces/bridges libvirt used to report its own + error messages instead of passing (more accurate) error messages from + `ovs-vsctl`. This is now changed. + * **Bug fixes** + * Various virtio-mem/virtio-pmem fixes + + It was discovered that libvirt did not validate some values wrt virtio-mem + and virtio-pmem memory devices, e.g. overlapping memory addresses or + alignment. + v9.7.0 (2023-09-01) =================== -- 2.41.0

2 1

[PATCH] NEWS: Fix placement of network metadata entry
by Michal Privoznik 29 Sep '23

29 Sep '23

The network metadata support is a new feature in the upcoming release, not a removed one. Place it accordingly. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- NEWS.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/NEWS.rst b/NEWS.rst index 768e6fc326..c17a1d002d 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -15,14 +15,14 @@ v9.8.0 (unreleased) * **Removed features** +* **New features** + * network: New metadata change event The network object now has a new event ID ``VIR_NETWORK_EVENT_ID_METADATA_CHANGE`` that can be used to get notifications upon changes in any of ``<title>``, ``<description>`` or ``<metadata>``. -* **New features** - * qemu: Add support for vDPA block devices With a new enough version of qemu, libvirt will allow you to assign vDPA block -- 2.41.0

2 1

Entering freeze for libvirt-9.8.0
by Jiri Denemark 29 Sep '23

29 Sep '23

I have just tagged v9.8.0-rc1 in the repository and pushed signed tarballs and source RPMs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue is more visible. If you have not done so yet, please update NEWS.rst to document any significant change you made since the last release. Thanks, Jirka

1 1

[libvirt PATCH] rpm: Drop with_vz define
by Andrea Bolognani 28 Sep '23

28 Sep '23

Commit 56edf2fefe30 removed the last use. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- libvirt.spec.in | 1 - 1 file changed, 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 57cf46a16d..f3d21ccc8f 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -128,7 +128,6 @@ %define with_vmware 0 %define with_libxl 0 %define with_hyperv 0 - %define with_vz 0 %define with_lxc 0 %endif -- 2.41.0

2 1