- Devel - libvirt List Archives

Re: [PATCH] apparmor: Upgrade ABI version to 4.0, explicitly enable user namespace creation
by Andrea Bolognani 13 Jan '26

13 Jan '26

[adding libvirt devel list] On Sat, Jan 10, 2026 at 04:14:30PM +0100, Stefano Brivio wrote: > In the 3.0 AppArmor ABI version we currently use, user namespace rules > are not supported, and, as long as we load confined profiles, those > implicitly allow creation of user namespaces. > > However, ABI version 4.0 introduces rules for user namespaces, and if > we don't specify any, we can't create user namespaces, see: > > https://gitlab.com/apparmor/apparmor/-/wikis/unprivileged_userns_restriction > > This wouldn't affect us in general, given that we're using the 3.0 > ABI, but libvirt's policy uses 4.0 instead, and if our abstractions > are used from there, no matter what ABI policy version we declare, > rules for user namespace creation now match ABI policy version 4.0. AFAICT libvirt's policy doesn't explicitly declares any ABI version, so how does that work? Is the most recent one being used in that case? Assuming that's the case, how far back will that result in ABI 4.0 being the effective one? It looks like Debian only got AppArmor 4+ in March of last year. Do we want to make the ABI version explicit in libvirt's policy? If so, should we stick with 3.0 for maximum compatibility? > As a result, when libvirtd runs as root, and its profile includes > passt's abstraction, cf. commit 66769c2de825 ("apparmor: Workaround > for unconfined libvirtd when triggered by unprivileged user"), passt > can't detach user namespaces and will fail to start, as reported by > Niklas: > > ERROR internal error: Child process (passt --one-off --socket /run/libvirt/qemu/passt/1-haos-net0.socket --pid /run/libvirt/qemu/passt/1-haos-net0-passt.pid --tcp-ports 8123) unexpected exit status 1: Multiple interfaces with IPv6 routes, picked first > UNIX domain socket bound at /run/libvirt/qemu/passt/1-haos-net0.socket > Couldn't create user namespace: Permission denied > > This isn't a problem with libvirtd running as regular user, because > in that case, as a workaround, passt currently runs under its own > profile, not as a libvirtd subprofile (see commit referenced above). > > Given that ABI 4.0 has been around for a while, being introduced in > July 2023, finally take the step to upgrade to it and explicitly > enable user namespace creation. > > No further changes are needed in the existing policies to match new > features introduced in AppArmor 4.0. > > Reported-by: Niklas Edmundsson <nikke(a)accum.se> > Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1124801 > Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com> > --- > contrib/apparmor/abstractions/passt | 3 ++- > contrib/apparmor/abstractions/pasta | 2 +- > contrib/apparmor/usr.bin.passt | 2 +- > contrib/apparmor/usr.bin.passt-repair | 2 +- > contrib/apparmor/usr.bin.pasta | 2 +- > 5 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/contrib/apparmor/abstractions/passt b/contrib/apparmor/abstractions/passt > index 25b2ea8..0ffadaf 100644 > --- a/contrib/apparmor/abstractions/passt > +++ b/contrib/apparmor/abstractions/passt > @@ -11,7 +11,7 @@ > # Copyright (c) 2022 Red Hat GmbH > # Author: Stefano Brivio <sbrivio(a)redhat.com> > > - abi <abi/3.0>, > + abi <abi/4.0>, > > include <abstractions/base> > > @@ -24,6 +24,7 @@ > capability setpcap, > capability net_admin, > capability sys_ptrace, > + userns, > > / r, # isolate_prefork(), isolation.c > mount options=(rw, runbindable) -> /, > diff --git a/contrib/apparmor/abstractions/pasta b/contrib/apparmor/abstractions/pasta > index 9f73bee..251d4a2 100644 > --- a/contrib/apparmor/abstractions/pasta > +++ b/contrib/apparmor/abstractions/pasta > @@ -11,7 +11,7 @@ > # Copyright (c) 2022 Red Hat GmbH > # Author: Stefano Brivio <sbrivio(a)redhat.com> > > - abi <abi/3.0>, > + abi <abi/4.0>, > > include <abstractions/passt> > > diff --git a/contrib/apparmor/usr.bin.passt b/contrib/apparmor/usr.bin.passt > index 62a4514..c123a86 100644 > --- a/contrib/apparmor/usr.bin.passt > +++ b/contrib/apparmor/usr.bin.passt > @@ -11,7 +11,7 @@ > # Copyright (c) 2022 Red Hat GmbH > # Author: Stefano Brivio <sbrivio(a)redhat.com> > > -abi <abi/3.0>, > +abi <abi/4.0>, > > include <tunables/global> > > diff --git a/contrib/apparmor/usr.bin.passt-repair b/contrib/apparmor/usr.bin.passt-repair > index 901189d..23ff1ce 100644 > --- a/contrib/apparmor/usr.bin.passt-repair > +++ b/contrib/apparmor/usr.bin.passt-repair > @@ -11,7 +11,7 @@ > # Copyright (c) 2025 Red Hat GmbH > # Author: Stefano Brivio <sbrivio(a)redhat.com> > > -abi <abi/3.0>, > +abi <abi/4.0>, > > #include <tunables/global> > > diff --git a/contrib/apparmor/usr.bin.pasta b/contrib/apparmor/usr.bin.pasta > index 2483968..56b5024 100644 > --- a/contrib/apparmor/usr.bin.pasta > +++ b/contrib/apparmor/usr.bin.pasta > @@ -11,7 +11,7 @@ > # Copyright (c) 2022 Red Hat GmbH > # Author: Stefano Brivio <sbrivio(a)redhat.com> > > -abi <abi/3.0>, > +abi <abi/4.0>, > > include <tunables/global> > > -- > 2.43.0 >

2 3

[PATCH 0/3] syntax-check: Introduce sc_prohibit_g_autofree_const rule
by Michal Privoznik 13 Jan '26

13 Jan '26

Stems out from discussion here: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/HYT… Michal Prívozník (3): hyperv: Drop const for resourceType in hypervDomainAttachSerial() network: Drop const for forwardIf in pfAddNatFirewallRules() syntax-check: Introduce sc_prohibit_g_autofree_const rule build-aux/syntax-check.mk | 6 ++++++ src/hyperv/hyperv_driver.c | 2 +- src/network/network_pf.c | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) -- 2.52.0

3 5

[PATCH] NEWS: Mention JSON nesting bug and TPM migration quirk with NFS
by Peter Krempa 13 Jan '26

13 Jan '26

From: Peter Krempa <pkrempa(a)redhat.com> Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index a0fae3c661..ce55445695 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -54,6 +54,18 @@ v12.0.0 (unreleased) * **Bug fixes** + * qemu: Fix startup of VMs with more than ~25 external snapshots + + After switch to json-c VMs with too deeply nested image chains would fail + to start due to nesting depth limit in json-c, which is now increased to once + again support backing chains up to 200 images deep. + + * qemu: TPM: Properly handle migration when storage resides on NFS + + The VM now can be properly migrated in scenarios where TPM data is stored + on a shared filesystem on the destination but on the source it's either + on a different NFS or unshared completely. + v11.10.0 (2025-12-01) ===================== -- 2.52.0

2 1

Entering freeze for libvirt-12.0.0
by Jiri Denemark 13 Jan '26

13 Jan '26

I have just tagged v12.0.0-rc1 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue is more visible. If you have not done so yet, please update NEWS.rst to document any significant change you made since the last release. Jirka

1 1

[PATCH 0/3] qemu: forbid modifying portForwards with live update-device
by Laine Stump 13 Jan '26

13 Jan '26

See 3/3 for details. Resolves: https://issues.redhat.com/browse/RHEL-7338 Laine Stump (3): util: fix equivalence of AF_UNSPEC virSocketAddrs conf: new function virDomainNetPortForwardIsEqual() qemu: forbid modifying network device portForwards with update-device src/conf/domain_conf.c | 53 ++++++++++++++++++++++++++++++++++++++++ src/conf/domain_conf.h | 3 +++ src/libvirt_private.syms | 1 + src/qemu/qemu_hotplug.c | 9 +++++++ src/util/virsocketaddr.c | 2 ++ 5 files changed, 68 insertions(+) -- 2.52.0

2 4

[PATCH v2 0/1] x86: install modules-load.d file to load msr module
by Hector Cao 12 Jan '26

12 Jan '26

This submission is a follow-up (v2) of the discussion (RFC) that was happening at: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/ADJ4A... On x86, libvirt makes use of the API exposed by the msr kernel module to read the MSR (Model Specific Registers) values. On some Linux distros, this module is not loaded by default so libvirt might fail to read the MSR values and falls back to /dev/kvm to obtain these values. KVM might be behind in term of exposing all the values of the MSRs so using /dev/kvm is not ideal. This submission tries to make libvirt deploy the modules-load.d configuration so that linux loads the msr module at next boot. One caveat, libvirt installs only the file and does not trigger the load that is only done at next reboot, it is up to each distro to trigger immediately the load of the module without a reboot. v2: - only install the file when qemu driver is enabled Hector Cao (1): x86: install modules-load.d file to load msr module meson_options.txt | 1 + src/util/meson.build | 19 +++++++++++++++++++ src/util/modules-load.d/msr.conf | 1 + tools/virt-host-validate-qemu.c | 7 +++++++ 4 files changed, 28 insertions(+) create mode 100644 src/util/modules-load.d/msr.conf -- 2.45.2

3 8

[PATCH] news: document bhyve new features for 12.0.0
by Roman Bogorodskiy 12 Jan '26

12 Jan '26

Signed-off-by: Roman Bogorodskiy <bogorodskiy(a)gmail.com> --- NEWS.rst | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 6ca49a4c1b..6f9d1d2b34 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,31 @@ v12.0.0 (unreleased) * **New features** + * bhyve: SLIRP networking support + + Domain XMLs now can use SLIRP user-mode networking:: + + <interface type='user'> + <model type='virtio'/> + </interface> + + * bhyve: virtio-scsi support + + Domain XMLs now can use ``virtio-scsi`` devices:: + + <disk type='ctl'> + <source dev='/dev/cam/ctl'/> + <target dev='sda' bus='scsi'/> + </disk> + + * bhyve: initial ARM64 support + + The bhyve driver now supports booting ARM64 domains on ARM64 hosts. + This support is still in early stage of development and has some + limitations. For example, it requires using + ``<clock offset='localtime'/>`` in domain XMLs, and + bootrom autofill is not implemented. + * **Improvements** * qemu: Improvements and fixes to firmware selection -- 2.52.0

2 1

[PATCH v2] qemu: fix locking in qemuProcessHandleMemoryFailure
by Thomas Prescher 09 Jan '26

09 Jan '26

Fix locking in qemuProcessHandleMemoryFailure. We use a lock guard now because we can directly return from the default switch cases. Issue has been discovered by johannes.kulik(a)sap.com On-behalf-of: SAP thomas.prescher(a)sap.com Signed-off-by: Thomas Prescher <thomas.prescher(a)cyberus-technology.de> --- src/qemu/qemu_process.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 4e1d713809..a53bb40783 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -1939,8 +1939,8 @@ qemuProcessHandleMemoryFailure(qemuMonitor *mon G_GNUC_UNUSED, virDomainMemoryFailureRecipientType recipient; virDomainMemoryFailureActionType action; unsigned int flags = 0; + VIR_LOCK_GUARD lock = virObjectLockGuard(vm); - virObjectLock(vm); driver = QEMU_DOMAIN_PRIVATE(vm)->driver; switch (mfp->recipient) { @@ -1980,8 +1980,6 @@ qemuProcessHandleMemoryFailure(qemuMonitor *mon G_GNUC_UNUSED, event = virDomainEventMemoryFailureNewFromObj(vm, recipient, action, flags); - virObjectUnlock(vm); - virObjectEventStateQueue(driver->domainEventState, event); } -- 2.52.0

2 1

[PATCH 0/2] migration: Drop deprecated QMP stuff
by Markus Armbruster 09 Jan '26

09 Jan '26

Markus Armbruster (2): migration: Drop deprecated QMP command query-migrationthreads migration: Drop deprecated QMP migrate argument @detach docs/about/deprecated.rst | 13 ------- docs/about/removed-features.rst | 14 ++++++++ qapi/migration.json | 38 -------------------- migration/threadinfo.h | 25 ------------- migration/migration-hmp-cmds.c | 2 +- migration/migration.c | 8 +---- migration/multifd.c | 5 --- migration/threadinfo.c | 64 --------------------------------- migration/meson.build | 1 - 9 files changed, 16 insertions(+), 154 deletions(-) delete mode 100644 migration/threadinfo.h delete mode 100644 migration/threadinfo.c -- 2.52.0

2 3

Re: Question about error conditions for ACPI usage on aarch64
by Andrea Bolognani 09 Jan '26

09 Jan '26

On Mon, Dec 15, 2025 at 07:08:28AM +0000, Kazuhiro Abe (Fujitsu) wrote: > > On Tue, Dec 02, 2025 at 12:52:02AM +0000, Kazuhiro Abe (Fujitsu) wrote: > > > > You've just identified one of those issues that I predicted I would > > > > run into and have to fix :) > > > > > > > > I already have a patch addressing that, among other things, > > > > in my local branch. I expect to be able to post the whole > > > > series shortly, probably next week. > > > > > > It would be great if you can share the updates of your patch. > > > > Still working on it :) It's taking a bit longer than I had anticipated to get all the > > ducks in a row, but I'm hoping that I will be able to finally post the series this > > week or the next one. > > When can we expect this patch to be ready? > We would appreciate it if you could provide us with this information as soon as possible. I plan have patches on the list by the end of the week. -- Andrea Bolognani / Red Hat / Virtualization

2 5