- Devel - libvirt List Archives

[PATCH] NEWS: Mention documention improvements of image format settings
by Jim Fehlig 10 Oct '24

10 Oct '24

Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- Although small, the change seems NEWS noteworthy. NEWS.rst | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 7f4f33c8f8..dd9f261933 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -35,6 +35,14 @@ v10.9.0 (unreleased) Users are encouraged to report any occurence of the above message along with steps they took to the upstream tracker. + * qemu: improve documentation of image format settings + + The documentation of the various ``*_image_format`` settings in ``qemu.conf`` + imply they can only be used to control compression of the image. The + documentation has been improved to clarify the settings describe the + representation of guest memory blocks on disk, which includes compression + among other possible layouts. + * **Bug fixes** -- 2.35.3

2 1

[PATCH] lxc: fix variable storage order before call
by Adam Julis 10 Oct '24

10 Oct '24

virDomainConfNWFilterInstantiate() was called without updated net->ifname, it caused in some cases throwing error message. If function failed, change is reverted. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/658 Signed-off-by: Adam Julis <ajulis(a)redhat.com> --- src/lxc/lxc_process.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c index 205ab96ebb..b00608e30a 100644 --- a/src/lxc/lxc_process.c +++ b/src/lxc/lxc_process.c @@ -271,6 +271,7 @@ virLXCProcessSetupInterfaceTap(virDomainDef *vm, { g_autofree char *parentVeth = NULL; g_autofree char *containerVeth = NULL; + g_autofree char *backupIfname = NULL; const virNetDevVPortProfile *vport = virDomainNetGetActualVirtPortProfile(net); VIR_DEBUG("calling vethCreate()"); @@ -315,14 +316,18 @@ virLXCProcessSetupInterfaceTap(virDomainDef *vm, return NULL; } - if (net->filter && - virDomainConfNWFilterInstantiate(vm->name, vm->uuid, net, false) < 0) - return NULL; - - /* success is guaranteed, so update the interface object */ + /* success almost guaranteed, next function needs updated net->ifname */ + backupIfname = g_strdup(net->ifname); g_free(net->ifname); net->ifname = g_steal_pointer(&parentVeth); + if (net->filter && + virDomainConfNWFilterInstantiate(vm->name, vm->uuid, net, false) < 0) { + g_free(net->ifname); + net->ifname = g_steal_pointer(&backupIfname); + return NULL; + } + return g_steal_pointer(&containerVeth); } -- 2.45.2

2 1

[PATCH V2 0/2] qemu: Clarify purpose of image format settings
by Jim Fehlig 10 Oct '24

10 Oct '24

The current documentation of the various foo_image_format settings in qemu.conf subtly implies they are only used for specifying compression. Patch1 of this small series attempts to clarify and improve the description of the settings. It defines image format as a way to specify the desired layout of guest memory blocks on disk. Patch2 changes the use of 'compressed' with 'format' throughout the code, removing implication that format == compressed. V2: Replace more uses of 'compressed' with 'format' in patch2 Jim Fehlig (2): qemu: conf: Improve the foo_image_format setting descriptions qemu: Use consistent naming for save image format src/qemu/qemu.conf.in | 40 +++++++++++++++++++++++---------------- src/qemu/qemu_driver.c | 30 ++++++++++++++--------------- src/qemu/qemu_saveimage.c | 32 +++++++++++++++---------------- src/qemu/qemu_saveimage.h | 4 ++-- src/qemu/qemu_snapshot.c | 6 +++--- 5 files changed, 60 insertions(+), 52 deletions(-) -- 2.35.3

2 7

[PATCH 0/2] qemu: mention caveat with zero detection during migration and add NEWS
by Peter Krempa 10 Oct '24

10 Oct '24

Peter Krempa (2): docs: Add warning about using a cleared image with VIR_MIGRATE_PARAM_MIGRATE_DISKS_DETECT_ZEROES_ZEROES NEWS: mention zero detection for non-shared-storage migration NEWS.rst | 11 +++++++++++ docs/manpages/virsh.rst | 4 +++- include/libvirt/libvirt-domain.h | 5 ++++- 3 files changed, 18 insertions(+), 2 deletions(-) -- 2.47.0

3 4

[PULL 0/2] chardev patches
by marcandre.lureau＠redhat.com 09 Oct '24

09 Oct '24

From: Marc-André Lureau <marcandre.lureau(a)redhat.com> The following changes since commit 2af37e791906cfda42cb9604a16d218e56994bb1: Merge tag 'pull-request-2024-10-07' of https://gitlab.com/thuth/qemu into staging (2024-10-07 12:55:02 +0100) are available in the Git repository at: https://gitlab.com/marcandre.lureau/qemu.git tags/chr-pull-request for you to fetch changes up to b74cb8761c68275240af0826086590a03a1f419d: chardev: add path option for pty backend (2024-10-09 12:13:05 +0400) ---------------------------------------------------------------- chardev: introduce 'reconnect-ms' and deprecate 'reconnect' chardev: add path option for pty backend ---------------------------------------------------------------- Daniil Tatianin (1): chardev: introduce 'reconnect-ms' and deprecate 'reconnect' Octavian Purdila (1): chardev: add path option for pty backend docs/about/deprecated.rst | 6 +++++ qapi/char.json | 44 ++++++++++++++++++++++++++++++++--- include/chardev/char-socket.h | 2 +- chardev/char-pty.c | 33 ++++++++++++++++++++++++++ chardev/char-socket.c | 33 +++++++++++++++++++------- chardev/char.c | 8 +++++++ qemu-options.hx | 33 +++++++++++++++++++++----- 7 files changed, 140 insertions(+), 19 deletions(-) -- 2.47.0

2 3

[PATCH v3 00/10] qemu: Rework internal active snapshots to use QMP commands
by Peter Krempa 09 Oct '24

09 Oct '24

Changes to v2: - added few cleanups - added qemumonitorjson test cases for new commands - dropped duplicate capability flags - fixed bugs pointed out in v2 - rewritten logic for selecting snapshot images (both for creation/deletion) - fixed the logic to be fault tolerant same way as 'delvm' - allowed internal snapshots of VMs with UEFI - added explanation to all code with non-obvious implications Nikolai Barybin via Devel (4): qemu: monitor: Add plumbing for 'snaphot-save'/'snapshot-delete' QMP commands qemu: blockjob: Add job types for 'snapshot-save/delete' qemu: capabilities: Introduce QEMU_CAPS_SNAPSHOT_INTERNAL_QMP capability qemu snapshot: use QMP snapshot-save for internal snapshots creation Peter Krempa (6): qemuDomainObjWait: Annotate with G_GNUC_WARN_UNUSED_RESULT qemu: monitor: Store internal snapshot names from 'query-named-block-nodes' qemu snapshot: use QMP snapshot-delete for internal snapshots deletion qemuSnapshotActiveInternalDeleteGetDevices: Add warning when deleting inconsistent snapshot qemu: snapshot: Allow internal snapshots with PFLASH nvram news: mention internal snapshot changes NEWS.rst | 16 + src/qemu/qemu_block.c | 2 + src/qemu/qemu_blockjob.c | 7 + src/qemu/qemu_blockjob.h | 2 + src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_domain.c | 10 + src/qemu/qemu_domain.h | 3 +- src/qemu/qemu_monitor.c | 30 ++ src/qemu/qemu_monitor.h | 17 + src/qemu/qemu_monitor_json.c | 79 ++++ src/qemu/qemu_monitor_json.h | 13 + src/qemu/qemu_snapshot.c | 358 +++++++++++++++++- tests/qemublocktest.c | 11 + .../bitmap/snapshots-internal.json | 298 +++++++++++++++ .../bitmap/snapshots-internal.out | 2 + .../caps_6.0.0_aarch64.xml | 1 + .../qemucapabilitiesdata/caps_6.0.0_s390x.xml | 1 + .../caps_6.0.0_x86_64.xml | 1 + .../caps_6.1.0_x86_64.xml | 1 + .../caps_6.2.0_aarch64.xml | 1 + .../qemucapabilitiesdata/caps_6.2.0_ppc64.xml | 1 + .../caps_6.2.0_x86_64.xml | 1 + .../caps_7.0.0_aarch64+hvf.xml | 1 + .../caps_7.0.0_aarch64.xml | 1 + .../qemucapabilitiesdata/caps_7.0.0_ppc64.xml | 1 + .../caps_7.0.0_x86_64.xml | 1 + .../qemucapabilitiesdata/caps_7.1.0_ppc64.xml | 1 + .../caps_7.1.0_x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml | 1 + .../caps_7.2.0_x86_64+hvf.xml | 1 + .../caps_7.2.0_x86_64.xml | 1 + .../caps_8.0.0_riscv64.xml | 1 + .../caps_8.0.0_x86_64.xml | 1 + .../qemucapabilitiesdata/caps_8.1.0_s390x.xml | 1 + .../caps_8.1.0_x86_64.xml | 1 + .../caps_8.2.0_aarch64.xml | 1 + .../caps_8.2.0_armv7l.xml | 1 + .../caps_8.2.0_loongarch64.xml | 1 + .../qemucapabilitiesdata/caps_8.2.0_s390x.xml | 1 + .../caps_8.2.0_x86_64.xml | 1 + .../qemucapabilitiesdata/caps_9.0.0_sparc.xml | 1 + .../caps_9.0.0_x86_64.xml | 1 + .../caps_9.1.0_riscv64.xml | 1 + .../caps_9.1.0_x86_64.xml | 1 + tests/qemumonitorjsontest.c | 33 ++ 46 files changed, 895 insertions(+), 22 deletions(-) create mode 100644 tests/qemublocktestdata/bitmap/snapshots-internal.json create mode 100644 tests/qemublocktestdata/bitmap/snapshots-internal.out -- 2.46.0

3 18

[PATCH 0/7] qemu: Fix some more migration issues related to vmx-* features
by Jiri Denemark 09 Oct '24

09 Oct '24

Sigh. Jiri Denemark (7): qemu: Drop vmx-* from migratable CPU model only when origCPU is set qemu: Do not drop unknown CPU features from domain XML cpu-data.py: Properly handle aliases qemu: Translate vmx-invvpid-single-context-noglobals CPU feature qemu: Replace big condition in virQEMUCapsCPUFilterFeatures with array cpu_map: Drop vmx-ept-{uc,wb} features from CPU models cpu_map: Drop vmx-invvpid-single-context from CPU models src/cpu_map/sync_qemu_features_i386.py | 3 -- src/cpu_map/sync_qemu_models_i386.py | 5 ++- src/cpu_map/x86_Broadwell-IBRS.xml | 2 -- src/cpu_map/x86_Broadwell-noTSX-IBRS.xml | 2 -- src/cpu_map/x86_Broadwell-noTSX.xml | 2 -- src/cpu_map/x86_Broadwell.xml | 2 -- src/cpu_map/x86_Cascadelake-Server-noTSX.xml | 2 -- src/cpu_map/x86_Cascadelake-Server.xml | 2 -- src/cpu_map/x86_Cooperlake.xml | 2 -- src/cpu_map/x86_GraniteRapids.xml | 2 -- src/cpu_map/x86_Haswell-IBRS.xml | 2 -- src/cpu_map/x86_Haswell-noTSX-IBRS.xml | 2 -- src/cpu_map/x86_Haswell-noTSX.xml | 2 -- src/cpu_map/x86_Haswell.xml | 2 -- src/cpu_map/x86_Icelake-Server-noTSX.xml | 2 -- src/cpu_map/x86_Icelake-Server.xml | 2 -- src/cpu_map/x86_IvyBridge-IBRS.xml | 2 -- src/cpu_map/x86_IvyBridge.xml | 2 -- src/cpu_map/x86_Nehalem-IBRS.xml | 2 -- src/cpu_map/x86_Nehalem.xml | 2 -- src/cpu_map/x86_SandyBridge-IBRS.xml | 2 -- src/cpu_map/x86_SandyBridge.xml | 2 -- src/cpu_map/x86_SapphireRapids.xml | 2 -- src/cpu_map/x86_Skylake-Client-IBRS.xml | 2 -- src/cpu_map/x86_Skylake-Client-noTSX-IBRS.xml | 2 -- src/cpu_map/x86_Skylake-Client.xml | 2 -- src/cpu_map/x86_Skylake-Server-IBRS.xml | 2 -- src/cpu_map/x86_Skylake-Server-noTSX-IBRS.xml | 2 -- src/cpu_map/x86_Skylake-Server.xml | 2 -- src/cpu_map/x86_Snowridge.xml | 2 -- src/cpu_map/x86_Westmere-IBRS.xml | 2 -- src/cpu_map/x86_Westmere.xml | 2 -- src/qemu/qemu_capabilities.c | 19 +++++++---- src/qemu/qemu_command.c | 13 +++++++- src/qemu/qemu_domain.c | 26 +++++++-------- src/qemu/qemu_process.c | 32 ------------------- tests/cputestdata/cpu-data.py | 5 +++ .../x86_64-cpuid-Atom-P5362-enabled.xml | 2 +- .../x86_64-cpuid-Atom-P5362-json.xml | 1 + .../x86_64-cpuid-Cooperlake-enabled.xml | 2 +- .../x86_64-cpuid-Cooperlake-json.xml | 1 + .../x86_64-cpuid-Core-i7-8550U-enabled.xml | 2 +- .../x86_64-cpuid-Core-i7-8550U-json.xml | 1 + ...86_64-cpuid-Xeon-Platinum-9242-enabled.xml | 2 +- .../x86_64-cpuid-Xeon-Platinum-9242-json.xml | 1 + ...-cpuid-baseline-Cooperlake+Cascadelake.xml | 1 + 46 files changed, 53 insertions(+), 123 deletions(-) -- 2.46.2

2 8

[PATCH 0/6] docs: link fixes and improvements
by Peter Krempa 09 Oct '24

09 Oct '24

*** BLURB HERE *** Peter Krempa (6): docs: remote: Replace broken link to article about 'ssh-agent' docs: Reject non-https external links kbase: Fix link in 'merging_disk_image_chains' article docs: Use relative links within the web page docs: newreposetup: Drop section about 'libvirt project server' docs: Prohibit 'external' links within the webpage docs/api_extension.rst | 4 +- docs/issue-handling.rst | 2 +- docs/kbase/backing_chains.rst | 4 +- docs/kbase/debuglogs.rst | 4 +- docs/kbase/internals/incremental-backup.rst | 6 +- docs/kbase/launch_security_sev.rst | 2 +- docs/kbase/live_full_disk_backup.rst | 2 +- docs/kbase/merging_disk_image_chains.rst | 6 +- docs/kbase/rpm-deployment.rst | 2 +- docs/kbase/s390_protected_virt.rst | 2 +- docs/kbase/systemtap.rst | 2 +- docs/meson.build | 4 ++ docs/newreposetup.rst | 34 ----------- docs/remote.rst | 2 +- docs/securityprocess.rst | 2 +- docs/testtck.rst | 2 +- docs/windows.rst | 5 +- scripts/check-html-references.py | 67 +++++++++++++++++++-- 18 files changed, 86 insertions(+), 66 deletions(-) -- 2.46.0

2 7

[PATCH 0/5] network: fix regression in firewalld zone setting
by Laine Stump 08 Oct '24

08 Oct '24

commit v10.7.0-76-g1a72b83d56 improperly assumed that reloading firewalld wouldn't reset the firewalld zone of libvirt-managed bridge devices. This resulted in loss of networking to guests when something on the host triggered a reload of firewalld rules, reported here: https://issues.redhat.com/browse/RHEL-61576 This new series of patches, reverts that commit, along with commit v10.7.0-78-g200f60b2e1, then reimplements their functionality assuming that a firewalld reload *will* reset the zone of all libvirt-managed bridge devices. Laine Stump (5): Revert "network: *un*set the firewalld zone while shutting down a network" Revert "network: support setting firewalld zone for bridge device of open networks" network: call network(Add|Remove)FirewallRules() for forward mode='open' network: a different way of supporting firewalld zone for mode='open' networks network: a different implementation of *un*setting firewalld zone when network is destroyed src/network/bridge_driver.c | 34 +++---- src/network/bridge_driver_linux.c | 140 ++++++++++++++++----------- src/network/bridge_driver_nop.c | 19 ---- src/network/bridge_driver_platform.h | 4 - src/util/virfirewalld.c | 16 +-- 5 files changed, 102 insertions(+), 111 deletions(-) -- 2.46.1

2 7

[PATCH v2 0/1] Add support for RAPL MSRs feature in QEMU
by Anthony Harivel 07 Oct '24

07 Oct '24

Hi, First of all, kudos to Peter Krempa for his fast review! In this v2, I've addressed the following points: - The socket is *not* mandatory and my code totally confused Peter. Sorry about that! here a snippet of the QEMU code to understand: /* Compute the socket path if necessary */ if (s->msr_energy.socket_path == NULL) { s->msr_energy.socket_path = vmsr_compute_default_paths(); } So I made all the modification to make it not necessary. - Change the socket name to "rapl_helper_socket" - Change the socket to be absFilePath - I did not add anything to honour the _OFF state, because it is not necessary to explicitly disable it. That's about it. Regards, Anthony Anthony Harivel (1): qemu: Add support for RAPL MSRs feature docs/formatdomain.rst | 2 ++ src/conf/domain_conf.c | 18 ++++++++++++++++++ src/conf/domain_conf.h | 2 ++ src/conf/schemas/domaincommon.rng | 10 ++++++++++ src/qemu/qemu_command.c | 11 +++++++++++ tests/qemuxmlconfdata/kvm-features-off.xml | 1 + .../kvm-features.x86_64-latest.args | 2 +- tests/qemuxmlconfdata/kvm-features.xml | 1 + 8 files changed, 46 insertions(+), 1 deletion(-) -- 2.46.0

3 14