May 2025 - Devel - libvirt List Archives

[PATCH v3 0/1] rpc: Re-read the data if EAGAIN or EINTR were captured
by yong.huang＠smartx.com 15 May '25

15 May '25

From: Hyman Huang <yong.huang(a)smartx.com> v3: Add the overlooked Signed-off-by v2: 1. Move the retry logic outside of virNetTLSSession{Read,Write} 2. Try re-polling when handing EAGAIN suggested by Daniel v1: 1. Encapsulate the retry logic inside virNetTLSSession{Read,Write} 2. Use VIR_DEBUG instead of VIR_WARN to log the retry operation rfc: https://patchew.org/Libvirt/d716a59dc2c61916917c6d2e07d62055745606d5.174404… Please review, thanks. Yong Hyman Huang (1): rpc: Add the {repoll,retry} logic in virNetClientSetTLSSession src/rpc/virnetclient.c | 8 ++++++++ 1 file changed, 8 insertions(+) -- 2.27.0

2 2

[PATCH 0/7] Fix return type of some functions
by Michal Privoznik 15 May '25

15 May '25

Inspired by Peter's patch: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/TRQ3… (since it wasn't merged yet, one hunk in patch 7/7 is the same as Peter's; I'll update it after Peter merges his patches) There are some function which are declared to return an int, but in fact return a boolean: int foo(...) { ... return true; } Worse, some mix ints and bools. With a help of coccinelle I was able to identify some offenders. And either redeclare them to return a bool, or fix those (misleading) return statements. Michal Prívozník (7): storage_backend_rbd.c: Make virStorageBackendRBDSetAllocation() stub report an error nwfilter: Fix return type of virNWFilterCanApplyBasicRules callback qemu_process: Fix return type of qemuDomainHasHotpluggableStartupVcpus() storage_backend_rbd.C: Fix return type of a volStorageBackendRBDUseFastDiff() stub virnetdevvlan: Fix return type of virNetDevVlanEqual() virsh-pool.c: Fix return type of virshBuildPoolXML() src: Fix retval of some functions declared to return an int src/ch/ch_hostdev.c | 8 ++++---- src/nwfilter/nwfilter_ebiptables_driver.c | 2 +- src/nwfilter/nwfilter_tech_driver.h | 2 +- src/qemu/qemu_domain.c | 8 ++++---- src/qemu/qemu_process.c | 2 +- src/storage/storage_backend_rbd.c | 5 +++-- src/util/vircommand.c | 2 +- src/util/virnetdevvlan.c | 2 +- src/util/virnetdevvlan.h | 2 +- tools/virsh-pool.c | 2 +- 10 files changed, 18 insertions(+), 17 deletions(-) -- 2.49.0

3 16

[PATCH v2] virnetdevtap: Fix memory leak in virNetDevTapReattachBridge
by liu.song13＠zte.com.cn 14 May '25

14 May '25

From: QiangWei Zhang <zhang.qiangwei(a)zte.com.cn> Variable 'master' needs to be free because it will be reassigned in virNetDevOpenvswitchInterfaceGetMaster(). The leaked stack: Direct leak of 11 byte(s) in 1 object(s) allocated from: #0 0x7f7dad8ba6df in __interceptor_malloc (/lib64/libasan.so.8+0xba6df) #1 0x7f7dad715728 in g_malloc (/lib64/libglib-2.0.so.0+0x60728) #2 0x7f7dad72d8b2 in g_strdup (/lib64/libglib-2.0.so.0+0x788b2) #3 0x7f7dacb63088 in g_strdup_inline /usr/include/glib-2.0/glib/gstrfuncs.h:321 #4 0x7f7dacb63088 in virNetDevGetName ../src/util/virnetdev.c:823 #5 0x7f7dacb63886 in virNetDevGetMaster ../src/util/virnetdev.c:909 #6 0x7f7dacb90288 in virNetDevTapReattachBridge ../src/util/virnetdevtap.c:527 #7 0x7f7dacd5cd67 in virDomainNetNotifyActualDevice ../src/conf/domain_conf.c:30505 #8 0x7f7da3a10bc3 in qemuProcessNotifyNets ../src/qemu/qemu_process.c:3290 #9 0x7f7da3a375c6 in qemuProcessReconnect ../src/qemu/qemu_process.c:9211 #10 0x7f7dacc0cc53 in virThreadHelper ../src/util/virthread.c:256 #11 0x7f7dac2875d4 in start_thread (/lib64/libc.so.6+0x875d4) #12 0x7f7dac3091bb in __GI___clone3 (/lib64/libc.so.6+0x1091bb) Fixes: de938b92c9d3a47647164aa643c20d2fc96cd2bc Signed-off-by: QiangWei Zhang <zhang.qiangwei(a)zte.com.cn> Reviewed-by: Peter Krempa <pkrempa(a)redhat.com> --- src/util/virnetdevtap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/util/virnetdevtap.c b/src/util/virnetdevtap.c index 1dc77f0f5c..f26afb2ce0 100644 --- a/src/util/virnetdevtap.c +++ b/src/util/virnetdevtap.c @@ -541,6 +541,9 @@ virNetDevTapReattachBridge(const char *tapname, /* IFLA_MASTER for a tap on an OVS switch is always "ovs-system" */ if (STREQ_NULLABLE(master, "ovs-system")) { useOVS = true; + + /* master needs to be released here because it will be reassigned */ + g_clear_pointer(&master, g_free); if (virNetDevOpenvswitchInterfaceGetMaster(tapname, &master) < 0) return -1; } -- 2.27.0

2 1

[PATCH v2] virnetdevtap: Fix memory leak in virNetDevTapReattachBridge
by liu.song13＠zte.com.cn 14 May '25

14 May '25

From: QiangWei Zhang <zhang.qiangwei(a)zte.com.cn> Variable 'master' needs to be free because it will be reassigned in virNetDevOpenvswitchInterfaceGetMaster(). The leaked stack: Direct leak of 11 byte(s) in 1 object(s) allocated from: #0 0x7f7dad8ba6df in __interceptor_malloc (/lib64/libasan.so.8+0xba6df) #1 0x7f7dad715728 in g_malloc (/lib64/libglib-2.0.so.0+0x60728) #2 0x7f7dad72d8b2 in g_strdup (/lib64/libglib-2.0.so.0+0x788b2) #3 0x7f7dacb63088 in g_strdup_inline /usr/include/glib-2.0/glib/gstrfuncs.h:321 #4 0x7f7dacb63088 in virNetDevGetName ../src/util/virnetdev.c:823 #5 0x7f7dacb63886 in virNetDevGetMaster ../src/util/virnetdev.c:909 #6 0x7f7dacb90288 in virNetDevTapReattachBridge ../src/util/virnetdevtap.c:527 #7 0x7f7dacd5cd67 in virDomainNetNotifyActualDevice ../src/conf/domain_conf.c:30505 #8 0x7f7da3a10bc3 in qemuProcessNotifyNets ../src/qemu/qemu_process.c:3290 #9 0x7f7da3a375c6 in qemuProcessReconnect ../src/qemu/qemu_process.c:9211 #10 0x7f7dacc0cc53 in virThreadHelper ../src/util/virthread.c:256 #11 0x7f7dac2875d4 in start_thread (/lib64/libc.so.6+0x875d4) #12 0x7f7dac3091bb in __GI___clone3 (/lib64/libc.so.6+0x1091bb) Fixes: de938b92c9d3a47647164aa643c20d2fc96cd2bc Signed-off-by: QiangWei Zhang <zhang.qiangwei(a)zte.com.cn> Reviewed-by: Peter Krempa <pkrempa(a)redhat.com> --- src/util/virnetdevtap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/util/virnetdevtap.c b/src/util/virnetdevtap.c index 1dc77f0f5c..f26afb2ce0 100644 --- a/src/util/virnetdevtap.c +++ b/src/util/virnetdevtap.c @@ -541,6 +541,9 @@ virNetDevTapReattachBridge(const char *tapname, /* IFLA_MASTER for a tap on an OVS switch is always "ovs-system" */ if (STREQ_NULLABLE(master, "ovs-system")) { useOVS = true; + + /* master needs to be released here because it will be reassigned */ + g_clear_pointer(&master, g_free); if (virNetDevOpenvswitchInterfaceGetMaster(tapname, &master) < 0) return -1; } -- 2.27.0

3 2

[RESEND PATCH v2 0/1] rpc: Re-read the data if EAGAIN or EINTR were captured
by yong.huang＠smartx.com 14 May '25

14 May '25

From: Hyman Huang <yong.huang(a)smartx.com> v2: 1. Move the retry logic outside of virNetTLSSession{Read,Write} 2. Try re-polling when handing EAGAIN suggested by Daniel v1: 1. Encapsulate the retry logic inside virNetTLSSession{Read,Write} 2. Use VIR_DEBUG instead of VIR_WARN to log the retry operation rfc: https://patchew.org/Libvirt/d716a59dc2c61916917c6d2e07d62055745606d5.174404… Please review, thanks. Yong Hyman Huang (1): rpc: Add the {repoll,retry} logic in virNetClientSetTLSSession src/rpc/virnetclient.c | 8 ++++++++ 1 file changed, 8 insertions(+) -- 2.27.0

2 2

[PATCH v2 0/1] rpc: Re-read the data if EAGAIN or EINTR were captured
by yong.huang＠smartx.com 14 May '25

14 May '25

From: Hyman Huang <yong.huang(a)smartx.com> v2: 1. Move the retry logic outside of virNetTLSSession{Read,Write} 2. Try re-polling when handing EAGAIN suggested by Daniel v1: 1. Encapsulate the retry logic inside virNetTLSSession{Read,Write} 2. Use VIR_DEBUG instead of VIR_WARN to log the retry operation rfc: https://patchew.org/Libvirt/d716a59dc2c61916917c6d2e07d62055745606d5.174404… Please review, thanks. Yong Hyman Huang (1): rpc: Add the {repoll,retry} logic in virNetClientSetTLSSession src/rpc/virnetclient.c | 8 ++++++++ 1 file changed, 8 insertions(+) -- 2.27.0

1 1

[PATCH RESEND 0/6] Add support for configuring PCI high memory MMIO size
by Matthew R. Ochs 13 May '25

13 May '25

Resending: Series has been re-based over latest upstream. This patch series adds support for configuring the PCI high memory MMIO window size for aarch64 virt machine types. This feature has been merged into the QEMU upstream master branch [1] and will be available in QEMU 10.0. It allows users to configure the size of the high memory MMIO window above 4GB, which is particularly useful for systems with large amounts of PCI memory requirements. The feature is exposed through the domain XML as a new PCI feature: <features> <pci> <highmem-mmio-size unit='G'>512</highmem-mmio-size> </pci> </features> When enabled, this configures the size of the PCI high memory MMIO window via QEMU's highmem-mmio-size machine property. The feature is only available for aarch64 virt machine types and requires QEMU support. This series depends on [2] and should be applied on top of those patches. For your convenience, this series is also available on Github [3]. [1] https://github.com/qemu/qemu/commit/f10104aeae3a17f181d5bb37b7fd7dad7fe86cba [2] https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/Z4NQ… [3] git fetch https://github.com/nvmochs/libvirt.git pci_highmem_mmio_size Signed-off-by: Matthew R. Ochs <mochs(a)nvidia.com> Matthew R. Ochs (6): domain: Add PCI configuration feature infrastructure schema: Add PCI configuration feature schema conf: Add PCI configuration XML parsing and formatting qemu: Add capability for PCI high memory MMIO size qemu: Add command line support for PCI high memory MMIO size tests: Add tests for machine PCI features src/conf/domain_conf.c | 103 ++++++++++++++++++ src/conf/domain_conf.h | 6 + src/conf/schemas/domaincommon.rng | 9 ++ src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 6 + src/qemu/qemu_validate.c | 15 +++ .../caps_10.0.0_aarch64.replies | 10 ++ .../caps_10.0.0_aarch64.xml | 1 + ...rch64-virt-machine-pci.aarch64-latest.args | 31 ++++++ ...arch64-virt-machine-pci.aarch64-latest.xml | 30 +++++ .../aarch64-virt-machine-pci.xml | 20 ++++ tests/qemuxmlconftest.c | 2 + 13 files changed, 236 insertions(+) create mode 100644 tests/qemuxmlconfdata/aarch64-virt-machine-pci.aarch64-latest.args create mode 100644 tests/qemuxmlconfdata/aarch64-virt-machine-pci.aarch64-latest.xml create mode 100644 tests/qemuxmlconfdata/aarch64-virt-machine-pci.xml -- 2.46.0

3 15

[PATCH v2 0/4] Fix build without libnl
by Michal Privoznik 13 May '25

13 May '25

v2 of: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/VYUE… diff to v1: 1) Patch 1/5 from the original is dropped, no symbol addition to the private syms file, 2) The "virnetlink.h" is included more often in patch 3/4, 3) Some fixes around virNetlinkBridgeVlanFilterSet() stub Michal Prívozník (4): virnetlink: Provide stub for virNetlinkBridgeVlanFilterSet() virnetdevbridge.c: Fix comments in virNetDevBridgeSetupVlans() virnetdevbridge: Include virnetlink.h more often virnetlink: Split virNetlinkBridgeVlanFilterSet() src/util/virnetdevbridge.c | 18 ++++----- src/util/virnetlink.c | 83 ++++++++++++++++++++++++++++++++++---- src/util/virnetlink.h | 5 ++- 3 files changed, 88 insertions(+), 18 deletions(-) -- 2.49.0

2 5

[PATCH 0/5] Fix build without libnl
by Michal Privoznik 13 May '25

13 May '25

Resolves: https://gitlab.com/libvirt/libvirt/-/issues/770 While the original issue report describes scenario where libnl devel package wasn't installed, it's perfectly reproducible with -Dlibnl=disabled passed to meson. Michal Prívozník (5): libvirt_private.syms: Export virNetlinkBridgeVlanFilterSet virnetlink: Provide stub for virNetlinkBridgeVlanFilterSet() virnetdevbridge.c: Fix comments in virNetDevBridgeSetupVlans() virnetdevbridge: Include virnetlink.h always virnetlink: Split virNetlinkBridgeVlanFilterSet() src/libvirt_private.syms | 2 + src/util/virnetdevbridge.c | 18 ++++----- src/util/virnetlink.c | 82 ++++++++++++++++++++++++++++++++++---- src/util/virnetlink.h | 5 ++- 4 files changed, 89 insertions(+), 18 deletions(-) -- 2.49.0

3 15

[PATCH 0/2] virtio-net queue handling fixes
by Peter Krempa 13 May '25

13 May '25

Peter Krempa (2): virNetDevTapCreate: Use error message hinting to multiqueue use only when opening multiple queues virDomainNetDefCheckABIStability: Consider virtio 'queues' ABI src/conf/domain_conf.c | 11 +++++++++++ src/util/virnetdevtap.c | 2 +- 2 files changed, 12 insertions(+), 1 deletion(-) -- 2.49.0

3 6