November 2024 - Devel - libvirt List Archives

[PATCH 0/3] migration: Fix attempt to fix use of VIR_MIGRATE_PARAM_DEST_XML with VIR_MIGRATE_PERSIST_DEST
by Peter Krempa 18 Nov '24

18 Nov '24

Revert the code, document the quirks. Peter Krempa (3): Revert "qemu: migration: Improve handling of VIR_MIGRATE_PARAM_DEST_XML with VIR_MIGRATE_PERSIST_DEST" API: migration: Warn about use of VIR_MIGRATE_PERSIST_DEST with VIR_MIGRATE_PARAM_DEST_XML manpage: virsh: Add warning about 'migrate' with '--persistent' together with '--xml' docs/manpages/virsh.rst | 22 +++++++++++++-------- include/libvirt/libvirt-domain.h | 13 +++++++++++++ src/qemu/qemu_migration.c | 33 ++++++++++---------------------- 3 files changed, 37 insertions(+), 31 deletions(-) -- 2.47.0

2 4

[PATCH] vmx: Get the VMware boolean uefi.secureBoot.enabled
by Richard W.M. Jones 18 Nov '24

18 Nov '24

Some VMware guests have a boolean uefi.secureBoot.enabled. If found, and it's set to "TRUE", and if it's a UEFI guest, then add this clause into the domain XML: <os firmware='efi'> <firmware> <feature enabled='yes' name='enrolled-keys'/> <feature enabled='yes' name='secure-boot'/> </firmware> </os> This approximates the meaning of this VMware flag. Signed-off-by: Richard W.M. Jones <rjones(a)redhat.com> Fixes: https://issues.redhat.com/browse/RHEL-67836 --- src/vmx/vmx.c | 22 ++++++++++++++++++++++ tests/vmx2xmldata/esx-in-the-wild-12.xml | 4 ++++ 2 files changed, 26 insertions(+) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 132e54e15f..23a8a35360 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -1387,6 +1387,7 @@ virVMXParseConfig(virVMXContext *ctx, char *sched_cpu_shares = NULL; char *guestOS = NULL; bool smbios_reflecthost = false; + bool uefi_secureboot = false; int controller; int bus; int port; @@ -1963,6 +1964,27 @@ virVMXParseConfig(virVMXContext *ctx, } } + /* vmx:uefi.secureBoot.enabled */ + if (virVMXGetConfigBoolean(conf, "uefi.secureBoot.enabled", + &uefi_secureboot, false, true) < 0) { + goto cleanup; + } + if (uefi_secureboot && + def->os.firmware == VIR_DOMAIN_OS_DEF_FIRMWARE_EFI) { + int *features = def->os.firmwareFeatures; + + if (!features) { + features = g_new0(int, VIR_DOMAIN_OS_DEF_FIRMWARE_FEATURE_LAST); + def->os.firmwareFeatures = features; + } + /* Just set both to true, as VMware doesn't have any concept + * of the two features separately. + */ + features[VIR_DOMAIN_OS_DEF_FIRMWARE_FEATURE_SECURE_BOOT] = + features[VIR_DOMAIN_OS_DEF_FIRMWARE_FEATURE_ENROLLED_KEYS] = + VIR_TRISTATE_BOOL_YES; + } + if (virDomainDefPostParse(def, VIR_DOMAIN_DEF_PARSE_ABI_UPDATE, xmlopt, NULL) < 0) goto cleanup; diff --git a/tests/vmx2xmldata/esx-in-the-wild-12.xml b/tests/vmx2xmldata/esx-in-the-wild-12.xml index 42184501d0..c5aad90677 100644 --- a/tests/vmx2xmldata/esx-in-the-wild-12.xml +++ b/tests/vmx2xmldata/esx-in-the-wild-12.xml @@ -9,6 +9,10 @@ </cputune> <os firmware='efi'> <type arch='x86_64'>hvm</type> + <firmware> + <feature enabled='yes' name='enrolled-keys'/> + <feature enabled='yes' name='secure-boot'/> + </firmware> </os> <clock offset='utc'/> <on_poweroff>destroy</on_poweroff> -- 2.46.0

2 1

[PATCH v2] ch: Enable callbacks for ch domain events
by Praveen K Paladugu 18 Nov '24

18 Nov '24

From: Praveen K Paladugu <prapal(a)linux.microsoft.com> Enable callbacks for define, undefine, started, booted, stopped, destroyed events of ch guests. Signed-off-by: Praveen K Paladugu <praveenkpaladugu(a)gmail.com> --- src/ch/ch_conf.h | 4 +++ src/ch/ch_driver.c | 82 ++++++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 84 insertions(+), 2 deletions(-) diff --git a/src/ch/ch_conf.h b/src/ch/ch_conf.h index a77cad7a2a..97c6c24aa5 100644 --- a/src/ch/ch_conf.h +++ b/src/ch/ch_conf.h @@ -24,6 +24,7 @@ #include "virthread.h" #include "ch_capabilities.h" #include "virebtables.h" +#include "object_event.h" #define CH_DRIVER_NAME "CH" #define CH_CMD "cloud-hypervisor" @@ -75,6 +76,9 @@ struct _virCHDriver * then lockless thereafter */ virCHDriverConfig *config; + /* Immutable pointer, self-locking APIs */ + virObjectEventState *domainEventState; + /* pid file FD, ensures two copies of the driver can't use the same root */ int lockFD; diff --git a/src/ch/ch_driver.c b/src/ch/ch_driver.c index dab025edc1..d18f266387 100644 --- a/src/ch/ch_driver.c +++ b/src/ch/ch_driver.c @@ -28,6 +28,7 @@ #include "ch_monitor.h" #include "ch_process.h" #include "domain_cgroup.h" +#include "domain_event.h" #include "datatypes.h" #include "driver.h" #include "viraccessapicheck.h" @@ -263,6 +264,7 @@ chDomainCreateWithFlags(virDomainPtr dom, unsigned int flags) virCHDriver *driver = dom->conn->privateData; virDomainObj *vm; virCHDomainObjPrivate *priv; + virObjectEvent *event; g_autofree char *managed_save_path = NULL; int ret = -1; @@ -304,6 +306,14 @@ chDomainCreateWithFlags(virDomainPtr dom, unsigned int flags) ret = virCHProcessStart(driver, vm, VIR_DOMAIN_RUNNING_BOOTED); } + if (ret == 0) { + event = virDomainEventLifecycleNewFromObj(vm, + VIR_DOMAIN_EVENT_STARTED, + VIR_DOMAIN_EVENT_STARTED_BOOTED); + if (event) + virObjectEventStateQueue(driver->domainEventState, event); + } + endjob: virDomainObjEndJob(vm); @@ -323,8 +333,10 @@ chDomainDefineXMLFlags(virConnectPtr conn, const char *xml, unsigned int flags) { virCHDriver *driver = conn->privateData; g_autoptr(virDomainDef) vmdef = NULL; + g_autoptr(virDomainDef) oldDef = NULL; virDomainObj *vm = NULL; virDomainPtr dom = NULL; + virObjectEvent *event = NULL; g_autofree char *managed_save_path = NULL; unsigned int parse_flags = VIR_DOMAIN_DEF_PARSE_INACTIVE; @@ -345,7 +357,7 @@ chDomainDefineXMLFlags(virConnectPtr conn, const char *xml, unsigned int flags) if (!(vm = virDomainObjListAdd(driver->domains, &vmdef, driver->xmlopt, - 0, NULL))) + 0, &oldDef))) goto cleanup; /* cleanup if there's any stale managedsave dir */ @@ -358,11 +370,17 @@ chDomainDefineXMLFlags(virConnectPtr conn, const char *xml, unsigned int flags) } vm->persistent = 1; - + event = virDomainEventLifecycleNewFromObj(vm, + VIR_DOMAIN_EVENT_DEFINED, + !oldDef ? + VIR_DOMAIN_EVENT_DEFINED_ADDED : + VIR_DOMAIN_EVENT_DEFINED_UPDATED); dom = virGetDomain(conn, vm->def->name, vm->def->uuid, vm->def->id); cleanup: virDomainObjEndAPI(&vm); + virObjectEventStateQueue(driver->domainEventState, event); + return dom; } @@ -378,6 +396,7 @@ chDomainUndefineFlags(virDomainPtr dom, { virCHDriver *driver = dom->conn->privateData; virDomainObj *vm; + virObjectEvent *event = NULL; int ret = -1; virCheckFlags(0, -1); @@ -393,6 +412,9 @@ chDomainUndefineFlags(virDomainPtr dom, "%s", _("Cannot undefine transient domain")); goto cleanup; } + event = virDomainEventLifecycleNewFromObj(vm, + VIR_DOMAIN_EVENT_UNDEFINED, + VIR_DOMAIN_EVENT_UNDEFINED_REMOVED); vm->persistent = 0; if (!virDomainObjIsActive(vm)) { @@ -403,6 +425,8 @@ chDomainUndefineFlags(virDomainPtr dom, cleanup: virDomainObjEndAPI(&vm); + virObjectEventStateQueue(driver->domainEventState, event); + return ret; } @@ -643,6 +667,7 @@ chDomainDestroyFlags(virDomainPtr dom, unsigned int flags) { virCHDriver *driver = dom->conn->privateData; virDomainObj *vm; + virObjectEvent *event = NULL; int ret = -1; virCheckFlags(0, -1); @@ -662,6 +687,9 @@ chDomainDestroyFlags(virDomainPtr dom, unsigned int flags) if (virCHProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_DESTROYED) < 0) goto endjob; + event = virDomainEventLifecycleNewFromObj(vm, + VIR_DOMAIN_EVENT_STOPPED, + VIR_DOMAIN_EVENT_STOPPED_DESTROYED); virCHDomainRemoveInactive(driver, vm); ret = 0; @@ -670,6 +698,8 @@ chDomainDestroyFlags(virDomainPtr dom, unsigned int flags) cleanup: virDomainObjEndAPI(&vm); + virObjectEventStateQueue(driver->domainEventState, event); + return ret; } @@ -1365,6 +1395,7 @@ static int chStateCleanup(void) virObjectUnref(ch_driver->xmlopt); virObjectUnref(ch_driver->caps); virObjectUnref(ch_driver->domains); + virObjectUnref(ch_driver->domainEventState); virMutexDestroy(&ch_driver->lock); g_clear_pointer(&ch_driver, g_free); @@ -1414,6 +1445,9 @@ chStateInitialize(bool privileged, if (!(ch_driver->config = virCHDriverConfigNew(privileged))) goto cleanup; + if (!(ch_driver->domainEventState = virObjectEventStateNew())) + goto cleanup; + if ((rv = chExtractVersion(ch_driver)) < 0) { if (rv == -2) ret = VIR_DRV_STATE_INIT_SKIPPED; @@ -2205,6 +2239,48 @@ chDomainSetNumaParameters(virDomainPtr dom, return ret; } +static int +chConnectDomainEventRegisterAny(virConnectPtr conn, + virDomainPtr dom, + int eventID, + virConnectDomainEventGenericCallback callback, + void *opaque, + virFreeCallback freecb) +{ + virCHDriver *driver = conn->privateData; + int ret = -1; + + if (virConnectDomainEventRegisterAnyEnsureACL(conn) < 0) + return -1; + + if (virDomainEventStateRegisterID(conn, + driver->domainEventState, + dom, eventID, + callback, opaque, freecb, &ret) < 0) + ret = -1; + + return ret; +} + + +static int +chConnectDomainEventDeregisterAny(virConnectPtr conn, + int callbackID) +{ + virCHDriver *driver = conn->privateData; + + if (virConnectDomainEventDeregisterAnyEnsureACL(conn) < 0) + return -1; + + if (virObjectEventStateDeregisterID(conn, + driver->domainEventState, + callbackID, true) < 0) + return -1; + + return 0; +} + + /* Function Tables */ static virHypervisorDriver chHypervisorDriver = { .name = "CH", @@ -2262,6 +2338,8 @@ static virHypervisorDriver chHypervisorDriver = { .domainHasManagedSaveImage = chDomainHasManagedSaveImage, /* 10.2.0 */ .domainRestore = chDomainRestore, /* 10.2.0 */ .domainRestoreFlags = chDomainRestoreFlags, /* 10.2.0 */ + .connectDomainEventRegisterAny = chConnectDomainEventRegisterAny, /* 10.8.0 */ + .connectDomainEventDeregisterAny = chConnectDomainEventDeregisterAny, /* 10.8.0 */ }; static virConnectDriver chConnectDriver = { -- 2.44.0

2 4

[PATCH] ch: enable virNodeGetMemoryStats API
by Praveen K Paladugu 18 Nov '24

18 Nov '24

Enable virNodeGetMemoryStats API to return the stats of host memory. Signed-off-by: Praveen K Paladugu <prapal(a)linux.microsoft.com> Signed-off-by: Praveen K Paladugu <praveenkpaladugu(a)gmail.com> --- src/ch/ch_driver.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/src/ch/ch_driver.c b/src/ch/ch_driver.c index 17ae488a02..34f3a495fc 100644 --- a/src/ch/ch_driver.c +++ b/src/ch/ch_driver.c @@ -40,6 +40,7 @@ #include "virutil.h" #include "viruuid.h" #include "virnuma.h" +#include "virhostmem.h" #define VIR_FROM_THIS VIR_FROM_CH @@ -2209,6 +2210,19 @@ chDomainSetNumaParameters(virDomainPtr dom, return ret; } +static int +chNodeGetMemoryStats(virConnectPtr conn, + int cellNum, + virNodeMemoryStatsPtr params, + int *nparams, + unsigned int flags) +{ + if (virNodeGetMemoryStatsEnsureACL(conn) < 0) + return -1; + + return virHostMemGetStats(cellNum, params, nparams, flags); +} + /* Function Tables */ static virHypervisorDriver chHypervisorDriver = { .name = "CH", @@ -2266,6 +2280,7 @@ static virHypervisorDriver chHypervisorDriver = { .domainHasManagedSaveImage = chDomainHasManagedSaveImage, /* 10.2.0 */ .domainRestore = chDomainRestore, /* 10.2.0 */ .domainRestoreFlags = chDomainRestoreFlags, /* 10.2.0 */ + .nodeGetMemoryStats = chNodeGetMemoryStats, /* 10.10.0 */ }; static virConnectDriver chConnectDriver = { -- 2.47.0

2 1

[PATCH 00/10] PCI passthrough support for ch guests
by Praveen K Paladugu 15 Nov '24

15 Nov '24

This patch series introduces PCI passthrough support for ch guests. While enabling this feature I refactored a bunch of methods from qemu to hypervisor to reduce duplication of logic between the drivers. Praveen K Paladugu (7): hypervisor: move HostdevNeedsVFIO to hypervisor hypervisor: move HostdevHostSupportsPassthroughVFIO qemu: replace qemuHostdevPreparePCIDevices ch: prepare domain definition for pci passthrough ch: allow hostdev in domain definitions ch: reattach PCI devices to host while stopping guest ch: explicitly set INFILESIZE to 0 Wei Liu (3): ch: add host device manager to driver ch: add scaffolding for host devices management ch: prepare host for PCI passthrough po/POTFILES | 1 + src/ch/ch_conf.h | 4 ++ src/ch/ch_domain.c | 2 +- src/ch/ch_driver.c | 4 ++ src/ch/ch_hostdev.c | 115 +++++++++++++++++++++++++++++++++++ src/ch/ch_hostdev.h | 32 ++++++++++ src/ch/ch_monitor.c | 1 + src/ch/ch_process.c | 74 +++++++++++++++++++++- src/ch/meson.build | 2 + src/hypervisor/virhostdev.c | 23 +++++++ src/hypervisor/virhostdev.h | 5 ++ src/libvirt_private.syms | 2 + src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_cgroup.c | 5 +- src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_hostdev.c | 40 +----------- src/qemu/qemu_hostdev.h | 10 --- src/qemu/qemu_hotplug.c | 5 +- src/qemu/qemu_namespace.c | 2 +- tests/domaincapstest.c | 2 +- 21 files changed, 276 insertions(+), 59 deletions(-) create mode 100644 src/ch/ch_hostdev.c create mode 100644 src/ch/ch_hostdev.h -- 2.44.0

2 17

[PATCH] qemu: Avoid useless tmp variable in qemuCanonicalizeMachine
by Jiri Denemark 15 Nov '24

15 Nov '24

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_postparse.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/qemu/qemu_postparse.c b/src/qemu/qemu_postparse.c index 11134fb030..03b5ef825a 100644 --- a/src/qemu/qemu_postparse.c +++ b/src/qemu/qemu_postparse.c @@ -947,10 +947,8 @@ qemuCanonicalizeMachine(virDomainDef *def, virQEMUCaps *qemuCaps) return 0; if (STRNEQ(canon, def->os.machine)) { - char *tmp; - tmp = g_strdup(canon); VIR_FREE(def->os.machine); - def->os.machine = tmp; + def->os.machine = g_strdup(canon); } return 0; -- 2.47.0

2 1

[PATCH 0/9] qemu: snapshot: Fix internal snapshot reversion with NVRAM image
by Peter Krempa 15 Nov '24

15 Nov '24

This series fixes two things: - inactive snapshot handling with NVRAM image - use of '-loadvm' commandline option to revert snapshots, both are individually described Peter Krempa (9): qemu: Don't store path to qemu img qemuDomainSnapshotForEachQcow2Raw: Remove 'driver' argument qemu: Move 'qemuDomainSnapshotForEachQcow2(Raw)' to qemu_snapshot.c qemuSnapshotForEachQcow2: Refactor qemuSnapshotForEachQcow2: Handle also NVRAM image for internal snapshots qemu: monitor: Add monitor infrastructure for 'snapshot-load' QMP command qemu: Add enum entries for 'snapshot-load' qemu job qemu: monitor: Extract vmstate presence for internal snapshots in qemuBlockGetNamedNodeData qemu: Avoid use of '-loadvm' commandline argument for internal snapshot reversion src/qemu/qemu_block.c | 1 + src/qemu/qemu_blockjob.c | 2 + src/qemu/qemu_blockjob.h | 1 + src/qemu/qemu_command.c | 5 +- src/qemu/qemu_conf.h | 3 - src/qemu/qemu_domain.c | 106 +---- src/qemu/qemu_domain.h | 8 - src/qemu/qemu_driver.c | 3 - src/qemu/qemu_monitor.c | 16 + src/qemu/qemu_monitor.h | 19 +- src/qemu/qemu_monitor_json.c | 49 +- src/qemu/qemu_monitor_json.h | 7 + src/qemu/qemu_process.c | 7 + src/qemu/qemu_snapshot.c | 437 ++++++++++++++++-- src/qemu/qemu_snapshot.h | 5 + tests/qemublocktest.c | 14 +- .../bitmap/snapshots-internal.out | 2 +- 17 files changed, 511 insertions(+), 174 deletions(-) -- 2.47.0

2 10

[PATCH] kbase: virtiofs: Clarify migration support statement
by Peter Krempa 15 Nov '24

15 Nov '24

virtiofs 1.11 contains support for migration so update the 'Note' which states that migration is not supported. Additionally mention that VM snapshots don't save state of the files shared via virtiofs so reverting is not a good idea. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- docs/kbase/virtiofs.rst | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/docs/kbase/virtiofs.rst b/docs/kbase/virtiofs.rst index 457c15da7f..d0e09b078f 100644 --- a/docs/kbase/virtiofs.rst +++ b/docs/kbase/virtiofs.rst @@ -13,9 +13,13 @@ is designed to offer local file system semantics and performance. See https://virtio-fs.gitlab.io/ -*Note:* virtiofs currently does not support migration so operations such as -migration, save/managed-save, or snapshots with memory are not supported if -a VM has a virtiofs filesystem connected. +*Note:* Older versions of ``virtiofsd`` (prior to ``1.11``) do not not support +migration so operations such as migration, save/managed-save, or snapshots with +memory may not supported if a VM has a virtiofs filesystem connected. + +Additionally snapshot operations managed by libvirt do not snapshot the state +of the files shared via ``virtiofs``, and thus reverting to an earlier state is +not recommended. Sharing a host directory with a guest ===================================== -- 2.47.0

2 1

[PATCH] syntax-check: Suggest ways to fix internal references
by Andrea Bolognani 14 Nov '24

14 Nov '24

The rule catches incorrect attempts to use internal references, but doesn't guide the developer hitting a failure towards the not exactly obvious acceptable alternatives. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- build-aux/syntax-check.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 6ed2a61192..2c9593c28f 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -1135,7 +1135,7 @@ sc_prohibit_backup_files: sc_avoid_remote_reference_to_local_file: @prohibit='<#' \ in_vc_files='\.rst$$' \ - halt='use local reference within a file' \ + halt='use `section`_ or `here <section_>`__ instead of `here <#section>`__' \ $(_sc_search_regexp) # This Perl code is slightly obfuscated. Not only is each "$" doubled -- 2.47.0

2 1

[PATCH 0/2] docs: Rework and extend NSS module page
by Andrea Bolognani 13 Nov '24

13 Nov '24

My initial goal was to write the second patch, but as usual I just couldn't stop myself... Andrea Bolognani (2): docs: Rework documentation for the NSS module docs: Document authselect to enable the NSS module docs/nss.rst | 194 ++++++++++++++++++++------------------------------- 1 file changed, 76 insertions(+), 118 deletions(-) -- 2.47.0

2 5