[PATCH 0/6] qemuBuildHostNetProps: Properly handle unsupported netdevs and remove virJSONValueObjectAppendStringPrintf
by Peter Krempa
First patch fixes a crasher if unsupported network device is used and
subsequently virJSONValueObjectAppendStringPrintf is removed.
Peter Krempa (6):
qemuBuildHostNetProps: Report proper errors for unhandled interface
types
qemuBuildHostNetProps: Don't use virJSONValueObjectAppendStringPrintf
to format address
qemuBuildChannelGuestfwdNetdevProps: Don't use
virJSONValueObjectAppendStringPrintf
qemuBuildHostNetProps: Append ipv6 address using virJSONValueObjectAdd
qemuBuildHostNetProps: Append aliases without
virJSONValueObjectAppendStringPrintf
util: json: Remove unused virJSONValueObjectAppendStringPrintf
src/libvirt_private.syms | 1 -
src/qemu/qemu_command.c | 113 +++++++++++++++++++++++++--------------
src/util/virjson.c | 17 ------
src/util/virjson.h | 6 ---
4 files changed, 74 insertions(+), 63 deletions(-)
--
2.39.2
1 year, 9 months
[libvirt PATCH 00/33] qemu: Move firmware selection to postparse and add support for QCOW2 firmware
by Andrea Bolognani
Motivation for these changes can be found in the commit message
for patch 20 ("qemu: Move firmware selection from startup to
postparse") as well as [RHBZ#2161965].
Patches 01-17 are preparatory fixes/improvements/cleanups.
Patches 19-20 move firmware selection from startup to postparse,
and patches 21-22 clean up a bit after that change. Patch 20 in
particular is significantly larger than I would have liked, but
I haven't been able to come up with a way to split it while
still preserving bisectability and making things clearer instead
of complicating them. If anyone has ideas in this regard, please
let me know!
Patches 23-27 add support for choosing a firmware format, but
are effectively no-op because formats other than raw are still
rejected at this point.
Patches 28-30 add support for QCOW2 format firmware in the QEMU
driver.
Patches 31-33 document the changes.
[RHBZ#2161965] https://bugzilla.redhat.com/show_bug.cgi?id=2161965
Andrea Bolognani (33):
docs: Fix documentation for loader.stateless attribute
tests: Set nvramDir in qemuxml2xmltest
tests: Rename firmware-manual-efi-rw* tests
tests: Use x86_64 for all x86 firmware tests
tests: Move firmware tests to CAPS_LATEST
tests: Unify input files for firmware tests
tests: Enable qemuxml2xml for more firmware tests
tests: Add more firmware tests
qemu: Introduce qemuDomainDefMachinePostParse()
qemu: Introduce qemuDomainDefBootPostParse()
conf: Introduce virDomainLoaderDefParseXMLLoader()
conf: introduce virDomainLoaderDefNew()
qemu: Add convenience local variables
qemu: Only fill nvramTemplate for local sources
qemu: Clear os.firmwareFeatures after autoselection
qemu: Don't pick firmware that requires SMM when smm=off
qemu: Don't pick firmware with unsupported format
tests: Add descriptors for QCOW2 format firmware builds
conf: Export virDomainDefOSValidate()
qemu: Move firmware selection from startup to postparse
qemu: Move qemuDomainNVRAMPathFormat() to qemu_firmware
qemu: Introduce qemuFirmwareEnsureNVRAM()
conf: Change handling for empty NVRAM path
conf: Parse firmware format
drivers: Reject unsupported firmware formats
qemu: Filter firmwares based on format
qemu: Propagate firmware format
conf: Accept QCOW2 firmware format
qemu: Add support for QCOW2 format firmware
tests: Add more firmware tests
docs: Document firmware format attribute
news: Document changes to firmware autoselection
news: Document support for QCOW2 format firmware
NEWS.rst | 16 +
docs/formatdomain.rst | 11 +-
src/bhyve/bhyve_firmware.c | 9 +-
src/conf/domain_conf.c | 123 ++++-
src/conf/domain_conf.h | 2 +
src/conf/domain_validate.c | 4 +-
src/conf/domain_validate.h | 3 +
src/conf/schemas/domaincommon.rng | 15 +
src/libvirt_private.syms | 2 +
src/libxl/libxl_conf.c | 9 +-
src/libxl/xen_xl.c | 4 +-
src/libxl/xen_xm.c | 2 +-
src/qemu/qemu_domain.c | 113 +++--
src/qemu/qemu_domain.h | 5 -
src/qemu/qemu_driver.c | 2 -
src/qemu/qemu_firmware.c | 460 +++++++++++++-----
src/qemu/qemu_firmware.h | 3 +-
src/qemu/qemu_process.c | 33 +-
.../share/qemu/firmware/65-ovmf-qcow2.json | 35 ++
.../share/qemu/firmware/66-aavmf-qcow2.json | 36 ++
tests/qemufirmwaretest.c | 11 +-
.../firmware-auto-bios-not-stateless.xml | 4 +-
.../firmware-auto-bios-nvram.xml | 6 +-
...are-auto-bios-stateless.x86_64-latest.args | 16 +-
.../firmware-auto-bios-stateless.xml | 4 +-
.../firmware-auto-bios.x86_64-latest.args | 16 +-
tests/qemuxml2argvdata/firmware-auto-bios.xml | 4 +-
...mware-auto-efi-aarch64.aarch64-latest.args | 22 +-
.../firmware-auto-efi-aarch64.xml | 4 +-
...ware-auto-efi-enrolled-keys-no-secboot.xml | 4 +-
...-auto-efi-enrolled-keys.x86_64-latest.args | 18 +-
.../firmware-auto-efi-enrolled-keys.xml | 4 +-
...fi-format-loader-qcow2.x86_64-latest.args} | 24 +-
...firmware-auto-efi-format-loader-qcow2.xml} | 6 +-
...efi-format-loader-raw.aarch64-latest.args} | 5 +-
...> firmware-auto-efi-format-loader-raw.xml} | 5 +-
...auto-efi-format-mismatch.x86_64-latest.err | 1 +
... => firmware-auto-efi-format-mismatch.xml} | 7 +-
...vram-qcow2-network-nbd.x86_64-latest.args} | 22 +-
...to-efi-format-nvram-qcow2-network-nbd.xml} | 11 +-
...ormat-nvram-qcow2-path.x86_64-latest.args} | 24 +-
...ware-auto-efi-format-nvram-qcow2-path.xml} | 6 +-
...efi-format-nvram-qcow2.x86_64-latest.args} | 24 +-
... firmware-auto-efi-format-nvram-qcow2.xml} | 6 +-
.../firmware-auto-efi-loader-insecure.xml | 4 +-
.../firmware-auto-efi-loader-path.xml | 4 +-
...-auto-efi-loader-secure.x86_64-latest.args | 18 +-
.../firmware-auto-efi-loader-secure.xml | 4 +-
...to-efi-no-enrolled-keys.x86_64-latest.args | 18 +-
.../firmware-auto-efi-no-enrolled-keys.xml | 4 +-
...are-auto-efi-no-secboot.x86_64-latest.args | 18 +-
.../firmware-auto-efi-no-secboot.xml | 4 +-
...re-auto-efi-nvram-file.x86_64-latest.args} | 13 +-
...5.xml => firmware-auto-efi-nvram-file.xml} | 9 +-
...fi-nvram-network-iscsi.x86_64-latest.args} | 16 +-
...firmware-auto-efi-nvram-network-iscsi.xml} | 9 +-
...-efi-nvram-network-nbd.x86_64-latest.args} | 16 +-
...> firmware-auto-efi-nvram-network-nbd.xml} | 9 +-
...firmware-auto-efi-nvram.x86_64-latest.args | 18 +-
.../firmware-auto-efi-nvram.xml | 6 +-
...rmware-auto-efi-secboot.x86_64-latest.args | 18 +-
.../firmware-auto-efi-secboot.xml | 4 +-
...mware-auto-efi-smm-off.x86_64-latest.args} | 17 +-
...-efi.xml => firmware-auto-efi-smm-off.xml} | 5 +-
...ware-auto-efi-stateless.x86_64-latest.args | 16 +-
.../firmware-auto-efi-stateless.xml | 4 +-
.../firmware-auto-efi.x86_64-latest.args | 18 +-
tests/qemuxml2argvdata/firmware-auto-efi.xml | 4 +-
...nual-bios-not-stateless.x86_64-latest.err} | 0
.../firmware-manual-bios-not-stateless.xml | 8 +-
.../firmware-manual-bios-stateless.args | 30 --
...-manual-bios-stateless.x86_64-latest.args} | 12 +-
.../firmware-manual-bios-stateless.xml | 8 +-
.../firmware-manual-bios.args | 30 --
...> firmware-manual-bios.x86_64-latest.args} | 12 +-
.../qemuxml2argvdata/firmware-manual-bios.xml | 8 +-
...nual-efi-acpi-aarch64.aarch64-latest.args} | 11 +-
.../firmware-manual-efi-acpi-aarch64.xml | 6 +-
...re-manual-efi-acpi-q35.x86_64-latest.args} | 11 +-
.../firmware-manual-efi-acpi-q35.xml | 6 +-
.../firmware-manual-efi-features.xml | 6 +-
...ware-manual-efi-no-path.x86_64-latest.err} | 0
.../firmware-manual-efi-no-path.xml | 6 +-
...al-efi-noacpi-aarch64.aarch64-latest.args} | 11 +-
.../firmware-manual-efi-noacpi-aarch64.xml | 6 +-
...e-manual-efi-noacpi-q35.x86_64-latest.err} | 0
.../firmware-manual-efi-noacpi-q35.xml | 6 +-
...e-manual-efi-nvram-file.x86_64-latest.args | 18 +-
.../firmware-manual-efi-nvram-file.xml | 8 +-
...efi-nvram-network-iscsi.x86_64-latest.args | 16 +-
...irmware-manual-efi-nvram-network-iscsi.xml | 6 +-
...l-efi-nvram-network-nbd.x86_64-latest.args | 16 +-
.../firmware-manual-efi-nvram-network-nbd.xml | 6 +-
.../firmware-manual-efi-nvram-stateless.xml | 8 +-
...re-manual-efi-nvram-template-stateless.xml | 6 +-
...nual-efi-nvram-template.x86_64-latest.args | 18 +-
.../firmware-manual-efi-nvram-template.xml | 6 +-
...manual-efi-rw-implicit.x86_64-latest.args} | 18 +-
...ml => firmware-manual-efi-rw-implicit.xml} | 8 +-
...firmware-manual-efi-rw.x86_64-latest.args} | 18 +-
...bios-rw.xml => firmware-manual-efi-rw.xml} | 8 +-
.../firmware-manual-efi-secure.args | 35 --
...ware-manual-efi-secure.x86_64-latest.args} | 20 +-
.../firmware-manual-efi-secure.xml | 8 +-
...re-manual-efi-stateless.x86_64-latest.args | 16 +-
.../firmware-manual-efi-stateless.xml | 6 +-
.../qemuxml2argvdata/firmware-manual-efi.args | 32 --
...=> firmware-manual-efi.x86_64-latest.args} | 13 +-
.../qemuxml2argvdata/firmware-manual-efi.xml | 8 +-
...ual-noefi-acpi-aarch64.aarch64-latest.err} | 0
.../firmware-manual-noefi-acpi-aarch64.xml | 4 +-
...-manual-noefi-acpi-q35.x86_64-latest.args} | 9 +-
.../firmware-manual-noefi-acpi-q35.xml | 4 +-
...-noefi-noacpi-aarch64.aarch64-latest.args} | 9 +-
.../firmware-manual-noefi-noacpi-aarch64.xml | 4 +-
...anual-noefi-noacpi-q35.x86_64-latest.args} | 9 +-
.../firmware-manual-noefi-noacpi-q35.xml | 4 +-
.../virtio-iommu-aarch64.aarch64-latest.args | 8 +-
tests/qemuxml2argvtest.c | 51 +-
.../aarch64-virt-graphics.aarch64-latest.xml | 2 +-
.../aarch64-virt-headless.aarch64-latest.xml | 2 +-
...ware-auto-bios-stateless.x86_64-latest.xml | 10 +-
.../firmware-auto-bios.x86_64-latest.xml | 9 +-
...rmware-auto-efi-aarch64.aarch64-latest.xml | 8 +-
...e-auto-efi-enrolled-keys.x86_64-latest.xml | 15 +-
...efi-format-loader-qcow2.x86_64-latest.xml} | 11 +-
...-efi-format-loader-raw.aarch64-latest.xml} | 8 +-
...nvram-qcow2-network-nbd.x86_64-latest.xml} | 10 +-
...format-nvram-qcow2-path.x86_64-latest.xml} | 11 +-
...-efi-format-nvram-qcow2.x86_64-latest.xml} | 11 +-
...e-auto-efi-loader-secure.x86_64-latest.xml | 12 +-
...uto-efi-no-enrolled-keys.x86_64-latest.xml | 13 +-
...ware-auto-efi-no-secboot.x86_64-latest.xml | 13 +-
...are-auto-efi-nvram-file.x86_64-latest.xml} | 10 +-
...efi-nvram-network-iscsi.x86_64-latest.xml} | 6 +-
...o-efi-nvram-network-nbd.x86_64-latest.xml} | 6 +-
.../firmware-auto-efi-nvram.x86_64-latest.xml | 12 +-
...irmware-auto-efi-secboot.x86_64-latest.xml | 14 +-
...rmware-auto-efi-smm-off.x86_64-latest.xml} | 12 +-
...ware-auto-efi-stateless.x86_64-latest.xml} | 10 +-
.../firmware-auto-efi.x86_64-latest.xml | 11 +-
...e-manual-bios-stateless.x86_64-latest.xml} | 11 +-
...=> firmware-manual-bios.x86_64-latest.xml} | 11 +-
...anual-efi-acpi-aarch64.aarch64-latest.xml} | 8 +-
...are-manual-efi-acpi-q35.x86_64-latest.xml} | 13 +-
...ual-efi-noacpi-aarch64.aarch64-latest.xml} | 9 +-
...re-manual-efi-nvram-file.x86_64-latest.xml | 10 +-
...-efi-nvram-network-iscsi.x86_64-latest.xml | 6 +-
...al-efi-nvram-network-nbd.x86_64-latest.xml | 6 +-
...nual-efi-nvram-template.x86_64-latest.xml} | 10 +-
...-manual-efi-rw-implicit.x86_64-latest.xml} | 11 +-
... firmware-manual-efi-rw.x86_64-latest.xml} | 11 +-
...mware-manual-efi-secure.x86_64-latest.xml} | 14 +-
...re-manual-efi-stateless.x86_64-latest.xml} | 11 +-
... => firmware-manual-efi.x86_64-latest.xml} | 11 +-
...e-manual-noefi-acpi-q35.x86_64-latest.xml} | 10 +-
...l-noefi-noacpi-aarch64.aarch64-latest.xml} | 7 +-
...manual-noefi-noacpi-q35.x86_64-latest.xml} | 13 +-
.../virtio-iommu-aarch64.aarch64-latest.xml | 4 +-
tests/qemuxml2xmltest.c | 32 +-
160 files changed, 1408 insertions(+), 990 deletions(-)
create mode 100644 tests/qemufirmwaredata/usr/share/qemu/firmware/65-ovmf-qcow2.json
create mode 100644 tests/qemufirmwaredata/usr/share/qemu/firmware/66-aavmf-qcow2.json
copy tests/qemuxml2argvdata/{firmware-auto-efi-no-enrolled-keys.x86_64-latest.args => firmware-auto-efi-format-loader-qcow2.x86_64-latest.args} (61%)
copy tests/qemuxml2argvdata/{firmware-auto-efi-stateless.xml => firmware-auto-efi-format-loader-qcow2.xml} (81%)
copy tests/qemuxml2argvdata/{virtio-iommu-aarch64.aarch64-latest.args => firmware-auto-efi-format-loader-raw.aarch64-latest.args} (89%)
copy tests/qemuxml2argvdata/{firmware-auto-efi-aarch64.xml => firmware-auto-efi-format-loader-raw.xml} (79%)
create mode 100644 tests/qemuxml2argvdata/firmware-auto-efi-format-mismatch.x86_64-latest.err
copy tests/qemuxml2argvdata/{firmware-auto-efi-nvram.xml => firmware-auto-efi-format-mismatch.xml} (75%)
copy tests/qemuxml2argvdata/{firmware-manual-efi-nvram-network-nbd.x86_64-latest.args => firmware-auto-efi-format-nvram-qcow2-network-nbd.x86_64-latest.args} (61%)
copy tests/qemuxml2argvdata/{firmware-manual-efi-nvram-network-nbd.xml => firmware-auto-efi-format-nvram-qcow2-network-nbd.xml} (63%)
copy tests/qemuxml2argvdata/{firmware-auto-efi-no-enrolled-keys.x86_64-latest.args => firmware-auto-efi-format-nvram-qcow2-path.x86_64-latest.args} (58%)
copy tests/qemuxml2argvdata/{firmware-auto-efi-nvram.xml => firmware-auto-efi-format-nvram-qcow2-path.xml} (76%)
copy tests/qemuxml2argvdata/{firmware-auto-efi-no-enrolled-keys.x86_64-latest.args => firmware-auto-efi-format-nvram-qcow2.x86_64-latest.args} (61%)
copy tests/qemuxml2argvdata/{firmware-auto-efi-loader-secure.xml => firmware-auto-efi-format-nvram-qcow2.xml} (81%)
copy tests/qemuxml2argvdata/{firmware-manual-efi-acpi-q35.args => firmware-auto-efi-nvram-file.x86_64-latest.args} (63%)
copy tests/qemuxml2argvdata/{firmware-manual-noefi-acpi-q35.xml => firmware-auto-efi-nvram-file.xml} (60%)
copy tests/qemuxml2argvdata/{firmware-manual-efi-nvram-network-iscsi.x86_64-latest.args => firmware-auto-efi-nvram-network-iscsi.x86_64-latest.args} (77%)
copy tests/qemuxml2argvdata/{firmware-manual-efi-nvram-network-iscsi.xml => firmware-auto-efi-nvram-network-iscsi.xml} (73%)
copy tests/qemuxml2argvdata/{firmware-manual-efi-nvram-network-nbd.x86_64-latest.args => firmware-auto-efi-nvram-network-nbd.x86_64-latest.args} (72%)
copy tests/qemuxml2argvdata/{firmware-manual-efi-nvram-network-nbd.xml => firmware-auto-efi-nvram-network-nbd.xml} (67%)
copy tests/qemuxml2argvdata/{virtio-iommu-aarch64.aarch64-latest.args => firmware-auto-efi-smm-off.x86_64-latest.args} (67%)
copy tests/qemuxml2argvdata/{firmware-auto-efi.xml => firmware-auto-efi-smm-off.xml} (82%)
rename tests/qemuxml2argvdata/{firmware-manual-bios-not-stateless.err => firmware-manual-bios-not-stateless.x86_64-latest.err} (100%)
delete mode 100644 tests/qemuxml2argvdata/firmware-manual-bios-stateless.args
copy tests/qemuxml2argvdata/{firmware-manual-noefi-noacpi-q35.args => firmware-manual-bios-stateless.x86_64-latest.args} (60%)
delete mode 100644 tests/qemuxml2argvdata/firmware-manual-bios.args
copy tests/qemuxml2argvdata/{firmware-manual-noefi-noacpi-q35.args => firmware-manual-bios.x86_64-latest.args} (60%)
rename tests/qemuxml2argvdata/{firmware-manual-efi-acpi-aarch64.args => firmware-manual-efi-acpi-aarch64.aarch64-latest.args} (62%)
copy tests/qemuxml2argvdata/{firmware-manual-efi-acpi-q35.args => firmware-manual-efi-acpi-q35.x86_64-latest.args} (64%)
rename tests/qemuxml2argvdata/{firmware-manual-efi-no-path.err => firmware-manual-efi-no-path.x86_64-latest.err} (100%)
rename tests/qemuxml2argvdata/{firmware-manual-efi-noacpi-aarch64.args => firmware-manual-efi-noacpi-aarch64.aarch64-latest.args} (62%)
rename tests/qemuxml2argvdata/{firmware-manual-efi-noacpi-q35.err => firmware-manual-efi-noacpi-q35.x86_64-latest.err} (100%)
rename tests/qemuxml2argvdata/{firmware-manual-bios-rw.x86_64-latest.args => firmware-manual-efi-rw-implicit.x86_64-latest.args} (57%)
rename tests/qemuxml2argvdata/{firmware-manual-bios-rw-implicit.xml => firmware-manual-efi-rw-implicit.xml} (60%)
rename tests/qemuxml2argvdata/{firmware-manual-bios-rw-implicit.x86_64-latest.args => firmware-manual-efi-rw.x86_64-latest.args} (57%)
rename tests/qemuxml2argvdata/{firmware-manual-bios-rw.xml => firmware-manual-efi-rw.xml} (59%)
delete mode 100644 tests/qemuxml2argvdata/firmware-manual-efi-secure.args
copy tests/qemuxml2argvdata/{firmware-auto-efi-nvram.x86_64-latest.args => firmware-manual-efi-secure.x86_64-latest.args} (70%)
delete mode 100644 tests/qemuxml2argvdata/firmware-manual-efi.args
rename tests/qemuxml2argvdata/{firmware-manual-efi-acpi-q35.args => firmware-manual-efi.x86_64-latest.args} (63%)
rename tests/qemuxml2argvdata/{firmware-manual-noefi-acpi-aarch64.err => firmware-manual-noefi-acpi-aarch64.aarch64-latest.err} (100%)
rename tests/qemuxml2argvdata/{firmware-manual-noefi-acpi-q35.args => firmware-manual-noefi-acpi-q35.x86_64-latest.args} (63%)
rename tests/qemuxml2argvdata/{firmware-manual-noefi-noacpi-aarch64.args => firmware-manual-noefi-noacpi-aarch64.aarch64-latest.args} (60%)
rename tests/qemuxml2argvdata/{firmware-manual-noefi-noacpi-q35.args => firmware-manual-noefi-noacpi-q35.x86_64-latest.args} (64%)
copy tests/qemuxml2xmloutdata/{firmware-auto-efi-loader-secure.x86_64-latest.xml => firmware-auto-efi-format-loader-qcow2.x86_64-latest.xml} (74%)
copy tests/qemuxml2xmloutdata/{firmware-auto-efi-aarch64.aarch64-latest.xml => firmware-auto-efi-format-loader-raw.aarch64-latest.xml} (74%)
copy tests/qemuxml2xmloutdata/{firmware-manual-efi-nvram-network-nbd.x86_64-latest.xml => firmware-auto-efi-format-nvram-qcow2-network-nbd.x86_64-latest.xml} (76%)
copy tests/qemuxml2xmloutdata/{firmware-auto-efi-loader-secure.x86_64-latest.xml => firmware-auto-efi-format-nvram-qcow2-path.x86_64-latest.xml} (75%)
copy tests/qemuxml2xmloutdata/{firmware-auto-efi-loader-secure.x86_64-latest.xml => firmware-auto-efi-format-nvram-qcow2.x86_64-latest.xml} (74%)
copy tests/qemuxml2xmloutdata/{firmware-manual-efi-nvram-file.x86_64-latest.xml => firmware-auto-efi-nvram-file.x86_64-latest.xml} (78%)
copy tests/qemuxml2xmloutdata/{firmware-manual-efi-nvram-network-iscsi.x86_64-latest.xml => firmware-auto-efi-nvram-network-iscsi.x86_64-latest.xml} (89%)
copy tests/qemuxml2xmloutdata/{firmware-manual-efi-nvram-network-nbd.x86_64-latest.xml => firmware-auto-efi-nvram-network-nbd.x86_64-latest.xml} (88%)
copy tests/qemuxml2xmloutdata/{firmware-auto-efi-loader-secure.x86_64-latest.xml => firmware-auto-efi-smm-off.x86_64-latest.xml} (75%)
copy tests/qemuxml2xmloutdata/{firmware-auto-bios-stateless.x86_64-latest.xml => firmware-auto-efi-stateless.x86_64-latest.xml} (82%)
rename tests/qemuxml2xmloutdata/{firmware-manual-bios-stateless.xml => firmware-manual-bios-stateless.x86_64-latest.xml} (69%)
rename tests/qemuxml2xmloutdata/{firmware-manual-bios.xml => firmware-manual-bios.x86_64-latest.xml} (69%)
copy tests/qemuxml2xmloutdata/{firmware-auto-efi-aarch64.aarch64-latest.xml => firmware-manual-efi-acpi-aarch64.aarch64-latest.xml} (76%)
copy tests/qemuxml2xmloutdata/{firmware-auto-efi-loader-secure.x86_64-latest.xml => firmware-manual-efi-acpi-q35.x86_64-latest.xml} (76%)
copy tests/qemuxml2xmloutdata/{firmware-auto-efi-aarch64.aarch64-latest.xml => firmware-manual-efi-noacpi-aarch64.aarch64-latest.xml} (76%)
copy tests/qemuxml2xmloutdata/{firmware-manual-efi-nvram-file.x86_64-latest.xml => firmware-manual-efi-nvram-template.x86_64-latest.xml} (78%)
copy tests/qemuxml2xmloutdata/{firmware-manual-efi-nvram-file.x86_64-latest.xml => firmware-manual-efi-rw-implicit.x86_64-latest.xml} (72%)
copy tests/qemuxml2xmloutdata/{firmware-manual-efi-nvram-file.x86_64-latest.xml => firmware-manual-efi-rw.x86_64-latest.xml} (72%)
copy tests/qemuxml2xmloutdata/{firmware-auto-efi-loader-secure.x86_64-latest.xml => firmware-manual-efi-secure.x86_64-latest.xml} (73%)
copy tests/qemuxml2xmloutdata/{firmware-manual-efi-nvram-file.x86_64-latest.xml => firmware-manual-efi-stateless.x86_64-latest.xml} (72%)
rename tests/qemuxml2xmloutdata/{firmware-manual-efi.xml => firmware-manual-efi.x86_64-latest.xml} (70%)
copy tests/qemuxml2xmloutdata/{firmware-auto-efi.x86_64-latest.xml => firmware-manual-noefi-acpi-q35.x86_64-latest.xml} (86%)
copy tests/qemuxml2xmloutdata/{firmware-auto-efi-aarch64.aarch64-latest.xml => firmware-manual-noefi-noacpi-aarch64.aarch64-latest.xml} (88%)
copy tests/qemuxml2xmloutdata/{firmware-auto-efi.x86_64-latest.xml => firmware-manual-noefi-noacpi-q35.x86_64-latest.xml} (83%)
--
2.39.1
1 year, 9 months
[PATCH v2 0/6] Deprecate support for 32-bit x86 and arm hosts
by Thomas Huth
We're struggling quite badly with our CI minutes on the shared
gitlab runners, so we urgently need to think of ways to cut down
our supported build and target environments. qemu-system-i386 and
qemu-system-arm are not really required anymore, since nobody uses
KVM on the corresponding systems for production anymore, and the
-x86_64 and -arch64 variants are a proper superset of those binaries.
So it's time to deprecate them and the corresponding 32-bit host
environments now.
This is a follow-up patch series from the previous discussion here:
https://lore.kernel.org/qemu-devel/20230130114428.1297295-1-thuth@redhat....
where people still mentioned that there is still interest in certain
support for 32-bit host hardware. But as far as I could see, there is
no real need for 32-bit x86 host support and for system emulation on
32-bit arm hosts anymore, so it should be fine if we drop these host
environments soon (these are also the two architectures that contribute
the most to the long test times in our CI, so we would benefit a lot by
dropping those).
v2:
- Split binary and host deprecation into separate patches
- Added patches to immediately drop the jobs from the CI
Thomas Huth (6):
docs/about/deprecated: Deprecate the qemu-system-i386 binary
docs/about/deprecated: Deprecate 32-bit x86 hosts
gitlab-ci.d/crossbuilds: Drop the i386 jobs
docs/about/deprecated: Deprecate the qemu-system-arm binary
docs/about/deprecated: Deprecate 32-bit arm hosts
gitlab-ci.d/crossbuilds: Drop the 32-bit arm system emulation jobs
docs/about/deprecated.rst | 43 ++++++++++++++++++++++++++++++++++++
.gitlab-ci.d/crossbuilds.yml | 30 -------------------------
2 files changed, 43 insertions(+), 30 deletions(-)
--
2.31.1
1 year, 9 months
[PATCH v3 0/6] Deprecate support for 32-bit x86 and arm hosts
by Thomas Huth
We're struggling quite badly with our CI minutes on the shared
gitlab runners, so we urgently need to think of ways to cut down
our supported build and target environments. qemu-system-i386 and
qemu-system-arm are not really required anymore, since nobody uses
KVM on the corresponding systems for production anymore, and the
-x86_64 and -arch64 variants are a proper superset of those binaries.
So it's time to deprecate them and the corresponding 32-bit host
environments now (32-bit arm for system emulation, and 32-bit x86
completely).
This is a follow-up patch series from the previous discussion here:
https://lore.kernel.org/qemu-devel/20230130114428.1297295-1-thuth@redhat....
where people still mentioned that there is still interest in certain
support for 32-bit host hardware. But as far as I could see, there is
no real need for 32-bit x86 host support and for system emulation on
32-bit arm hosts anymore, so it should be fine if we drop these host
environments soon (these are also the two architectures that contribute
the most to the long test times in our CI, so we would benefit a lot by
dropping those).
v3:
- Update some commit descriptions according to the suggestions in v2
- Added the Reviewed-bys from v2
v2:
- Split binary and host deprecation into separate patches
- Added patches to immediately drop the jobs from the CI
Thomas Huth (6):
docs/about/deprecated: Deprecate 32-bit x86 hosts
docs/about/deprecated: Deprecate the qemu-system-i386 binary
gitlab-ci.d/crossbuilds: Drop the i386 jobs
docs/about/deprecated: Deprecate 32-bit arm hosts for system emulation
docs/about/deprecated: Deprecate the qemu-system-arm binary
gitlab-ci.d/crossbuilds: Drop the 32-bit arm system emulation jobs
docs/about/deprecated.rst | 43 ++++++++++++++++++++++++++++++++++++
.gitlab-ci.d/crossbuilds.yml | 34 ----------------------------
2 files changed, 43 insertions(+), 34 deletions(-)
--
2.31.1
1 year, 9 months
[PATCH 0/6] Generate ACL permision data in apibuild
by Peter Krempa
Peter Krempa (6):
remote_protocol: Fix list of supported ACL object names
apibuild: Add infrastructure for generating ACL flag info into
function docs
scripts/apibuild: Extract and format API ACLs
docs/newapi.xsl: Take API flag data from libvirt-api.xml rather than
access/libvirt-access.xml
docs|access: Don't build the ACL flags into a separate XML
gendispatch: Drop 'aclapi' mode
docs/html/meson.build | 32 +------
docs/meson.build | 3 +
docs/newapi.xsl | 20 ++---
scripts/apibuild.py | 163 ++++++++++++++++++++++++++++++++++-
src/access/meson.build | 16 ----
src/remote/remote_protocol.x | 5 +-
src/rpc/gendispatch.pl | 64 +-------------
7 files changed, 176 insertions(+), 127 deletions(-)
--
2.39.2
1 year, 9 months
[PATCH 0/4] qemu: Let virCommand report errors
by Michal Privoznik
In a lot of places we catch errors from qemuSecurityCommandRun() only to
produce an error report. But we can let virCommand module do the same.
Michal Prívozník (4):
qemu_slirp: Don't set errfd when starting slirp helper
qemu: Don't overwrite error from qemuSecurityCommandRun()
qemu: Drop @cmdret argument from qemuSecurityCommandRun()
qemu: Let virCommand module translate exitstatus
src/qemu/qemu_dbus.c | 11 +----------
src/qemu/qemu_passt.c | 12 +-----------
src/qemu/qemu_security.c | 13 ++++++-------
src/qemu/qemu_security.h | 3 +--
src/qemu/qemu_slirp.c | 12 +-----------
src/qemu/qemu_tpm.c | 9 +--------
src/qemu/qemu_vhost_user_gpu.c | 11 ++---------
7 files changed, 13 insertions(+), 58 deletions(-)
--
2.39.2
1 year, 9 months
[libvirt PATCH v6 0/8] Add support for 'blob' to virtio video device
by Jonathon Jongsma
Add support to libvirt for the 'blob' option for virtio video devices in qemu.
Also do a little preparatory refactoring of the video device xml parsing code.
This series was basically acked by Jan some time ago, but I made a couple
changes and apparently I dropped the ball and forgot to send out the revised
series. So here's a v6 after rebasing yet again to current master.
changes in v6:
- added two new patches:
- conf: explicitly set VIR_DOMAIN_VIDEO_TYPE_DEFAULT to 0
- util: add virXMLPropUIntDefault() function
- other minor fixes from Jan's review
Jonathon Jongsma (8):
conf: explicitly set VIR_DOMAIN_VIDEO_TYPE_DEFAULT to 0
conf: Refactor video model parsing
util: add virXMLPropUIntDefault() function
conf: switch to virXMLProp* functions for parsing video
conf: use enum variable for video type
conf: add support for 'blob' in virtio video device
qemu: Add capability for virtio-gpu.blob
qemu: Implement 'blob' support for virtio gpu
docs/formatdomain.rst | 7 +
src/conf/cpu_conf.c | 9 +-
src/conf/domain_conf.c | 134 ++++++++----------
src/conf/domain_conf.h | 5 +-
src/conf/domain_validate.c | 13 +-
src/conf/numa_conf.c | 7 +-
src/conf/schemas/domaincommon.rng | 5 +
src/libxl/libxl_conf.c | 10 ++
src/libxl/libxl_domain.c | 11 ++
src/qemu/qemu_capabilities.c | 2 +
src/qemu/qemu_capabilities.h | 1 +
src/qemu/qemu_cgroup.c | 22 ++-
src/qemu/qemu_command.c | 3 +
src/qemu/qemu_domain.h | 1 +
src/qemu/qemu_monitor_json.c | 16 ++-
src/qemu/qemu_namespace.c | 22 +++
src/qemu/qemu_process.c | 7 +
src/qemu/qemu_validate.c | 9 ++
src/util/virxml.c | 29 +++-
src/util/virxml.h | 9 ++
.../caps_6.1.0.x86_64.xml | 1 +
.../caps_6.2.0.aarch64.xml | 1 +
.../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 1 +
.../caps_6.2.0.x86_64.xml | 1 +
.../caps_7.0.0.aarch64.xml | 1 +
.../qemucapabilitiesdata/caps_7.0.0.ppc64.xml | 1 +
.../caps_7.0.0.x86_64.xml | 1 +
.../qemucapabilitiesdata/caps_7.1.0.ppc64.xml | 1 +
.../caps_7.1.0.x86_64.xml | 1 +
.../caps_7.2.0.x86_64.xml | 1 +
.../caps_8.0.0.riscv64.xml | 1 +
.../caps_8.0.0.x86_64.xml | 1 +
.../video-virtio-blob-off.x86_64-latest.args | 39 +++++
.../video-virtio-blob-off.xml | 36 +++++
.../video-virtio-blob-on.x86_64-latest.args | 39 +++++
.../qemuxml2argvdata/video-virtio-blob-on.xml | 36 +++++
tests/qemuxml2argvtest.c | 2 +
.../video-virtio-blob-off.x86_64-latest.xml | 48 +++++++
.../video-virtio-blob-on.x86_64-latest.xml | 48 +++++++
tests/qemuxml2xmltest.c | 2 +
40 files changed, 483 insertions(+), 101 deletions(-)
create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-off.x86_64-latest.args
create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-off.xml
create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-on.x86_64-latest.args
create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-on.xml
create mode 100644 tests/qemuxml2xmloutdata/video-virtio-blob-off.x86_64-latest.xml
create mode 100644 tests/qemuxml2xmloutdata/video-virtio-blob-on.x86_64-latest.xml
--
2.39.0
1 year, 9 months
[PATCH] security: Add support for SUSE edk2 firmware paths
by Jim Fehlig
SUSE installs edk2 firmwares for both x86_64 and aarch64 in /usr/share/qemu.
Add support for this path in virt-aa-helper and allow locking files within
the path in the libvirt qemu abstraction.
Signed-off-by: Jim Fehlig <jfehlig(a)suse.com>
---
FYI, I'm fine maintaining this patch downstream if such distro-specific
change is unwanted upstream. I've already maintained the virt-aa-helper
hunk for several years.
src/security/apparmor/libvirt-qemu | 2 +-
src/security/virt-aa-helper.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/security/apparmor/libvirt-qemu b/src/security/apparmor/libvirt-qemu
index d0289b8943..9af1333b22 100644
--- a/src/security/apparmor/libvirt-qemu
+++ b/src/security/apparmor/libvirt-qemu
@@ -91,7 +91,7 @@
/usr/share/proll/** r,
/usr/share/qemu-efi/** r,
/usr/share/qemu-kvm/** r,
- /usr/share/qemu/** r,
+ /usr/share/qemu/** rk,
/usr/share/seabios/** r,
/usr/share/sgabios/** r,
/usr/share/slof/** r,
diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c
index f6c9703db6..d65d459850 100644
--- a/src/security/virt-aa-helper.c
+++ b/src/security/virt-aa-helper.c
@@ -481,6 +481,7 @@ valid_path(const char *path, const bool readonly)
"/usr/share/AAVMF/", /* for AAVMF images */
"/usr/share/qemu-efi/", /* for AAVMF images */
"/usr/share/qemu-efi-aarch64/", /* for AAVMF images */
+ "/usr/share/qemu/", /* SUSE path for OVMF and AAVMF images */
"/usr/lib/u-boot/", /* u-boot loaders for qemu */
"/usr/lib/riscv64-linux-gnu/opensbi" /* RISC-V SBI implementation */
};
--
2.39.2
1 year, 9 months
[PATCH 00/21] qemu: IOthread setting changes
by Peter Krempa
This series:
0) cleans up various things (patches 1, 16)
1) Fixes and modernizes testing of iothreads (patches 2-9)
2) Cleans up unneeded iothread capabilities (patches 10 - 13)
3) Adds XML and commandline support for iothread polling attributes
(patches 14-15)
4) Contains a RFC for adding iothread to virtqueue mapping for disks
(patches 17-21)
The last patches are RFC because the qemu implementation is not done
yet. It's based on Stefan's patches which add the intrface part (see
patch 21)
Peter Krempa (21):
conf: virDomainDiskDefDriverParseXML: Drop unused XPath infrastructure
qemuxml2argvtest: Remove 'iothreads-nocap'
qemuxml2(argv|xml)test: Remove 'iothreads' case
qemuxml2argvtest: Modernize the rest of 'iohtreads-*'
qemuxml2xmltest: Modernize iothread CWW/SCSI test cases
qemuxml2(argv|xml)test: Modernize 'cputune' test cases
qemuxml2(argv|xmltest): Simplify testing of scheduler settings
qemuxml2argvtest: Modernize negative cputune-* cases
tests: qemuxml2argvdata: Remove irrelevant <disk> from 'iothread-*'
cases
qemu: Always assume support for iothreads
qemu: capabilities: Retire unused QEMU_CAPS_OBJECT_IOTHREAD
qemu: Always assume support for QEMU_CAPS_IOTHREAD_POLLING
qemu: capabilities: Retire unused QEMU_CAPS_IOTHREAD_POLLING
conf: Store the iothread 'poll' settings in the XML
qemu: Use configured iothread poll parameters on startup
docs: formatdomain: Properly indent example XML for setting
'metadata_cache'
<<< RFC starts here >>>
util: xml: Introduce virXMLNodeGetSubelement
qemucapabilitiesdata: Bump qemu-8.0 caps for virtqeueues
qemu: capabilities: Introduce QEMU_CAPS_VIRTIO_BLK_IOTHREAD_MAPPING
conf: Add possibility to configure multiple iothreads per disk
qemu: Implement support for configuring iothread to virtqueue mapping
for disks
docs/formatdomain.rst | 76 ++++---
src/conf/domain_conf.c | 124 ++++++++++-
src/conf/domain_conf.h | 21 ++
src/conf/domain_validate.c | 8 +
src/conf/schemas/domaincommon.rng | 66 ++++--
src/libvirt_private.syms | 1 +
src/qemu/qemu_capabilities.c | 10 +-
src/qemu/qemu_capabilities.h | 5 +-
src/qemu/qemu_command.c | 63 ++++++
src/qemu/qemu_driver.c | 57 ++---
src/qemu/qemu_process.c | 23 --
src/qemu/qemu_validate.c | 117 ++++++++++-
src/util/virxml.c | 29 +++
src/util/virxml.h | 4 +
.../caps_4.2.0.aarch64.xml | 2 -
.../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 2 -
.../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 2 -
.../caps_4.2.0.x86_64.xml | 2 -
.../caps_5.0.0.aarch64.xml | 2 -
.../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 2 -
.../caps_5.0.0.riscv64.xml | 2 -
.../caps_5.0.0.x86_64.xml | 2 -
.../qemucapabilitiesdata/caps_5.1.0.sparc.xml | 2 -
.../caps_5.1.0.x86_64.xml | 2 -
.../caps_5.2.0.aarch64.xml | 2 -
.../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 2 -
.../caps_5.2.0.riscv64.xml | 2 -
.../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 2 -
.../caps_5.2.0.x86_64.xml | 2 -
.../caps_6.0.0.aarch64.xml | 2 -
.../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 2 -
.../caps_6.0.0.x86_64.xml | 2 -
.../caps_6.1.0.x86_64.xml | 2 -
.../caps_6.2.0.aarch64.xml | 2 -
.../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 2 -
.../caps_6.2.0.x86_64.xml | 2 -
.../caps_7.0.0.aarch64.xml | 2 -
.../qemucapabilitiesdata/caps_7.0.0.ppc64.xml | 2 -
.../caps_7.0.0.x86_64.xml | 2 -
.../qemucapabilitiesdata/caps_7.1.0.ppc64.xml | 2 -
.../caps_7.1.0.x86_64.xml | 2 -
.../caps_7.2.0.x86_64.xml | 2 -
.../caps_8.0.0.riscv64.xml | 2 -
.../caps_8.0.0.x86_64.replies | 197 +++++++++---------
.../caps_8.0.0.x86_64.xml | 5 +-
tests/qemuxml2argvdata/cputune-iothreads.xml | 39 ----
...e-iothreadsched-toomuch.x86_64-latest.err} | 0
.../cputune-iothreadsched-zeropriority.xml | 40 ----
.../cputune-iothreadsched.xml | 39 ----
tests/qemuxml2argvdata/cputune-numatune.args | 32 ---
...gs => cputune-numatune.x86_64-latest.args} | 14 +-
...utune-vcpusched-overlap.x86_64-latest.err} | 0
...=> cputune-zero-shares.x86_64-latest.args} | 15 +-
.../qemuxml2argvdata/cputune-zero-shares.xml | 4 +-
...artial.args => cputune.x86_64-latest.args} | 24 ++-
tests/qemuxml2argvdata/cputune.xml | 12 +-
tests/qemuxml2argvdata/iothreads-disk.args | 41 ----
.../iothreads-disk.x86_64-latest.args | 46 ++++
tests/qemuxml2argvdata/iothreads-disk.xml | 35 +++-
... iothreads-ids-partial.x86_64-latest.args} | 20 +-
.../iothreads-ids-partial.xml | 10 +-
...othreads-ids-pool-sizes.x86_64-latest.args | 9 +-
.../iothreads-ids-pool-sizes.xml | 18 +-
....args => iothreads-ids.x86_64-latest.args} | 17 +-
tests/qemuxml2argvdata/iothreads-ids.xml | 10 +-
tests/qemuxml2argvdata/iothreads-nocap.err | 1 -
tests/qemuxml2argvdata/iothreads-nocap.xml | 37 ----
...othreads-virtio-scsi-pci.x86_64-5.2.0.args | 5 +-
...threads-virtio-scsi-pci.x86_64-latest.args | 5 +-
.../iothreads-virtio-scsi-pci.xml | 6 -
tests/qemuxml2argvdata/iothreads.args | 35 ----
tests/qemuxml2argvdata/iothreads.xml | 31 ---
.../vcpu-placement-static.x86_64-latest.args | 39 ++++
.../vcpu-placement-static.xml | 16 ++
tests/qemuxml2argvtest.c | 24 +--
.../qemuxml2xmloutdata/cputune-iothreads.xml | 48 -----
.../cputune-iothreadsched-zeropriority.xml | 51 -----
.../cputune-iothreadsched.xml | 51 -----
...xml => cputune-numatune.x86_64-latest.xml} | 5 +-
... => cputune-zero-shares.x86_64-latest.xml} | 9 +-
...{cputune.xml => cputune.x86_64-latest.xml} | 19 +-
...othreads-disk-virtio-ccw.s390x-latest.xml} | 4 +
...k.xml => iothreads-disk.x86_64-latest.xml} | 41 +++-
...> iothreads-ids-partial.x86_64-latest.xml} | 15 +-
...ds.xml => iothreads-ids.x86_64-latest.xml} | 15 +-
...othreads-virtio-scsi-ccw.s390x-latest.xml} | 4 +
...threads-virtio-scsi-pci.x86_64-latest.xml} | 11 +-
tests/qemuxml2xmloutdata/iothreads.xml | 36 ----
...> vcpu-placement-static.x86_64-latest.xml} | 0
tests/qemuxml2xmltest.c | 28 +--
90 files changed, 887 insertions(+), 938 deletions(-)
delete mode 100644 tests/qemuxml2argvdata/cputune-iothreads.xml
rename tests/qemuxml2argvdata/{cputune-iothreadsched-toomuch.err => cputune-iothreadsched-toomuch.x86_64-latest.err} (100%)
delete mode 100644 tests/qemuxml2argvdata/cputune-iothreadsched-zeropriority.xml
delete mode 100644 tests/qemuxml2argvdata/cputune-iothreadsched.xml
delete mode 100644 tests/qemuxml2argvdata/cputune-numatune.args
rename tests/qemuxml2argvdata/{vcpu-placement-static.args => cputune-numatune.x86_64-latest.args} (55%)
rename tests/qemuxml2argvdata/{cputune-vcpusched-overlap.err => cputune-vcpusched-overlap.x86_64-latest.err} (100%)
rename tests/qemuxml2argvdata/{cputune-zero-shares.args => cputune-zero-shares.x86_64-latest.args} (59%)
rename tests/qemuxml2argvdata/{iothreads-ids-partial.args => cputune.x86_64-latest.args} (50%)
delete mode 100644 tests/qemuxml2argvdata/iothreads-disk.args
create mode 100644 tests/qemuxml2argvdata/iothreads-disk.x86_64-latest.args
rename tests/qemuxml2argvdata/{iothreads-ids.args => iothreads-ids-partial.x86_64-latest.args} (51%)
rename tests/qemuxml2argvdata/{cputune.args => iothreads-ids.x86_64-latest.args} (55%)
delete mode 100644 tests/qemuxml2argvdata/iothreads-nocap.err
delete mode 100644 tests/qemuxml2argvdata/iothreads-nocap.xml
delete mode 100644 tests/qemuxml2argvdata/iothreads.args
delete mode 100644 tests/qemuxml2argvdata/iothreads.xml
create mode 100644 tests/qemuxml2argvdata/vcpu-placement-static.x86_64-latest.args
delete mode 100644 tests/qemuxml2xmloutdata/cputune-iothreads.xml
delete mode 100644 tests/qemuxml2xmloutdata/cputune-iothreadsched-zeropriority.xml
delete mode 100644 tests/qemuxml2xmloutdata/cputune-iothreadsched.xml
rename tests/qemuxml2xmloutdata/{cputune-numatune.xml => cputune-numatune.x86_64-latest.xml} (86%)
rename tests/qemuxml2xmloutdata/{cputune-zero-shares.xml => cputune-zero-shares.x86_64-latest.xml} (84%)
rename tests/qemuxml2xmloutdata/{cputune.xml => cputune.x86_64-latest.xml} (68%)
rename tests/qemuxml2xmloutdata/{iothreads-disk-virtio-ccw.xml => iothreads-disk-virtio-ccw.s390x-latest.xml} (89%)
rename tests/qemuxml2xmloutdata/{iothreads-disk.xml => iothreads-disk.x86_64-latest.xml} (58%)
rename tests/qemuxml2xmloutdata/{iothreads-ids-partial.xml => iothreads-ids-partial.x86_64-latest.xml} (72%)
rename tests/qemuxml2xmloutdata/{iothreads-ids.xml => iothreads-ids.x86_64-latest.xml} (71%)
rename tests/qemuxml2xmloutdata/{iothreads-virtio-scsi-ccw.xml => iothreads-virtio-scsi-ccw.s390x-latest.xml} (90%)
rename tests/qemuxml2xmloutdata/{iothreads-virtio-scsi-pci.xml => iothreads-virtio-scsi-pci.x86_64-latest.xml} (85%)
delete mode 100644 tests/qemuxml2xmloutdata/iothreads.xml
rename tests/qemuxml2xmloutdata/{vcpu-placement-static.xml => vcpu-placement-static.x86_64-latest.xml} (100%)
--
2.39.2
1 year, 9 months
[libvirt PATCH] qemu: Remove duplicate user/group lookup
by Andrea Bolognani
Commit 068efae5b1a9 created a copy of this code instead of
simply moving it.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
src/qemu/qemu_conf.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index a831783d75..680832742c 100644
--- a/src/qemu/qemu_conf.c
+++ b/src/qemu/qemu_conf.c
@@ -173,12 +173,6 @@ virQEMUDriverConfig *virQEMUDriverConfigNew(bool privileged,
cfg->memoryBackingDir = g_strdup_printf("%s/ram", cfg->libDir);
cfg->swtpmStorageDir = g_strdup_printf("%s/lib/libvirt/swtpm",
LOCALSTATEDIR);
- if (!virDoesUserExist("tss") ||
- virGetUserID("tss", &cfg->swtpm_user) < 0)
- cfg->swtpm_user = 0; /* fall back to root */
- if (!virDoesGroupExist("tss") ||
- virGetGroupID("tss", &cfg->swtpm_group) < 0)
- cfg->swtpm_group = 0; /* fall back to root */
} else {
g_autofree char *rundir = NULL;
g_autofree char *cachedir = NULL;
--
2.39.2
1 year, 9 months
