February 2023 - Devel - libvirt List Archives

[PATCH 00/10] remote: Pass 'mode' and 'socket' URI parameters to virt-ssh-helper
by Michal Privoznik 07 Feb '23

07 Feb '23

The first couple of patches are cleanups, mostly. The last 5 patches are the important ones. Now, the fix I went with in the 10/10 is to format URI anew, just for the virt-ssh-helper's sake. I did not want to touch @name as it's passed to sub-daemon's .open() method. If desired, I can change the @name variable instead as it seems that no driver relies on ?mode or ?socket (they couldn't anyway). Thoughts? Michal Prívozník (10): viruri: Search params case insensitively Drop checks for virURIFormat() retval doRemoteOpen(): Rename 'failed' label to 'error' remote_driver: Expose EXTRACT_URI_ARG_* macros src: Unify URI params parsing virt-ssh-helper: Accept ?mode= in connection URI virt-ssh-helper: Accept ?socket= in connection URI remote_driver: Move URI re-generation into a function viruri: Introduce virURIParamsSetIgnore() remote: Pass 'mode' and 'socket' URI parameters to virt-ssh-helper po/POTFILES | 1 + src/admin/libvirt-admin.c | 21 ++-- src/esx/esx_util.c | 96 ++++++++-------- src/hyperv/hyperv_util.c | 30 +++-- src/libvirt-host.c | 10 +- src/libvirt_private.syms | 1 + src/qemu/qemu_block.c | 3 +- src/qemu/qemu_migration.c | 24 ++-- src/remote/remote_driver.c | 158 +++++++++++++------------- src/remote/remote_ssh_helper.c | 27 ++++- src/storage/storage_backend_gluster.c | 6 +- src/util/virauth.c | 12 +- src/util/viruri.c | 24 +++- src/util/viruri.h | 37 ++++++ tests/viruritest.c | 3 +- 15 files changed, 245 insertions(+), 208 deletions(-) -- 2.39.1

4 22

[PATCH] qemu: Jump to cleanup label on umount failure
by Jim Fehlig 07 Feb '23

07 Feb '23

Similar to other error paths in qemuDomainUnshareNamespace(), jump to the cleanup label on umount error instead of directly returning -1. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- I noticed this while looking at a bug report containing the error. ATM I'm not sure why the umount failed, but have asked for more info in the bug https://bugzilla.opensuse.org/show_bug.cgi?id=1207889 src/qemu/qemu_namespace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_namespace.c b/src/qemu/qemu_namespace.c index 5769a4dfe0..833313d5a6 100644 --- a/src/qemu/qemu_namespace.c +++ b/src/qemu/qemu_namespace.c @@ -779,7 +779,7 @@ qemuDomainUnshareNamespace(virQEMUDriverConfig *cfg, #if defined(__linux__) if (umount("/dev") < 0) { virReportSystemError(errno, "%s", _("failed to umount devfs on /dev")); - return -1; + goto cleanup; } #endif /* !defined(__linux__) */ -- 2.39.1

2 1

[PATCH 0/2] virhostdevtest: Initialize hostdev @subsys
by Michal Privoznik 06 Feb '23

06 Feb '23

While the first one qualifies to be pushed as trivial, the second less so. I'll wait a while and if there's no reply I'll just push these, as the build is currently broken. Michal Prívozník (2): virhostdevtest: Initialize hostdev @subsys virhostdevtest: Decrease possibility of uninitialized @subsys tests/virhostdevtest.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) -- 2.39.1

3 4

[PATCH] Revert ".gitignore: Ignore cscope and other *tags files"
by Martin Kletzander 06 Feb '23

06 Feb '23

This reverts commit f2d379e7cb802f922409c35e4831ee52a2162486. On top of that it also removes the `/tags` file because we don't even have the `make tags` target any more. Any tool-related ignores should go to user's global ignore file or the user's local exclude file which is per-project. See git-config(1) and gitignore(5) for more details. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- .gitignore | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/.gitignore b/.gitignore index 61ea7779b02b..0898c0d29f3c 100644 --- a/.gitignore +++ b/.gitignore @@ -20,17 +20,6 @@ __pycache__/ /build/ /ci/scratch/ -# *tags and cscope files -/GPATH -/GRTAGS -/GTAGS -/TAGS -/cscope.files -/cscope.in.out -/cscope.out -/cscope.po.out -/tags - # clangd related ignores .clangd compile_commands.json -- 2.39.1

2 4

[PATCH v3 0/5] logging: add log cleanup for obsolete domains
by Oleg Vasilev 06 Feb '23

06 Feb '23

Presently, logs from deleted domains remain forever. Particular motivation comes from the case when libguestfs has repeatedly created transient VMs, which in turn created plenty of logs. This takes up space and lots of files troubles filesystem navigation. More motivation in [1]. Patch solving same problem in [2]. Changes in v3: codestyle cleanup, minor fixes Changes in v2: substantial rework according to Martin Kletzander's comments v1: https://www.mail-archive.com/libvir-list@redhat.com/msg233754.html v2: https://www.spinics.net/linux/fedora/libvir/msg236081.html [1]: https://listman.redhat.com/archives/libvir-list/2022-February/228149.html [2]: https://listman.redhat.com/archives/libvir-list/2022-February/msg00865.html CC: Martin Kletzander <mkletzan(a)redhat.com> Oleg Vasilev (5): logging: refactor to store config inside log handler logging: move virLogHandler to header logging: add configuration for future log cleaner logging: add log cleanup for obsolete domains logging: use the log cleaner po/POTFILES | 1 + src/logging/log_cleaner.c | 268 +++++++++++++++++++++++++++++++ src/logging/log_cleaner.h | 29 ++++ src/logging/log_daemon.c | 6 +- src/logging/log_daemon_config.c | 9 ++ src/logging/log_daemon_config.h | 3 + src/logging/log_handler.c | 64 +++----- src/logging/log_handler.h | 50 ++++-- src/logging/meson.build | 1 + src/logging/test_virtlogd.aug.in | 2 + src/logging/virtlogd.aug | 2 + src/logging/virtlogd.conf | 14 ++ 12 files changed, 391 insertions(+), 58 deletions(-) create mode 100644 src/logging/log_cleaner.c create mode 100644 src/logging/log_cleaner.h -- 2.39.1

3 10

[PATCH] .gitignore: Ignore cscope and other *tags files
by Martin Kletzander 06 Feb '23

06 Feb '23

Commit f7114e61dbc2 cleaned up way too much and now that I have cscope working again I noticed there are some files that ought to stay ignored. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- .gitignore | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 469539134280..61ea7779b02b 100644 --- a/.gitignore +++ b/.gitignore @@ -19,7 +19,17 @@ __pycache__/ # libvirt related ignores /build/ /ci/scratch/ -tags + +# *tags and cscope files +/GPATH +/GRTAGS +/GTAGS +/TAGS +/cscope.files +/cscope.in.out +/cscope.out +/cscope.po.out +/tags # clangd related ignores .clangd -- 2.39.1

5 6

[PATCH 0/3] qemu: Fix setting TPM state seclabels wrt save/restore
by Michal Privoznik 06 Feb '23

06 Feb '23

*** BLURB HERE *** Michal Prívozník (3): qemuProcessStop: Fix detection of outgoing migration for external devices qemuExtTPMStop: Restore TPM state label more often qemuProcessLaunch: Tighten rules for external devices wrt incoming migration src/qemu/qemu_process.c | 11 +++++++++-- src/qemu/qemu_tpm.c | 2 +- 2 files changed, 10 insertions(+), 3 deletions(-) -- 2.39.1

3 5

[libvirt PATCH v2 0/8] Extract the integration job commands to a shell script
by Erik Skultety 06 Feb '23

06 Feb '23

Using shell scripts rather than inlining shell commands to YAML feels more natural, more readable, and will keep all different variations of execution consistent. Essentially the only disadvantage is that we won't see each command listed one-by-one in gitlab's log output (unless we set -x that is), but given that shell would complain if something was wrong with the script, it's fairly easy to identify the problem. Here's a test pipeline after the change: https://gitlab.com/eskultety/libvirt/-/pipelines/759277200 Since v1: - 3/7 - reworded commit message as requested - 4/7 was dropped - point the SCRATCH_DIR to /var/tmp instead of /tmp to not be limited by the size of ramdisk mounted in there Erik Skultety (8): syntax-check: Drop the shell's 'check for minus' rule ci: Move the SCRATCH_DIR from /tmp ci: integration: Extract several hidden job definitions to a script ci: integration: Drop the 'install-deps' hidden job and reference ci: integration-template: Drop the '-lt Fedora 35' check ci: integration.sh: Add/Rewrite/Reformat commentaries ci: integration.sh: Replace 'test' with '[' operator ci: integration.sh: Define the SCRATCH_DIR variable for local execution build-aux/syntax-check.mk | 9 -------- ci/integration-template.yml | 44 +++-------------------------------- ci/integration.sh | 46 +++++++++++++++++++++++++++++++++++++ 3 files changed, 49 insertions(+), 50 deletions(-) create mode 100644 ci/integration.sh -- 2.39.1

1 9

[PATCH 0/5] Various (json related) cleanups
by Peter Krempa 06 Feb '23

06 Feb '23

Some more patches from old branches that I didn't get around finishing before. Peter Krempa (5): virbitmap: Allow NULL bitmap in functions returning index of a set/clear bit qemuMonitorJSONQueryStats: Simplify logic to construct 'provider_list' qemu_monitor_json: Replace simplify fetching Array from JSON object qemu: agent: Use virJSONValueObjectGetArray qemuDomainGetStatsVcpu: Refactor cleanup src/qemu/qemu_agent.c | 29 ++++--------------- src/qemu/qemu_driver.c | 22 ++++++--------- src/qemu/qemu_monitor_json.c | 54 ++++++++++++++---------------------- src/util/virbitmap.c | 9 ++++++ src/util/virbitmap.h | 9 ++---- 5 files changed, 46 insertions(+), 77 deletions(-) -- 2.39.1

2 6

Unable to use Routed (brouter) method with netmask 255.255.255.255 in both host and vm
by jose.r.r＠metztli.com 04 Feb '23

04 Feb '23

Hello- Assuming I have the host /etc/network/interfaces in Debian Bullseye as follows: ----------------------------------------------------- auto enpXYs0 iface eth0 inet static address mn.opq.rst.xy # Main IP netmask 255.255.255.255 pointopoint (Gateway IP) gateway (Gateway IP) auto virbr0 iface virbr0 inet static address mn.opq.rst.xy #Main IP netmask 255.255.255.255 bridge_ports none bridge_stp off bridge_fd 0 pre-up brctl addbr virbr0 # Additional IP for VM below: only mn.opq octets match main IP up ip route add mn.opq.uw.z/32 dev virbr0 down ip route del mn.opq.uw.z/32 dev virbr0 ---------------------------------------------------- Using the above configuration, ip addr shows the main host IP address as 'peer' with its gateway IP. Please, see: < https://docs.hetzner.com/robot/dedicated-server/network/net-config-debian-u… > What kind of /etc/libvirt/qemu/network/mytestnetwork.xml file should I create for a virtual machine installation connected via libvirtd? Please note that nftables are in use and possibly I should edit its configuration file to add the IP mn.opq.uw.z of the virtual machine and thus enable the VM to utilize the main host IP as a gateway. Currently I have mytestnetwork.xml which contains: <network> <name>mytestnetwork</name> <uuid>char-string</uuid> <forward mode='bridge'/> <bridge name='virbr0'/> </network> The VirtManager GUI advances the installation of the Debian OS in the VM but even if I have provided the main host IP as its gateway IP it cannot fetch the debian packages from its repository, i.e., there is no connection to the outside world. Any insight is appreciated. -- Best Professional Regards. -- Jose R R http://metztli.it --------------------------------------------------------------------------------------------- Download Metztli Reiser4: Debian Buster w/ Linux 5.16.20 AMD64 --------------------------------------------------------------------------------------------- feats ZSTD compression https://sf.net/projects/metztli-reiser4/ ------------------------------------------------------------------------------------------- Official current Reiser4 resources: https://reiser4.wiki.kernel.org/

1 0