May 2022 - Devel - libvirt List Archives

[libvirt RFCv10 00/32] multifd save restore prototype
by Claudio Fontana 15 May '22

15 May '22

This is v10 of the multifd save prototype, which improves the DIRECT I/O APIs and makes changes to the on disk format backward and forward compatible, avoiding the need to alter the QEMU_SAVE_VERSION. This series demonstrates the DIRECT I/O friendly read/write code working by using the block-friently multifd streams supplied by the multifd helper, but could also work with block-aware QEMU streams if ever available in the future. KNOWN ISSUES: a) still applies only to save/restore (no managed save etc) b) multifd: saves to multiple files instead of just one file --- changes from v9: * exposed virFileDirectAlign * separated the >= 2 QEMU_SAVE_VERSION change in own patch * reworked the write code to add the alignment padding to the data_len, making the on disk format compatible when loaded from an older libvirt. * reworked the read code to use direct I/O APIs only for actual direct I/O file descriptors, so as to make old images work with newer libvirt. --- changes from v8: * rebased on master * reordered patches to add more upstreamable content at the start * split introduction of virQEMUSaveFd, so the first part is multifd-free * new virQEMUSaveDataRead as a mirror of virQEMUSaveDataWrite * introduced virFileDirect API, using it in virFileDisk operations and for virQEMUSaveRead and virQEMUSaveWrite --- changes from v7: * [ base params API and iohelper refactoring upstreamed ] * extended the QEMU save image format more, to record the nr of multifd channels on save. Made the data header struct packed. * removed --parallel-connections from the restore command, as now it is useless due to QEMU save image format extension. * separate out patches to expose migration_params APIs to saveimage, including qemuMigrationParamsSetString, SetCap, SetInt. * fixed bugs in the ImageOpen patch (missing saveFd init), removed some whitespace, and fixed some convoluted code paths for return value -3. --- changes from v6: * improved error path handling, with error messages and especially cancellation of qemu process on error during restore. * split patches more and reordered them to keep general refactoring at the beginning before the --parallel stuff is introduced. * improved multifd compression support, including adding an enum and extending the QEMU save image format to record the compression used on save, and pick it up automatically on restore. --- changes from v4: * runIO renamed to virFileDiskCopy and rethought arguments * renamed new APIs from ...ParametersFlags to ...Params * introduce the new virDomainSaveParams and virDomainRestoreParams without any additional parameters, so they can be upstreamed first. * solved the issue in the gendispatch.pl script generating code that was missing the conn parameter. --- changes from v3: * reordered series to have all helper-related change at the start * solved all reported issues from ninja test, including documentation * fixed most broken migration capabilities code (still imperfect likely) * added G_GNUC_UNUSED as needed * after multifd restore, added what I think were the missing operations: qemuProcessRefreshState(), qemuProcessStartCPUs() - most importantly, virDomainObjSave() The domain now starts running after restore without further encouragement * removed the sleep(10) from the multifd-helper --- changes from v2: * added ability to restore the VM from disk using multifd * fixed the multifd-helper to work in both directions, assuming the need to listen for save, and connect for restore. * fixed a large number of bugs, and probably introduced some :-) --- Claudio Fontana (32): virfile: introduce virFileDirect APIs virfile: use virFileDirect API in runIOCopy qemu: saveimage: rework image read/write to be O_DIRECT friendly qemu: saveimage: assume future formats will also support compression virfile: virFileDiskCopy: prepare for O_DIRECT files without wrapper qemu: saveimage: introduce virQEMUSaveFd qemu: saveimage: convert qemuSaveImageCreate to use virQEMUSaveFd qemu: saveimage: convert qemuSaveImageOpen to use virQEMUSaveFd tools: prepare doSave to use parameters tools: prepare cmdRestore to use parameters libvirt: add new VIR_DOMAIN_SAVE_PARALLEL flag and parameter qemu: add stub support for VIR_DOMAIN_SAVE_PARALLEL in save qemu: add stub support for VIR_DOMAIN_SAVE_PARALLEL in restore multifd-helper: new helper for parallel save/restore qemu: saveimage: add virQEMUSaveFd APIs for multifd qemu: saveimage: wire up saveimage code with the multifd helper qemu: capabilities: add multifd to the probed migration capabilities qemu: saveimage: add multifd related fields to save format qemu: migration_params: add APIs to set Int and Cap qemu: migration: implement qemuMigrationSrcToFilesMultiFd for save qemu: add parameter to qemuMigrationDstRun to skip waiting qemu: implement qemuSaveImageLoadMultiFd for restore tools: add parallel parameter to virsh save command tools: add parallel parameter to virsh restore command qemu: add migration parameter multifd-compression libvirt: add new VIR_DOMAIN_SAVE_PARAM_PARALLEL_COMPRESSION qemu: saveimage: add parallel compression argument to ImageCreate qemu: saveimage: add stub support for multifd compression parameter qemu: migration: expose qemuMigrationParamsSetString qemu: saveimage: implement multifd-compression in parallel save qemu: saveimage: restore compressed parallel images tools: add parallel-compression parameter to virsh save command docs/manpages/virsh.rst | 39 +- include/libvirt/libvirt-domain.h | 29 + po/POTFILES.in | 1 + src/libvirt_private.syms | 9 + src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 2 + src/qemu/qemu_driver.c | 146 ++-- src/qemu/qemu_migration.c | 160 ++-- src/qemu/qemu_migration.h | 16 +- src/qemu/qemu_migration_params.c | 71 +- src/qemu/qemu_migration_params.h | 15 + src/qemu/qemu_process.c | 3 +- src/qemu/qemu_process.h | 5 +- src/qemu/qemu_saveimage.c | 793 ++++++++++++++---- src/qemu/qemu_saveimage.h | 71 +- src/qemu/qemu_snapshot.c | 6 +- src/util/meson.build | 16 + src/util/multifd-helper.c | 247 ++++++ src/util/virfile.c | 316 ++++++- src/util/virfile.h | 11 + src/util/virthread.c | 5 + src/util/virthread.h | 1 + .../caps_4.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1 + .../caps_4.0.0.riscv32.xml | 1 + .../caps_4.0.0.riscv64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 1 + .../caps_4.0.0.x86_64.xml | 1 + .../caps_4.1.0.x86_64.xml | 1 + .../caps_4.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 + .../caps_4.2.0.x86_64.xml | 1 + .../caps_5.0.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 2 + .../caps_5.0.0.riscv64.xml | 2 + .../caps_5.0.0.x86_64.xml | 2 + .../qemucapabilitiesdata/caps_5.1.0.sparc.xml | 2 + .../caps_5.1.0.x86_64.xml | 2 + .../caps_5.2.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 2 + .../caps_5.2.0.riscv64.xml | 2 + .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 2 + .../caps_5.2.0.x86_64.xml | 2 + .../caps_6.0.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 2 + .../caps_6.0.0.x86_64.xml | 2 + .../caps_6.1.0.x86_64.xml | 2 + .../caps_6.2.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 2 + .../caps_6.2.0.x86_64.xml | 2 + .../caps_7.0.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_7.0.0.ppc64.xml | 2 + .../caps_7.0.0.x86_64.xml | 2 + .../caps_7.1.0.x86_64.xml | 2 + tools/virsh-domain.c | 101 ++- 56 files changed, 1718 insertions(+), 404 deletions(-) create mode 100644 src/util/multifd-helper.c -- 2.35.3

1 32

[libvirt RFCv9 00/31] multifd save restore prototype
by Claudio Fontana 15 May '22

15 May '22

This is v9 of the multifd save prototype, which splits things up more in order to hopefully offer more upstreamable code, and adds DIRECT I/O APIs and changes to the save/restore format to be more block friendly, potentially removing the need of an iohelper completely. This is demonstrated in this case using the multifd streams supplied by the multifd helper, but could also work with block-aware QEMU streams if ever available in the future. KNOWN ISSUES: a) still applies only to save/restore (no managed save etc) b) multifd: saves to multiple files instead of just one file --- changes from v8: * rebased on master * reordered patches to add more upstreamable content at the start * split introduction of virQEMUSaveFd, so the first part is multifd-free * new virQEMUSaveDataRead as a mirror of virQEMUSaveDataWrite * introduced virFileDirect API, using it in virFileDisk operations and for virQEMUSaveRead and virQEMUSaveWrite --- changes from v7: * [ base params API and iohelper refactoring upstreamed ] * extended the QEMU save image format more, to record the nr of multifd channels on save. Made the data header struct packed. * removed --parallel-connections from the restore command, as now it is useless due to QEMU save image format extension. * separate out patches to expose migration_params APIs to saveimage, including qemuMigrationParamsSetString, SetCap, SetInt. * fixed bugs in the ImageOpen patch (missing saveFd init), removed some whitespace, and fixed some convoluted code paths for return value -3. --- changes from v6: * improved error path handling, with error messages and especially cancellation of qemu process on error during restore. * split patches more and reordered them to keep general refactoring at the beginning before the --parallel stuff is introduced. * improved multifd compression support, including adding an enum and extending the QEMU save image format to record the compression used on save, and pick it up automatically on restore. --- changes from v4: * runIO renamed to virFileDiskCopy and rethought arguments * renamed new APIs from ...ParametersFlags to ...Params * introduce the new virDomainSaveParams and virDomainRestoreParams without any additional parameters, so they can be upstreamed first. * solved the issue in the gendispatch.pl script generating code that was missing the conn parameter. --- changes from v3: * reordered series to have all helper-related change at the start * solved all reported issues from ninja test, including documentation * fixed most broken migration capabilities code (still imperfect likely) * added G_GNUC_UNUSED as needed * after multifd restore, added what I think were the missing operations: qemuProcessRefreshState(), qemuProcessStartCPUs() - most importantly, virDomainObjSave() The domain now starts running after restore without further encouragement * removed the sleep(10) from the multifd-helper --- changes from v2: * added ability to restore the VM from disk using multifd * fixed the multifd-helper to work in both directions, assuming the need to listen for save, and connect for restore. * fixed a large number of bugs, and probably introduced some :-) --- Claudio Fontana (31): virfile: introduce virFileDirect APIs virfile: use virFileDirect API in runIOCopy qemu: saveimage: rework save format and read/write to be O_DIRECT friendly virfile: virFileDiskCopy: prepare for O_DIRECT files without wrapper qemu: saveimage: introduce virQEMUSaveFd qemu: saveimage: convert qemuSaveImageCreate to use virQEMUSaveFd qemu: saveimage: convert qemuSaveImageOpen to use virQEMUSaveFd tools: prepare doSave to use parameters tools: prepare cmdRestore to use parameters libvirt: add new VIR_DOMAIN_SAVE_PARALLEL flag and parameter qemu: add stub support for VIR_DOMAIN_SAVE_PARALLEL in save qemu: add stub support for VIR_DOMAIN_SAVE_PARALLEL in restore multifd-helper: new helper for parallel save/restore qemu: saveimage: add virQEMUSaveFd APIs for multifd qemu: saveimage: wire up saveimage code with the multifd helper qemu: capabilities: add multifd to the probed migration capabilities qemu: saveimage: add multifd related fields to save format qemu: migration_params: add APIs to set Int and Cap qemu: migration: implement qemuMigrationSrcToFilesMultiFd for save qemu: add parameter to qemuMigrationDstRun to skip waiting qemu: implement qemuSaveImageLoadMultiFd for restore tools: add parallel parameter to virsh save command tools: add parallel parameter to virsh restore command qemu: add migration parameter multifd-compression libvirt: add new VIR_DOMAIN_SAVE_PARAM_PARALLEL_COMPRESSION qemu: saveimage: add parallel compression argument to ImageCreate qemu: saveimage: add stub support for multifd compression parameter qemu: migration: expose qemuMigrationParamsSetString qemu: saveimage: implement multifd-compression in parallel save qemu: saveimage: restore compressed parallel images tools: add parallel-compression parameter to virsh save command docs/manpages/virsh.rst | 39 +- include/libvirt/libvirt-domain.h | 29 + po/POTFILES.in | 1 + src/libvirt_private.syms | 7 + src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 2 + src/qemu/qemu_driver.c | 146 ++-- src/qemu/qemu_migration.c | 160 ++-- src/qemu/qemu_migration.h | 16 +- src/qemu/qemu_migration_params.c | 71 +- src/qemu/qemu_migration_params.h | 15 + src/qemu/qemu_process.c | 3 +- src/qemu/qemu_process.h | 5 +- src/qemu/qemu_saveimage.c | 753 +++++++++++++----- src/qemu/qemu_saveimage.h | 73 +- src/qemu/qemu_snapshot.c | 6 +- src/util/meson.build | 16 + src/util/multifd-helper.c | 247 ++++++ src/util/virfile.c | 316 +++++++- src/util/virfile.h | 10 + src/util/virthread.c | 5 + src/util/virthread.h | 1 + .../caps_4.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1 + .../caps_4.0.0.riscv32.xml | 1 + .../caps_4.0.0.riscv64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 1 + .../caps_4.0.0.x86_64.xml | 1 + .../caps_4.1.0.x86_64.xml | 1 + .../caps_4.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 + .../caps_4.2.0.x86_64.xml | 1 + .../caps_5.0.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 2 + .../caps_5.0.0.riscv64.xml | 2 + .../caps_5.0.0.x86_64.xml | 2 + .../qemucapabilitiesdata/caps_5.1.0.sparc.xml | 2 + .../caps_5.1.0.x86_64.xml | 2 + .../caps_5.2.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 2 + .../caps_5.2.0.riscv64.xml | 2 + .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 2 + .../caps_5.2.0.x86_64.xml | 2 + .../caps_6.0.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 2 + .../caps_6.0.0.x86_64.xml | 2 + .../caps_6.1.0.x86_64.xml | 2 + .../caps_6.2.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 2 + .../caps_6.2.0.x86_64.xml | 2 + .../caps_7.0.0.aarch64.xml | 2 + .../qemucapabilitiesdata/caps_7.0.0.ppc64.xml | 2 + .../caps_7.0.0.x86_64.xml | 2 + .../caps_7.1.0.x86_64.xml | 2 + tools/virsh-domain.c | 101 ++- 56 files changed, 1675 insertions(+), 406 deletions(-) create mode 100644 src/util/multifd-helper.c -- 2.35.3

1 32

[PATCH 00/29] Remove some unused includes
by Peng Liang 14 May '22

14 May '22

4 34

[PATCH 00/37] qemu: Improve 'qemuFDPass' usability and refactor interface code to use it
by Peter Krempa 13 May '22

13 May '22

This series modifies qemuFDPass to be a bit more convenient to use by e.g. remembering the maximum fd set index currently used across libvirtd restarts so that we can avoid having to pass the FDs before actually constructing the device properties. Along with that this code refactors the handling of FDs used for network interfaces. There was a substantial amount of duplicated code with plethora of helper variables and such. By converting to qemuFDPass stored in the private data we can simplify the functions. Peter Krempa (37): qemu_fd: Add return value handling for qemuFDPassTransfer* APIs qemu_fd: Add validation before transferring file descriptors qemu_fd: Remove error checking from qemuFDPassAddFD qemuDomainAttachNetDevice: Use 'qemuFDPass' for the vdpa file descriptor qemu: monitor: Don't parse actual fd's from query-fdsets/add-fd replies qemuMonitorJSONQueryFdsets: Ensure that JSON arrays are valid before using them qemu: domain: Store and update 'fdsetindex' across libvirtd restarts qemu_fd: Don't rely on fdset id allocation by qemu qemuMonitorAddFileHandleToSet: Remove return of 'qemuMonitorAddFdInfo' qemuFDPassTransferMonitor: Close local copy of the FD as soon as it's passed to qemu qemu: Clear 'qemuFDPass' helpers of char devices when no longer needed qemu: domain: Add qemuFDPass helpers into network private data qemu: command: Introduce 'qemuBuildInterfaceConnect' helper qemuBuildInterfaceConnect: Connect to 'vdpa' netdev qemuBuildHostNetProps: Move all 'tap' code together qemuBuildHostNetProps: Refactor construction of tapfd/vhostfd arguments qemuDomainAttachNetDevice: Don't construct network device properties under monitor lock qemu: Prepare netdev code for use of qemuFDPass for tapfd/vhostfd passing qemuBuildNicDevProps: Don't pass 'vhostfdSize' qemuInterfaceOpenVhostNet: Reformat error messages per new guidelines qemu: Move opening of vhost file descriptors for net devices into qemuBuildInterfaceConnect qemuDomainAttachNetDevice: Remove 'vhostfd' machinery qemuBuildInterfaceCommandLine: Remove 'vhostfd' machinery qemuBuildHostNetProps: Remove 'vhostfd' machinery qemuMonitorAddNetdev: Remove 'vhostfd' machinery qemu: Move opening of tap file descriptors for net devices into qemuBuildInterfaceConnect qemuBuildInterfaceCommandLine: Remove 'tapfd' infrastructure qemuDomainAttachNetDevice: Remove unused 'tapfd' infrastructure qemuBuildNicDevProps: Remove unused 'tapfd' infrastructure qemuMonitorAddNetdev: Remove unused 'tapfd' infrastructure qemuInterfacePrepareSlirp: Directly populate the 'slirp' variable in network private data qemuSlirpStart: Simplify parameters qemu: slirp: Call qemuSlirpOpen directly from qemuSlirpStart qemu: slirp: Pass FDs to qemu via qemuFDPass in the network private data qemuDomainAttachNetDevice: Clean up unneeded 'slirp' helper variables qemuMonitorAddNetdev: Remove unneeded 'slirp' variables and useless debug qemu: slirp: Remove unused 'qemuSlirpGetFD' src/qemu/qemu_command.c | 393 +++++++++--------- src/qemu/qemu_command.h | 15 +- src/qemu/qemu_domain.c | 34 +- src/qemu/qemu_domain.h | 14 +- src/qemu/qemu_extdevice.c | 13 +- src/qemu/qemu_fd.c | 118 +++--- src/qemu/qemu_fd.h | 7 +- src/qemu/qemu_hotplug.c | 172 ++------ src/qemu/qemu_interface.c | 83 ++-- src/qemu/qemu_interface.h | 9 +- src/qemu/qemu_monitor.c | 50 +-- src/qemu/qemu_monitor.h | 14 +- src/qemu/qemu_monitor_json.c | 78 +--- src/qemu/qemu_monitor_json.h | 3 +- src/qemu/qemu_process.c | 47 ++- src/qemu/qemu_slirp.c | 30 +- src/qemu/qemu_slirp.h | 10 +- tests/qemuhotplugtest.c | 1 + tests/qemumonitorjsontest.c | 3 - .../qemustatusxml2xmldata/backup-pull-in.xml | 1 + .../blockjob-blockdev-in.xml | 1 + .../blockjob-mirror-in.xml | 1 + .../migration-in-params-in.xml | 1 + .../migration-out-nbd-bitmaps-in.xml | 1 + .../migration-out-nbd-out.xml | 1 + .../migration-out-nbd-tls-out.xml | 1 + .../migration-out-params-in.xml | 1 + tests/qemustatusxml2xmldata/modern-in.xml | 1 + tests/qemustatusxml2xmldata/upgrade-out.xml | 1 + .../qemustatusxml2xmldata/vcpus-multi-in.xml | 1 + .../net-eth-unmanaged-tap.args | 2 +- tests/qemuxml2argvdata/user-aliases.args | 2 +- tests/qemuxml2argvmock.c | 28 +- tests/testutilsqemu.c | 6 +- 34 files changed, 502 insertions(+), 641 deletions(-) -- 2.35.1

3 58

[PATCH v2] virt-xml-validate: Add more XML formats support
by Han Han 13 May '22

13 May '22

Add these XML formats validation in manpage or script: cpu, domainbackup, domaincaps, domaincheckpoint, networkport, storagepoolcaps. Signed-off-by: Han Han <hhan(a)redhat.com> --- Diff from v1: Add domainbackup, domaincaps, networkport, storagepoolcaps v1: https://listman.redhat.com/archives/libvir-list/2021-November/225070.html --- docs/manpages/virt-xml-validate.rst | 24 ++++++++++++++++++++++++ tools/virt-xml-validate.in | 15 +++++++++++++++ 2 files changed, 39 insertions(+) diff --git a/docs/manpages/virt-xml-validate.rst b/docs/manpages/virt-xml-validate.rst index 940eada3a8..503ddbd35a 100644 --- a/docs/manpages/virt-xml-validate.rst +++ b/docs/manpages/virt-xml-validate.rst @@ -31,18 +31,42 @@ from the name of the root element in the XML document. Valid schema names currently include +- ``cpu`` + +The schema for the XML format of cpu + - ``domainsnapshot`` The schema for the XML format used by domain snapshot configuration +- ``domaincheckpoint`` + +The schema for the XML format used by domain checkpoint configuration + +- ``domainbackup`` + +The schema for the XML format used by domain backup configuration + +- ``domaincaps`` + +The schema for the XML format of domain capabilities + - ``domain`` The schema for the XML format used by guest domains configuration +- ``networkport`` + +The schema for the XML format used by network port configuration + - ``network`` The schema for the XML format used by virtual network configuration +- ``storagepoolcaps`` + +The schema for the XML format of storage pool capabilities + - ``storagepool`` The schema for the XML format used by storage pool configuration diff --git a/tools/virt-xml-validate.in b/tools/virt-xml-validate.in index 249bcf7eef..e444ef2fbc 100644 --- a/tools/virt-xml-validate.in +++ b/tools/virt-xml-validate.in @@ -74,9 +74,21 @@ if [ -z "$TYPE" ]; then ROOT=`xmllint --stream --debug "$XMLFILE" 2>/dev/null | grep "^0 1 " | awk '{ print $3 }'` fi case "$ROOT" in + *cpu*) + TYPE="cpu" + ;; *domainsnapshot*) # Must come first, since *domain* is a substring TYPE="domainsnapshot" ;; + *domaincheckpoint*) + TYPE="domaincheckpoint" + ;; + *domainbackup*) + TYPE="domainbackup" + ;; + *domaincaps*) + TYPE="domaincaps" + ;; *domain*) TYPE="domain" ;; @@ -86,6 +98,9 @@ if [ -z "$TYPE" ]; then *network*) TYPE="network" ;; + *storagepoolcaps*) + TYPE="storagepoolcaps" + ;; *pool*) TYPE="storagepool" ;; -- 2.36.0

2 1

[libvirt PATCH 0/3] conf: Fix handling of SMM feature
by Andrea Bolognani 13 May '22

13 May '22

Andrea Bolognani (3): tests: Update smm=on test tests: Introduce smm=off test conf: Fix smm=off handling src/conf/domain_conf.c | 9 +++++--- ...rgs => machine-smm-off.x86_64-latest.args} | 16 ++++++-------- tests/qemuxml2argvdata/machine-smm-off.xml | 17 +++++++++++++++ ...args => machine-smm-on.x86_64-latest.args} | 16 ++++++-------- tests/qemuxml2argvdata/machine-smm-on.xml | 17 +++++++++++++++ tests/qemuxml2argvtest.c | 8 ++----- .../machine-smm-off.x86_64-latest.xml} | 21 ++++++++++++------- .../machine-smm-on.x86_64-latest.xml} | 19 ++++++++++------- tests/qemuxml2xmltest.c | 2 ++ 9 files changed, 81 insertions(+), 44 deletions(-) copy tests/qemuxml2argvdata/{machine-smm-opt.args => machine-smm-off.x86_64-latest.args} (52%) create mode 100644 tests/qemuxml2argvdata/machine-smm-off.xml rename tests/qemuxml2argvdata/{machine-smm-opt.args => machine-smm-on.x86_64-latest.args} (52%) create mode 100644 tests/qemuxml2argvdata/machine-smm-on.xml copy tests/{qemuxml2argvdata/machine-smm-opt.xml => qemuxml2xmloutdata/machine-smm-off.x86_64-latest.xml} (51%) rename tests/{qemuxml2argvdata/machine-smm-opt.xml => qemuxml2xmloutdata/machine-smm-on.x86_64-latest.xml} (53%) -- 2.35.3

2 4

[PATCH v2 0/3] virDomain{Save,Restore}Params: More fixes
by Michal Privoznik 13 May '22

13 May '22

v2 of: https://listman.redhat.com/archives/libvir-list/2022-May/231307.html diff to v1: - Reworked 3/3, instead of promoting restore path to a regular argument, let's keep it in typed params as this is more future proof. But require it for now. Michal Prívozník (3): qemu: Separate out save code from qemuDomainManagedSave() lib: Repurpose virDomainSaveParams() with no VIR_DOMAIN_SAVE_PARAM_FILE virDomainRestoreFlags: Require VIR_DOMAIN_SAVE_PARAM_FILE for now src/libvirt-domain.c | 6 ++- src/qemu/qemu_driver.c | 117 +++++++++++++++++++++++++---------------- 2 files changed, 77 insertions(+), 46 deletions(-) -- 2.35.1

4 7

[PATCH 0/3] virDomain{Save,Restore}Params: More fixes
by Michal Privoznik 13 May '22

13 May '22

*** BLURB HERE *** Michal Prívozník (3): qemu: Separate out save code from qemuDomainManagedSave() lib: Repurpose virDomainSaveParams() with no VIR_DOMAIN_SAVE_PARAM_FILE lib: Require path in virDomainRestoreParams() include/libvirt/libvirt-domain.h | 1 + src/driver-hypervisor.h | 1 + src/libvirt-domain.c | 27 +++++-- src/qemu/qemu_driver.c | 120 ++++++++++++++++++------------- src/remote/remote_protocol.x | 1 + src/remote_protocol-structs | 1 + src/rpc/gendispatch.pl | 2 +- 7 files changed, 97 insertions(+), 56 deletions(-) -- 2.35.1

4 8

[PATCH 0/4] network: firewalld: fix routed network
by Eric Garver 12 May '22

12 May '22

This series fixes routed networks when a newer firewalld (>= 1.0.0) is present [1]. Firewalld 1.0.0 included a change that disallows implicit forwarding between zones [2]. libvirt was relying on this behavior to allow routed networks to function. New firewalld policies are added. This is done to use common rules between NAT and routed networks. Policies have been supported since firewalld 0.9.0. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=2055706 [2]: https://github.com/firewalld/firewalld/issues/177 Eric Garver (4): network: firewalld: convert to policies network: firewalld: add zone for routed networks network: firewalld: add policies for routed networks network: firewalld: add support for routed networks src/network/bridge_driver_linux.c | 6 +++++- src/network/libvirt-nat-out.policy | 12 ++++++++++++ src/network/libvirt-routed-in.policy | 11 +++++++++++ src/network/libvirt-routed-out.policy | 12 ++++++++++++ src/network/libvirt-routed.zone | 12 ++++++++++++ src/network/libvirt-to-host.policy | 21 +++++++++++++++++++++ src/network/libvirt.zone | 23 +++++------------------ src/network/meson.build | 25 +++++++++++++++++++++++++ 8 files changed, 103 insertions(+), 19 deletions(-) create mode 100644 src/network/libvirt-nat-out.policy create mode 100644 src/network/libvirt-routed-in.policy create mode 100644 src/network/libvirt-routed-out.policy create mode 100644 src/network/libvirt-routed.zone create mode 100644 src/network/libvirt-to-host.policy -- 2.33.0

3 19

[PATCH] qemu: Don't check for qemuDomainManagedSavePath() retval
by Michal Privoznik 12 May '22

12 May '22

The qemuDomainManagedSavePath() function does no more than a g_strdup_printf() and as such can't return NULL really. Therefore, don't check for its return value. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_driver.c | 25 ++++++------------------- 1 file changed, 6 insertions(+), 19 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 41c6836390..edba400a7b 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2904,8 +2904,7 @@ qemuDomainManagedSave(virDomainPtr dom, unsigned int flags) "save", false)) < 0) goto cleanup; - if (!(name = qemuDomainManagedSavePath(driver, vm))) - goto cleanup; + name = qemuDomainManagedSavePath(driver, vm); VIR_INFO("Saving state of domain '%s' to '%s'", vm->def->name, name); @@ -2926,19 +2925,15 @@ qemuDomainManagedSaveLoad(virDomainObj *vm, { virQEMUDriver *driver = opaque; g_autofree char *name = NULL; - int ret = -1; virObjectLock(vm); - if (!(name = qemuDomainManagedSavePath(driver, vm))) - goto cleanup; + name = qemuDomainManagedSavePath(driver, vm); vm->hasManagedSave = virFileExists(name); - ret = 0; - cleanup: virObjectUnlock(vm); - return ret; + return 0; } @@ -2979,8 +2974,7 @@ qemuDomainManagedSaveRemove(virDomainPtr dom, unsigned int flags) if (virDomainManagedSaveRemoveEnsureACL(dom->conn, vm->def) < 0) goto cleanup; - if (!(name = qemuDomainManagedSavePath(driver, vm))) - goto cleanup; + name = qemuDomainManagedSavePath(driver, vm); if (unlink(name) < 0) { virReportSystemError(errno, @@ -6079,8 +6073,7 @@ qemuDomainManagedSaveGetXMLDesc(virDomainPtr dom, unsigned int flags) if (virDomainManagedSaveGetXMLDescEnsureACL(dom->conn, vm->def, flags) < 0) goto cleanup; - if (!(path = qemuDomainManagedSavePath(driver, vm))) - goto cleanup; + path = qemuDomainManagedSavePath(driver, vm); if (!virFileExists(path)) { virReportError(VIR_ERR_OPERATION_INVALID, "%s", @@ -6117,8 +6110,7 @@ qemuDomainManagedSaveDefineXML(virDomainPtr dom, const char *dxml, if (virDomainManagedSaveDefineXMLEnsureACL(conn, vm->def) < 0) goto cleanup; - if (!(path = qemuDomainManagedSavePath(driver, vm))) - goto cleanup; + path = qemuDomainManagedSavePath(driver, vm); if (!virFileExists(path)) { virReportError(VIR_ERR_OPERATION_INVALID, "%s", @@ -6427,9 +6419,6 @@ qemuDomainObjStart(virConnectPtr conn, */ managed_save = qemuDomainManagedSavePath(driver, vm); - if (!managed_save) - return ret; - if (virFileExists(managed_save)) { if (force_boot) { if (unlink(managed_save) < 0) { @@ -6690,8 +6679,6 @@ qemuDomainUndefineFlags(virDomainPtr dom, } name = qemuDomainManagedSavePath(driver, vm); - if (name == NULL) - goto endjob; if (virFileExists(name)) { if (flags & VIR_DOMAIN_UNDEFINE_MANAGED_SAVE) { -- 2.35.1

2 1