[PATCH 0/8] kbase: debuglogs: Include guidance how to setup logging with modular daemons
by Peter Krempa
Modular daemons are the default in many cases yet, one of our most
frequented documents neglects to describe the intricacies of the setup.
Browsable result is available at:
https://pipo.sk.gitlab.io/-/libvirt/-/jobs/1983126893/artifacts/website/d...
https://pipo.sk.gitlab.io/-/libvirt/-/jobs/1983126893/artifacts/website/k...
Sorry for TLS warnings. Gitlab didn't really think through allowing
users to pick username with a dot and I refuse to change it.
Peter Krempa (8):
docs: daemons: Add section on figuring out whether modular or
monolithic daemon is in use
kbase: debuglogs: Use common heading hierarchy
kbase: debuglogs: Un-nest section on enabling debug logs
kbase: debuglogs: Section off the settings for legacy libvirt
kbase: debuglogs: Add a section describing log outputs and filters
kbase: debuglogs: Extract client library logging setup
kbase: debuglogs: Emphasise 'virt-admin'
kbase: debuglogs: Fix for modular daemons
docs/daemons.rst | 47 ++++++++
docs/kbase/debuglogs.rst | 239 ++++++++++++++++++++++++++++++---------
2 files changed, 235 insertions(+), 51 deletions(-)
--
2.34.1
2 years, 11 months
[PATCH 0/5] storage: Implement 'checkPool' for 'disk' pools and various fixes
by Peter Krempa
Peter Krempa (5):
storage: Add debug logs for storage pool config loading
virStoragePoolObjLoadAllConfigs: Use automatic memory clearing
storageDriverAutostartCallback: Refactor control flow
virStoragePoolObjSourceFindDuplicateCb: Fix handling of
VIR_STORAGE_POOL_ISCSI_DIRECT
storage: Implement 'checkPool' method for 'disk' type pools
src/conf/virstorageobj.c | 23 ++++----------
src/storage/storage_backend_disk.c | 27 ++++++++++++++++
src/storage/storage_driver.c | 51 ++++++++++++++++--------------
3 files changed, 61 insertions(+), 40 deletions(-)
--
2.34.1
2 years, 11 months
[libvirt][PATCH v9 0/5] Support query and use SGX
by Haibin Huang
This patch series provides support for enabling Intel's Software Guard
Extensions (SGX) feature in guest VM.
Giving the SGX support in QEMU be accepted and will be merged in two
days Intel SGX is a set of instructions that increases the security
of application code and data, giving them more protection from disclosure
or modification.
Developers can partition sensitive information into enclaves, which are
areas of execution in memory with more security protection.
The typical flow looks below at very high level:
1. Calls virConnectGetDomainCapabilities API to domain capabilities that
includes the following SGX information.
<feature>
...
<sgx supported='yes'>
<epc_size unit='KiB'>N</epc_size>
</sgx>
</feature>
2. User requests to start a guest calling virCreateXML() with SGX requirement.
It should contain
<devices>
...
<memory model='sgx-epc'>
<target>
<size unit='KiB'>N</size>
</target>
</memory>
...
</devices>
Haibin Huang (2):
Get SGX Capabilities from QEMU
Transfer Qemu SGX Capabilities to XML
Lin Yang (3):
conf: Introduce SGX EPC element into device memory xml
qemu: Add command-line to generate SGX EPC memory backend
Add unit tests for guest VM creation command with SGX EPC
docs/schemas/domaincaps.rng | 22 ++-
docs/schemas/domaincommon.rng | 1 +
src/conf/domain_capabilities.c | 29 ++++
src/conf/domain_capabilities.h | 13 ++
src/conf/domain_conf.c | 6 +
src/conf/domain_conf.h | 1 +
src/conf/domain_validate.c | 1 +
src/libvirt_private.syms | 1 +
src/qemu/qemu_alias.c | 6 +-
src/qemu/qemu_capabilities.c | 143 +++++++++++++++++-
src/qemu/qemu_capabilities.h | 4 +
src/qemu/qemu_command.c | 41 ++++-
src/qemu/qemu_domain.c | 12 +-
src/qemu/qemu_domain_address.c | 6 +
src/qemu/qemu_driver.c | 1 +
src/qemu/qemu_monitor.c | 10 ++
src/qemu/qemu_monitor.h | 3 +
src/qemu/qemu_monitor_json.c | 83 ++++++++++
src/qemu/qemu_monitor_json.h | 3 +
src/qemu/qemu_process.c | 2 +
src/qemu/qemu_validate.c | 8 +
src/security/security_apparmor.c | 1 +
src/security/security_dac.c | 2 +
src/security/security_selinux.c | 2 +
tests/domaincapsdata/bhyve_basic.x86_64.xml | 1 +
tests/domaincapsdata/bhyve_fbuf.x86_64.xml | 1 +
tests/domaincapsdata/bhyve_uefi.x86_64.xml | 1 +
tests/domaincapsdata/empty.xml | 1 +
tests/domaincapsdata/libxl-xenfv.xml | 1 +
tests/domaincapsdata/libxl-xenpv.xml | 1 +
.../domaincapsdata/qemu_2.11.0-q35.x86_64.xml | 1 +
.../domaincapsdata/qemu_2.11.0-tcg.x86_64.xml | 1 +
tests/domaincapsdata/qemu_2.11.0.s390x.xml | 1 +
tests/domaincapsdata/qemu_2.11.0.x86_64.xml | 1 +
.../domaincapsdata/qemu_2.12.0-q35.x86_64.xml | 1 +
.../domaincapsdata/qemu_2.12.0-tcg.x86_64.xml | 1 +
.../qemu_2.12.0-virt.aarch64.xml | 1 +
tests/domaincapsdata/qemu_2.12.0.aarch64.xml | 1 +
tests/domaincapsdata/qemu_2.12.0.ppc64.xml | 1 +
tests/domaincapsdata/qemu_2.12.0.s390x.xml | 1 +
tests/domaincapsdata/qemu_2.12.0.x86_64.xml | 1 +
.../domaincapsdata/qemu_2.4.0-q35.x86_64.xml | 1 +
.../domaincapsdata/qemu_2.4.0-tcg.x86_64.xml | 1 +
tests/domaincapsdata/qemu_2.4.0.x86_64.xml | 1 +
.../domaincapsdata/qemu_2.5.0-q35.x86_64.xml | 1 +
.../domaincapsdata/qemu_2.5.0-tcg.x86_64.xml | 1 +
tests/domaincapsdata/qemu_2.5.0.x86_64.xml | 1 +
.../domaincapsdata/qemu_2.6.0-q35.x86_64.xml | 1 +
.../domaincapsdata/qemu_2.6.0-tcg.x86_64.xml | 1 +
.../qemu_2.6.0-virt.aarch64.xml | 1 +
tests/domaincapsdata/qemu_2.6.0.aarch64.xml | 1 +
tests/domaincapsdata/qemu_2.6.0.ppc64.xml | 1 +
tests/domaincapsdata/qemu_2.6.0.x86_64.xml | 1 +
.../domaincapsdata/qemu_2.7.0-q35.x86_64.xml | 1 +
.../domaincapsdata/qemu_2.7.0-tcg.x86_64.xml | 1 +
tests/domaincapsdata/qemu_2.7.0.s390x.xml | 1 +
tests/domaincapsdata/qemu_2.7.0.x86_64.xml | 1 +
.../domaincapsdata/qemu_2.8.0-q35.x86_64.xml | 1 +
.../domaincapsdata/qemu_2.8.0-tcg.x86_64.xml | 1 +
tests/domaincapsdata/qemu_2.8.0.s390x.xml | 1 +
tests/domaincapsdata/qemu_2.8.0.x86_64.xml | 1 +
.../domaincapsdata/qemu_2.9.0-q35.x86_64.xml | 1 +
.../domaincapsdata/qemu_2.9.0-tcg.x86_64.xml | 1 +
tests/domaincapsdata/qemu_2.9.0.ppc64.xml | 1 +
tests/domaincapsdata/qemu_2.9.0.s390x.xml | 1 +
tests/domaincapsdata/qemu_2.9.0.x86_64.xml | 1 +
.../domaincapsdata/qemu_3.0.0-q35.x86_64.xml | 1 +
.../domaincapsdata/qemu_3.0.0-tcg.x86_64.xml | 1 +
tests/domaincapsdata/qemu_3.0.0.ppc64.xml | 1 +
tests/domaincapsdata/qemu_3.0.0.s390x.xml | 1 +
tests/domaincapsdata/qemu_3.0.0.x86_64.xml | 1 +
.../domaincapsdata/qemu_3.1.0-q35.x86_64.xml | 1 +
.../domaincapsdata/qemu_3.1.0-tcg.x86_64.xml | 1 +
tests/domaincapsdata/qemu_3.1.0.ppc64.xml | 1 +
tests/domaincapsdata/qemu_3.1.0.x86_64.xml | 1 +
.../domaincapsdata/qemu_4.0.0-q35.x86_64.xml | 1 +
.../domaincapsdata/qemu_4.0.0-tcg.x86_64.xml | 1 +
.../qemu_4.0.0-virt.aarch64.xml | 1 +
tests/domaincapsdata/qemu_4.0.0.aarch64.xml | 1 +
tests/domaincapsdata/qemu_4.0.0.ppc64.xml | 1 +
tests/domaincapsdata/qemu_4.0.0.s390x.xml | 1 +
tests/domaincapsdata/qemu_4.0.0.x86_64.xml | 1 +
.../domaincapsdata/qemu_4.1.0-q35.x86_64.xml | 1 +
.../domaincapsdata/qemu_4.1.0-tcg.x86_64.xml | 1 +
tests/domaincapsdata/qemu_4.1.0.x86_64.xml | 1 +
.../domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 1 +
.../domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 1 +
.../qemu_4.2.0-virt.aarch64.xml | 1 +
tests/domaincapsdata/qemu_4.2.0.aarch64.xml | 1 +
tests/domaincapsdata/qemu_4.2.0.ppc64.xml | 1 +
tests/domaincapsdata/qemu_4.2.0.s390x.xml | 1 +
tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 1 +
.../domaincapsdata/qemu_5.0.0-q35.x86_64.xml | 1 +
.../domaincapsdata/qemu_5.0.0-tcg.x86_64.xml | 1 +
.../qemu_5.0.0-virt.aarch64.xml | 1 +
tests/domaincapsdata/qemu_5.0.0.aarch64.xml | 1 +
tests/domaincapsdata/qemu_5.0.0.ppc64.xml | 1 +
tests/domaincapsdata/qemu_5.0.0.x86_64.xml | 1 +
.../domaincapsdata/qemu_5.1.0-q35.x86_64.xml | 1 +
.../domaincapsdata/qemu_5.1.0-tcg.x86_64.xml | 1 +
tests/domaincapsdata/qemu_5.1.0.sparc.xml | 1 +
tests/domaincapsdata/qemu_5.1.0.x86_64.xml | 1 +
.../domaincapsdata/qemu_5.2.0-q35.x86_64.xml | 1 +
.../domaincapsdata/qemu_5.2.0-tcg.x86_64.xml | 1 +
.../qemu_5.2.0-virt.aarch64.xml | 1 +
tests/domaincapsdata/qemu_5.2.0.aarch64.xml | 1 +
tests/domaincapsdata/qemu_5.2.0.ppc64.xml | 1 +
tests/domaincapsdata/qemu_5.2.0.s390x.xml | 1 +
tests/domaincapsdata/qemu_5.2.0.x86_64.xml | 1 +
.../domaincapsdata/qemu_6.0.0-q35.x86_64.xml | 1 +
.../domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 1 +
.../qemu_6.0.0-virt.aarch64.xml | 1 +
tests/domaincapsdata/qemu_6.0.0.aarch64.xml | 1 +
tests/domaincapsdata/qemu_6.0.0.s390x.xml | 1 +
tests/domaincapsdata/qemu_6.0.0.x86_64.xml | 1 +
.../domaincapsdata/qemu_6.1.0-q35.x86_64.xml | 1 +
.../domaincapsdata/qemu_6.1.0-tcg.x86_64.xml | 1 +
tests/domaincapsdata/qemu_6.1.0.x86_64.xml | 1 +
.../domaincapsdata/qemu_6.2.0-q35.x86_64.xml | 4 +
.../domaincapsdata/qemu_6.2.0-tcg.x86_64.xml | 4 +
tests/domaincapsdata/qemu_6.2.0.x86_64.xml | 4 +
.../caps_6.2.0.x86_64.replies | 22 ++-
.../caps_6.2.0.x86_64.xml | 5 +
.../sgx-epc.x86_64-6.2.0.args | 37 +++++
tests/qemuxml2argvdata/sgx-epc.xml | 36 +++++
tests/qemuxml2argvtest.c | 2 +
126 files changed, 597 insertions(+), 12 deletions(-)
create mode 100644 tests/qemuxml2argvdata/sgx-epc.x86_64-6.2.0.args
create mode 100644 tests/qemuxml2argvdata/sgx-epc.xml
--
2.17.1
2 years, 11 months
[PATCH] docs: man: virsh: Document more carefully that 'guestinfo' can return nothing
by Peter Krempa
When invoking 'virsh guestinfo $VM' without explicitly specifying a
group of information to return, virsh always reports success even when
the guest agent doesn't report any information in the current state.
This is desired in situations when you are okay with stats being missing
and avoids spurious errors being reported.
Clarify that this is really desired in the man page.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2041665
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
docs/manpages/virsh.rst | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
index dd534c10cb..19fb8cd0e4 100644
--- a/docs/manpages/virsh.rst
+++ b/docs/manpages/virsh.rst
@@ -2768,11 +2768,14 @@ Note that this command requires a guest agent to be configured and running in
the domain's guest OS.
When run without any arguments, this command prints all information types that
-are supported by the guest agent. You can limit the types of information that
-are returned by specifying one or more flags. If a requested information
-type is not supported, the processes will provide an exit code of 1.
-Available information types flags are *--user*, *--os*,
+are supported by the guest agent at that point, omitting unavailable ones.
+Success is always reported in this mode.
+
+You can limit the types of information that are returned by specifying one or
+more flags. Available information types flags are *--user*, *--os*,
*--timezone*, *--hostname*, *--filesystem*, *--disk* and *--interface*.
+If an explicitly requested information type is not supported by the guest agent
+at that point, the processes will provide an exit code of 1.
Note that depending on the hypervisor type and the version of the guest agent
running within the domain, not all of the following information may be
--
2.34.1
2 years, 11 months
[libvirt PATCH] manpages: libvirt-guests: Fix typos
by Tim Wiederhake
Signed-off-by: Tim Wiederhake <twiederh(a)redhat.com>
---
docs/manpages/libvirt-guests.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/manpages/libvirt-guests.rst b/docs/manpages/libvirt-guests.rst
index 76045ed11a..bea08e3bff 100644
--- a/docs/manpages/libvirt-guests.rst
+++ b/docs/manpages/libvirt-guests.rst
@@ -21,7 +21,7 @@ DESCRIPTION
===========
``libvirt-guests`` is a service that can be used to coordinate guest and host
-lifecyle actions. By default, ``libvirt-guests`` will suspend running guests
+lifecycle actions. By default, ``libvirt-guests`` will suspend running guests
when the host shuts down, and restore them to their pre-shutdown state when
the host reboots.
@@ -40,7 +40,7 @@ FILES
=====
``libvirt-guests`` defines several variables to control service behavior.
-The default vaule of these variables can be overridden in:
+The default value of these variables can be overridden in:
* ``@SYSCONFDIR@/sysconfig/libvirt-guests``
--
2.31.1
2 years, 11 months
[PATCH] spec: Run pre/post-install stuff on 'daemon-driver-storage-core'
by Peter Krempa
'daemon-driver-storage' is just a meta-package, the actual daemon is in
the 'daemon-driver-storage-core' package, so without installing the meta
package the storage daemon is not being enabled.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2025644
Fixes: 50eae3f8859, b8ef6255444
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
libvirt.spec.in | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index b9f1e30906..f0ff4c0ece 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1483,19 +1483,19 @@ fi
%libvirt_daemon_perform_restart virtsecretd
-%pre daemon-driver-storage
+%pre daemon-driver-storage-core
%libvirt_sysconfig_pre virtstoraged
-%post daemon-driver-storage
+%post daemon-driver-storage-core
%if %{with_modular_daemons}
%libvirt_daemon_systemd_post virtstoraged
%endif
%libvirt_daemon_schedule_restart virtstoraged
-%preun daemon-driver-storage
+%preun daemon-driver-storage-core
%libvirt_daemon_systemd_preun virtstoraged
-%posttrans daemon-driver-storage
+%posttrans daemon-driver-storage-core
%libvirt_sysconfig_posttrans virtstoraged
%libvirt_daemon_perform_restart virtstoraged
--
2.34.1
2 years, 11 months
[PATCH] docs: man: Unify wording for the description of '--timeout' of daemons
by Peter Krempa
Use a common wording for all various daemons to prevent having to adjust
the documentation any further by just outlining that neither clients nor
anything else needing the attention of the daemon must be present in
order to shut down.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2035985
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
docs/manpages/virtbhyved.rst | 3 ++-
docs/manpages/virtinterfaced.rst | 3 ++-
docs/manpages/virtlockd.rst | 5 +++--
docs/manpages/virtlogd.rst | 5 +++--
docs/manpages/virtlxcd.rst | 3 ++-
docs/manpages/virtnetworkd.rst | 3 ++-
docs/manpages/virtnodedevd.rst | 3 ++-
docs/manpages/virtnwfilterd.rst | 3 ++-
docs/manpages/virtproxyd.rst | 3 ++-
docs/manpages/virtqemud.rst | 3 ++-
docs/manpages/virtsecretd.rst | 3 ++-
docs/manpages/virtstoraged.rst | 3 ++-
docs/manpages/virtvboxd.rst | 3 ++-
docs/manpages/virtvzd.rst | 3 ++-
docs/manpages/virtxend.rst | 3 ++-
15 files changed, 32 insertions(+), 17 deletions(-)
diff --git a/docs/manpages/virtbhyved.rst b/docs/manpages/virtbhyved.rst
index 9fdaca6da2..2e56514914 100644
--- a/docs/manpages/virtbhyved.rst
+++ b/docs/manpages/virtbhyved.rst
@@ -61,7 +61,8 @@ Use this name for the PID file, overriding the default value.
``-t``, ``--timeout *SECONDS*``
Exit after timeout period (in seconds), provided there are neither any client
-connections nor any running domains.
+connections nor any other resources (e.g. running domains, locks, etc.) needing
+attention of the daemon.
``-v``, ``--verbose``
diff --git a/docs/manpages/virtinterfaced.rst b/docs/manpages/virtinterfaced.rst
index 5777dba638..9b836b0b12 100644
--- a/docs/manpages/virtinterfaced.rst
+++ b/docs/manpages/virtinterfaced.rst
@@ -83,7 +83,8 @@ Use this name for the PID file, overriding the default value.
``-t``, ``--timeout *SECONDS*``
Exit after timeout period (in seconds), provided there are neither any client
-connections nor any running domains.
+connections nor any other resources (e.g. running domains, locks, etc.) needing
+attention of the daemon.
``-v``, ``--verbose``
diff --git a/docs/manpages/virtlockd.rst b/docs/manpages/virtlockd.rst
index 0bbee5a5f7..7ea720d1b7 100644
--- a/docs/manpages/virtlockd.rst
+++ b/docs/manpages/virtlockd.rst
@@ -50,8 +50,9 @@ Use this configuration file, overriding the default value.
``-t``, ``--timeout`` *SECONDS*
-Automatically shutdown after *SECONDS* have elapsed with
-no active client or lock.
+Exit after timeout period (in seconds), provided there are neither any client
+connections nor any other resources (e.g. running domains, locks, etc.) needing
+attention of the daemon.
``-p``, ``--pid-file`` *FILE*
diff --git a/docs/manpages/virtlogd.rst b/docs/manpages/virtlogd.rst
index 1e39ff1b49..0b00595a85 100644
--- a/docs/manpages/virtlogd.rst
+++ b/docs/manpages/virtlogd.rst
@@ -50,8 +50,9 @@ Use this configuration file, overriding the default value.
``-t``, ``--timeout`` *SECONDS*
-Automatically shutdown after *SECONDS* have elapsed with
-no active console log.
+Exit after timeout period (in seconds), provided there are neither any client
+connections nor any other resources (e.g. running domains, locks, etc.) needing
+attention of the daemon.
``-p``, ``--pid-file`` *FILE*
diff --git a/docs/manpages/virtlxcd.rst b/docs/manpages/virtlxcd.rst
index 2e9d8fd14b..4c9a441d0d 100644
--- a/docs/manpages/virtlxcd.rst
+++ b/docs/manpages/virtlxcd.rst
@@ -83,7 +83,8 @@ Use this name for the PID file, overriding the default value.
``-t``, ``--timeout *SECONDS*``
Exit after timeout period (in seconds), provided there are neither any client
-connections nor any running domains.
+connections nor any other resources (e.g. running domains, locks, etc.) needing
+attention of the daemon.
``-v``, ``--verbose``
diff --git a/docs/manpages/virtnetworkd.rst b/docs/manpages/virtnetworkd.rst
index 6d9c5e5fa3..b9409723fb 100644
--- a/docs/manpages/virtnetworkd.rst
+++ b/docs/manpages/virtnetworkd.rst
@@ -83,7 +83,8 @@ Use this name for the PID file, overriding the default value.
``-t``, ``--timeout *SECONDS*``
Exit after timeout period (in seconds), provided there are neither any client
-connections nor any running domains.
+connections nor any other resources (e.g. running domains, locks, etc.) needing
+attention of the daemon.
``-v``, ``--verbose``
diff --git a/docs/manpages/virtnodedevd.rst b/docs/manpages/virtnodedevd.rst
index ef968e486e..1c79529bd8 100644
--- a/docs/manpages/virtnodedevd.rst
+++ b/docs/manpages/virtnodedevd.rst
@@ -82,7 +82,8 @@ Use this name for the PID file, overriding the default value.
``-t``, ``--timeout *SECONDS*``
Exit after timeout period (in seconds), provided there are neither any client
-connections nor any running domains.
+connections nor any other resources (e.g. running domains, locks, etc.) needing
+attention of the daemon.
``-v``, ``--verbose``
diff --git a/docs/manpages/virtnwfilterd.rst b/docs/manpages/virtnwfilterd.rst
index 4faa6b225d..0690c795d9 100644
--- a/docs/manpages/virtnwfilterd.rst
+++ b/docs/manpages/virtnwfilterd.rst
@@ -83,7 +83,8 @@ Use this name for the PID file, overriding the default value.
``-t``, ``--timeout *SECONDS*``
Exit after timeout period (in seconds), provided there are neither any client
-connections nor any running domains.
+connections nor any other resources (e.g. running domains, locks, etc.) needing
+attention of the daemon.
``-v``, ``--verbose``
diff --git a/docs/manpages/virtproxyd.rst b/docs/manpages/virtproxyd.rst
index 0366935b9a..918aae6c2b 100644
--- a/docs/manpages/virtproxyd.rst
+++ b/docs/manpages/virtproxyd.rst
@@ -105,7 +105,8 @@ Use this name for the PID file, overriding the default value.
``-t``, ``--timeout *SECONDS*``
Exit after timeout period (in seconds), provided there are neither any client
-connections nor any running domains.
+connections nor any other resources (e.g. running domains, locks, etc.) needing
+attention of the daemon.
``-v``, ``--verbose``
diff --git a/docs/manpages/virtqemud.rst b/docs/manpages/virtqemud.rst
index ea8d6e3105..f1f1710393 100644
--- a/docs/manpages/virtqemud.rst
+++ b/docs/manpages/virtqemud.rst
@@ -83,7 +83,8 @@ Use this name for the PID file, overriding the default value.
``-t``, ``--timeout *SECONDS*``
Exit after timeout period (in seconds), provided there are neither any client
-connections nor any running domains.
+connections nor any other resources (e.g. running domains, locks, etc.) needing
+attention of the daemon.
``-v``, ``--verbose``
diff --git a/docs/manpages/virtsecretd.rst b/docs/manpages/virtsecretd.rst
index fffb3a24f6..f35bfb6b5a 100644
--- a/docs/manpages/virtsecretd.rst
+++ b/docs/manpages/virtsecretd.rst
@@ -82,7 +82,8 @@ Use this name for the PID file, overriding the default value.
``-t``, ``--timeout *SECONDS*``
Exit after timeout period (in seconds), provided there are neither any client
-connections nor any running domains.
+connections nor any other resources (e.g. running domains, locks, etc.) needing
+attention of the daemon.
``-v``, ``--verbose``
diff --git a/docs/manpages/virtstoraged.rst b/docs/manpages/virtstoraged.rst
index 4ceae57e40..ae25a90040 100644
--- a/docs/manpages/virtstoraged.rst
+++ b/docs/manpages/virtstoraged.rst
@@ -83,7 +83,8 @@ Use this name for the PID file, overriding the default value.
``-t``, ``--timeout *SECONDS*``
Exit after timeout period (in seconds), provided there are neither any client
-connections nor any running domains.
+connections nor any other resources (e.g. running domains, locks, etc.) needing
+attention of the daemon.
``-v``, ``--verbose``
diff --git a/docs/manpages/virtvboxd.rst b/docs/manpages/virtvboxd.rst
index d7339d99f2..0be68d87b8 100644
--- a/docs/manpages/virtvboxd.rst
+++ b/docs/manpages/virtvboxd.rst
@@ -81,7 +81,8 @@ Use this name for the PID file, overriding the default value.
``-t``, ``--timeout *SECONDS*``
Exit after timeout period (in seconds), provided there are neither any client
-connections nor any running domains.
+connections nor any other resources (e.g. running domains, locks, etc.) needing
+attention of the daemon.
``-v``, ``--verbose``
diff --git a/docs/manpages/virtvzd.rst b/docs/manpages/virtvzd.rst
index 42dfa263e4..d2d6fecce6 100644
--- a/docs/manpages/virtvzd.rst
+++ b/docs/manpages/virtvzd.rst
@@ -83,7 +83,8 @@ Use this name for the PID file, overriding the default value.
``-t``, ``--timeout *SECONDS*``
Exit after timeout period (in seconds), provided there are neither any client
-connections nor any running domains.
+connections nor any other resources (e.g. running domains, locks, etc.) needing
+attention of the daemon.
``-v``, ``--verbose``
diff --git a/docs/manpages/virtxend.rst b/docs/manpages/virtxend.rst
index b08346b489..d12196956c 100644
--- a/docs/manpages/virtxend.rst
+++ b/docs/manpages/virtxend.rst
@@ -83,7 +83,8 @@ Use this name for the PID file, overriding the default value.
``-t``, ``--timeout *SECONDS*``
Exit after timeout period (in seconds), provided there are neither any client
-connections nor any running domains.
+connections nor any other resources (e.g. running domains, locks, etc.) needing
+attention of the daemon.
``-v``, ``--verbose``
--
2.34.1
2 years, 11 months
[PATCH 0/2] virsh: Introduce completer for two net-update arguments
by Michal Privoznik
*** BLURB HERE ***
Michal Prívozník (2):
virsh: Introduce net-update --command completer
virsh: Introduce net-update --section completer
tools/virsh-completer-network.c | 43 +++++++++++++++++++++++++++++++++
tools/virsh-completer-network.h | 10 ++++++++
tools/virsh-network.c | 4 +--
tools/virsh-network.h | 3 +++
4 files changed, 58 insertions(+), 2 deletions(-)
--
2.34.1
2 years, 11 months
[PATCH v1 0/5] qemu: Allow prealloc for virtio-mem-pci
by Michal Privoznik
See 5/5 for explanation, but long story short when prealloc is needed we
can't set it on memory-backend-* but on virtio-mem-pci.
Patches 1-3 are cleanup and independent of the feature.
Michal Prívozník (5):
qemuBuildMemoryDeviceProps: Fix const correctness
qemu: Separate out hugepages handling from
qemuBuildMemoryBackendProps()
qemu: Move @prealloc into qemuBuildMemoryGetPagesize()
qemu_capabilities: Introduce QEMU_CAPS_DEVICE_VIRTIO_MEM_PCI_PREALLOC
qemu: Allow prealloc for virtio-mem-pci
src/qemu/qemu_capabilities.c | 8 +
src/qemu/qemu_capabilities.h | 1 +
src/qemu/qemu_command.c | 220 +++++++------
src/qemu/qemu_command.h | 6 +-
src/qemu/qemu_hotplug.c | 2 +-
.../caps_5.1.0.x86_64.replies | 255 +++++++++++++--
.../caps_5.2.0.x86_64.replies | 260 ++++++++++++++--
.../caps_6.0.0.x86_64.replies | 282 +++++++++++++++--
.../caps_6.1.0.x86_64.replies | 282 +++++++++++++++--
.../caps_6.2.0.x86_64.replies | 282 +++++++++++++++--
.../caps_7.0.0.x86_64.replies | 293 ++++++++++++++++--
.../caps_7.0.0.x86_64.xml | 1 +
...mory-hotplug-virtio-mem.x86_64-latest.args | 2 +-
13 files changed, 1646 insertions(+), 248 deletions(-)
--
2.34.1
2 years, 11 months
