January 2022 - Devel - libvirt List Archives

[PATCH v1 0/5] qemu: Allow prealloc for virtio-mem-pci
by Michal Privoznik 19 Jan '22

19 Jan '22

See 5/5 for explanation, but long story short when prealloc is needed we can't set it on memory-backend-* but on virtio-mem-pci. Patches 1-3 are cleanup and independent of the feature. Michal Prívozník (5): qemuBuildMemoryDeviceProps: Fix const correctness qemu: Separate out hugepages handling from qemuBuildMemoryBackendProps() qemu: Move @prealloc into qemuBuildMemoryGetPagesize() qemu_capabilities: Introduce QEMU_CAPS_DEVICE_VIRTIO_MEM_PCI_PREALLOC qemu: Allow prealloc for virtio-mem-pci src/qemu/qemu_capabilities.c | 8 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 220 +++++++------ src/qemu/qemu_command.h | 6 +- src/qemu/qemu_hotplug.c | 2 +- .../caps_5.1.0.x86_64.replies | 255 +++++++++++++-- .../caps_5.2.0.x86_64.replies | 260 ++++++++++++++-- .../caps_6.0.0.x86_64.replies | 282 +++++++++++++++-- .../caps_6.1.0.x86_64.replies | 282 +++++++++++++++-- .../caps_6.2.0.x86_64.replies | 282 +++++++++++++++-- .../caps_7.0.0.x86_64.replies | 293 ++++++++++++++++-- .../caps_7.0.0.x86_64.xml | 1 + ...mory-hotplug-virtio-mem.x86_64-latest.args | 2 +- 13 files changed, 1646 insertions(+), 248 deletions(-) -- 2.34.1

2 7

[libvirt PATCH v3 0/2] Code style documentation
by Tim Wiederhake 19 Jan '22

19 Jan '22

Some additions and clarifications to libvirt's code style documentation, based on points of feedback that are given regularly on the mailing list. V1: https://listman.redhat.com/archives/libvir-list/2022-January/msg00631.html V2: https://listman.redhat.com/archives/libvir-list/2022-January/msg00681.html Changes since V2: * Changed the example type name in patch 1 Tim Wiederhake (2): docs: coding-style: Clarify on virXXXPtr types docs: coding-style: One variable declaration per line docs/coding-style.rst | 28 +++++++++++++++++++++++----- 1 file changed, 23 insertions(+), 5 deletions(-) -- 2.31.1

7 8

[libvirt PATCH 0/7] remove support for unpriv_sgio
by Ján Tomko 19 Jan '22

19 Jan '22

This feature was never merged in upstream kernel and only made it to upstream libvirt by mistakes. Remove it as well as the 'sharedDevices' hash table that was only used for this purpose. The 'sgio' attribute is preserved for compatibility reasons and its 'filtered' value is left intact. An error is added to the XML validator for the 'unfiltered' value, which means 'unpriv_sgio' Ján Tomko (7): util: remove virGetUnprivSGIOSysfsPath conf: reject unfiltered sgio on validation qemu: remove all use of SGIO qemu: remove sharedDevices hash table util: remove virGetDeviceID util: remove {Get,Set}UnprivSGIO qemu: simplify qemuProcessSetupRawIO src/conf/domain_validate.c | 11 + src/libvirt_private.syms | 4 - src/qemu/qemu_conf.c | 448 ------------------ src/qemu/qemu_conf.h | 37 -- src/qemu/qemu_driver.c | 3 - src/qemu/qemu_hostdev.c | 31 -- src/qemu/qemu_hotplug.c | 23 - src/qemu/qemu_process.c | 36 +- src/util/virutil.c | 122 ----- src/util/virutil.h | 12 - tests/qemuhotplugmock.c | 17 - .../disk-scsi-lun-passthrough-sgio.xml | 35 -- tests/qemuxml2argvdata/hostdev-scsi-rawio.xml | 37 -- tests/qemuxml2argvdata/hostdev-scsi-sgio.xml | 37 -- .../disk-scsi-lun-passthrough-sgio.xml | 46 -- .../qemuxml2xmloutdata/hostdev-scsi-rawio.xml | 47 -- .../qemuxml2xmloutdata/hostdev-scsi-sgio.xml | 47 -- tests/qemuxml2xmltest.c | 11 - 18 files changed, 14 insertions(+), 990 deletions(-) delete mode 100644 tests/qemuxml2argvdata/disk-scsi-lun-passthrough-sgio.xml delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-rawio.xml delete mode 100644 tests/qemuxml2argvdata/hostdev-scsi-sgio.xml delete mode 100644 tests/qemuxml2xmloutdata/disk-scsi-lun-passthrough-sgio.xml delete mode 100644 tests/qemuxml2xmloutdata/hostdev-scsi-rawio.xml delete mode 100644 tests/qemuxml2xmloutdata/hostdev-scsi-sgio.xml -- 2.31.1

2 10

[PATCH 0/5] qemu: Clean up and fix corner case in 'max_outputs'/heads handling
by Peter Krempa 18 Jan '22

18 Jan '22

Peter Krempa (5): qemuBuildDeviceVideoCmd: Always assume support for 'max_outputs' property qemu: capabilities: Retire QEMU_CAPS_QXL_MAX_OUTPUTS and QEMU_CAPS_VIRTIO_GPU_MAX_OUTPUTS qemuBuildDeviceVideoCmd: Simplify formatting of 'max_outputs' property qemuValidateDomainDeviceDefVideo: Refactor condition checking for qxl and virtio-vga qemuValidateDomainDeviceDefVideo: Reject non-default video head count for devices not supporting it src/qemu/qemu_capabilities.c | 6 ++--- src/qemu/qemu_capabilities.h | 4 ++-- src/qemu/qemu_command.c | 24 +++++-------------- src/qemu/qemu_validate.c | 21 ++++++++++------ .../caps_2.11.0.s390x.xml | 1 - .../caps_2.11.0.x86_64.xml | 2 -- .../caps_2.12.0.aarch64.xml | 1 - .../caps_2.12.0.ppc64.xml | 1 - .../caps_2.12.0.s390x.xml | 1 - .../caps_2.12.0.x86_64.xml | 2 -- .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 1 - .../caps_3.0.0.riscv32.xml | 1 - .../caps_3.0.0.riscv64.xml | 1 - .../qemucapabilitiesdata/caps_3.0.0.s390x.xml | 1 - .../caps_3.0.0.x86_64.xml | 2 -- .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 1 - .../caps_3.1.0.x86_64.xml | 2 -- .../caps_4.0.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1 - .../caps_4.0.0.riscv32.xml | 1 - .../caps_4.0.0.riscv64.xml | 1 - .../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 1 - .../caps_4.0.0.x86_64.xml | 2 -- .../caps_4.1.0.x86_64.xml | 2 -- .../caps_4.2.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 - .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 - .../caps_4.2.0.x86_64.xml | 2 -- .../caps_5.0.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 - .../caps_5.0.0.riscv64.xml | 1 - .../caps_5.0.0.x86_64.xml | 2 -- .../caps_5.1.0.x86_64.xml | 2 -- .../caps_5.2.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 1 - .../caps_5.2.0.riscv64.xml | 1 - .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 1 - .../caps_5.2.0.x86_64.xml | 2 -- .../caps_6.0.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 1 - .../caps_6.0.0.x86_64.xml | 2 -- .../caps_6.1.0.x86_64.xml | 2 -- .../caps_6.2.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 1 - .../caps_6.2.0.x86_64.xml | 2 -- .../caps_7.0.0.x86_64.xml | 2 -- .../aarch64-video-default.args | 2 +- .../aarch64-video-virtio-gpu-pci.args | 2 +- ...s-spice-agent-file-xfer.x86_64-latest.args | 4 ++-- ...phics-spice-compression.x86_64-latest.args | 4 ++-- ...hics-spice-egl-headless.x86_64-latest.args | 2 +- .../graphics-spice-qxl-vga.x86_64-latest.args | 4 ++-- .../graphics-spice-sasl.x86_64-latest.args | 2 +- .../graphics-spice.x86_64-latest.args | 4 ++-- ...tdev-mdev-display-ramfb.x86_64-latest.args | 2 +- ...play-spice-egl-headless.x86_64-latest.args | 2 +- ...ev-display-spice-opengl.x86_64-latest.args | 2 +- ...isplay-vnc-egl-headless.x86_64-latest.args | 2 +- ...ostdev-mdev-display-vnc.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/pcie-root-port.args | 2 +- .../pcie-switch-downstream-port.args | 2 +- .../pcie-switch-upstream-port.args | 2 +- tests/qemuxml2argvdata/pcihole64-q35.args | 2 +- tests/qemuxml2argvdata/q35-pcie-autoadd.args | 2 +- tests/qemuxml2argvdata/q35-pcie.args | 2 +- tests/qemuxml2argvdata/q35-usb2-multi.args | 2 +- tests/qemuxml2argvdata/q35-usb2-reorder.args | 2 +- tests/qemuxml2argvdata/q35-usb2.args | 2 +- .../q35-virt-manager-basic.args | 2 +- tests/qemuxml2argvdata/q35-virtio-pci.args | 2 +- tests/qemuxml2argvdata/q35.args | 2 +- tests/qemuxml2argvdata/serial-spiceport.args | 2 +- .../serial-spiceport.x86_64-latest.args | 2 +- .../video-device-pciaddr-default.args | 6 ++--- .../video-qxl-device-vgamem.args | 2 +- ...video-qxl-device-vram64.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/video-qxl-device.args | 2 +- tests/qemuxml2argvdata/video-qxl-heads.args | 6 ++--- tests/qemuxml2argvdata/video-qxl-noheads.args | 2 +- .../video-qxl-resolution.args | 2 +- .../video-qxl-sec-device-vgamem.args | 4 ++-- ...o-qxl-sec-device-vram64.x86_64-latest.args | 4 ++-- .../video-qxl-sec-device.args | 4 ++-- .../qemuxml2argvdata/video-vga-qxl-heads.args | 6 ++--- .../video-virtio-gpu-device.args | 2 +- .../video-virtio-gpu-sdl-gl.args | 2 +- .../video-virtio-gpu-secondary.args | 4 ++-- .../video-virtio-gpu-spice-gl.args | 2 +- .../video-virtio-gpu-virgl.args | 2 +- .../x86_64-pc-graphics.x86_64-latest.args | 2 +- .../x86_64-q35-graphics.x86_64-latest.args | 2 +- tests/qemuxml2argvtest.c | 16 ++++--------- tests/qemuxml2xmltest.c | 2 -- 93 files changed, 87 insertions(+), 160 deletions(-) -- 2.34.1

2 6

[libvirt PATCH 0/2] util: misc syslog fixes
by Daniel P. Berrangé 18 Jan '22

18 Jan '22

Daniel P. Berrangé (2): util: fix syslog facility value util: set facility when opening syslog channel src/util/virlog.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) -- 2.33.1

2 3

[libvirt PATCHv2 0/3] remove transitional virtio-input-host support
by Ján Tomko 18 Jan '22

18 Jan '22

*** BLURB HERE *** Ján Tomko (3): qemu: capabilities: do not check for transitional input host qemu: remove support for transitional virtio-input-host qemu: remove support for transitional virtio-input-host src/qemu/qemu_capabilities.c | 2 -- src/qemu/qemu_command.c | 2 -- src/qemu/qemu_validate.c | 26 +++++-------------- .../virtio-non-transitional.x86_64-3.1.0.args | 4 +-- ...virtio-non-transitional.x86_64-latest.args | 4 +-- .../virtio-non-transitional.xml | 3 --- .../virtio-transitional.x86_64-3.1.0.args | 3 +-- .../virtio-transitional.x86_64-latest.args | 3 +-- .../qemuxml2argvdata/virtio-transitional.xml | 3 --- .../virtio-non-transitional.x86_64-latest.xml | 11 +------- .../virtio-transitional.x86_64-latest.xml | 6 +---- 11 files changed, 12 insertions(+), 55 deletions(-) -- 2.31.1

2 4

[libvirt PATCH 0/2] remove transitional virtio-input-host support
by Ján Tomko 18 Jan '22

18 Jan '22

Ján Tomko (2): qemu: capabilities: do not check for transitional input host qemu: remove support for transitional virtio-input-host src/qemu/qemu_capabilities.c | 2 -- src/qemu/qemu_command.c | 2 -- .../qemuxml2argvdata/virtio-non-transitional.x86_64-3.1.0.args | 2 +- .../qemuxml2argvdata/virtio-non-transitional.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/virtio-transitional.x86_64-3.1.0.args | 2 +- tests/qemuxml2argvdata/virtio-transitional.x86_64-latest.args | 2 +- 6 files changed, 4 insertions(+), 8 deletions(-) -- 2.31.1

2 4

[PATCH] remote: systemd: Remove unix sockets from filesystem when disabling a '.socket' unit
by Peter Krempa 18 Jan '22

18 Jan '22

The existence of the unix socket path is used by the remote driver to determine whether modular daemons are in use, so if the socket file stays behind and the user decided to switch from modular to monolithic daemon which was socket activated, the remote driver will insist on picking '/var/run/libvirt/virtqemud-sock', even when it's no longer in use: # systemctl start libvirtd.service # virsh list Id Name State -------------------- # systemctl stop libvirtd.service Warning: Stopping libvirtd.service, but it can still be activated by: libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket # systemctl start virtqemud.socket # virsh list Id Name State -------------------- # systemctl stop virtqemud.socket # systemctl start libvirtd.service # virsh list error: failed to connect to the hypervisor error: Failed to connect socket to '/var/run/libvirt/virtqemud-sock': Connection refused # virsh -c 'qemu:///system?socket=/var/run/libvirt/libvirt-sock' list Id Name State -------------------- Fix this by instructing systemd to delete the socket file when deactivating the unit file for the socket. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/remote/libvirtd.socket.in | 1 + 1 file changed, 1 insertion(+) diff --git a/src/remote/libvirtd.socket.in b/src/remote/libvirtd.socket.in index 85b4aa800a..0f349656f5 100644 --- a/src/remote/libvirtd.socket.in +++ b/src/remote/libvirtd.socket.in @@ -9,6 +9,7 @@ Before=@service@.service ListenStream=@runstatedir@/libvirt/@sockprefix@-sock Service=@service@.service SocketMode=@mode@ +RemoveOnStop=yes [Install] WantedBy=sockets.target -- 2.34.1

5 7

[PATCH v5 00/13] virdnsmasq: Lookup DNSMASQ in PATH
by Michal Privoznik 18 Jan '22

18 Jan '22

v5 of: https://listman.redhat.com/archives/libvir-list/2022-January/msg00715.html diff to v4: - Switched to virCommandSetDryRun() in commit 10/13, because using a separate script was conflicting with ASAN. Tried to debug, failed miserably. - Extended error message from patch 11/13 to include virGetLastErrorMessage() (because if a test fails one simply doesn't access libvirt log in the CI). Michal Prívozník (13): virdnsmasq: Drop @binaryPath argument from dnsmasqCapsNewEmpty() lib: Prefer g_autoptr(dnsmasqCaps) instead of explicit unref virdnsmasq: Drop @force argument of dnsmasqCapsRefreshInternal() virdnsmasq: Drop mtime member from struct _dnsmasqCaps virdnsmasq: Drop noRefresh member from from struct _dnsmasqCaps virdnsmasq: Drop !caps check from dnsmasqCapsRefreshInternal() virdnsmasq: Don't run 'dnsmasq --help' virdnsmasq: Lookup DNSMASQ in PATH virdnsmasq: Require non NULL @caps in dnsmasqCapsGetBinaryPath() networkxml2conftest: Use dnsmasqCapsNewFromBinary() to construct caps networkxml2conftest: Check if capabilities were created successfully virdnsmasq: Drop dnsmasqCapsNewFromBuffer() virdnsmasq: Join dnsmasqCapsNewEmpty() and dnsmasqCapsNewFromBinary() meson.build | 1 - src/libvirt_private.syms | 1 - src/util/virdnsmasq.c | 84 ++++++------------------------------- src/util/virdnsmasq.h | 1 - tests/meson.build | 1 + tests/networkxml2conftest.c | 47 ++++++++++++++++++--- tests/virdnsmasqmock.c | 19 +++++++++ 7 files changed, 75 insertions(+), 79 deletions(-) create mode 100644 tests/virdnsmasqmock.c -- 2.34.1

2 14

[PATCH] virDomainDeviceInfoParseXML: Reject '0' value for ACPI index
by Peter Krempa 18 Jan '22

18 Jan '22

Value of '0' is treated equivalently to when it's not provided by the user. Reject an explicit '0' provided by the user as it would get ignored. In this rare case we can make the XML parser more strict, as libvirt would never format the '<acpi/>' element if the index is '0' thus there are no libvirt-generated XMLs we'd not load back, as of such this is identical to rejecting it in the validation phase. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2037146 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index a805f7f6a3..393f9d9478 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -6786,7 +6786,7 @@ virDomainDeviceInfoParseXML(virDomainXMLOption *xmlopt, } if ((acpi = virXPathNode("./acpi", ctxt))) { - if (virXMLPropUInt(acpi, "index", 10, VIR_XML_PROP_NONE, + if (virXMLPropUInt(acpi, "index", 10, VIR_XML_PROP_NONZERO, &info->acpiIndex) < 0) goto cleanup; } -- 2.34.1

2 1