June 2021 - Devel - libvirt List Archives

[libvirt PATCH] security: fix SELinux label generation logic
by Daniel P. Berrangé 30 Jun '21

30 Jun '21

A process can access a file if the set of MCS categories for the file is equal-to *or* a subset-of, the set of MCS categories for the process. If there are two VMs: a) svirt_t:s0:c117 b) svirt_t:s0:c117,c720 Then VM (b) is able to access files labelled for VM (a). IOW, we must discard case where the categories are equal because that is a subset of many other valid category pairs. Fixes: https://gitlab.com/libvirt/libvirt/-/issues/153 CVE-2021-xxxx - tbd before pushing Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/security/security_selinux.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index b50f4463cc..c98dab0d6f 100644 --- a/src/security/security_selinux.c +++ b/src/security/security_selinux.c @@ -383,7 +383,15 @@ virSecuritySELinuxMCSFind(virSecurityManager *mgr, VIR_DEBUG("Try cat %s:c%d,c%d", sens, c1 + catMin, c2 + catMin); if (c1 == c2) { - mcs = g_strdup_printf("%s:c%d", sens, catMin + c1); + /* + * A process can access a file if the set of MCS categories + * for the file is equal-to *or* a subset-of, the set of + * MCS categories for the process. + * + * IOW, we must discard case where the categories are equal + * because that is a subset of other category pairs. + */ + continue } else { if (c1 > c2) { int t = c1; -- 2.31.1

2 3

[PATCH] ui: Mark the '-no-quit' option as deprecated
by Thomas Huth 30 Jun '21

30 Jun '21

It's just a cumbersome wrapper around the -display ...,window_close=off parameter, so we should rather tell our users to use that instead. Signed-off-by: Thomas Huth <thuth(a)redhat.com> --- docs/system/deprecated.rst | 6 ++++++ qemu-options.hx | 5 +++-- softmmu/vl.c | 2 ++ 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index e2e0090878..c76da98761 100644 --- a/docs/system/deprecated.rst +++ b/docs/system/deprecated.rst @@ -126,6 +126,12 @@ other options have been processed. This will either have no effect (if if they were not given. The property is therefore useless and should not be specified. +``-no-quit`` (since 6.1.0) +'''''''''''''''''''''''''' + +The ``-no-quit`` is a synonym for ``-display ...,window_close=off`` which +should be used instead. + QEMU Machine Protocol (QMP) commands ------------------------------------ diff --git a/qemu-options.hx b/qemu-options.hx index ba3ca9da1d..9fdd823c1b 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1910,10 +1910,11 @@ SRST ERST DEF("no-quit", 0, QEMU_OPTION_no_quit, - "-no-quit disable SDL window close capability\n", QEMU_ARCH_ALL) + "-no-quit disable SDL window close capability (deprecated)\n", QEMU_ARCH_ALL) SRST ``-no-quit`` - Disable SDL window close capability. + Disable SDL window close capability. This option is deprecated, please + use ``-display ...,window_close=off`` instead. ERST DEF("sdl", 0, QEMU_OPTION_sdl, diff --git a/softmmu/vl.c b/softmmu/vl.c index cee6339580..3f79b9c8a3 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -3232,6 +3232,8 @@ void qemu_init(int argc, char **argv, char **envp) case QEMU_OPTION_no_quit: dpy.has_window_close = true; dpy.window_close = false; + warn_report("-no-quit is deprecated, please use " + "-display ...,window_close=off instead."); break; case QEMU_OPTION_sdl: #ifdef CONFIG_SDL -- 2.27.0

3 5

[PATCH] docs: formatdomain: Document disk serial truncation status quo
by Peter Krempa 30 Jun '21

30 Jun '21

Disk serials are truncated arbitrarily and silently by qemu depending on the device type and how they are configured. Since changing the current state would lead to more regressions than we have now, document that the truncation is arbitrary. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- docs/formatdomain.rst | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index aa7bb8da14..3ee537da14 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -3146,6 +3146,16 @@ paravirtualized driver is specified via the ``disk`` element. may look like ``<serial>WD-WMAP9A966149</serial>``. Not supported for scsi-block devices, that is those using disk ``type`` 'block' using ``device`` 'lun' on ``bus`` 'scsi'. :since:`Since 0.7.1` + + Note that depending on hypervisor and device type the serial number may be + truncated silently. IDE/SATA devices are commonly limited to 20 characters. + SCSI devices depending on hypervisor version are limited to 20, 36 or 247 + characters. + + Hypervisors may also start rejecting overly long serials instead of + truncating them in the future so it's advised to avoid the implicit + truncation by testing the desired serial length range with the desired device + and hypervisor combination. ``wwn`` If present, this element specifies the WWN (World Wide Name) of a virtual hard disk or CD-ROM drive. It must be composed of 16 hexadecimal digits. -- 2.31.1

3 5

[libvirt PATCH 0/5] qemu: Fix defaults for TPM on ARM virt guests
by Andrea Bolognani 30 Jun '21

30 Jun '21

The current default is unfortunately broken, and the user has to manually step in and provide the version number explicitly for the TPM device to work at all. https://bugzilla.redhat.com/show_bug.cgi?id=1970310 Andrea Bolognani (5): docs: Fix information for default TPM version tests: Add aarch64-tpm test to qemuxml2xml qemu: Default to TPM 2.0 for ARM virt guests tests: Test the defaults for TPM on ARM virt guests qemu: Reject TPM 1.2 for ARM virt guests docs/formatdomain.rst | 9 ++++-- src/qemu/qemu_domain.c | 3 +- src/qemu/qemu_validate.c | 6 ++++ .../aarch64-tpm-wrong-model.err | 1 + ...64-tpm.xml => aarch64-tpm-wrong-model.xml} | 2 +- tests/qemuxml2argvdata/aarch64-tpm.xml | 4 +-- tests/qemuxml2argvtest.c | 1 + .../aarch64-tpm.aarch64-latest.xml | 29 +++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 9 files changed, 49 insertions(+), 7 deletions(-) create mode 100644 tests/qemuxml2argvdata/aarch64-tpm-wrong-model.err copy tests/qemuxml2argvdata/{aarch64-tpm.xml => aarch64-tpm-wrong-model.xml} (88%) create mode 100644 tests/qemuxml2xmloutdata/aarch64-tpm.aarch64-latest.xml -- 2.31.1

3 10

[PATCH 0/4] Add qemu support setting qos via ovs on ovs interface
by zhangjl02 29 Jun '21

29 Jun '21

Now libvirt use tc rules to manage interface's qos. But when a interface is created by ovs, there is no qos setting result in ovs database. Therefore, qos of ovs port should be set via ovs management command. We add a function to tell whether a port definition is an ovs managed virtual port. Change default qdisc rules, which return 0 directly if the port is ovs managed(When the ovs port is set noqueue, qos config on this port will not work). Add ovs management function of setting and cleaning qos. Then check if the port is an ovs managed port during its life cycle, and call the ovs management function to set or clean qos settings. zhangjl02 (4): qemu: interface: add qemuDomainDefIsOvsport qemu: interface: add virNetDevOpenvswitchInterfaceSetQos and virNetDevOpenvswitchInterfaceClearQos qemu: interface: remove setting noqueue for ovs port qemu: interface: check and use ovs command to set qos of ovs managed port src/libvirt_private.syms | 2 + src/qemu/qemu_command.c | 10 +- src/qemu/qemu_domain.c | 15 ++ src/qemu/qemu_domain.h | 3 + src/qemu/qemu_driver.c | 21 ++- src/qemu/qemu_hotplug.c | 39 +++-- src/qemu/qemu_process.c | 11 +- src/util/virnetdevopenvswitch.c | 269 ++++++++++++++++++++++++++++++++ src/util/virnetdevopenvswitch.h | 11 ++ 9 files changed, 365 insertions(+), 16 deletions(-) -- 2.30.2.windows.1

2 8

[PATCH v2 0/3] Implement virDomainGetMessages for test driver
by Luke Yue 29 Jun '21

29 Jun '21

Implement virDomainGetMessages API for test driver. v2: Introduce testDomainObjCheckTaint to test the API. Luke Yue (3): test_driver: Implement virDomainGetMessages test_driver: Introduce testDomainObjCheckTaint tests: Add messages for virshtest src/test/test_driver.c | 110 +++++++++++++++++++++++++++++++++++++++++ tests/virshtest.c | 2 + 2 files changed, 112 insertions(+) -- 2.32.0

2 10

Entering freeze for libvirt-7.5.0
by Jiri Denemark 29 Jun '21

29 Jun '21

I have just tagged v7.5.0-rc1 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue is more visible. If you have not done so yet, please update NEWS.rst to document any significant change you made since the last release. Thanks, Jirka

1 1

[PATCH 0/2] virSetUIDGIDWithCaps: Two small improvements
by Michal Privoznik 28 Jun '21

28 Jun '21

The first one fixes a problem I've started seeing with RHEL-9 and the other is just removal of check for tautology. Michal Prívozník (2): virSetUIDGIDWithCaps: Don't drop CAP_SETPCAP right away virSetUIDGIDWithCaps: Assume PR_CAPBSET_DROP is always defined src/util/virutil.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) -- 2.31.1

2 4

[PATCH] NEWS: Update for 7.5.0
by Peter Krempa 28 Jun '21

28 Jun '21

Mention fixing of disk iothread validation and the disk serial truncation state. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 2c7180cb95..3da2047d36 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -22,8 +22,19 @@ v7.5.0 (unreleased) * **Improvements** + * docs: Document disk serial truncation status quo + + Disk ``<serial>`` is being truncated by qemu before passed to the guest. + Since it's impossible to fix it without running into further regressions + the documentation was improved to document the intricacies. + * **Bug fixes** + * qemu: Fixed validation of disk ``iothread`` configuration + + The validation of ``iotrhead`` config was previously moved to a place where + it caused bogus errors when address wasn't allocated when hotplugging a + disk. The check is now removed as it wasn't actually necessary at all. v7.4.0 (2021-06-01) =================== -- 2.31.1

2 1

[RFCv3 00/25] RFC: Generate parsexml/formatbuf functions based on directives
by Shi Lei 27 Jun '21

27 Jun '21

V2 here: [https://listman.redhat.com/archives/libvir-list/2020-September/msg00204.html] Differ from V2: * Add tests for xmlgen to illustrate all the different features we can use and make sure its proper functions in the future. * Add docs/xmlgen.rst to explain the usage of all directives and the tool itself. * Now xmlgen can check whether the first item of enum ends with _NONE, _DEFAULT or _ABSENT and generate proper code. So we no longer need to add extra 'default' item for enum. * Now xmlgen can provide extra [tips] when we execute its command-line to show generated code for preview. * Enable/disable hooks by macros rather than by special directives. * Add virStrToBoolYesNo/virStrToBoolTrueFalse/virStrToBoolOnOff and explicitly check both the true and false values. * Stronger check for python3-clang and libclang.so to make sure it can work. * Add python3-clang to the libvirt.spec.in and the mingw-libvirt.spec.in. Thanks! Shi Lei (25): scripts: Add a tool to generate xml parse/format functions maint: Check python3-clang and libclang maint: Call xmlgen automatically when c-head-files change docs: Add xmlgen.rst to explain how to use it build-aux: Only check *.[ch] for sc_prohibit_useless_translation tests: Add tests for xmlgen util: Add some xml-helper-functions to cooperate with xmlgen util: Add helper aliases and functions for 'bool' and 'time_t' to cooperate with xmlgen util: Add parsexml/formatbuf helper functions for virSocketAddr util: Add virUUID type and parse/format functions conf: Extract error-checking code from virNetworkDNSTxtDefParseXML conf: Replace virNetworkDNSTxtDefParseXML(hardcoded) with namesake(generated) conf: Generate virNetworkDNSTxtDefFormatBuf conf: Extract error-checking code from virNetworkDNSSrvDefParseXML conf: Replace virNetworkDNSSrvDefParseXML(hardcoded) with namesake(generated) conf: Generate virNetworkDNSSrvDefFormatBuf conf: Extract error-checking code from virNetworkDNSHostDefParseXML conf: Replace virNetworkDNSHostDefParseXML(hardcoded) with namesake(generated) conf: Generate virNetworkDNSHostDefFormatBuf conf: Extract virNetworkDNSForwarderParseXML from virNetworkDNSParseXML conf: Replace virNetworkDNSForwarderParseXML(hardcoded) with namesake(generated) conf: Generate virNetworkDNSForwarderFormatBuf conf: Extract error-checking code from virNetworkDNSDefParseXML conf: Replace virNetworkDNSDefParseXML(hardcoded) with namesake(generated) conf: Generate virNetworkDNSDefFormatBuf build-aux/syntax-check.mk | 2 +- docs/meson.build | 1 + docs/xmlgen.rst | 684 +++++++++++++ libvirt.spec.in | 1 + meson.build | 10 + mingw-libvirt.spec.in | 1 + po/POTFILES.in | 2 + scripts/meson.build | 8 + scripts/xmlgen/directive.py | 1192 ++++++++++++++++++++++ scripts/xmlgen/go | 29 + scripts/xmlgen/main.py | 534 ++++++++++ scripts/xmlgen/utils.py | 121 +++ src/conf/meson.build | 37 + src/conf/network_conf.c | 463 ++------- src/conf/network_conf.h | 59 +- src/internal.h | 8 + src/libvirt_private.syms | 13 + src/meson.build | 6 + src/util/meson.build | 36 + src/util/virbuffer.c | 44 + src/util/virbuffer.h | 8 +- src/util/virsocketaddr.c | 42 + src/util/virsocketaddr.h | 23 +- src/util/virstring.c | 102 ++ src/util/virstring.h | 15 + src/util/viruuid.c | 31 + src/util/viruuid.h | 18 + src/util/virxml.c | 120 +++ src/util/virxml.h | 6 + tests/meson.build | 3 + tests/xmlgenin/conf/array.h | 17 + tests/xmlgenin/conf/empty.h | 7 + tests/xmlgenin/conf/enum-first-item.h | 12 + tests/xmlgenin/conf/external.h | 9 + tests/xmlgenin/conf/genformat-separate.h | 11 + tests/xmlgenin/conf/genformat.h | 11 + tests/xmlgenin/conf/genparse.h | 11 + tests/xmlgenin/conf/namespace.h | 12 + tests/xmlgenin/conf/required.h | 9 + tests/xmlgenin/conf/skipparse.h | 10 + tests/xmlgenin/conf/specify.h | 13 + tests/xmlgenin/conf/xmlattr.h | 10 + tests/xmlgenin/conf/xmlelem.h | 10 + tests/xmlgenin/conf/xmlgroup.h | 8 + tests/xmlgenin/conf/xmlswitch.h | 17 + tests/xmlgenin/util/enums.h | 58 ++ tests/xmlgenin/util/structs.h | 67 ++ tests/xmlgenout/array.txt | 364 +++++++ tests/xmlgenout/empty.txt | 181 ++++ tests/xmlgenout/enum-first-item.txt | 297 ++++++ tests/xmlgenout/external.txt | 205 ++++ tests/xmlgenout/genformat-separate.txt | 190 ++++ tests/xmlgenout/genformat.txt | 142 +++ tests/xmlgenout/genparse.txt | 154 +++ tests/xmlgenout/namespace.txt | 222 ++++ tests/xmlgenout/required.txt | 236 +++++ tests/xmlgenout/skipparse.txt | 223 ++++ tests/xmlgenout/specify.txt | 291 ++++++ tests/xmlgenout/xmlattr.txt | 252 +++++ tests/xmlgenout/xmlelem.txt | 243 +++++ tests/xmlgenout/xmlgroup.txt | 204 ++++ tests/xmlgenout/xmlswitch.txt | 470 +++++++++ tests/xmlgentest.c | 107 ++ tools/meson.build | 3 + 64 files changed, 7289 insertions(+), 406 deletions(-) create mode 100644 docs/xmlgen.rst create mode 100644 scripts/xmlgen/directive.py create mode 100755 scripts/xmlgen/go create mode 100755 scripts/xmlgen/main.py create mode 100644 scripts/xmlgen/utils.py create mode 100644 tests/xmlgenin/conf/array.h create mode 100644 tests/xmlgenin/conf/empty.h create mode 100644 tests/xmlgenin/conf/enum-first-item.h create mode 100644 tests/xmlgenin/conf/external.h create mode 100644 tests/xmlgenin/conf/genformat-separate.h create mode 100644 tests/xmlgenin/conf/genformat.h create mode 100644 tests/xmlgenin/conf/genparse.h create mode 100644 tests/xmlgenin/conf/namespace.h create mode 100644 tests/xmlgenin/conf/required.h create mode 100644 tests/xmlgenin/conf/skipparse.h create mode 100644 tests/xmlgenin/conf/specify.h create mode 100644 tests/xmlgenin/conf/xmlattr.h create mode 100644 tests/xmlgenin/conf/xmlelem.h create mode 100644 tests/xmlgenin/conf/xmlgroup.h create mode 100644 tests/xmlgenin/conf/xmlswitch.h create mode 100644 tests/xmlgenin/util/enums.h create mode 100644 tests/xmlgenin/util/structs.h create mode 100644 tests/xmlgenout/array.txt create mode 100644 tests/xmlgenout/empty.txt create mode 100644 tests/xmlgenout/enum-first-item.txt create mode 100644 tests/xmlgenout/external.txt create mode 100644 tests/xmlgenout/genformat-separate.txt create mode 100644 tests/xmlgenout/genformat.txt create mode 100644 tests/xmlgenout/genparse.txt create mode 100644 tests/xmlgenout/namespace.txt create mode 100644 tests/xmlgenout/required.txt create mode 100644 tests/xmlgenout/skipparse.txt create mode 100644 tests/xmlgenout/specify.txt create mode 100644 tests/xmlgenout/xmlattr.txt create mode 100644 tests/xmlgenout/xmlelem.txt create mode 100644 tests/xmlgenout/xmlgroup.txt create mode 100644 tests/xmlgenout/xmlswitch.txt create mode 100644 tests/xmlgentest.c -- 2.25.1

1 26