[PATCH 0/7] Polkit tty agent fixes
by Martin Kletzander
Apart from fixing bz 1945501 [0] there are some small changes/fixes to some of
the polkit code.
[0] https://bugzilla.redhat.com/show_bug.cgi?id=1945501
Martin Kletzander (7):
virsh: Remove needless variable
util: Tiny reword fix in comment
util: Add virPolkitAgentAvailable
virsh: Do not try connecting first time without polkit agent
util: Report errors in all code paths in virPolkitAgentCreate
util: Check for pkttyagent availability properly
util: Make client-side polkit work even with polkit disabled
src/libvirt_private.syms | 1 +
src/util/virpolkit.c | 202 ++++++++++++++++++++++-----------------
src/util/virpolkit.h | 1 +
tools/virsh.c | 14 ++-
4 files changed, 127 insertions(+), 91 deletions(-)
--
2.34.0
3 years
[libvirt PATCH 00/10] Enable hyperv-passthrough
by Tim Wiederhake
This series enables "hv-passthrough" in libvirt.
See https://bugzilla.redhat.com/show_bug.cgi?id=1851249.
Example usage in VM definition:
<features>
<hyperv mode='passthrough'/>
</features>
Tim Wiederhake (10):
schema: Wrap hyperv element in choice and group
schema: Add optional "mode" attribute to hyperv
conf: domain: Define enum for HyperV mode
virDomainFeaturesHyperVDefParse: Read attribute "mode" of element
"hyperv"
virDomainDefFormatFeatures: Write attribute "mode" of element "hyperv"
docs: domain: Add documentation for "hyperv"'s new "mode" attribute
conf: domain: Add hyperv passthrough mode
schema: hyperv: Add mode "passthrough"
tests: Add tests for hyperv-passthrough
docs: domain: Add documentation for hyperv passthrough mode
docs/formatdomain.rst | 13 +-
docs/schemas/domaincommon.rng | 172 ++++++++++--------
src/conf/domain_conf.c | 23 ++-
src/conf/domain_conf.h | 8 +
src/qemu/qemu_command.c | 18 +-
src/qemu/qemu_validate.c | 2 +-
.../hyperv-passthrough.x86_64-6.1.0.args | 32 ++++
.../hyperv-passthrough.x86_64-latest.args | 32 ++++
tests/qemuxml2argvdata/hyperv-passthrough.xml | 27 +++
tests/qemuxml2argvtest.c | 2 +
tests/qemuxml2xmloutdata/hyperv-off.xml | 2 +-
.../qemuxml2xmloutdata/hyperv-passthrough.xml | 31 ++++
.../hyperv-stimer-direct.xml | 2 +-
tests/qemuxml2xmloutdata/hyperv.xml | 2 +-
tests/qemuxml2xmltest.c | 1 +
15 files changed, 277 insertions(+), 90 deletions(-)
create mode 100644 tests/qemuxml2argvdata/hyperv-passthrough.x86_64-6.1.0.args
create mode 100644 tests/qemuxml2argvdata/hyperv-passthrough.x86_64-latest.args
create mode 100644 tests/qemuxml2argvdata/hyperv-passthrough.xml
create mode 100644 tests/qemuxml2xmloutdata/hyperv-passthrough.xml
--
2.31.1
3 years
[PATCH v7 0/2] Dirty Ring support (Libvirt)
by huangy81＠chinatelecom.cn
From: "Hyman Huang(黄勇)" <huangy81(a)chinatelecom.cn>
v7
- rebase on master
- modify the following points according to the advice given by Peter
1. skip the -accel switch and reuse the existing commit d20ebdda2
'qemu: Switch to -accel'
2. remove the post-parse function and do the parse work in
virDomainFeaturesKVMDefParse once for all
3. throw an error if "size" not specified when kvm-dirty-ring
feature enabled in xml
4. fix the memory leak when parsing xml
5. use macro VIR_ROUND_UP_POWER_OF_TWO to check power-of-two
6. put error messages in one line
7. squash the last 2 commit into 1
8. add test for kvm-dirty-ring feature
Thanks for the careful reviews made by Peter.
Please review, Thanks!
Hyman
Ping for this series.
I still keep thinking the dirty ring feature is something good to
have for libvirt.
qemu-6.1 has supported dirty ring feature and followed up with the
commit 0e21bf24 "support dirtyrate at the granualrity of vcpu",
which is a typical usage scenario of dirty ring. another usage
scenario may be the implementation of per-vcpu auto-converge during
live migration which is already being reviewed. so we can make full
use of dirty ring feature if libvirt supports. and any corrections
and comments about this series would be very appreciated.
Please review, Thanks!
Hyman
v6
- rebase on master
v5,v4: blank, just make v6 be the the latest version.
v3
- rebase master and fix the confilict when apply
"conf: introduce dirty_ring_size in struct "_virDomainDef" to current
master.
v2
- split patchset into 4 patches
- leave out the tcg case when building commandline.
- handle the VIR_DOMAIN_KVM_DIRTY_RING case independently in ,
virDomainFeatureDefParse and virDomainDefFeaturesCheckABIStability,
do not integrate it with other cases...
- add dirty ring size check in virDomainDefFeaturesCheckABIStability
- modify zero checks on integers of dirty ring size in a explicit way.
- set the default value of dirty ring size in a post-parser callback.
- check the absence of kvm_feature in a explicit way.
- code clean of virTristateSwitchTypeToString function.
this version's modification base on Peter's advices mostly, thanks
a lot, please review !
v1
since qemu has introduced a dirty ring feature in 6.1.0, may be it's
the right time to introduce dirty ring in libvirt meanwhile.
this patch add feature named 'dirty-ring', which enable dirty ring
feature when starting vm. to try this out, three things has done
in this patchset:
- introduce QEMU_CAPS_ACCEL so the the libvirt can use it to select
the right option when specifying the accelerator type.
- switch the option "-machine accel=xxx" to "-accel xxx" when specifying
accelerator type once libvirt build QEMU command line, so that
dirty-ring-size property can be passed to qemu when start vm.
- introduce dirty_ring_size to hold the ring size configured by user
and pass dirty_ring_size when building qemu commandline if dirty
ring feature enabled.
though dirty ring is per-cpu logically, the size of dirty ring is
registered by 'struct kvm' in QEMU. so we would like to place the
dirty_ring_size as a property of vm in Libvirt as the QEMU do.
the dirty ring feature is disabled by default, and if enabled, the
default value of ring size if 4096 if size not configured.
for more details about dirty ring and "-accel" option, please refer to:
https://lore.kernel.org/qemu-devel/20210108165050.406906-10-peterx@redhat...
https://lore.kernel.org/qemu-devel/3aa73987-40e8-3619-0723-9f17f73850bd@r...
please review, Thanks!
Best Regards !
Hyman Huang(黄勇) (2):
qemu: support dirty ring feature
tests: add test for kvm-dirty-ring feature
docs/formatdomain.rst | 18 ++++---
docs/schemas/domaincommon.rng | 10 ++++
src/conf/domain_conf.c | 54 +++++++++++++++++++
src/conf/domain_conf.h | 4 ++
src/qemu/qemu_command.c | 12 +++++
tests/qemuxml2argvdata/kvm-features-off.xml | 1 +
tests/qemuxml2argvdata/kvm-features.args | 2 +-
tests/qemuxml2argvdata/kvm-features.xml | 1 +
tests/qemuxml2xmloutdata/kvm-features-off.xml | 1 +
tests/qemuxml2xmloutdata/kvm-features.xml | 1 +
10 files changed, 95 insertions(+), 9 deletions(-)
--
2.27.0
3 years
[PATCH v1 00/12] Add riscv kvm accel support
by Yifei Jiang
This series adds both riscv32 and riscv64 kvm support, and implements
migration based on riscv.
Because of RISC-V KVM has been merged into the Linux master, so this
series are changed from RFC to patch v1.
Several steps to use this:
1. Build emulation
$ ./configure --target-list=riscv64-softmmu
$ make -j$(nproc)
2. Build kernel
3. Build QEMU VM
Cross built in riscv toolchain.
$ PKG_CONFIG_LIBDIR=<toolchain pkgconfig path>
$ export PKG_CONFIG_SYSROOT_DIR=<toolchain sysroot path>
$ ./configure --target-list=riscv64-softmmu --enable-kvm \
--cross-prefix=riscv64-linux-gnu- --disable-libiscsi --disable-glusterfs \
--disable-libusb --disable-usb-redir --audio-drv-list= --disable-opengl \
--disable-libxml2
$ make -j$(nproc)
4. Start emulation
$ ./qemu-system-riscv64 -M virt -m 4096M -cpu rv64,x-h=true -nographic \
-name guest=riscv-hyp,debug-threads=on \
-smp 4 \
-bios ./fw_jump.bin \
-kernel ./Image \
-drive file=./hyp.img,format=raw,id=hd0 \
-device virtio-blk-device,drive=hd0 \
-append "root=/dev/vda rw console=ttyS0 earlycon=sbi"
5. Start kvm-acceled QEMU VM in emulation
$ ./qemu-system-riscv64 -M virt,accel=kvm -m 1024M -cpu host -nographic \
-name guest=riscv-guset \
-smp 2 \
-bios none \
-kernel ./Image \
-drive file=./guest.img,format=raw,id=hd0 \
-device virtio-blk-device,drive=hd0 \
-append "root=/dev/vda rw console=ttyS0 earlycon=sbi"
Changes since RFC v6
- Rebase on recent commit 8627edfb3f1fca24a96a0954148885c3241c10f8
- Sync-up headers with Linux-5.16-rc1
Changes since RFC v5
- Rebase on QEMU v6.1.0-rc1 and kvm-riscv linux v19.
- Move kvm interrupt setting to riscv_cpu_update_mip().
- Replace __u64 with uint64_t.
Changes since RFC v4
- Rebase on QEMU v6.0.0-rc2 and kvm-riscv linux v17.
- Remove time scaling support as software solution is incomplete.
Because it will cause unacceptable performance degradation. and
We will post a better solution.
- Revise according to Alistair's review comments.
- Remove compile time XLEN checks in kvm_riscv_reg_id
- Surround TYPE_RISCV_CPU_HOST definition by CONFIG_KVM and share
it between RV32 and RV64.
- Add kvm-stub.c for reduce unnecessary compilation checks.
- Add riscv_setup_direct_kernel() to direct boot kernel for KVM.
Changes since RFC v3
- Rebase on QEMU v5.2.0-rc2 and kvm-riscv linux v15.
- Add time scaling support(New patches 13, 14 and 15).
- Fix the bug that guest vm can't reboot.
Changes since RFC v2
- Fix checkpatch error at target/riscv/sbi_ecall_interface.h.
- Add riscv migration support.
Changes since RFC v1
- Add separate SBI ecall interface header.
- Add riscv32 kvm accel support.
Yifei Jiang (12):
update-linux-headers: Add asm-riscv/kvm.h
target/riscv: Add target/riscv/kvm.c to place the public kvm interface
target/riscv: Implement function kvm_arch_init_vcpu
target/riscv: Implement kvm_arch_get_registers
target/riscv: Implement kvm_arch_put_registers
target/riscv: Support start kernel directly by KVM
target/riscv: Support setting external interrupt by KVM
target/riscv: Handle KVM_EXIT_RISCV_SBI exit
target/riscv: Add host cpu type
target/riscv: Add kvm_riscv_get/put_regs_timer
target/riscv: Implement virtual time adjusting with vm state changing
target/riscv: Support virtual time context synchronization
hw/riscv/boot.c | 11 +
hw/riscv/virt.c | 7 +
include/hw/riscv/boot.h | 1 +
linux-headers/asm-riscv/kvm.h | 128 ++++++
linux-headers/linux/kvm.h | 8 +
meson.build | 2 +
target/riscv/cpu.c | 57 +++
target/riscv/cpu.h | 10 +
target/riscv/cpu_helper.c | 27 --
target/riscv/kvm-stub.c | 30 ++
target/riscv/kvm.c | 610 +++++++++++++++++++++++++++++
target/riscv/kvm_riscv.h | 25 ++
target/riscv/machine.c | 14 +
target/riscv/meson.build | 1 +
target/riscv/sbi_ecall_interface.h | 72 ++++
15 files changed, 976 insertions(+), 27 deletions(-)
create mode 100644 linux-headers/asm-riscv/kvm.h
create mode 100644 target/riscv/kvm-stub.c
create mode 100644 target/riscv/kvm.c
create mode 100644 target/riscv/kvm_riscv.h
create mode 100644 target/riscv/sbi_ecall_interface.h
--
2.19.1
3 years
[PATCH 0/3] Add virDomainSetLaunchSecurityState API
by Jim Fehlig
V1 series based on initial RFC found here
https://listman.redhat.com/archives/libvir-list/2021-November/msg00460.html
This series is compile tested only. Functional testing will require
reserving the test machine, configuring it, and writing some form of
functional test :-). Is anyone aware of functional tests for the
existing SEV-related APIs?
Also, it has been a while since I added a new API, so not sure about
the current state of the language bindings. Are there any non-automated
tasks to expose the API in the various bindings?
Jim Fehlig (3):
libvirt: Introduce virDomainSetLaunchSecurityState public API
remote: Add RPC support for the virDomainSetLaunchSecurityState API
qemu: Implement the virDomainSetLaunchSecurityState API
include/libvirt/libvirt-domain.h | 35 ++++++++++++++
src/driver-hypervisor.h | 7 +++
src/libvirt-domain.c | 52 +++++++++++++++++++++
src/libvirt_public.syms | 5 ++
src/qemu/qemu_driver.c | 78 ++++++++++++++++++++++++++++++++
src/qemu/qemu_monitor.c | 12 +++++
src/qemu/qemu_monitor.h | 6 +++
src/qemu/qemu_monitor_json.c | 34 ++++++++++++++
src/qemu/qemu_monitor_json.h | 5 ++
src/remote/remote_driver.c | 1 +
src/remote/remote_protocol.x | 17 ++++++-
src/remote_protocol-structs | 9 ++++
12 files changed, 260 insertions(+), 1 deletion(-)
--
2.33.0
3 years
[libvirt PATCH 0/9] WIP/RFC: add QEMU "-display dbus" support
by marcandre.lureau＠redhat.com
From: Marc-André Lureau <marcandre.lureau(a)redhat.com>
Hi,
This series implements supports for the upcoming QEMU "-display dbus" support.
Development is still in progress, but I hope to land the QEMU support early in
6.3 (last version posted:
https://patchew.org/QEMU/20211009210838.2219430-1-marcandre.lureau@redhat...).
By default, libvirt will start a private VM bus (sharing and reusing the
existing "vmstate" code). A client will need the address of the bus and access
to it. Since D-Bus addresses are not URIs unfortunately, I am not sure yet what
should "virsh domdisplay" return.
The feature set should cover the needs to replace Spice as local client of choice,
including 3daccel/dmabuf, audio, clipboard sharing, usb redirection, and arbitrary
chardev/channels (for serial etc).
The test Gtk4 client is also in progress, currently in development at
https://gitlab.com/marcandre.lureau/qemu-display/. A few dependencies, such as
zbus, require an upcoming release. virt-viewer & boxes will need a port to Gtk4
to make use of the shared widget.
Comments welcome, as we can still adjust the QEMU side etc.
thanks
Marc-André Lureau (9):
qemu: start the D-Bus daemon as needed
qemu: add chardev-vdagent capability check
qemu: add -display dbus capability check (to update to 6.3)
qemu: add -display dbus support
qemu: add audio type 'dbus'
qemu: add dbus clipboard sharing
qemu: add -chardev dbus
qemu: add usbredir type 'dbus'
docs: document <graphics> type dbus
docs/formatdomain.rst | 24 ++++
docs/schemas/basictypes.rng | 7 ++
docs/schemas/domaincommon.rng | 71 +++++++++++
src/bhyve/bhyve_command.c | 1 +
src/conf/domain_conf.c | 116 +++++++++++++++++-
src/conf/domain_conf.h | 14 +++
src/conf/domain_validate.c | 32 +++--
src/libxl/libxl_conf.c | 1 +
src/qemu/qemu_capabilities.c | 6 +
src/qemu/qemu_capabilities.h | 2 +
src/qemu/qemu_command.c | 94 +++++++++++++-
src/qemu/qemu_domain.c | 1 +
src/qemu/qemu_domain.h | 1 +
src/qemu/qemu_driver.c | 10 +-
src/qemu/qemu_hotplug.c | 1 +
src/qemu/qemu_monitor_json.c | 1 +
src/qemu/qemu_process.c | 15 ++-
src/qemu/qemu_validate.c | 33 +++++
src/security/security_dac.c | 2 +
src/vmx/vmx.c | 1 +
.../domaincapsdata/qemu_6.2.0-q35.x86_64.xml | 1 +
.../domaincapsdata/qemu_6.2.0-tcg.x86_64.xml | 1 +
tests/domaincapsdata/qemu_6.2.0.x86_64.xml | 1 +
.../caps_6.1.0.x86_64.xml | 1 +
.../caps_6.2.0.aarch64.xml | 1 +
.../caps_6.2.0.x86_64.replies | 10 +-
.../caps_6.2.0.x86_64.xml | 2 +
.../graphics-dbus-address.args | 31 +++++
.../graphics-dbus-address.xml | 34 +++++
.../qemuxml2argvdata/graphics-dbus-audio.args | 32 +++++
.../qemuxml2argvdata/graphics-dbus-audio.xml | 40 ++++++
.../graphics-dbus-chardev.args | 33 +++++
.../graphics-dbus-chardev.xml | 38 ++++++
.../graphics-dbus-clipboard.args | 32 +++++
.../graphics-dbus-clipboard.xml | 36 ++++++
tests/qemuxml2argvdata/graphics-dbus-p2p.args | 31 +++++
tests/qemuxml2argvdata/graphics-dbus-p2p.xml | 36 ++++++
.../graphics-dbus-usbredir.args | 35 ++++++
.../graphics-dbus-usbredir.xml | 36 ++++++
tests/qemuxml2argvdata/graphics-dbus.args | 31 +++++
tests/qemuxml2argvdata/graphics-dbus.xml | 34 +++++
tests/qemuxml2argvtest.c | 21 ++++
.../graphics-dbus-address.xml | 39 ++++++
.../graphics-dbus-audio.xml | 43 +++++++
.../qemuxml2xmloutdata/graphics-dbus-p2p.xml | 39 ++++++
tests/qemuxml2xmloutdata/graphics-dbus.xml | 39 ++++++
tests/qemuxml2xmltest.c | 14 +++
47 files changed, 1106 insertions(+), 18 deletions(-)
create mode 100644 tests/qemuxml2argvdata/graphics-dbus-address.args
create mode 100644 tests/qemuxml2argvdata/graphics-dbus-address.xml
create mode 100644 tests/qemuxml2argvdata/graphics-dbus-audio.args
create mode 100644 tests/qemuxml2argvdata/graphics-dbus-audio.xml
create mode 100644 tests/qemuxml2argvdata/graphics-dbus-chardev.args
create mode 100644 tests/qemuxml2argvdata/graphics-dbus-chardev.xml
create mode 100644 tests/qemuxml2argvdata/graphics-dbus-clipboard.args
create mode 100644 tests/qemuxml2argvdata/graphics-dbus-clipboard.xml
create mode 100644 tests/qemuxml2argvdata/graphics-dbus-p2p.args
create mode 100644 tests/qemuxml2argvdata/graphics-dbus-p2p.xml
create mode 100644 tests/qemuxml2argvdata/graphics-dbus-usbredir.args
create mode 100644 tests/qemuxml2argvdata/graphics-dbus-usbredir.xml
create mode 100644 tests/qemuxml2argvdata/graphics-dbus.args
create mode 100644 tests/qemuxml2argvdata/graphics-dbus.xml
create mode 100644 tests/qemuxml2xmloutdata/graphics-dbus-address.xml
create mode 100644 tests/qemuxml2xmloutdata/graphics-dbus-audio.xml
create mode 100644 tests/qemuxml2xmloutdata/graphics-dbus-p2p.xml
create mode 100644 tests/qemuxml2xmloutdata/graphics-dbus.xml
--
2.33.0.721.g106298f7f9
3 years
[PATCH 1/1] NEWS: document DEVICE_UNPLUG_GUEST_ERROR support
by Daniel Henrique Barboza
Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com>
---
NEWS.rst | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index a71b84c363..9e990ff93a 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -30,6 +30,11 @@ v7.10.0 (unreleased)
Libvirt is now able to report interface information from the guest's
perspective (using guest agent).
+ * qemu: detect guest side errors during device removal
+
+ Libvirt is now able to detect guest side errors during device removal by
+ using the DEVICE_UNPLUG_GUEST_ERROR event, available in QEMU 6.2.0.
+
* **Bug fixes**
--
2.31.1
3 years
[PATCH] NEWS: Mention two minor regression fixes and addition to bulk stats
by Peter Krempa
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
NEWS.rst | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index b63a0aa721..006724eafa 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -37,8 +37,24 @@ v7.10.0 (unreleased)
The current hardcoded minimum is 56 (single-DES) and will be raised to 112
in the future. Setting a minimum lower than 112 is not supported.
+ * qemu: Report stats also for block copy destination and backup job scratch
+ images
+
+ The statistics are available via the bulk domain stats API.
+
* **Bug fixes**
+ * qemu: Don't format 'ramfb' attribute when disabled
+
+ Fix a regression caused by the conversion to JSON -device arguments where
+ 'ramfb' would be put on the commandline of 'vfio-pci' which doesn't have it,
+ thus breaking VMs with a mediated host device.
+
+ * qemu: Fix block copy and backup to encrypted storage
+
+ An oversight in last release lead to a spurious error being reported when
+ encrypted storage was requested for disk images which are not directly
+ backing the disk, which is now fixed.
v7.9.0 (2021-11-01)
===================
--
2.31.1
3 years
[PATCH 00/23] virHashFree refactoring and removal
by Peter Krempa
Peter Krempa (23):
virDomainNetDefParseXML: Automatically free GHashTable
virDomainDeviceValidateAliasImpl: Automatically free GHashTable and
remove cleanup
libxlLoggerNew: Avoid virHashFree by rearranging code
virNWFilterDoInstantiate: Automatically free temporary GHashTable
virNWFilterBuildAll: Automatically free temporary GHashTable
qemuDomainUpdateMemoryDeviceInfo: Automatically free temporary
GHashTable
qemuDomainBlocksStatsGather: Automatically free GHashTable and
refactor cleanup
qemuDomainGetDiskErrors: Automatically free GHashTable
qemuMigrationSrcFetchMirrorStats: Automatically free GHashTable
qemuRefreshVirtioChannelState: Automatically free GHashTable and
refactor cleanup
qemuRefreshPRManagerState: Automatically free GHashTable and refactor
cleanup
qemuProcessWaitForMonitor: Automatically free GHashTable
qemuProcessRefreshDisks: Automatically free GHashTable and refactor
cleanup
qemuProcessRefreshLegacyBlockjobs: Automatically free GHashTable and
refactor cleanup
qemuCheckpointGetXMLDescUpdateSize: Don't combine automatic freeing
with manual
nwfilterxml2firewalltest: virNWFilterIncludeDefToRuleInst:
Automatically free GHashTable
nwfilterxml2firewalltest: testCompareXMLToArgvFiles: Automatically
free GHashTable
qemumonitorjsontest: testBlockNodeNameDetect: Automatically free
GHashTable
qemumonitorjsontest: mymain: Automatically free GHashTable
qemuxml2arvtest: Use 'g_hash_table_unref' for clearing the qapi schema
cache
Switch away from virHashFree
util: virhash: Remove 'virHashFree'
util: virhash: Replace 'virHashDataFree' by 'GDestroyNotify'
src/conf/domain_addr.c | 2 +-
src/conf/domain_conf.c | 6 +--
src/conf/domain_validate.c | 13 ++---
src/conf/nwfilter_conf.c | 2 +-
src/conf/nwfilter_ipaddrmap.c | 3 +-
src/conf/virchrdev.c | 2 +-
src/conf/virdomainmomentobjlist.c | 2 +-
src/conf/virdomainobjlist.c | 4 +-
src/conf/virinterfaceobj.c | 2 +-
src/conf/virnetworkobj.c | 4 +-
src/conf/virnodedeviceobj.c | 2 +-
src/conf/virnwfilterbindingdef.c | 2 +-
src/conf/virnwfilterbindingobjlist.c | 2 +-
src/conf/virsecretobj.c | 2 +-
src/conf/virstorageobj.c | 10 ++--
src/hyperv/hyperv_wmi.c | 2 +-
src/hypervisor/virclosecallbacks.c | 2 +-
src/libvirt_private.syms | 1 -
src/libxl/libxl_logger.c | 9 ++--
src/locking/lock_daemon.c | 2 +-
src/nwfilter/nwfilter_dhcpsnoop.c | 6 +--
src/nwfilter/nwfilter_gentech_driver.c | 11 ++--
src/nwfilter/nwfilter_learnipaddr.c | 7 +--
src/qemu/qemu_checkpoint.c | 16 +++---
src/qemu/qemu_domain.c | 9 ++--
src/qemu/qemu_driver.c | 26 ++++------
src/qemu/qemu_migration.c | 3 +-
src/qemu/qemu_monitor_json.c | 2 +-
src/qemu/qemu_process.c | 69 ++++++++------------------
src/rpc/virnetdaemon.c | 2 +-
src/security/security_selinux.c | 6 +--
src/util/virfilecache.c | 2 +-
src/util/virhash.c | 25 ++--------
src/util/virhash.h | 13 +----
src/util/virlockspace.c | 2 +-
src/util/virmacmap.c | 2 +-
src/util/virobject.c | 4 +-
src/util/virsystemd.c | 2 +-
tests/nwfilterxml2firewalltest.c | 8 ++-
tests/qemumonitorjsontest.c | 32 ++++++------
tests/qemusecuritymock.c | 7 ++-
tests/qemuxml2argvtest.c | 2 +-
42 files changed, 123 insertions(+), 207 deletions(-)
--
2.31.1
3 years
[PATCH] qemu_domainjob: remove dead code
by Kristina Hanicova
Function qemuDomainJobAllowed() is never used -> remove it.
Signed-off-by: Kristina Hanicova <khanicov(a)redhat.com>
---
src/qemu/qemu_domainjob.c | 6 ------
src/qemu/qemu_domainjob.h | 2 --
2 files changed, 8 deletions(-)
diff --git a/src/qemu/qemu_domainjob.c b/src/qemu/qemu_domainjob.c
index cff8d7bb83..439a9d10c2 100644
--- a/src/qemu/qemu_domainjob.c
+++ b/src/qemu/qemu_domainjob.c
@@ -771,12 +771,6 @@ qemuDomainNestedJobAllowed(qemuDomainJobObj *jobs, qemuDomainJob newJob)
(jobs->mask & JOB_MASK(newJob)) != 0;
}
-bool
-qemuDomainJobAllowed(qemuDomainJobObj *jobs, qemuDomainJob newJob)
-{
- return !jobs->active && qemuDomainNestedJobAllowed(jobs, newJob);
-}
-
static bool
qemuDomainObjCanSetJob(qemuDomainJobObj *job,
qemuDomainJob newJob,
diff --git a/src/qemu/qemu_domainjob.h b/src/qemu/qemu_domainjob.h
index 46cbb8a067..eaa5cda3eb 100644
--- a/src/qemu/qemu_domainjob.h
+++ b/src/qemu/qemu_domainjob.h
@@ -277,8 +277,6 @@ int
qemuDomainObjInitJob(qemuDomainJobObj *job,
qemuDomainObjPrivateJobCallbacks *cb);
-bool qemuDomainJobAllowed(qemuDomainJobObj *jobs, qemuDomainJob newJob);
-
int
qemuDomainObjPrivateXMLFormatJob(virBuffer *buf,
virDomainObj *vm);
--
2.31.1
3 years
