[PATCH 1/1] migration.html.in: fix 'Offline migration' description
by Daniel Henrique Barboza
'transfers inactive the definition of a domain' seems odd.
Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com>
---
docs/migration.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/migration.html.in b/docs/migration.html.in
index 355f0e89af..e95ee9de6f 100644
--- a/docs/migration.html.in
+++ b/docs/migration.html.in
@@ -141,7 +141,7 @@
<h2><a id="offline">Offline migration</a></h2>
<p>
- Offline migration transfers inactive the definition of a domain
+ Offline migration transfers the inactive definition of a domain
(which may or may not be active). After successful completion, the
domain remains in its current state on the source host and is defined
but inactive on the destination host. It's a bit more clever than
--
2.26.2
3 years, 10 months
[PATCH 1/1] domain_conf.c: skip checking ZPCI address is incomplete if not present
by Daniel Henrique Barboza
Commit 076591009ad1 ("conf: fix zPCI address auto-generation on
s390") is doing a check for virZPCIDeviceAddressIsIncomplete()
prior to checking if the device has a ZPCI address at all. This
results in errors like these when starting Libvirt:
error : virDomainDeviceInfoFormat:7527 : internal error:
Missing uid or fid attribute of zPCI address
Fix it by moving virZPCIDeviceAddressIsIncomplete() after the
check done by virZPCIDeviceAddressIsPresent().
Fixes: 076591009ad11ec108521b52a4945d0f895fa160
CC: Bjoern Walk <bwalk(a)linux.ibm.com>
CC: Boris Fiuczynski <fiuczy(a)linux.ibm.com>
CC: Shalini Chellathurai Saroja <shalini(a)linux.ibm.com>
CC: Andrea Bolognani <abologna(a)redhat.com>
Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com>
---
src/conf/domain_conf.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 31ba78b950..33f177b16f 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -7522,11 +7522,11 @@ virDomainDeviceInfoFormat(virBufferPtr buf,
virTristateSwitchTypeToString(info->addr.pci.multi));
}
- if (virZPCIDeviceAddressIsIncomplete(&info->addr.pci.zpci)) {
- virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
- _("Missing uid or fid attribute of zPCI address"));
- }
if (virZPCIDeviceAddressIsPresent(&info->addr.pci.zpci)) {
+ if (virZPCIDeviceAddressIsIncomplete(&info->addr.pci.zpci))
+ virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
+ _("Missing uid or fid attribute of zPCI address"));
+
virBufferAsprintf(&childBuf,
"<zpci uid='0x%.4x' fid='0x%.8x'/>\n",
info->addr.pci.zpci.uid.value,
--
2.26.2
3 years, 10 months
[libvirt PATCH v2 0/1] cirrus: Add templates and refresh script
by Andrea Bolognani
This makes the Cirrus CI configurations as maintainable as the
Dockerfiles, by shifting the responsability of keeping the list
of dependencies and other details up to date to lcitool.
Test pipeline:
https://gitlab.com/abologna/libvirt/-/pipelines/161289292
For the refresh script to work, your copy of lcitool needs to
include these patches:
https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/30
Changes from [v1]:
* reduce duplication by only storing variables in the git
repository and instantiating the template at runtime.
[v1] https://www.redhat.com/archives/libvir-list/2020-June/msg01305.html
Andrea Bolognani (1):
cirrus: Generate jobs dynamically
.gitlab-ci.yml | 36 ++++++++++++++-
ci/cirrus/build.yml | 26 +++++++++++
ci/cirrus/freebsd-12.yml.j2 | 73 -------------------------------
ci/cirrus/libvirt-freebsd-12.vars | 7 +++
ci/cirrus/libvirt-macos-1015.vars | 7 +++
ci/cirrus/macos-1015.yml.j2 | 38 ----------------
ci/cirrus/refresh | 22 ++++++++++
7 files changed, 97 insertions(+), 112 deletions(-)
create mode 100644 ci/cirrus/build.yml
delete mode 100644 ci/cirrus/freebsd-12.yml.j2
create mode 100644 ci/cirrus/libvirt-freebsd-12.vars
create mode 100644 ci/cirrus/libvirt-macos-1015.vars
delete mode 100644 ci/cirrus/macos-1015.yml.j2
create mode 100755 ci/cirrus/refresh
--
2.25.4
3 years, 10 months
[libvirt PATCH] tools: fix misleading comments about command names
by Daniel P. Berrangé
The srv-XXX commands were renamed to server-XXX, with the old
name being a undocumented back compat alias only.
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
tools/virt-admin.c | 42 +++++++++++++++++++++---------------------
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/tools/virt-admin.c b/tools/virt-admin.c
index 6ff9729f66..fef0332a0d 100644
--- a/tools/virt-admin.c
+++ b/tools/virt-admin.c
@@ -315,9 +315,9 @@ cmdConnect(vshControl *ctl, const vshCmd *cmd)
}
-/* ---------------
- * Command srv-list
- * ---------------
+/* -------------------
+ * Command server-list
+ * -------------------
*/
static const vshCmdInfo info_srv_list[] = {
@@ -380,9 +380,9 @@ cmdSrvList(vshControl *ctl, const vshCmd *cmd G_GNUC_UNUSED)
}
-/* ---------------------------
- * Command srv-threadpool-info
- * ---------------------------
+/* ------------------------------
+ * Command server-threadpool-info
+ * ------------------------------
*/
static const vshCmdInfo info_srv_threadpool_info[] = {
@@ -441,9 +441,9 @@ cmdSrvThreadpoolInfo(vshControl *ctl, const vshCmd *cmd)
return ret;
}
-/* --------------------------
- * Command srv-threadpool-set
- * --------------------------
+/* -----------------------------
+ * Command server-threadpool-set
+ * -----------------------------
*/
static const vshCmdInfo info_srv_threadpool_set[] = {
@@ -550,9 +550,9 @@ cmdSrvThreadpoolSet(vshControl *ctl, const vshCmd *cmd)
goto cleanup;
}
-/* ------------------------
- * Command srv-clients-list
- * ------------------------
+/* ---------------------------
+ * Command server-clients-list
+ * ---------------------------
*/
static const vshCmdInfo info_srv_clients_list[] = {
@@ -793,9 +793,9 @@ cmdClientDisconnect(vshControl *ctl, const vshCmd *cmd)
return ret;
}
-/* ------------------------
- * Command srv-clients-info
- * ------------------------
+/* ---------------------------
+ * Command server-clients-info
+ * ---------------------------
*/
static const vshCmdInfo info_srv_clients_info[] = {
@@ -852,9 +852,9 @@ cmdSrvClientsInfo(vshControl *ctl, const vshCmd *cmd)
return ret;
}
-/* -----------------------
- * Command srv-clients-set
- * -----------------------
+/* --------------------------
+ * Command server-clients-set
+ * --------------------------
*/
static const vshCmdInfo info_srv_clients_set[] = {
@@ -957,9 +957,9 @@ cmdSrvClientsSet(vshControl *ctl, const vshCmd *cmd)
goto cleanup;
}
-/* ------------------------
- * Command srv-update-tls
- * ------------------------
+/* --------------------------
+ * Command server-update-tls
+ * --------------------------
*/
static const vshCmdInfo info_srv_update_tls_file[] = {
{.name = "help",
--
2.26.2
3 years, 10 months
[libvirt PATCH 0/3] cirrus: Add templates and refresh script
by Andrea Bolognani
This makes the Cirrus CI configurations as maintainable as the
Dockerfiles, by shifting the responsability of keeping the list
of dependencies and other details up to date to lcitool.
Test pipeline:
https://gitlab.com/abologna/libvirt/-/pipelines/161179474
The important job is the macOS one.
For the refresh script to work, your copy of lcitool needs to
include these patches:
https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/30
https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/31
Andrea Bolognani (3):
cirrus: Tweak configurations
cirrus: Add templates and refresh script
cirrus: Refresh configurations
ci/cirrus/freebsd-12.yml.j2 | 62 ++++--------------------------
ci/cirrus/macos-1015.yml.j2 | 29 +++++---------
ci/cirrus/refresh | 32 +++++++++++++++
ci/cirrus/templates/freebsd-12.yml | 25 ++++++++++++
ci/cirrus/templates/macos-1015.yml | 27 +++++++++++++
5 files changed, 100 insertions(+), 75 deletions(-)
create mode 100755 ci/cirrus/refresh
create mode 100644 ci/cirrus/templates/freebsd-12.yml
create mode 100644 ci/cirrus/templates/macos-1015.yml
--
2.25.4
3 years, 10 months
[PATCH] virConnectGetAllDomainStats: Document two vcpu stats
by Michal Privoznik
When introducing vcpu.<num>.wait (v1.3.2-rc1~301) and
vcpu.<num>.halted (v2.4.0-rc1~36) the documentation was
not written.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
src/libvirt-domain.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 60b5e65fc3..52ce3ef798 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -11493,6 +11493,11 @@ virConnectGetDomainCapabilities(virConnectPtr conn,
* from virVcpuState enum.
* "vcpu.<num>.time" - virtual cpu time spent by virtual CPU <num>
* as unsigned long long.
+ * "vcpu.<num>.wait" - time the vCPU <num> wants to run, but the host
+ * scheduler has something else running ahead of it.
+ * "vcpu.<num>.halted" - virtual CPU <num> is halted, may indicate the
+ * processor is idle or even disabled, depending
+ * on the architecture)
*
* VIR_DOMAIN_STATS_INTERFACE:
* Return network interface statistics (from domain point of view).
--
2.26.2
3 years, 10 months
[PATCH v2 for 6.5.0] domain_conf: Remove zPCI validation from formatter
by Michal Privoznik
In 076591009ad a validation code was added to
virDomainDeviceInfoFormat() which reports an error if zPCI
address entered in was incomplete. But, there are two problems
with this approach.
The first problem is the placement of the code - it doesn't
belong into XML formatter rather than XML validator.
The second one is that at the point of formatting XML the post
parse callback has run and thus filled in required info.
Therefore this check can never do something useful and instead of
moving it into validator, it's removed completely.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
This is v2 of:
https://www.redhat.com/archives/libvir-list/2020-June/msg01279.html
diff to v1:
- Instead of moving the check to validator remove it completely (per
discussion in v1)
src/conf/domain_conf.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 33f177b16f..0c883cd834 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -7523,10 +7523,6 @@ virDomainDeviceInfoFormat(virBufferPtr buf,
}
if (virZPCIDeviceAddressIsPresent(&info->addr.pci.zpci)) {
- if (virZPCIDeviceAddressIsIncomplete(&info->addr.pci.zpci))
- virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
- _("Missing uid or fid attribute of zPCI address"));
-
virBufferAsprintf(&childBuf,
"<zpci uid='0x%.4x' fid='0x%.8x'/>\n",
info->addr.pci.zpci.uid.value,
--
2.26.2
3 years, 10 months
[PATCH for 6.5.0 0/3] Move zPCI validation from formatter to validator
by Michal Privoznik
*** BLURB HERE ***
Michal Prívozník (3):
qemuhotplugtest: Free monitor iff successfully initialized
domain_conf: Move zPCI validation from formatter to validator
qemu_validate: Fix how qemuValidateDomainDeviceDefZPCIAddress() is
called
src/conf/domain_conf.c | 4 ----
src/qemu/qemu_validate.c | 9 ++++++++-
tests/qemuhotplugtest.c | 8 +++++---
3 files changed, 13 insertions(+), 8 deletions(-)
--
2.26.2
3 years, 10 months
[libvirt PATCH] ci: Run all jobs, for all branches, all the time
by Andrea Bolognani
After recent changes (increasing the parallelism of the pipeline
by reducing the number of stages, introducing FreeBSD builds that
take longer than any other job), the difference between running
the full pipeline or a reduced one has basically disappeared: in
both cases, the completion time is around 25-35 minutes depending
on whether containers need to be rebuilt and how many shared
runners are available.
Reduce the complexity of our .gitlab-ci.yml and make things
simpler for contributors by simply always running all jobs.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
.gitlab-ci.yml | 143 ++++++++++++++++++-------------------------------
1 file changed, 53 insertions(+), 90 deletions(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 6cb910b0fa..e6eb2f9905 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -15,8 +15,7 @@ stages:
# Common templates
-# Containers that are necessary for the default pipeline
-.container_default_job_template: &container_default_job_definition
+.container_job_template: &container_job_definition
image: docker:stable
stage: containers
services:
@@ -33,23 +32,15 @@ stages:
after_script:
- docker logout
-# Containers that are only needed for the full pipeline
-.container_extra_job_template: &container_extra_job_definition
- <<: *container_default_job_definition
- only:
- - master
- - /^ci-full-.*$/
-
# We build many containers which can be useful to debug problems but are not
# needed for the pipeline itself to complete: those sometimes fail, and when
# that happens it's mostly because of temporary issues with Debian sid. We
# don't want those failures to affect the overall pipeline status
.container_optional_job_template: &container_optional_job_definition
- <<: *container_extra_job_definition
+ <<: *container_job_definition
allow_failure: true
-# Default native build jobs that are always run
-.native_build_default_job_template: &native_build_default_job_definition
+.native_build_job_template: &native_build_job_definition
stage: builds
image: $CI_REGISTRY_IMAGE/ci-$NAME:latest
cache:
@@ -64,18 +55,10 @@ stages:
- ../autogen.sh || (cat config.log && exit 1)
- $MAKE distcheck
-# Extra native build jobs that are only run post-merge, or
-# when code is pushed to a branch with "ci-full-" name prefix
-.native_build_extra_job_template: &native_build_extra_job_definition
- <<: *native_build_default_job_definition
- only:
- - master
- - /^ci-full-.*$/
-
# Jobs that we delegate to Cirrus CI because they require an operating
# system other than Linux. These jobs will only run if the required
# setup has been performed on the GitLab account (see ci/README.rst).
-.cirrus_build_default_job_template: &cirrus_build_default_job_definition
+.cirrus_build_job_template: &cirrus_build_job_definition
stage: builds
image: registry.gitlab.com/libvirt/libvirt-ci/cirrus-run:master
script:
@@ -85,19 +68,7 @@ stages:
- $CIRRUS_GITHUB_REPO
- $CIRRUS_API_TOKEN
-.cirrus_build_extra_job_template: &cirrus_build_extra_job_definition
- <<: *cirrus_build_default_job_definition
- only:
- variables:
- - $CIRRUS_GITHUB_REPO
- - $CIRRUS_API_TOKEN
- refs:
- - master
- - /^ci-full-.*$/
-
-
-# Default cross build jobs that are always run
-.cross_build_default_job_template: &cross_build_default_job_definition
+.cross_build_default_job_template: &cross_build_job_definition
stage: builds
image: $CI_REGISTRY_IMAGE/ci-$NAME-cross-$CROSS:latest
cache:
@@ -112,74 +83,66 @@ stages:
- ../autogen.sh $CONFIGURE_OPTS || (cat config.log && exit 1)
- $MAKE
-# Extra cross build jobs that are only run post-merge, or
-# when code is pushed to a branch with "ci-full-" name prefix
-.cross_build_extra_job_template: &cross_build_extra_job_definition
- <<: *cross_build_default_job_definition
- only:
- - master
- - /^ci-full-.*$/
-
# Native container build jobs
x64-centos-7-container:
- <<: *container_default_job_definition
+ <<: *container_job_definition
variables:
NAME: centos-7
x64-centos-8-container:
- <<: *container_default_job_definition
+ <<: *container_job_definition
variables:
NAME: centos-8
x64-centos-stream-container:
- <<: *container_extra_job_definition
+ <<: *container_job_definition
variables:
NAME: centos-stream
x64-debian-9-container:
- <<: *container_extra_job_definition
+ <<: *container_job_definition
variables:
NAME: debian-9
x64-debian-10-container:
- <<: *container_default_job_definition
+ <<: *container_job_definition
variables:
NAME: debian-10
x64-debian-sid-container:
- <<: *container_extra_job_definition
+ <<: *container_job_definition
variables:
NAME: debian-sid
x64-fedora-31-container:
- <<: *container_extra_job_definition
+ <<: *container_job_definition
variables:
NAME: fedora-31
x64-fedora-32-container:
- <<: *container_default_job_definition
+ <<: *container_job_definition
variables:
NAME: fedora-32
x64-fedora-rawhide-container:
- <<: *container_default_job_definition
+ <<: *container_job_definition
variables:
NAME: fedora-rawhide
x64-opensuse-151-container:
- <<: *container_default_job_definition
+ <<: *container_job_definition
variables:
NAME: opensuse-151
x64-ubuntu-1804-container:
- <<: *container_extra_job_definition
+ <<: *container_job_definition
variables:
NAME: ubuntu-1804
x64-ubuntu-2004-container:
- <<: *container_default_job_definition
+ <<: *container_job_definition
variables:
NAME: ubuntu-2004
@@ -192,7 +155,7 @@ aarch64-debian-9-container:
NAME: debian-9-cross-aarch64
armv6l-debian-9-container:
- <<: *container_extra_job_definition
+ <<: *container_job_definition
variables:
NAME: debian-9-cross-armv6l
@@ -202,12 +165,12 @@ armv7l-debian-9-container:
NAME: debian-9-cross-armv7l
mips-debian-9-container:
- <<: *container_extra_job_definition
+ <<: *container_job_definition
variables:
NAME: debian-9-cross-mips
mips64el-debian-9-container:
- <<: *container_extra_job_definition
+ <<: *container_job_definition
variables:
NAME: debian-9-cross-mips64el
@@ -227,7 +190,7 @@ s390x-debian-9-container:
NAME: debian-9-cross-s390x
aarch64-debian-10-container:
- <<: *container_extra_job_definition
+ <<: *container_job_definition
variables:
NAME: debian-10-cross-aarch64
@@ -257,7 +220,7 @@ mips64el-debian-10-container:
NAME: debian-10-cross-mips64el
mipsel-debian-10-container:
- <<: *container_extra_job_definition
+ <<: *container_job_definition
variables:
NAME: debian-10-cross-mipsel
@@ -267,7 +230,7 @@ ppc64le-debian-10-container:
NAME: debian-10-cross-ppc64le
s390x-debian-10-container:
- <<: *container_default_job_definition
+ <<: *container_job_definition
variables:
NAME: debian-10-cross-s390x
@@ -282,12 +245,12 @@ armv6l-debian-sid-container:
NAME: debian-sid-cross-armv6l
armv7-ldebian-sid-container:
- <<: *container_default_job_definition
+ <<: *container_job_definition
variables:
NAME: debian-sid-cross-armv7l
i686-debian-sid-container:
- <<: *container_extra_job_definition
+ <<: *container_job_definition
variables:
NAME: debian-sid-cross-i686
@@ -302,7 +265,7 @@ mipsel-debian-sid-container:
NAME: debian-sid-cross-mipsel
ppc64le-debian-sid-container:
- <<: *container_extra_job_definition
+ <<: *container_job_definition
variables:
NAME: debian-sid-cross-ppc64le
@@ -312,12 +275,12 @@ s390x-debian-sid-container:
NAME: debian-sid-cross-s390x
mingw32-fedora-rawhide-container:
- <<: *container_default_job_definition
+ <<: *container_job_definition
variables:
NAME: fedora-rawhide-cross-mingw32
mingw64-fedora-rawhide-container:
- <<: *container_default_job_definition
+ <<: *container_job_definition
variables:
NAME: fedora-rawhide-cross-mingw64
@@ -325,72 +288,72 @@ mingw64-fedora-rawhide-container:
# Native architecture build + test jobs
x64-debian-9:
- <<: *native_build_extra_job_definition
+ <<: *native_build_job_definition
variables:
NAME: debian-9
x64-debian-10:
- <<: *native_build_default_job_definition
+ <<: *native_build_job_definition
variables:
NAME: debian-10
x64-debian-sid:
- <<: *native_build_extra_job_definition
+ <<: *native_build_job_definition
variables:
NAME: debian-sid
x64-centos-7:
- <<: *native_build_default_job_definition
+ <<: *native_build_job_definition
variables:
NAME: centos-7
x64-centos-8:
- <<: *native_build_extra_job_definition
+ <<: *native_build_job_definition
variables:
NAME: centos-8
x64-centos-stream:
- <<: *native_build_extra_job_definition
+ <<: *native_build_job_definition
variables:
NAME: centos-stream
x64-fedora-31:
- <<: *native_build_extra_job_definition
+ <<: *native_build_job_definition
variables:
NAME: fedora-31
x64-fedora-32:
- <<: *native_build_default_job_definition
+ <<: *native_build_job_definition
variables:
NAME: fedora-32
x64-fedora-rawhide:
- <<: *native_build_default_job_definition
+ <<: *native_build_job_definition
variables:
NAME: fedora-rawhide
x64-opensuse-151:
- <<: *native_build_default_job_definition
+ <<: *native_build_job_definition
variables:
NAME: opensuse-151
x64-ubuntu-1804:
- <<: *native_build_extra_job_definition
+ <<: *native_build_job_definition
variables:
NAME: ubuntu-1804
x64-ubuntu-2004:
- <<: *native_build_default_job_definition
+ <<: *native_build_job_definition
variables:
NAME: ubuntu-2004
x64-freebsd-12-build:
- <<: *cirrus_build_default_job_definition
+ <<: *cirrus_build_job_definition
variables:
NAME: freebsd-12
x64-macos-1015-build:
- <<: *cirrus_build_default_job_definition
+ <<: *cirrus_build_job_definition
variables:
NAME: macos-1015
@@ -398,67 +361,67 @@ x64-macos-1015-build:
# Cross compiled build jobs
armv6l-debian-9:
- <<: *cross_build_extra_job_definition
+ <<: *cross_build_job_definition
variables:
NAME: debian-9
CROSS: armv6l
mips64el-debian-9:
- <<: *cross_build_extra_job_definition
+ <<: *cross_build_job_definition
variables:
NAME: debian-9
CROSS: mips64el
mips-debian-9:
- <<: *cross_build_extra_job_definition
+ <<: *cross_build_job_definition
variables:
NAME: debian-9
CROSS: mips
aarch64-debian-10:
- <<: *cross_build_extra_job_definition
+ <<: *cross_build_job_definition
variables:
NAME: debian-10
CROSS: aarch64
mipsel-debian-10:
- <<: *cross_build_extra_job_definition
+ <<: *cross_build_job_definition
variables:
NAME: debian-10
CROSS: mipsel
s390x-debian-10:
- <<: *cross_build_default_job_definition
+ <<: *cross_build_job_definition
variables:
NAME: debian-10
CROSS: s390x
armv7l-debian-sid:
- <<: *cross_build_default_job_definition
+ <<: *cross_build_job_definition
variables:
NAME: debian-sid
CROSS: armv7l
i686-debian-sid:
- <<: *cross_build_extra_job_definition
+ <<: *cross_build_job_definition
variables:
NAME: debian-sid
CROSS: i686
ppc64le-debian-sid:
- <<: *cross_build_extra_job_definition
+ <<: *cross_build_job_definition
variables:
NAME: debian-sid
CROSS: ppc64le
mingw32-fedora-rawhide:
- <<: *cross_build_default_job_definition
+ <<: *cross_build_job_definition
variables:
NAME: fedora-rawhide
CROSS: mingw32
mingw64-fedora-rawhide:
- <<: *cross_build_default_job_definition
+ <<: *cross_build_job_definition
variables:
NAME: fedora-rawhide
CROSS: mingw64
--
2.25.4
3 years, 10 months
[PATCH 00/25] Several g_auto* conversion and related small bugfixes
by Laine Stump
This started out with me noticing a memory leak in a patch that led to
the realization that domain_conf.c hadn't been converted to use
g_autofree yet, and each step of the way uncovered some other
annoyance that I wanted to get rid of. Most of the changes are related
to converting code to use g_auto*, g_new0, and g_free, but there is
also a some of elimination of labels, fixing actual or theoretical
memory leaks, modifications for style, etc. None of it should have any
functional effect (except the fixing one or two memory leaks).
Laine Stump (25):
conf, vmx: check for OOM after calling xmlBufferCreate()
use g_autoptr for all xmlBuffers
conf: refactor virDomainBlkioDeviceParseXML to remove possible NULL
dereference
util: validate return from xmlNodeGetContent before use
util: remove OOM error log from virGetHostnameImpl()
conf: eliminate useless error label in virDomainFeaturesDefParse()
util: eliminate error label in virDomainDefFormatInternalSetRootName()
network: fix memory leak in networkBuildDhcpDaemonCommandLine()
util: add g_autoptr cleanup function for virFirewall objects
network: convert local pointers to g_auto*
network: use g_free() in place of remaining VIR_FREE()
network: make networkDnsmasqXmlNsDef private to bridge_driver.c
define g_autoptr cleanup function for virNetworkDHCPLease
network: replace VIR_ALLOC/REALLOC with g_new0/g_renew
network: use proper arg type when calling virNetDevSetOnline()
squash into 'network: convert local pointers to g_auto*'
use g_autoptr() for all usages of virFirewallNew/Free
nwfilter: define a typedef for struct ebtablesSubChainInst
nwfilter replace VIR_ALLOC with g_new0
nwfilter: remove unnecessary code from ebtablesGetSubChainInsts()
nwfilter: convert local pointers to use g_auto*
nwfilter: convert remaining VIR_FREE() to g_free()
nwfilter: transform logic in virNWFilterRuleInstSort to eliminate
label
nwfilter: use standard label names when reasonable
replace g_new() with g_new0() for consistency
src/conf/domain_conf.c | 254 +++++-----
src/conf/network_conf.c | 10 +-
src/datatypes.h | 2 +
src/network/bridge_driver.c | 585 +++++++++-------------
src/network/bridge_driver.h | 9 -
src/network/bridge_driver_linux.c | 58 +--
src/network/leaseshelper.c | 16 +-
src/nwfilter/nwfilter_dhcpsnoop.c | 150 +++---
src/nwfilter/nwfilter_driver.c | 13 +-
src/nwfilter/nwfilter_ebiptables_driver.c | 277 ++++------
src/nwfilter/nwfilter_gentech_driver.c | 60 +--
src/nwfilter/nwfilter_learnipaddr.c | 45 +-
src/qemu/qemu_backup.c | 2 +-
src/util/virdnsmasq.h | 4 +
src/util/virebtables.c | 24 +-
src/util/virfirewall.h | 1 +
src/util/viriptables.c | 14 +-
src/util/virutil.c | 12 +-
src/util/virxml.c | 12 +-
src/vmx/vmx.c | 17 +-
tests/qemuhotplugmock.c | 2 +-
tests/virfirewalltest.c | 50 +-
22 files changed, 640 insertions(+), 977 deletions(-)
--
2.25.4
3 years, 10 months