[PATCH v2 0/3] Re-think stance towards image format probing
by Peter Krempa
We decided that use of qemu-img would not be possible for this case. I'm
thus re-sending the patch with fixes to docs and the ISO image format
probe.
This approach is the simplest and most straightforward and deals with
most cases. Specifically we don't have to fix half of blockjob code by
doing this as opposed if we wanted to have qemu open the image itself by
looking into the overlay's metadata.
Peter Krempa (3):
qemu: domain: Convert detected 'iso' image format into 'raw'
virStorageFileGetMetadataRecurse: Allow format probing under special
circumstances
kbase: backing_chains: Clarify some aspects of image probing
docs/kbase/backing_chains.rst | 16 +++++++++--
src/qemu/qemu_domain.c | 4 +++
src/util/virstoragefile.c | 52 ++++++++++++++++++++---------------
3 files changed, 48 insertions(+), 24 deletions(-)
--
2.24.1
5 years, 2 months
[libvirt-jenkins-ci PATCH 0/4] Fixes and improvements to cross-build environments
by Andrea Bolognani
The first two commits are necessary to build container images that
can successfully be used in libosinfo's GitLab CI setup, which is
currently not performing MinGW builds because of the issues they
address.
Andrea Bolognani (4):
lcitool: Install dpkg-dev when doing cross-builds on Debian
Don't set $PKG_CONFIG_LIBDIR anywhere
lcitool: Drop duplicated code
lcitool: Don't specify --target in $CONFIGURE_OPTS
guests/lcitool | 15 +++------------
guests/playbooks/build/jobs/defaults.yml | 2 --
jenkins/jobs/defaults.yaml | 2 --
3 files changed, 3 insertions(+), 16 deletions(-)
--
2.24.1
5 years, 2 months
[PATCH 0/9] Re-think the stance towards image format probing
by Peter Krempa
Few recent changes broke wrong, but apparently widely used
configurations as used didn't really record the image format into the
image.
It turns out we can safely probe the image format in few limited
circumstances which on the other hand should fix the majority of the
problems. Please see patch 8/9 for further explanation.
Peter Krempa (9):
util: storagefile: Drop image format probing by file suffix
virStorageFileGetMetadataRecurse: Remove impossible error report
virStorageFileGetMetadataRecurse: Shuffle around assignment of backing
chain depth
virStorageFileGetMetadataRecurse: Expect NULL src->path
virStorageFileGetMetadataRecurse: Use virHashHasEntry instead of fake
pointers
virStorageFileGetMetadataRecurse: Extract storage access
virStorageFileGetMetadataRecurse: Remove 'cleanup' label
virStorageFileGetMetadataRecurse: Allow format probing under special
circumstances
WIP: Add tool for probing images
src/util/virstoragefile.c | 231 ++++++++++++++++++--------------------
tests/Makefile.am | 13 ++-
tests/qemublockprobe.c | 130 +++++++++++++++++++++
3 files changed, 251 insertions(+), 123 deletions(-)
create mode 100644 tests/qemublockprobe.c
--
2.24.1
5 years, 2 months
[PATCH] network: bridge_driver: Use new helpers for storing libvirt errors
by Gaurav Agrawal
From: GAURAV AGRAWAL <agrawalgaurav(a)gnome.org>
Signed-off-by: Gaurav Agrawal <agrawalgaurav(a)gnome.org>
---
src/network/bridge_driver_linux.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/network/bridge_driver_linux.c b/src/network/bridge_driver_linux.c
index 7bbde5c6a9..ac92d884b9 100644
--- a/src/network/bridge_driver_linux.c
+++ b/src/network/bridge_driver_linux.c
@@ -22,6 +22,7 @@
#include <config.h>
#include "viralloc.h"
+#include "virerror.h"
#include "virfile.h"
#include "viriptables.h"
#include "virstring.h"
@@ -53,7 +54,7 @@ static void networkSetupPrivateChains(void)
if (rc < 0) {
VIR_DEBUG("Failed to create global IPv4 chains: %s",
virGetLastErrorMessage());
- errInitV4 = virSaveLastError();
+ virErrorPreserveLast(&errInitV4);
virResetLastError();
} else {
virFreeError(errInitV4);
@@ -70,7 +71,7 @@ static void networkSetupPrivateChains(void)
if (rc < 0) {
VIR_DEBUG("Failed to create global IPv6 chains: %s",
virGetLastErrorMessage());
- errInitV6 = virSaveLastError();
+ virErrorPreserveLast(&errInitV6);
virResetLastError();
} else {
virFreeError(errInitV6);
@@ -790,7 +791,7 @@ int networkAddFirewallRules(virNetworkDefPtr def)
if (errInitV4 &&
(virNetworkDefGetIPByIndex(def, AF_INET, 0) ||
virNetworkDefGetRouteByIndex(def, AF_INET, 0))) {
- virSetError(errInitV4);
+ virErrorRestore(&errInitV4);
return -1;
}
@@ -798,7 +799,7 @@ int networkAddFirewallRules(virNetworkDefPtr def)
(virNetworkDefGetIPByIndex(def, AF_INET6, 0) ||
virNetworkDefGetRouteByIndex(def, AF_INET6, 0) ||
def->ipv6nogw)) {
- virSetError(errInitV6);
+ virErrorRestore(&errInitV6);
return -1;
}
--
2.24.1
5 years, 2 months
[libvirt PATCH] src: add virutil.h to more source files for geteuid() compat
by Daniel P. Berrangé
The virutil.h header defines a geteuid() macro for Windows platforms.
This fixes a few missed cases from:
commit b11e8cccdd5163727fd4cecda0076ac2b63fe32d
Author: Ján Tomko <jtomko(a)redhat.com>
Date: Sun Feb 16 23:09:15 2020 +0100
Remove virutil.h from all header files
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
Pushed to fix Windows build
src/admin/admin_server_dispatch.c | 1 +
src/driver.c | 1 +
src/util/virnetdevbandwidth.c | 1 +
src/util/virstoragefile.c | 1 +
tests/virlockspacetest.c | 1 +
5 files changed, 5 insertions(+)
diff --git a/src/admin/admin_server_dispatch.c b/src/admin/admin_server_dispatch.c
index 485f7d967c..7b3bd697f3 100644
--- a/src/admin/admin_server_dispatch.c
+++ b/src/admin/admin_server_dispatch.c
@@ -34,6 +34,7 @@
#include "virstring.h"
#include "virthreadjob.h"
#include "virtypedparam.h"
+#include "virutil.h"
#define VIR_FROM_THIS VIR_FROM_ADMIN
diff --git a/src/driver.c b/src/driver.c
index 2392fd7d5f..a2047beaef 100644
--- a/src/driver.c
+++ b/src/driver.c
@@ -31,6 +31,7 @@
#include "virmodule.h"
#include "virstring.h"
#include "virthread.h"
+#include "virutil.h"
#include "configmake.h"
VIR_LOG_INIT("driver");
diff --git a/src/util/virnetdevbandwidth.c b/src/util/virnetdevbandwidth.c
index d00ef57606..5fd7186760 100644
--- a/src/util/virnetdevbandwidth.c
+++ b/src/util/virnetdevbandwidth.c
@@ -24,6 +24,7 @@
#include "viralloc.h"
#include "virerror.h"
#include "virstring.h"
+#include "virutil.h"
#define VIR_FROM_THIS VIR_FROM_NONE
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index 831ce30d4d..d75d2a689a 100644
--- a/src/util/virstoragefile.c
+++ b/src/util/virstoragefile.c
@@ -39,6 +39,7 @@
#include "virjson.h"
#include "virstorageencryption.h"
#include "virsecret.h"
+#include "virutil.h"
#define VIR_FROM_THIS VIR_FROM_STORAGE
diff --git a/tests/virlockspacetest.c b/tests/virlockspacetest.c
index 1f156ba3d6..82aef8bc2b 100644
--- a/tests/virlockspacetest.c
+++ b/tests/virlockspacetest.c
@@ -27,6 +27,7 @@
#include "viralloc.h"
#include "virfile.h"
#include "virlog.h"
+#include "virutil.h"
#include "virlockspace.h"
--
2.24.1
5 years, 2 months
[PATCH 0/3] security: Don't fail if locking a file on NFS mount fails
by Michal Privoznik
*** BLURB HERE ***
Michal Prívozník (3):
virSecurityManagerMetadataLock: Store locked paths
security: Don't remember seclabel for paths we haven't locked
successfully
security: Don't fail if locking a file on NFS mount fails
src/security/security_dac.c | 14 ++++++++++++++
src/security/security_manager.c | 29 ++++++++++++++++++-----------
src/security/security_manager.h | 6 ++++++
src/security/security_selinux.c | 14 ++++++++++++++
4 files changed, 52 insertions(+), 11 deletions(-)
--
2.24.1
5 years, 2 months
[libvirt PATCH] node_device: hal: include virutil.h
by Ján Tomko
Signed-off-by: Ján Tomko <jtomko(a)redhat.com>
Fixes: b11e8cccdd5163727fd4cecda0076ac2b63fe32d
---
Pushed as a build fix.
Also re-ran configure on my FreeBSD guest to pick up HAL.
src/node_device/node_device_hal.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/node_device/node_device_hal.c b/src/node_device/node_device_hal.c
index c3ca310bb7..a48b4ffcd1 100644
--- a/src/node_device/node_device_hal.c
+++ b/src/node_device/node_device_hal.c
@@ -38,6 +38,7 @@
#include "virlog.h"
#include "virdbus.h"
#include "virstring.h"
+#include "virutil.h"
#include "configmake.h"
--
2.24.1
5 years, 2 months
[libvirt PATCH 0/7] tests: libxl: clean up test mocking
by Ján Tomko
Refactor libxlDriverConfigNew to remove the need
for mocking virFilePath and add libxlDomainGetEmulatorType
to the mock to remove the need to invoke a binary
for nearly every domain we parse
Ján Tomko (7):
testutilsxen: error out on initialization failure
libxl: conf: move default keepalive settings to libxlDriverConfigNew
libxl: StateInitialize: use g_autofree
libxl: split out DriverConfigInit out of DriverConfigNew
libxl: do not mock virFileMakePath
tests: link the libxl tests with libxltestdriver.la
tests: libxl: do not run the emulator
src/libxl/libxl_capabilities.h | 3 +-
src/libxl/libxl_conf.c | 85 ++++++++++++++++++----------------
src/libxl/libxl_conf.h | 2 +
src/libxl/libxl_driver.c | 7 +--
tests/Makefile.am | 9 ++--
tests/libxlmock.c | 18 +++----
tests/testutilsxen.c | 9 +++-
7 files changed, 75 insertions(+), 58 deletions(-)
--
2.24.1
5 years, 2 months
[PATCH] build: stop running aclocal manually
by Daniel P. Berrangé
The autoreconf script will already run aclocal for us,
so there's no need todo that ahead of time.
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
autogen.sh | 1 -
1 file changed, 1 deletion(-)
diff --git a/autogen.sh b/autogen.sh
index 671dd63eb6..4e1bbceb0a 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -15,7 +15,6 @@ cd "$srcdir"
git submodule update --init || exit 1
-aclocal --install || exit 1
autoreconf --verbose --force --install || exit 1
if test "x$1" = "x--system"; then
--
2.24.1
5 years, 2 months
[libvirt PATCH] bhyve: utils: use relative path for virclosecallbacks.h
by Ján Tomko
When moving virclosecallbacks to src/hypervisor, I did not
adjust all the possible includes in Makefiles.
Use a path relative to src to fix the build.
Signed-off-by: Ján Tomko <jtomko(a)redhat.com>
Fixes: 25c29ac2f5842a7d48d9f9619317f68acf5d9995
---
Pushed as a build fix.
src/bhyve/bhyve_utils.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/bhyve/bhyve_utils.h b/src/bhyve/bhyve_utils.h
index 8dda6062b5..f3e80b6121 100644
--- a/src/bhyve/bhyve_utils.h
+++ b/src/bhyve/bhyve_utils.h
@@ -26,7 +26,7 @@
#include "configmake.h"
#include "virdomainobjlist.h"
#include "virthread.h"
-#include "virclosecallbacks.h"
+#include "hypervisor/virclosecallbacks.h"
#include "virportallocator.h"
#define BHYVE_AUTOSTART_DIR SYSCONFDIR "/libvirt/bhyve/autostart"
--
2.24.1
5 years, 2 months
