[libvirt] [dockerfiles PATCH] Add git-publish configuration file
by Andrea Bolognani
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
.gitpublish | 4 ++++
1 file changed, 4 insertions(+)
create mode 100644 .gitpublish
diff --git a/.gitpublish b/.gitpublish
new file mode 100644
index 0000000..a56a6d0
--- /dev/null
+++ b/.gitpublish
@@ -0,0 +1,4 @@
+[gitpublishprofile "default"]
+base = master
+to = libvir-list(a)redhat.com
+prefix = dockerfiles PATCH
--
2.20.1
5 years, 5 months
[libvirt] [PATCH 1/1] Revert "Revert "qemu: Temporary disable owner remembering""
by Daniel Henrique Barboza
After this commit, QEMU domains with PCI hostdevs running with
managed=true started to fail to launch with the following error:
error : virProcessRunInFork:1170 : internal error: child reported (status=125): unable to open /dev/vfio/1: Device or resource busy
One way to avoid this issue is to disable this new feature
in qemu.conf, setting remember_owner=0. However, given that
this feature is enabled by default and it is breaking domains that
were running before it, it is best to revert the change until
it is fixed for this scenario as well.
This reverts commit 8695793d726e37e31498f9fcbf0bce0adc56dc91.
Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com>
---
docs/news.xml | 13 -------------
src/qemu/libvirtd_qemu.aug | 1 -
src/qemu/qemu.conf | 5 -----
src/qemu/qemu_conf.c | 4 ----
src/qemu/test_libvirtd_qemu.aug.in | 1 -
5 files changed, 24 deletions(-)
diff --git a/docs/news.xml b/docs/news.xml
index 07d4575a65..8931f74bb9 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -25,19 +25,6 @@
<section title="New features">
</section>
<section title="Improvements">
- <change>
- <summary>
- Remember original owners and SELinux labels of files
- </summary>
- <description>
- When a domain is starting up libvirt changes DAC and
- SELinux labels so that domain can access it. However,
- it never remembered the original labels and therefore
- the file was returned back to <code>root:root</code>.
- With this release, the original labels are remembered
- and restored properly.
- </description>
- </change>
</section>
<section title="Bug fixes">
</section>
diff --git a/src/qemu/libvirtd_qemu.aug b/src/qemu/libvirtd_qemu.aug
index eea9094d39..6821cc4a29 100644
--- a/src/qemu/libvirtd_qemu.aug
+++ b/src/qemu/libvirtd_qemu.aug
@@ -72,7 +72,6 @@ module Libvirtd_qemu =
| str_entry "user"
| str_entry "group"
| bool_entry "dynamic_ownership"
- | bool_entry "remember_owner"
| str_array_entry "cgroup_controllers"
| str_array_entry "cgroup_device_acl"
| int_entry "seccomp_sandbox"
diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf
index fd2ed9dc21..1969b3f0a1 100644
--- a/src/qemu/qemu.conf
+++ b/src/qemu/qemu.conf
@@ -456,11 +456,6 @@
# Set to 0 to disable file ownership changes.
#dynamic_ownership = 1
-# Whether libvirt should remember and restore the original
-# ownership over files it is relabeling. Defaults to 1, set
-# to 0 to disable the feature.
-#remember_owner = 1
-
# What cgroup controllers to make use of with QEMU guests
#
# - 'cpu' - use for scheduler tunables
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index e0195dac29..8312f99f80 100644
--- a/src/qemu/qemu_conf.c
+++ b/src/qemu/qemu_conf.c
@@ -125,7 +125,6 @@ virQEMUDriverConfigPtr virQEMUDriverConfigNew(bool privileged)
cfg->group = (gid_t)-1;
}
cfg->dynamicOwnership = privileged;
- cfg->rememberOwner = privileged;
cfg->cgroupControllers = -1; /* -1 == auto-detect */
@@ -891,9 +890,6 @@ virQEMUDriverConfigLoadSecurityEntry(virQEMUDriverConfigPtr cfg,
if (virConfGetValueBool(conf, "dynamic_ownership", &cfg->dynamicOwnership) < 0)
return -1;
- if (virConfGetValueBool(conf, "remember_owner", &cfg->rememberOwner) < 0)
- return -1;
-
if (virConfGetValueStringList(conf, "cgroup_controllers", false,
&controllers) < 0)
return -1;
diff --git a/src/qemu/test_libvirtd_qemu.aug.in b/src/qemu/test_libvirtd_qemu.aug.in
index 388ba24b8b..50b728ad22 100644
--- a/src/qemu/test_libvirtd_qemu.aug.in
+++ b/src/qemu/test_libvirtd_qemu.aug.in
@@ -44,7 +44,6 @@ module Test_libvirtd_qemu =
{ "user" = "root" }
{ "group" = "root" }
{ "dynamic_ownership" = "1" }
-{ "remember_owner" = "1" }
{ "cgroup_controllers"
{ "1" = "cpu" }
{ "2" = "devices" }
--
2.21.0
5 years, 5 months
[libvirt] [PATCH] util: Fix uninitalized variable to avoid garbage value.
by Julio Faracco
This commit is similar with 596aa144. It fixes an uninitialized
variable to avoid garbage value. This case, it uses time 't' 0 if
an error occurs with virTimeMillisNowRaw.
Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com>
---
src/util/virtime.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virtime.c b/src/util/virtime.c
index d1187726ee..86993e4e8d 100644
--- a/src/util/virtime.c
+++ b/src/util/virtime.c
@@ -422,7 +422,7 @@ virTimeBackOffStart(virTimeBackOffVar *var,
bool
virTimeBackOffWait(virTimeBackOffVar *var)
{
- unsigned long long t, next;
+ unsigned long long next, t = 0;
ignore_value(virTimeMillisNowRaw(&t));
--
2.20.1
5 years, 5 months
[libvirt] [jenkins-ci PATCH v2 00/20] quayadmin: Introduce Quay API client
by Andrea Bolognani
Changes from [v1]:
* add Dan's R-b to the patch importing the initial implementation;
* don't break quiet mode for show-repo, and make sure it works for
all other show-* commands as well;
* fix typos.
[v1] https://www.redhat.com/archives/libvir-list/2019-July/msg01018.html
Andrea Bolognani (20):
quayadmin: Import initial implementation
quayadmin: Fix argument parsing for delete-repo
quayadmin: Tweak quiet logic
quayadmin: Tweak show-repo output format
quayadmin: Tweak list-repos output format
quayadmin: Build endpoint, params and payload separately
quayadmin: Implement debug mode
quayadmin: Remove clientid and clientsecret
quayadmin: Introduce configuration object
quayadmin: Read configuration from file
quayadmin: Add support for the PUT method
quayadmin: Add list-triggers command
quayadmin: Add show-trigger command
quayadmin: Add activate-trigger command
quayadmin: Add list-builds command
quayadmin: Add show-build command
quayadmin: Add list-tags command
quayadmin: Add show-tag command
quayadmin: Add create-tag command
quayadmin: Add delete-tag command
guests/quayadmin | 585 +++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 585 insertions(+)
create mode 100755 guests/quayadmin
--
2.21.0
5 years, 5 months
[libvirt] [PATCH 0/2] docs: news: add per-release links
by Ján Tomko
Ján Tomko (2):
docs: news: remove sed sorcery
docs: news: add per-release links
docs/Makefile.am | 8 +-------
docs/news-html.xsl | 21 ++++++++++++++-------
2 files changed, 15 insertions(+), 14 deletions(-)
--
2.20.1
5 years, 5 months
[libvirt] [PATCH 0/7] docs: assorted cleanups (virtio-fs epopee)
by Ján Tomko
Got a bit lost while navigating around the <filesystem> element
documentation.
Ján Tomko (7):
docs: link to networkportformat.html in format.html
docs: drvqemu: fix a typo
docs: drvqemu: remove relative time reference
docs: formatdomain: remove stray nbsp
docs: formatdomain: tsc is supported by QEMU
docs: formatdomain: remove "Since" references older than 1.1.1
docs: remove "Since" references older than 1.1.1
docs/drvnodedev.html.in | 8 +-
docs/drvqemu.html.in | 15 +-
docs/format.html.in | 1 +
docs/formatcaps.html.in | 22 ++-
docs/formatdomain.html.in | 340 +++++++++++++-------------------------
docs/storage.html.in | 5 -
6 files changed, 138 insertions(+), 253 deletions(-)
--
2.20.1
5 years, 5 months
[libvirt] [jenkins-ci PATCH 00/20] quayadmin: Introduce Quay API client
by Andrea Bolognani
Dan started building this a while ago, and I finally managed to find
some time to take it from a PoC to something that's actually useful
for our day to day operations.
There's still plenty of work to be done for sure, but it's already
at the point where I can at least partially script the process of
refreshing container images, which is something that up until now had
to be done slowly and painfully through the Web interface.
I will probably spend some more time on it in a couple of weeks,
after I've used it to refresh images right before the 5.6.0 release
and inevitably spotted a bunch of issues while doing so O:-)
Andrea Bolognani (20):
quayadmin: Import initial implementation
quayadmin: Fix argument parsing for delete-repo
quayadmin: Fix quiet mode for show-repo
quayadmin: Tweak show-repo output format
quayadmin: Tweak list-repos output format
quayadmin: Build endpoint, params and payload separately
quayadmin: Implement debug mode
quayadmin: Remove clientid and clientsecret
quayamdin: Introduce configuration object
quayadmin: Read configuration from file
quayadmin: Add support for the PUT method
quayadmin: Add list-triggers command
quayadmin: Add show-trigger command
quayadmin: Add activate-trigger command
quayadmin: Add list-builds command
quayadmin: Add show-build command
quayadmin: Add list-tags command
quayadmin: Add show-tag command
quayadmin: Add create-tag command
quayadmin: Add delete-tag command
guests/quayadmin | 563 +++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 563 insertions(+)
create mode 100755 guests/quayadmin
--
2.21.0
5 years, 5 months
[libvirt] [PATCH 00/29] Split the libvirtd daemon into per-driver daemons
by Daniel P. Berrangé
This is what all the driver refactoring I've done has been about
enabling.
We gain new daemons for each driver, for the primary virt drivers:
virtlibxld
virtlxcd
virtqemud
virtvboxd
virtvzd
And again for the secondary drivers
virtinterfaced
virtnetworkd
virtnodedevd
virtnwfilterd
virtsecretd
virtstoraged
Finally to support IP connectivity, and also the legacy lbivirtd UNIX
domain socket (for the old libvirt remote driver SSH tunnelling):
virtproxyd
The the sake of facilitating upgrades, the existing libvirtd still
exists and works the same way it always has.
You either run libvirtd, or you run the per-driver daemons, never both.
The remote driver will look to see whether libvirtd is running to figure
out whether to connect to libvirtd or the new per-driver daemons.
When auto-spawning daemons for nonroot users, we default to spawning the
per-driver daemons.
This can be controlled with a UR parameter "?mode=direct|legacy|auto",
where 'direct' means per-driver and 'legacy' means libvirtd (or indirect
via virtproxyd if that's running).
Still todo
- Add systemd unit files for the new daemons
- Make it possible to disable build of libvirtd, or of the per-driver
daemons so downstream vendors can decide which to ship
- Tuning of the daemon defaults for worker threads to better suit
the fact that we have per-driver daemons
- More work on RPM packaging to allow install of per-driver daemosn
without pulling in libvirtd too
- A bunch of stuff that doesn't occurr to me right now
- Identify & fix more bugs I've created here
Daniel P. Berrangé (29):
rpc: add API for checking whether an auth scheme is in use on a server
remote: simplify libvirtd code for deciding if SASL auth is needed
logging: pass binary name not logfile name when enabling logging
remote: conditionalize socket names in libvirtd daemon
remote: conditionalize daemon name in libvirtd daemon
remote: conditionalize driver loading in libvirtd daemon
remote: conditionalize IP socket usage in libvirtd daemon
remote: conditionalize IP socket config in libvirtd.conf
remote: conditionalize IP socket config in augeas definitions
remote: refactor & rename variables for building libvirtd
secret: introduce virtsecretd daemon
network: introduce virtnetworkd daemon
interface: introduce virtinterfaced daemon
storage: introduce virtstoraged daemon
nodedev: introduce virtnodedevd daemon
nwfilter: introduce virtnwfilterd daemon
libxl: introduce virtlibxld daemon
qemu: introduce virtqemud daemon
lxc: introduce virtlxcd daemon
vbox: introduce virtvboxd daemon
bhyve: introduce virtbhyved daemon
vz: introduce virtvzd daemon
remote: introduce virtproxyd daemon to handle IP connectivity
remote: open secondary drivers via remote driver if needed
remote: use enum helpers for parsing remote driver transport
remote: refactor the code for choosing the UNIX socket path
remote: switch to connect to per-driver daemons by default
all: don't wait for driver lock during startup
interface: fix driver name in state directory path
.gitignore | 12 +
build-aux/augeas-gentest.pl | 2 +-
libvirt.spec.in | 10 +
src/bhyve/Makefile.inc.am | 14 +
src/bhyve/bhyve_driver.c | 2 +-
src/driver.h | 2 +
src/interface/Makefile.inc.am | 14 +
src/interface/interface_backend_netcf.c | 6 +-
src/interface/interface_backend_udev.c | 6 +-
src/libvirt.c | 24 ++
src/libvirt_remote.syms | 1 +
src/libxl/Makefile.inc.am | 14 +
src/libxl/libxl_driver.c | 2 +-
src/locking/lock_daemon.c | 2 +-
src/logging/log_daemon.c | 2 +-
src/lxc/Makefile.inc.am | 15 +
src/lxc/lxc_driver.c | 2 +-
src/network/Makefile.inc.am | 14 +
src/network/leaseshelper.c | 2 +-
src/node_device/Makefile.inc.am | 14 +
src/node_device/node_device_hal.c | 2 +-
src/node_device/node_device_udev.c | 2 +-
src/nwfilter/Makefile.inc.am | 14 +
src/nwfilter/nwfilter_driver.c | 2 +-
src/qemu/Makefile.inc.am | 14 +
src/qemu/qemu_driver.c | 2 +-
src/remote/Makefile.inc.am | 153 ++++---
src/remote/{libvirtd.aug => libvirtd.aug.in} | 24 +-
.../{libvirtd.conf => libvirtd.conf.in} | 42 +-
src/remote/remote_daemon.c | 221 +++++++---
src/remote/remote_daemon_config.c | 41 +-
src/remote/remote_daemon_config.h | 9 +-
src/remote/remote_daemon_dispatch.c | 82 +++-
src/remote/remote_driver.c | 391 ++++++++++++------
src/remote/remote_driver.h | 4 -
src/remote/test_libvirtd.aug.in | 16 +-
src/rpc/virnetserver.c | 17 +
src/rpc/virnetserver.h | 3 +
src/secret/Makefile.inc.am | 14 +
src/secret/secret_driver.c | 2 +-
src/storage/Makefile.inc.am | 14 +
src/util/virlog.c | 20 +-
src/vbox/Makefile.inc.am | 14 +
src/vz/Makefile.inc.am | 14 +
src/vz/vz_driver.c | 2 +-
45 files changed, 938 insertions(+), 341 deletions(-)
rename src/remote/{libvirtd.aug => libvirtd.aug.in} (88%)
rename src/remote/{libvirtd.conf => libvirtd.conf.in} (95%)
--
2.21.0
5 years, 5 months
[libvirt] [PATCH 0/9] qemu: refactor fsdev formatting (virtio-fs epopee)
by Ján Tomko
Ján Tomko (9):
tests: qemu: minimize fs9p.xml
qemu: add CAPS_LATEST tests for 9pfs
qemu: address: remove useless comment
qemu: command: rename qemuBuildFSDevCommandLine
qemu: command: re-introduce qemuBuildFSDevCommandLine
qemu: command: use VIR_AUTOFREE in qemuBuildFSDevCommandLine
qemu: introduce qemuDomainDeviceDefValidateFS
qemu: command: use VIR_AUTOCLEAN in qemuBuildFS*
qemu: command: remove qemuDomainFSDriver
src/qemu/qemu_command.c | 111 ++++++------------
src/qemu/qemu_domain.c | 46 +++++++-
src/qemu/qemu_domain_address.c | 3 +-
.../fs9p-ccw.s390x-latest.args | 44 +++++++
tests/qemuxml2argvdata/fs9p.args | 6 +-
.../qemuxml2argvdata/fs9p.x86_64-latest.args | 41 +++++++
tests/qemuxml2argvdata/fs9p.xml | 9 +-
tests/qemuxml2argvtest.c | 2 +
8 files changed, 175 insertions(+), 87 deletions(-)
create mode 100644 tests/qemuxml2argvdata/fs9p-ccw.s390x-latest.args
create mode 100644 tests/qemuxml2argvdata/fs9p.x86_64-latest.args
--
2.19.2
5 years, 5 months
