June 2019 - Devel - libvirt List Archives

[libvirt] Plans for next release
by Daniel Veillard 25 Jun '19

25 Jun '19

Ideally if we want to push the next release on Monday, we should enter freeze tomorrow, then push Rc2 on Friday and then if everything goes well we can push 5.5.0 final next Monday. Hopefully that plan works for everyone, Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] [PATCH] qemu: distinguish pr disk before qemuHotplugRemoveManagedPR
by Jie Wang 25 Jun '19

25 Jun '19

when a disk without PR perform attach or detach operation, need not call qemuHotplugRemoveManagedPR, otherwise, it will print err log about PR, let us fix it. Signed-off-by: Jie Wang <wangjie88(a)huawei.com> --- src/qemu/qemu_hotplug.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index efda539..7ef92d0 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -928,7 +928,9 @@ qemuDomainAttachDiskGeneric(virQEMUDriverPtr driver, if (qemuDomainObjExitMonitor(driver, vm) < 0) ret = -2; - if (qemuHotplugRemoveManagedPR(driver, vm, QEMU_ASYNC_JOB_NONE) < 0) + + if (virStorageSourceChainHasManagedPR(disk->src) && + qemuHotplugRemoveManagedPR(driver, vm, QEMU_ASYNC_JOB_NONE) < 0) ret = -2; virDomainAuditDisk(vm, NULL, disk->src, "attach", false); @@ -4481,7 +4483,8 @@ qemuDomainRemoveDiskDevice(virQEMUDriverPtr driver, dev.data.disk = disk; ignore_value(qemuRemoveSharedDevice(driver, &dev, vm->def->name)); - if (qemuHotplugRemoveManagedPR(driver, vm, QEMU_ASYNC_JOB_NONE) < 0) + if (virStorageSourceChainHasManagedPR(disk->src) && + qemuHotplugRemoveManagedPR(driver, vm, QEMU_ASYNC_JOB_NONE) < 0) goto cleanup; ret = 0; -- 1.8.3.1

3 3

[libvirt] [PATCH] storage: omit comma for ceph mon hosts to librados
by Yi Li 25 Jun '19

25 Jun '19

Silly mistakes omit the comma for multiple ipaddr Fixes: cdd362e0e7a34d4f8f102c75f2ca513d23dd1db0 Signed-off-by: Yi Li <yili(a)winhong.com> --- src/storage/storage_backend_rbd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c index bd6e3d5..315bef2 100644 --- a/src/storage/storage_backend_rbd.c +++ b/src/storage/storage_backend_rbd.c @@ -272,10 +272,10 @@ virStorageBackendRBDOpenRADOSConn(virStorageBackendRBDStatePtr ptr, const char *incFormat; if (virSocketAddrNumericFamily(source->hosts[i].name) == AF_INET6) { /* IPv6 address must be escaped in brackets on the cmd line */ - incFormat = "[%s]:%d"; + incFormat = "[%s]:%d,"; } else { /* listenAddress is a hostname or IPv4 */ - incFormat = "%s:%d"; + incFormat = "%s:%d,"; } virBufferAsprintf(&mon_host, incFormat, source->hosts[i].name, -- 2.7.5

3 2

[libvirt] [PATCH] deprecate -mem-path fallback to anonymous RAM
by Igor Mammedov 25 Jun '19

25 Jun '19

Fallback might affect guest or worse whole host performance or functionality if backing file were used to share guest RAM with another process. Patch deprecates fallback so that we could remove it in future and ensure that QEMU will provide expected behavior and fail if it can't use user provided backing file. Signed-off-by: Igor Mammedov <imammedo(a)redhat.com> --- PS: Patch is written on top of [PATCH v4 0/3] numa: deprecate '-numa node, mem' and default memory distribution to avoid conflicts in qemu-deprecated.texi numa.c | 4 ++-- qemu-deprecated.texi | 8 ++++++++ 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/numa.c b/numa.c index 91a29138a2..53d67b8ad9 100644 --- a/numa.c +++ b/numa.c @@ -494,8 +494,8 @@ static void allocate_system_memory_nonnuma(MemoryRegion *mr, Object *owner, if (mem_prealloc) { exit(1); } - error_report("falling back to regular RAM allocation."); - + warn_report("falling back to regular RAM allocation. " + "Fallback to RAM allocation is deprecated."); /* Legacy behavior: if allocation failed, fall back to * regular RAM allocation. */ diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 2fe9b72121..2193705644 100644 --- a/qemu-deprecated.texi +++ b/qemu-deprecated.texi @@ -112,6 +112,14 @@ QEMU using implicit generic or board specific splitting rule. Use @option{memdev} with @var{memory-backend-ram} backend or @option{mem} (if it's supported by used machine type) to define mapping explictly instead. +@subsection -mem-path fallback to RAM (since 4.1) +Currently if system memory allocation from file pointed by @option{mem-path} +fails, QEMU fallbacks to allocating from anonymous RAM. Which might result +in unpredictable behavior since provided backing file wasn't used. In future +QEMU will not fallback and fail to start up, so user could fix his/her QEMU/host +configuration or explicitly use -m without -mem-path if system memory allocated +from anonymous RAM suits usecase. + @section QEMU Machine Protocol (QMP) commands @subsection block-dirty-bitmap-add "autoload" parameter (since 2.12.0) -- 2.18.1

4 8

[libvirt] [PATCH v2 0/6] cgroups v2 fixes and improvements
by Pavel Hrdina 25 Jun '19

25 Jun '19

Pavel Hrdina (6): util: vircgroup: pass parent cgroup into virCgroupDetectControllersCB util: vircgroup: improve controller detection util: vircgroupv2: use any controller to create thread directory util: vircgroupv2: enable CPU controller only if it's available util: vircgroupv2: separate return values of virCgroupV2EnableController util: vircgroupv2: don't error out if enabling controller fails src/util/vircgroup.c | 32 ++++++++++---------- src/util/vircgroupbackend.h | 3 +- src/util/vircgroupv1.c | 3 +- src/util/vircgroupv2.c | 59 +++++++++++++++++++++++++++++-------- 4 files changed, 66 insertions(+), 31 deletions(-) -- 2.21.0

1 7

[libvirt] [PATCH 0/3] conf: Fix parsing of <disk> <seclabel> (blockdev-add saga)
by Peter Krempa 25 Jun '19

25 Jun '19

The parser for the seclabel would mess up context leaving disk source private data unparsed. Peter Krempa (3): tests: qemustatusxml2xml: Split out the output file for 'modern' test tests: qemustatusxml2xml: Add a seclabel for a disk with privateData conf: domain: Restore XPath context after virSecurityDeviceLabelDefParseXML src/conf/domain_conf.c | 1 + tests/qemustatusxml2xmldata/modern-in.xml | 3 + tests/qemustatusxml2xmldata/modern-out.xml | 474 ++++++++++++++++++++- 3 files changed, 477 insertions(+), 1 deletion(-) mode change 120000 => 100644 tests/qemustatusxml2xmldata/modern-out.xml -- 2.21.0

2 8

[libvirt] [PATCH 5/6] docs: Deprecate CPU model runnability guarantees
by Eduardo Habkost 25 Jun '19

25 Jun '19

Document that CPU model runnability guarantees won't apply to unversioned CPU models anymore. Signed-off-by: Eduardo Habkost <ehabkost(a)redhat.com> --- Cc: libvir-list(a)redhat.com --- qemu-deprecated.texi | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index df04f2840b..5fafb62a6d 100644 --- a/qemu-deprecated.texi +++ b/qemu-deprecated.texi @@ -243,3 +243,22 @@ Note that if you are exposing the export via /dev/nbd0, it is easier to just export the entire image and then mount only /dev/nbd0p1 than it is to reinvoke @command{qemu-nbd -c /dev/nbd0} limited to just a subset of the image. + +@section Backwards compatibility + +@subsection Runnability guarantee of CPU models (since 4.1.0) + +Previous versions of QEMU never changed existing CPU models in +ways that introduced additional host software or hardware +requirements to the VM. This allowed management software to +safely change the machine type of an existing VM without +introducing new requirements ("runnability guarantee"). This +prevented CPU models from being updated to include CPU +vulnerability mitigations, leaving guests vulnerable in the +default configuration. + +The CPU model runnability guarantee won't apply anymore to +existing CPU models. Management software that needs runnability +guarantees must resolve the CPU model aliases using te +``alias-of'' field returned by the ``query-cpu-definitions'' QMP +command. -- 2.18.0.rc1.1.g3f1ff2140

1 0

[libvirt] [PATCH 0/2] test_driver: A couple of small changes in testDomainInterfaceAddresses
by Ilias Stamatis 25 Jun '19

25 Jun '19

Ilias Stamatis (2): test_driver: use addr_offset for non-network infs too test_driver: use virDomainNetDefPtr instead of virDomainNetDef * src/test/test_driver.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) -- 2.22.0

1 2

[libvirt] [PATCH v2] test_driver: implement virNetworkGetDHCPLeases
by Ilias Stamatis 25 Jun '19

25 Jun '19

Signed-off-by: Ilias Stamatis <stamatis.iliass(a)gmail.com> --- src/test/test_driver.c | 141 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 141 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 4b1f2724a0..180940f859 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -4072,6 +4072,146 @@ testNetworkSetAutostart(virNetworkPtr net, } +static int +testNetworkGetDHCPLeases(virNetworkPtr net, + const char *mac, + virNetworkDHCPLeasePtr **leases, + unsigned int flags) +{ + int ret = -1; + int ndomains = 0; + size_t i, j; + size_t nleases = 0; + size_t addr_offset; + bool need_results = !!leases; + char *hostname = NULL; + VIR_AUTOFREE(char *) bridge_name = NULL; + char mac_str[VIR_MAC_STRING_BUFLEN]; + virMacAddr mac_addr; + virDomainObjPtr vm = NULL; + virDomainPtr *domains = NULL; + virDomainNetDefPtr inf = NULL; + virNetworkObjPtr obj = NULL; + virNetworkDefPtr obj_def = NULL; + virNetworkDHCPLeasePtr lease = NULL; + virNetworkDHCPLeasePtr *leases_ret = NULL; + virDomainInterfacePtr iface = NULL; + testDriverPtr privconn = net->conn->privateData; + + virCheckFlags(0, -1); + + if (mac && virMacAddrParse(mac, &mac_addr) < 0) { + virReportError(VIR_ERR_INVALID_MAC, "%s", mac); + return -1; + } + + if (!(obj = testNetworkObjFindByName(privconn, net->name))) + return -1; + + obj_def = virNetworkObjGetDef(obj); + + if (VIR_STRDUP(bridge_name, obj_def->bridge) < 0) + goto cleanup; + + virNetworkObjEndAPI(&obj); + + if ((ndomains = virDomainObjListExport(privconn->domains, net->conn, &domains, + NULL, VIR_CONNECT_LIST_DOMAINS_ACTIVE)) < 0) + goto cleanup; + + for (i = 0; i < ndomains; i++) { + /* the following must be called before testDomObjFromDomain */ + hostname = testDomainGetHostname(domains[i], 0); + + if (!(vm = testDomObjFromDomain(domains[i]))) + continue; + + for (j = 0; j < vm->def->nnets; j++) { + inf = vm->def->nets[j]; + + if (STRNEQ(inf->data.network.name, net->name)) + continue; + + virMacAddrFormat(&inf->mac, mac_str); + if (mac && virMacAddrCompare(mac, mac_str)) + continue; + + if (!need_results) { + nleases++; + continue; + } + + if (VIR_ALLOC(lease) < 0 || VIR_ALLOC(iface) < 0 || VIR_ALLOC(iface->addrs) < 0) + goto error; + iface->naddrs = 1; + + /* should be the same value as in testDomainInterfaceAddresses */ + addr_offset = 20 * (vm->def->id - 1) + j + 1; + if (testDomainInterfaceAddressFromNet(privconn, inf, addr_offset, iface) < 0) + goto error; + + if (VIR_STRDUP(lease->mac, mac_str) < 0 || + VIR_STRDUP(lease->iface, bridge_name) < 0 || + VIR_STRDUP(lease->hostname, hostname) < 0 || + VIR_STRDUP(lease->ipaddr, iface->addrs->addr) < 0) + goto error; + + lease->prefix = iface->addrs->prefix; + lease->type = iface->addrs->type; + + virDomainInterfaceFree(iface); + iface = NULL; + + lease->expirytime = 0; + + lease->iaid = NULL; + if (lease->type == VIR_IP_ADDR_TYPE_IPV6) { + if (VIR_STRDUP(lease->clientid, + "00:01:00:01:16:C1:BA:6E:08:00:27:30:C3:B8") < 0) + goto error; + } else { + lease->clientid = NULL; + } + + if (VIR_INSERT_ELEMENT(leases_ret, nleases, nleases, lease) < 0) + goto error; + } + + VIR_FREE(hostname); + virDomainObjEndAPI(&vm); + } + + if (leases_ret) { + /* NULL terminated array */ + ignore_value(VIR_REALLOC_N(leases_ret, nleases + 1)); + VIR_STEAL_PTR(*leases, leases_ret); + } + + ret = nleases; + + cleanup: + for (i = 0; i < ndomains; i++) + virDomainFree(domains[i]); + + VIR_FREE(domains); + VIR_FREE(lease); + VIR_FREE(hostname); + + virNetworkObjEndAPI(&obj); + virDomainInterfaceFree(iface); + virDomainObjEndAPI(&vm); + return ret; + + error: + if (leases_ret) { + for (i = 0; i < nleases; i++) + virNetworkDHCPLeaseFree(leases_ret[i]); + VIR_FREE(leases_ret); + } + goto cleanup; +} + + /* * Physical host interface routines */ @@ -7359,6 +7499,7 @@ static virNetworkDriver testNetworkDriver = { .networkGetBridgeName = testNetworkGetBridgeName, /* 0.3.2 */ .networkGetAutostart = testNetworkGetAutostart, /* 0.3.2 */ .networkSetAutostart = testNetworkSetAutostart, /* 0.3.2 */ + .networkGetDHCPLeases = testNetworkGetDHCPLeases, /* 5.5.0 */ .networkIsActive = testNetworkIsActive, /* 0.7.3 */ .networkIsPersistent = testNetworkIsPersistent, /* 0.7.3 */ }; -- 2.22.0

1 1

[libvirt] [PATCH 1/1] virpci: report dev->name in virPCIGetHeaderType error message
by Daniel Henrique Barboza 25 Jun '19

25 Jun '19

Trivial change. Adding the name of the device that has an unknown PCI header type in that function helps when debugging PCI code. Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com> --- src/util/virpci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/virpci.c b/src/util/virpci.c index 8f2936c23a..75e8daadd5 100644 --- a/src/util/virpci.c +++ b/src/util/virpci.c @@ -3239,7 +3239,8 @@ int virPCIGetHeaderType(virPCIDevicePtr dev, int *hdrType) type &= PCI_HEADER_TYPE_MASK; if (type >= VIR_PCI_HEADER_LAST) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Unknown PCI header type '%d'"), type); + _("Unknown PCI header type '%d' for device '%s'"), + type, dev->name); return -1; } -- 2.20.1

2 1