[libvirt] [PATCH 1/1] qemu_command: tidy up qemuBuildHostdevCommandLine loop
by Daniel Henrique Barboza
The current 'for' loop with 5 consecutive 'ifs' inside
qemuBuildHostdevCommandLine can be a bit smarter:
- all 5 'ifs' fails if hostdev->mode is not equal to
VIR_DOMAIN_HOSTDEV_MODE_SUBSYS. This check can be moved to the
start of the loop, failing to the next element immediately
in case it fails;
- all 5 'ifs' checks for a specific subsys->type to build the proper
command line argument (virHostdevIsSCSIDevice and virHostdevIsMdevDevice
do that but within a helper). Problem is that the code will keep
checking for matches even if one was already found, and there is
no way a hostdev will fit more than one 'if' (i.e. a hostdev can't
have 2+ different types). This means that a SUBSYS_TYPE_USB will
create its command line argument in the first 'if', then all other
conditionals will surely fail but will end up being checked anyway.
This can be avoided by adding 'continue' statements inside the first
4 conditionals.
Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com>
---
Arguably safe for freeze since it's trivial, but not a deal
breaker if postponed. I am fine with both.
src/qemu/qemu_command.c | 20 ++++++++++++++------
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 8c979fdf65..0357481dd1 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -5471,20 +5471,23 @@ qemuBuildHostdevCommandLine(virCommandPtr cmd,
virDomainHostdevSubsysPtr subsys = &hostdev->source.subsys;
VIR_AUTOFREE(char *) devstr = NULL;
+ if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS)
+ continue;
+
/* USB */
- if (hostdev->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS &&
- subsys->type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB) {
+ if (subsys->type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB) {
virCommandAddArg(cmd, "-device");
if (!(devstr =
qemuBuildUSBHostdevDevStr(def, hostdev, qemuCaps)))
return -1;
virCommandAddArg(cmd, devstr);
+
+ continue;
}
/* PCI */
- if (hostdev->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS &&
- subsys->type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI) {
+ if (subsys->type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI) {
int backend = subsys->u.pci.backend;
if (backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO) {
@@ -5514,6 +5517,8 @@ qemuBuildHostdevCommandLine(virCommandPtr cmd,
if (!devstr)
return -1;
virCommandAddArg(cmd, devstr);
+
+ continue;
}
/* SCSI */
@@ -5543,11 +5548,12 @@ qemuBuildHostdevCommandLine(virCommandPtr cmd,
if (!(devstr = qemuBuildSCSIHostdevDevStr(def, hostdev)))
return -1;
virCommandAddArg(cmd, devstr);
+
+ continue;
}
/* SCSI_host */
- if (hostdev->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS &&
- subsys->type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI_HOST) {
+ if (subsys->type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI_HOST) {
if (hostdev->source.subsys.u.scsi_host.protocol ==
VIR_DOMAIN_HOSTDEV_SUBSYS_SCSI_HOST_PROTOCOL_TYPE_VHOST) {
VIR_AUTOFREE(char *) vhostfdName = NULL;
@@ -5573,6 +5579,8 @@ qemuBuildHostdevCommandLine(virCommandPtr cmd,
virCommandAddArg(cmd, devstr);
}
+
+ continue;
}
/* MDEV */
--
2.21.0
5 years, 2 months
[libvirt] [PATCH v2 0/1] virsh: fixed handling of sourceless disks in 'domblkinfo' cmd
by Pavel Mores
Integrating feedback to the original version.
This changes the approach to fixing the problem - previously, we called
virDomainGetBlockInfo() and if it failed, we mitigated the failure for CDROMs
and floppies specifically. Now we first check for existence of a <source>
element in the corresponding XML and if we find none, we avoid calling
virDomainGetBlockInfo() altogether as we know it's bound to fail in that case.
The benefit is that whereas the previous fix swallowed all errors concerning
CDROMs and floppies - not just missing <source> - this one only handles
missing <source> specifically and doesn't mask other problems that might come
up.
The patch itself is fairly simple, unfortunately some noise is caused by
additional indentation of code related to the virDomainGetBlockInfo() call.
That code should however be unchanged (apart from reformating a comment to
keep line lengths under 80 chars).
Pavel Mores (1):
fixed handling of sourceless disks in 'domblkinfo' cmd
tools/virsh-domain-monitor.c | 33 ++++++++++++++++++++-------------
1 file changed, 20 insertions(+), 13 deletions(-)
--
2.21.0
5 years, 2 months
[libvirt] [PATCH 0/5] build: eliminate more redundant/obsolete gnulib modules
by Daniel P. Berrangé
A follow up to my previous series that was already pushed. This
identifies some more unused modules, or things that are easily
replaced.
Daniel P. Berrangé (5):
build: remove all gnulib bit manipulation modules
build: drop the ignore-value gnulib module
build: drop the ldexp gnulib module
build: drop the isatty gnulib module
build: remove the sched gnulib module
bootstrap.conf | 9 ---------
src/conf/capabilities.c | 3 +--
src/conf/domain_conf.c | 1 -
src/conf/snapshot_conf.c | 1 -
src/internal.h | 18 +++++++++++++++---
src/libxl/xen_common.c | 1 -
src/util/Makefile.inc.am | 1 +
src/util/virbitmap.c | 7 +++----
src/util/vircgroupv2.c | 2 +-
src/util/virhashcode.c | 6 +++++-
src/util/virhostcpu.c | 1 -
src/util/virhostmem.c | 1 -
src/util/virrandom.c | 4 +---
tools/vsh.c | 2 +-
14 files changed, 28 insertions(+), 29 deletions(-)
--
2.21.0
5 years, 2 months
[libvirt] [PATCH] qemu: capabilities: Fill in bochs-display info
by Fabiano Fidêncio
086c19d69 added bochs-display capability but didn't fill in the info for
domain capabilities.
Signed-off-by: Fabiano Fidêncio <fidencio(a)redhat.com>
---
src/qemu/qemu_capabilities.c | 2 ++
tests/domaincapsschemadata/qemu_3.1.0.x86_64.xml | 1 +
tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml | 1 +
tests/domaincapsschemadata/qemu_4.1.0.x86_64.xml | 1 +
tests/domaincapsschemadata/qemu_4.2.0.x86_64.xml | 1 +
5 files changed, 6 insertions(+)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 3b50576a2b..d0b789bbea 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -5357,6 +5357,8 @@ virQEMUCapsFillDomainDeviceVideoCaps(virQEMUCapsPtr qemuCaps,
VIR_DOMAIN_CAPS_ENUM_SET(dev->modelType, VIR_DOMAIN_VIDEO_TYPE_QXL);
if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VIRTIO_GPU))
VIR_DOMAIN_CAPS_ENUM_SET(dev->modelType, VIR_DOMAIN_VIDEO_TYPE_VIRTIO);
+ if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_BOCHS_DISPLAY))
+ VIR_DOMAIN_CAPS_ENUM_SET(dev->modelType, VIR_DOMAIN_VIDEO_TYPE_BOCHS);
return 0;
}
diff --git a/tests/domaincapsschemadata/qemu_3.1.0.x86_64.xml b/tests/domaincapsschemadata/qemu_3.1.0.x86_64.xml
index 402848442f..059403cebc 100644
--- a/tests/domaincapsschemadata/qemu_3.1.0.x86_64.xml
+++ b/tests/domaincapsschemadata/qemu_3.1.0.x86_64.xml
@@ -127,6 +127,7 @@
<value>vmvga</value>
<value>qxl</value>
<value>virtio</value>
+ <value>bochs</value>
</enum>
</video>
<hostdev supported='yes'>
diff --git a/tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml b/tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml
index 1ffd5e3cc0..eb24b9a604 100644
--- a/tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml
+++ b/tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml
@@ -127,6 +127,7 @@
<value>vmvga</value>
<value>qxl</value>
<value>virtio</value>
+ <value>bochs</value>
</enum>
</video>
<hostdev supported='yes'>
diff --git a/tests/domaincapsschemadata/qemu_4.1.0.x86_64.xml b/tests/domaincapsschemadata/qemu_4.1.0.x86_64.xml
index 79b41ef6da..f5685d2068 100644
--- a/tests/domaincapsschemadata/qemu_4.1.0.x86_64.xml
+++ b/tests/domaincapsschemadata/qemu_4.1.0.x86_64.xml
@@ -131,6 +131,7 @@
<value>vmvga</value>
<value>qxl</value>
<value>virtio</value>
+ <value>bochs</value>
</enum>
</video>
<hostdev supported='yes'>
diff --git a/tests/domaincapsschemadata/qemu_4.2.0.x86_64.xml b/tests/domaincapsschemadata/qemu_4.2.0.x86_64.xml
index 6bdeb20479..5bd376bb2e 100644
--- a/tests/domaincapsschemadata/qemu_4.2.0.x86_64.xml
+++ b/tests/domaincapsschemadata/qemu_4.2.0.x86_64.xml
@@ -131,6 +131,7 @@
<value>vmvga</value>
<value>qxl</value>
<value>virtio</value>
+ <value>bochs</value>
</enum>
</video>
<hostdev supported='yes'>
--
2.23.0
5 years, 2 months
[libvirt] Release of libvirt-5.8.0
by Daniel Veillard
So it's out, a bit late but better than never, without release notes
but after all everything is described in the commits, so here is a very
raw 5.8.0 release, it's tagged in git and signed sources and tarball
are available at the usual place:
https://libvirt.org/sources/
I also made python binding release that you can find at:
https://libvirt.org/sources/python
So the only thing listed in the release notes is
Removed features:
- Remove xenapi driver
The xenapi driver is removed since it has not received any significant
development since its initial contribution nine years ago and has no
known user base.
Glancing at the commit list, there is a lot of refactoring going on
which I assume don't have any visible user impact.
I would suggest users look at the new development strategy document,
https://libvirt.org/strategy.html
TBH since I started the project 14 or so years ago the core assumption
have been kept, but this indicates willingness to change some of the
directions by the current group of developers, one of the key point is
articulated there:
"There is thus a desire to make use of either Rust or Go, or a
combination of both, to incrementally replace existing use of C,
and also for greenfield development."
So if anybody mourns the absence of the release note for 5.8.0, I suggest
to instead takes the couple of minutes it takes to read the above page,
that will be well invested time !
Enjoy the release !
Daniel
--
Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/
veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | virtualization library http://libvirt.org/
5 years, 2 months
[libvirt] [PATCH 0/5] tests: Clean up some unused test files
by Peter Krempa
Some files were left behind when we deleted the qemu argv parser and few
other ones were missed when modifying tests.
Peter Krempa (5):
tests: qemuxml2argv: Remove unused data for 'serial-pty'
tests: qemuxml2argv: Remove unused data for 'pseries-disk'
tests: qemuxml2argv: Remove unused data for s390 keywrap
tests: qemuxml2argv: Remove unused output of 'mlock-on' legacy test
tests: qemuxml2argv: Make use of versioned cpu-tsc-frequency and
cpu-host-model-cmt tests
.../cpu-tsc-frequency.x86_64-4.0.0.args | 4 +-
.../machine-aeskeywrap-off-argv.args | 20 ---------
.../machine-aeskeywrap-off-argv.xml | 27 ------------
.../machine-aeskeywrap-on-argv.args | 20 ---------
.../machine-aeskeywrap-on-argv.xml | 27 ------------
.../machine-deakeywrap-off-argv.args | 20 ---------
.../machine-deakeywrap-off-argv.xml | 27 ------------
.../machine-deakeywrap-on-argv.args | 20 ---------
.../machine-deakeywrap-on-argv.xml | 27 ------------
.../machine-keywrap-none-argv.args | 20 ---------
.../machine-keywrap-none-argv.xml | 24 -----------
tests/qemuxml2argvdata/mlock-on.args | 27 ------------
tests/qemuxml2argvdata/pseries-disk.args | 18 --------
tests/qemuxml2argvdata/pseries-disk.xml | 42 -------------------
tests/qemuxml2argvdata/serial-pty.args | 24 -----------
tests/qemuxml2argvdata/serial-pty.xml | 36 ----------------
tests/qemuxml2argvtest.c | 2 +
17 files changed, 4 insertions(+), 381 deletions(-)
delete mode 100644 tests/qemuxml2argvdata/machine-aeskeywrap-off-argv.args
delete mode 100644 tests/qemuxml2argvdata/machine-aeskeywrap-off-argv.xml
delete mode 100644 tests/qemuxml2argvdata/machine-aeskeywrap-on-argv.args
delete mode 100644 tests/qemuxml2argvdata/machine-aeskeywrap-on-argv.xml
delete mode 100644 tests/qemuxml2argvdata/machine-deakeywrap-off-argv.args
delete mode 100644 tests/qemuxml2argvdata/machine-deakeywrap-off-argv.xml
delete mode 100644 tests/qemuxml2argvdata/machine-deakeywrap-on-argv.args
delete mode 100644 tests/qemuxml2argvdata/machine-deakeywrap-on-argv.xml
delete mode 100644 tests/qemuxml2argvdata/machine-keywrap-none-argv.args
delete mode 100644 tests/qemuxml2argvdata/machine-keywrap-none-argv.xml
delete mode 100644 tests/qemuxml2argvdata/mlock-on.args
delete mode 100644 tests/qemuxml2argvdata/pseries-disk.args
delete mode 100644 tests/qemuxml2argvdata/pseries-disk.xml
delete mode 100644 tests/qemuxml2argvdata/serial-pty.args
delete mode 100644 tests/qemuxml2argvdata/serial-pty.xml
--
2.21.0
5 years, 2 months
[libvirt] [PATCH v5 00/15] CPU Model Baseline and Comparison for s390x
by Collin Walling
Note: since I've made some changes to a lot of these patches / split
up some patches, I've decided to hold off on adding any r-b's in case
there is a specific change that someone does not agree with.
Changelog:
- Properly refactored code from CPU model expansion function
- Introduced a cleanup patch for CPU model expansion function
- Introduced patches that modifies the refactored code to suit
needs for baseline/comparison
- CPU expansion function now accepts a virCPUDefPtr
- Removed props parsing from CPU model comparison (they weren't
used)
- Cleaner error reporting when baselining/comparing with erroneous
CPU models / features
- Various cleanups based on feedback
___
To run these patches, execute the virsh hypervisor-cpu-compare or
hypervisor-cpu-baseline commands and pass an XML file describing one or
more CPU definition. You can use the definition from virsh domcapabilities
or from a guest XML. There is no need extract it from the file and place
it a new one, as the XML parser will look specifically for the CPU tags.
___
These patches hookup the virsh hypervisor-cpu-compare/baseline commands
for the s390x architecture. They take an XML file describing some CPU
definitions and passes the data to QEMU, where the actual CPU model
comparison / baseline calculation is handled (available since QEMU 2.8.5).
When baselining CPU models with the --features argument, s390x will report
a full CPU model expansion.
Thanks.
Collin Walling (15):
qemu_monitor: refactor cpu model expansion
qemu_monitor: expansion cleanups
qemu_monitor: use cpu def instead of char for expansion
qemu_monitor: add features to CPU model for QMP command
qemu_monitor: allow cpu props to be optional
qemu_monitor: make qemuMonitorJSONParseCPUModelData command-agnostic
qemu_monitor: implement query-cpu-model-baseline
qemu_capabilities: introduce QEMU_CAPS_QUERY_CPU_MODEL_BASELINE
qemu_driver: hook up query-cpu-model-baseline
qemu_driver: expand cpu features after baseline
qemu_monitor: implement query-cpu-model-comparison
qemu_capabilities: introduce QEMU_CAPS_QUERY_CPU_MODEL_COMPARISON
cpu_conf: xml to cpu definition parse helper
qemu_driver: hook up query-cpu-model-comparison
qemu_driver: improve comparison/baseline error reporting
src/conf/cpu_conf.c | 29 +++
src/conf/cpu_conf.h | 5 +
src/cpu/cpu.c | 14 +-
src/libvirt_private.syms | 1 +
src/qemu/qemu_capabilities.c | 21 +-
src/qemu/qemu_capabilities.h | 4 +
src/qemu/qemu_driver.c | 215 +++++++++++++++++
src/qemu/qemu_monitor.c | 39 +++-
src/qemu/qemu_monitor.h | 13 +-
src/qemu/qemu_monitor_json.c | 279 +++++++++++++++++------
src/qemu/qemu_monitor_json.h | 17 +-
tests/cputest.c | 11 +-
tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml | 2 +
tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 2 +
tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml | 2 +
tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 2 +
tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml | 2 +
tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml | 2 +
tests/qemucapabilitiesdata/caps_4.0.0.s390x.xml | 2 +
19 files changed, 573 insertions(+), 89 deletions(-)
--
2.7.4
5 years, 2 months
[libvirt] [PATCH] maint: Post-release version bump to 5.9.0
by Peter Krempa
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
configure.ac | 2 +-
docs/news.xml | 8 ++++++++
2 files changed, 9 insertions(+), 1 deletion(-)
Pushed now.
diff --git a/configure.ac b/configure.ac
index af8cbcdfd8..5269db425c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -16,7 +16,7 @@ dnl You should have received a copy of the GNU Lesser General Public
dnl License along with this library. If not, see
dnl <http://www.gnu.org/licenses/>.
-AC_INIT([libvirt], [5.8.0], [libvir-list(a)redhat.com], [], [https://libvirt.org])
+AC_INIT([libvirt], [5.9.0], [libvir-list(a)redhat.com], [], [https://libvirt.org])
AC_CONFIG_SRCDIR([src/libvirt.c])
AC_CONFIG_AUX_DIR([build-aux])
AC_CONFIG_HEADERS([config.h])
diff --git a/docs/news.xml b/docs/news.xml
index 70c325795e..9fd8f65515 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -39,6 +39,14 @@
-->
<libvirt>
+ <release version="v5.9.0" date="unreleased">
+ <section title="New features">
+ </section>
+ <section title="Improvements">
+ </section>
+ <section title="Bug fixes">
+ </section>
+ </release>
<release version="v5.8.0" date="2019-10-05">
<section title="Removed features">
<change>
--
2.21.0
5 years, 2 months
[libvirt] libvirt? qemu change that mmaps ELF files breaks libvirt svirt handling for os.kernel
by Christian Borntraeger
Stefano, Paolo,
I have an interesting fail in QEMU
2019-10-04T12:00:32.675188Z qemu-system-s390x: GLib: g_mapped_file_unref: assertion 'file != NULL' failed
that bisected to
commit 816b9fe450220e19acb91a0ce4a8ade7000648d1 (refs/bisect/bad)
elf-ops.h: Map into memory the ELF to load
strace tells that I can read the ELF file, but not mmap
strace:
214365 openat(AT_FDCWD, "/var/lib/libvirt/images/test_cpu_timer.elf", O_RDONLY) = 36
214365 read(46, "\177ELF\2\2\1\0\0\0\0\0\0\0\0\0", 16) = 16
214365 lseek(46, 0, SEEK_SET) = 0
[...]
214365 fstat(46, {st_mode=S_IFREG|0755, st_size=168176, ...}) = 0
214365 mmap(NULL, 168176, PROT_READ|PROT_WRITE, MAP_PRIVATE, 46, 0) = -1 EACCES (Permission denied)
So reading from /var/lib/libvirt/images/test_cpu_timer.elf does work, mmaping does not.
setenforce 0 makes the problem go away.
This might be more of an issue in libvirt, setting the svirt context too
restrictive, but I am not too deep into the svirt part of libvirt.
Reverting the qemu commit makes the problem go away.
5 years, 2 months
[libvirt] [PATCH 00/11] Integrate usage of glib into libvirt
by Daniel P. Berrangé
This is a followup to a previous patch series:
https://www.redhat.com/archives/libvir-list/2019-August/msg01374.html
The first abort-on-oom parts of that series merged already.
As well as fixing the issues mentioned last time, the glib parts now do
a little more:
- Demonstrate conversion of virObject to GObject
- Convert to gbase64 APIs
- Start to convert getopt to GOptionContext
I have explicitly now confirmed we can freely mix g_malloc/malloc and
g_free/free, given our min glib version.
my intention with the glib code will be to focus on converting bits of
code that allow us to eliminate gnulib modules.
About 50% of the gnulib stuff is related to the Windows portability
for sockets() and poll(). We can address this by integrate the
event loop with GMainLoop, and using GIO for its GSocket APIs.
The other gnulib stuff is a random bag of APIs. Some may be replaced
by glib APIs, for others we can pull the gnulib fix straight into
libvirt, for others the portability problems might be obsolete.
Daniel P. Berrangé (11):
build: probe for glib-2 library in configure
build: link to glib, gobject, gio libraries
remote: don't pull anonymous enums into rpc protocol structs
util: use glib memory allocation functions
util: use glib string allocation/formatting functions
util: use glib base64 encoding/decoding APIs
util: convert virIdentity class to use GObject
src: convert over to use GRegex for regular exprssions
virsh: convert command line parsing to use GOptionContext
virt-admin: convert command line parsing to use GOptionContext
virt-login-shell: convert command line parsing to use GOptionContext
bootstrap.conf | 5 -
configure.ac | 2 +
libvirt.spec.in | 1 +
m4/virt-glib.m4 | 36 ++++
mingw-libvirt.spec.in | 2 +
src/Makefile.am | 5 +-
src/access/viraccessdriverpolkit.c | 21 +-
src/admin/admin_server.c | 3 +-
src/admin_protocol-structs | 9 -
src/conf/domain_event.c | 25 +--
src/conf/virsecretobj.c | 38 +---
src/internal.h | 1 +
src/libvirt_private.syms | 1 -
src/libxl/libxl_capabilities.c | 44 ++--
src/libxl/libxl_conf.c | 3 +-
src/lxc/Makefile.inc.am | 2 +
src/qemu/qemu_agent.c | 9 +-
src/qemu/qemu_command.c | 5 +-
src/qemu/qemu_domain.c | 8 +-
src/qemu/qemu_process.c | 4 +-
src/remote/Makefile.inc.am | 1 +
src/remote/remote_daemon.c | 3 +-
src/remote/remote_daemon_dispatch.c | 35 ++--
src/remote_protocol-structs | 9 -
src/rpc/virnetserverclient.c | 57 +++---
src/rpc/virnetserverprogram.c | 13 +-
src/secret/secret_driver.c | 1 -
src/storage/storage_backend_rbd.c | 4 +-
src/util/Makefile.inc.am | 1 +
src/util/viralloc.c | 29 +--
src/util/viridentity.c | 87 ++++----
src/util/viridentity.h | 7 +-
src/util/virstring.c | 40 +---
src/util/virstring.h | 2 -
tests/Makefile.am | 3 +-
tests/viridentitytest.c | 45 ++---
tests/virnetserverclienttest.c | 3 +-
tools/Makefile.am | 1 +
tools/virsh-secret.c | 17 +-
tools/virsh.c | 303 +++++++++++++---------------
tools/virt-admin.c | 207 +++++++++----------
tools/virt-login-shell-helper.c | 66 ++----
42 files changed, 495 insertions(+), 663 deletions(-)
create mode 100644 m4/virt-glib.m4
--
2.21.0
5 years, 2 months