October 2019 - Devel - libvirt List Archives

[libvirt] [PATCH v2 0/5] build: take full ownership of syntax-check from gnulib
by Daniel P. Berrangé 09 Oct '19

09 Oct '19

Our syntax-check rule relies in various files imported during the gnulib bootstrap process. As we switch to meson & try to eliminate gnulib, we need to take ownership of syntax-check. This patch series follows the approach taken for libosinfo & other projects wrt syntax-check rules, but goes a step further and eliminates alot of baggage we don't care about & merges all logic into one file. Changed in v2: - Keep a top level GNUmakefile to preserve the hack that forced serialization of build targets Daniel P. Berrangé (5): build: import gnulib's syntax-check make rules build: move syntax-check code into build-aux directory build: remove all logic unrelated to syntax-check build: delete all syntax check rules we're skipping build: merge all syntax-check logic into one file .gitignore | 9 +- GNUmakefile | 74 ++ Makefile.am | 7 +- bootstrap.conf | 4 - cfg.mk => build-aux/syntax-check.mk | 1122 +++++++++++++++++++++++++-- build-aux/useless-if-before-free | 226 ++++++ build-aux/vc-list-files | 113 +++ configure.ac | 6 + 8 files changed, 1482 insertions(+), 79 deletions(-) create mode 100644 GNUmakefile rename cfg.mk => build-aux/syntax-check.mk (53%) create mode 100755 build-aux/useless-if-before-free create mode 100755 build-aux/vc-list-files -- 2.21.0

2 6

[libvirt] [jenkins-ci PATCH] lcitool: Fix pip handling in Dockerfiles
by Andrea Bolognani 09 Oct '19

09 Oct '19

We're currently only installing pip packages for cross-build Dockerfiles, which was obviously not the original intention. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. guests/lcitool | 28 ++++++++++++---------------- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/guests/lcitool b/guests/lcitool index 2c08455..a3ef137 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -705,18 +705,6 @@ class Application: {package_manager} autoremove -y && \\ {package_manager} autoclean -y """).format(**varmap)) - - if pip_pkgs: - sys.stdout.write(textwrap.dedent(""" - RUN pip3 install {pip_pkgs} - """).format(**varmap)) - - sys.stdout.write(textwrap.dedent(""" - ENV ABI "{cross_abi}" - ENV CONFIGURE_OPTS "--host={cross_abi} \\ - --target={cross_abi}" - ENV PKG_CONFIG_LIBDIR "/usr/lib/{cross_lib}/pkgconfig" - """).format(**varmap)) elif package_format == "rpm": if os_name == "Fedora" and os_version == "Rawhide": sys.stdout.write(textwrap.dedent(""" @@ -734,10 +722,18 @@ class Application: {package_manager} clean all -y """).format(**varmap)) - if pip_pkgs: - sys.stdout.write(textwrap.dedent(""" - RUN pip3 install {pip_pkgs} - """).format(**varmap)) + if pip_pkgs: + sys.stdout.write(textwrap.dedent(""" + RUN pip3 install {pip_pkgs} + """).format(**varmap)) + + if args.cross_arch: + sys.stdout.write(textwrap.dedent(""" + ENV ABI "{cross_abi}" + ENV CONFIGURE_OPTS "--host={cross_abi} \\ + --target={cross_abi}" + ENV PKG_CONFIG_LIBDIR "/usr/lib/{cross_lib}/pkgconfig" + """).format(**varmap)) def run(self): args = self._parser.parse_args() -- 2.21.0

1 0

[libvirt] [jenkins-ci PATCH v3 00/12] Meson, more meson!
by Fabiano Fidêncio 09 Oct '19

09 Oct '19

The first 5 patches in the series are adding the machinery for installing meson via pip, which will be needed for systems which do not have the minimum required version, as CentOS 7, Debian 9, Ubuntu 16, and Ubuntu 18. Next 3 patches build and test osinfo-db-tools, osinfo-db, and libosinfo on all supported machines as those now have the minimum requirements needed. Following these patches, there's a patch re-enabling virt-manager builds on the systems which are, again, building libosinfo. Next 2 are basically re-enabling syntax-check job for libvirt-dbus on CentOS 7 and removing some misleading comment. Finally, last patch in the series does the libvirt-dbus builds switch to using meson instead of autotools. This version addresses the comments raised by Andrea during v2. Daniel P. Berrangé (1): guests: add flake8 to libvirt project Fabiano Fidêncio (11): mappings: Add python2-setuptools guests: Add python2-setuptools to the base project mappings: Add python3-pip guests: Add python3-pip to the base project guests: Install meson via pip osinfo-db-tools: Build again on all machines osinfo-db: Build again on all machines libosinfo: Build again on all machines virt-manager: Build again on Debian9 and Ubuntu18 libvirt-dbus: Take advantage of Python 3 on CentOS 7 Switch libvirt-dbus to Meson guests/host_vars/libvirt-centos-7/main.yml | 3 ++ guests/host_vars/libvirt-debian-9/main.yml | 4 ++ guests/host_vars/libvirt-ubuntu-16/main.yml | 3 ++ guests/host_vars/libvirt-ubuntu-18/main.yml | 4 ++ guests/lcitool | 25 +++++++++++ guests/playbooks/build/projects/libosinfo.yml | 14 ++---- .../playbooks/build/projects/libvirt-dbus.yml | 28 ++++-------- .../build/projects/osinfo-db-tools.yml | 14 ++---- guests/playbooks/build/projects/osinfo-db.yml | 15 +------ .../playbooks/build/projects/virt-manager.yml | 4 ++ guests/playbooks/update/tasks/packages.yml | 44 +++++++++++++++++++ guests/vars/mappings.yml | 26 +++++++++++ guests/vars/projects/base.yml | 2 + guests/vars/projects/libvirt.yml | 1 + jenkins/projects/libosinfo.yaml | 10 ++--- jenkins/projects/libvirt-dbus.yaml | 26 +++++------ jenkins/projects/osinfo-db-tools.yaml | 12 ++--- jenkins/projects/osinfo-db.yaml | 13 +----- jenkins/projects/virt-manager.yaml | 2 + 19 files changed, 153 insertions(+), 97 deletions(-) -- 2.23.0

2 13

[libvirt] [PATCH v2 0/1] qemu_command: tidy up qemuBuildHostdevCommandLine loop
by Daniel Henrique Barboza 08 Oct '19

08 Oct '19

MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit changes from v2: - use a switch statement instead of keeping the chained ifs, as suggested by Jano v1: https://www.redhat.com/archives/libvir-list/2019-October/msg00062.html Daniel Henrique Barboza (1): qemu_command: tidy up qemuBuildHostdevCommandLine loop src/qemu/qemu_command.c | 48 +++++++++++++++++++++++------------------ 1 file changed, 27 insertions(+), 21 deletions(-) -- 2.21.0

1 1

[libvirt] [PATCH 0/2] Fix ppc64 CPU configuration for QEMU 2.11+
by Jiri Denemark 08 Oct '19

08 Oct '19

The original fix was both incomplete and too general. It only fixed domain startup, but libvirt would still report empty list of supported CPU models with recent QEMU for ppc64. On the other hand, while ppc64 QEMU ignores case when looking up CPU model names, x86_64 QEMU does case sensitive lookup. Jiri Denemark (2): Revert "domcaps: Treat host models as case-insensitive strings" qemu: Adapt to changed ppc64 CPU model names src/conf/domain_capabilities.c | 2 +- src/qemu/qemu_capabilities.c | 26 +++++++++++++++++-- src/qemu/qemu_capabilities.h | 3 ++- src/qemu/qemu_process.c | 2 +- .../qemu_2.12.0.ppc64.xml | 6 ++++- .../caps_2.12.0.ppc64.xml | 12 ++++----- .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 12 ++++----- .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 12 ++++----- .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 12 ++++----- 9 files changed, 57 insertions(+), 30 deletions(-) -- 2.23.0

2 3

[libvirt] [jenkins-ci PATCH v2 00/12] Meson, more meson!
by Fabiano Fidêncio 08 Oct '19

08 Oct '19

The first 5 patches in the series are adding the machinery for installing meson via pip, which will be needed for systems which do not have the minimum required version, as CentOS 7, Debian 9, Ubuntu 16, and Ubuntu 18. Next 3 patches build and test osinfo-db-tools, osinfo-db, and libosinfo on all supported machines as those now have the minimum requirements needed. Following these patches, there's a patch re-enabling virt-manager builds on the systems which are, again, building libosinfo. Next 2 are basically re-enabling syntax-check job for libvirt-dbus on CentOS 7 and removing some misleading comment. Finally, last patch in the series does the libvirt-dbus builds switch to using meson instead of autotools. Fabiano Fidêncio (12): mappings: Add python2-setuptools guests: Add python2-setuptools to the base project mappings: Add python3-pip guests: Add python3-pip to the base project guests: Install meson via pip osinfo-db-tools: Build again on all machines osinfo-db: Build again on all machines libosinfo: Build again on all machines virt-manager: Build again on Debian9 and Ubuntu18 libvirt-dbus: Take advantage of Python 3 on CentOS 7 libvirt-dbus: Remove misleading comment Switch libvirt-dbus to Meson guests/host_vars/libvirt-centos-7/main.yml | 4 +++ guests/host_vars/libvirt-debian-9/main.yml | 4 +++ guests/host_vars/libvirt-ubuntu-16/main.yml | 4 +++ guests/host_vars/libvirt-ubuntu-18/main.yml | 4 +++ guests/lcitool | 17 +++++++++ guests/playbooks/build/projects/libosinfo.yml | 14 ++------ .../playbooks/build/projects/libvirt-dbus.yml | 28 +++++---------- .../build/projects/osinfo-db-tools.yml | 14 ++------ guests/playbooks/build/projects/osinfo-db.yml | 6 ++-- .../playbooks/build/projects/virt-manager.yml | 4 +++ guests/playbooks/update/tasks/packages.yml | 35 +++++++++++++++++++ guests/vars/mappings.yml | 15 ++++++++ guests/vars/projects/base.yml | 2 ++ jenkins/projects/libosinfo.yaml | 10 ++---- jenkins/projects/libvirt-dbus.yaml | 25 +++++-------- jenkins/projects/osinfo-db-tools.yaml | 12 ++----- jenkins/projects/osinfo-db.yaml | 13 ++----- jenkins/projects/virt-manager.yaml | 2 ++ 18 files changed, 125 insertions(+), 88 deletions(-) -- 2.23.0

2 22

[libvirt] [PATCH] build: stop clang complaining about redefined typedefs
by Daniel P. Berrangé 08 Oct '19

08 Oct '19

Clang's gnu99 mode is not quite the same as GCC's. It will complain about redefined typedefs being a C11 feature, while GCC does not complain and allows them in GNU99. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Technically a build breaker fix, but given my track record of breaking the build today/yestday, lets have a reviewer approve :-) m4/virt-compile-warnings.m4 | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4 index 26f231f97e..4f9eee121c 100644 --- a/m4/virt-compile-warnings.m4 +++ b/m4/virt-compile-warnings.m4 @@ -125,6 +125,10 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[ # We do "bad" function casts all the time for event callbacks wantwarn="$wantwarn -Wno-cast-function-type" + # CLang incorrectly complains about dup typedefs win gnu99 mode + # so use this CLang-specific arg to keep it quiet + wantwarn="$wantwarn -Wno-typedef-redefinition" + # GNULIB expects this to be part of -Wc++-compat, but we turn # that one off, so we need to manually enable this again wantwarn="$wantwarn -Wjump-misses-init" -- 2.21.0

3 2

[libvirt] [libvirt-dbus] [PATCH 0/2] Implement Snaphots
by Simon Kobyda 08 Oct '19

08 Oct '19

Implement snapshot interface and its APIs. Simon Kobyda (2): Introduce Domain Snapshot Interface Implement snapshots APIs data/Makefile.am | 1 + data/org.libvirt.Domain.xml | 26 +++ data/org.libvirt.DomainSnapshot.xml | 41 ++++ src/Makefile.am | 2 + src/connect.c | 6 + src/connect.h | 1 + src/domain.c | 158 ++++++++++++++++ src/domainsnapshot.c | 281 ++++++++++++++++++++++++++++ src/domainsnapshot.h | 9 + src/util.c | 47 +++++ src/util.h | 16 ++ tests/Makefile.am | 1 + tests/libvirttest.py | 14 ++ tests/test_domain.py | 8 + tests/test_snapshot.py | 43 +++++ tests/xmldata.py | 6 + 16 files changed, 660 insertions(+) create mode 100644 data/org.libvirt.DomainSnapshot.xml create mode 100644 src/domainsnapshot.c create mode 100644 src/domainsnapshot.h create mode 100755 tests/test_snapshot.py -- 2.21.0

3 5

[libvirt] [PATCH 0/5] lib: autostart objects exactly once
by Michal Privoznik 08 Oct '19

08 Oct '19

See 2/5 for explanation. Michal Prívozník (5): qemu_driver: Fix comment of qemuStateCleanup() driver: Introduce virDriverShouldAutostart() lib: autostart objects exactly once news: Document autostart fix Revert "src: Document autostart for session demon" docs/news.xml | 15 ++++++++++++++ src/bhyve/bhyve_driver.c | 8 +++++++- src/driver.c | 39 ++++++++++++++++++++++++++++++++++++ src/driver.h | 3 +++ src/libvirt-domain.c | 5 ----- src/libvirt_private.syms | 1 + src/libxl/libxl_driver.c | 12 ++++++++--- src/lxc/lxc_driver.c | 7 ++++++- src/network/bridge_driver.c | 12 ++++++++--- src/qemu/qemu_driver.c | 9 +++++++-- src/storage/storage_driver.c | 7 ++++++- 11 files changed, 102 insertions(+), 16 deletions(-) -- 2.21.0

2 10

[libvirt] [PATCH] m4: fix setting of warning flags
by Daniel P. Berrangé 08 Oct '19

08 Oct '19

When adding the -std=gnu99 flag, we set $wantwarn instead of appending to it. This meant all the compiler warnings were accidentally discarded. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed as a trivial fix for the previous commit m4/virt-compile-warnings.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4 index 411d257465..26f231f97e 100644 --- a/m4/virt-compile-warnings.m4 +++ b/m4/virt-compile-warnings.m4 @@ -192,7 +192,7 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[ # Request the gnu99 standard which is the best choice with # gcc 4.8.0. Not a warning flag, but the probing mechanism # is convenient - wantwarn="-std=gnu99" + wantwarn="$wantwarn -std=gnu99" # Check for $CC support of each warning for w in $wantwarn; do -- 2.21.0

1 0