[libvirt] ANNOUNCE: libvirt-dbus 1.2.0 released
by Pavel Hrdina
I'm happy to announce the release of libvirt-dbus 1.2.0.
libvirt-dbus wraps libvirt API to provide high-level object-oriented
API better suited for dbus-based applications.
You can download it here:
https://libvirt.org/sources/dbus/libvirt-dbus-1.2.0.tar.xz
* Bug fixes
- Properly deregister NodeDevice event callback
* Improvements
- Allow system access to users in the libvirt group
- Switch to xz compression for release archives
* Build-system fixes
- Fix default polkit rule directory and make it configurable
- Fix typo to properly build binaries with PIE
Thanks everybody who contributed!
Pavel
6 years, 5 months
[libvirt] [PATCH 0/2] Two almost trivial fixes
by Michal Privoznik
that I haven't pushed.
Michal Privoznik (2):
src: Mention DEVICE_REMOVAL_FAILED event in virDomainDetachDeviceAlias
docs
qemu: Check for guest NUMA nodes properly when validating hugepages
src/libvirt-domain.c | 4 +++-
src/qemu/qemu_command.c | 4 ++--
2 files changed, 5 insertions(+), 3 deletions(-)
--
2.16.4
6 years, 5 months
[libvirt] [PATCH 0/7] Couple of PR fixes and improvements
by Michal Privoznik
QEMU implemented event when pr-manager connects to/disconnects from
pr-helper process. Also, it implemented query command to learn the
pr-manager state on libvirtd restart. Whilst working on patches for
this, I've noticed couple of other bugs too.
Michal Privoznik (7):
qemuProcessStartPRDaemonHook: Try to set NS iff domain was started
with one
qemuDomainValidateStorageSource: Relax PR validation
virStoragePRDefFormat: Suppress path formatting for migratable XML
virstoragefile: Introduce virStorageSourceChainGetManagedPRAlias
qemu: Wire up PR_MANAGER_STATUS_CHANGED event
qemu_monitor: Introduce qemuMonitorJSONGetPRManagerInfo
qemu: Fetch pr-helper process info on reconnect
src/conf/domain_conf.c | 3 +-
src/libvirt_private.syms | 1 +
src/qemu/qemu_domain.c | 21 +++----
src/qemu/qemu_monitor.c | 40 ++++++++++++
src/qemu/qemu_monitor.h | 20 ++++++
src/qemu/qemu_monitor_json.c | 113 ++++++++++++++++++++++++++++++++++
src/qemu/qemu_monitor_json.h | 4 ++
src/qemu/qemu_process.c | 143 +++++++++++++++++++++++++++++++++++++++++--
src/util/virstoragefile.c | 20 +++++-
src/util/virstoragefile.h | 6 +-
10 files changed, 349 insertions(+), 22 deletions(-)
--
2.16.4
6 years, 5 months
[libvirt] [PATCH] qemuDomainNestedJobAllowed: Allow QEMU_JOB_NONE
by Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=1598084
When creating a snapshot with --quiesce an async job is grabbed
and just before executing guest fs-freeze command an agent job is
grabbed. This is achieved by calling
qemuDomainObjBeginJobInternal(job = QEMU_JOB_NONE,
agentJob = QEMU_AGENT_JOB_MODIFY);
Since there already is an async job set on the domain (by the
same thread) qemuDomainNestedJobAllowed(priv, job) is consulted
if @job is allowed by job mask. But this function returns false
(meaning sync @job is not allowed) which leads to a deadlock.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
src/qemu/qemu_domain.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index a60bca29ca..1b8fb71ba8 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -6414,7 +6414,9 @@ qemuDomainObjReleaseAsyncJob(virDomainObjPtr obj)
static bool
qemuDomainNestedJobAllowed(qemuDomainObjPrivatePtr priv, qemuDomainJob job)
{
- return !priv->job.asyncJob || (priv->job.mask & JOB_MASK(job)) != 0;
+ return !priv->job.asyncJob ||
+ job == QEMU_JOB_NONE ||
+ (priv->job.mask & JOB_MASK(job)) != 0;
}
bool
--
2.16.4
6 years, 5 months
[libvirt] perl-Sys-Virt docs and linker options
by Olaf Hering
The docs in libvirt-perl.git refer still to Makefile.PL.
In the buildlog I noticed that somehow /usr/local is used, nothing uses the relevant flags from libvirt.pc:
cc -shared -L/usr/local/lib64 -fstack-protector -o blib/arch/auto/Sys/Virt/Virt.so lib/Sys/Virt.o -lvirt
But even the patch below just appends -L %{_libdir} to that command. Any idea how to suppress -L/usr/local/lib64? It happens to work for me, likely because the toolchain has /usr/lib64 in a default path.
Olaf
--- Sys-Virt-20180703T160550.57299b4.orig/Build.PL
+++ Sys-Virt-20180703T160550.57299b4/Build.PL
@@ -24,6 +24,7 @@ die "libvirt >= $libvirtver is required\
my $LIBVIRT_LIBS = `pkg-config --libs libvirt`;
my $LIBVIRT_CFLAGS = `pkg-config --cflags libvirt`;
+my $LIBVIRT_LIBDIR = `pkg-config --variable=libdir libvirt`;
my $GCC_CFLAGS = "";
if ($ENV{TEST_MAINTAINER}) {
@@ -76,7 +77,7 @@ my $b = Module::Build->new(
'perl' => '5.8.0',
},
extra_compiler_flags => $GCC_CFLAGS . $LIBVIRT_CFLAGS,
- extra_linker_flags => $LIBVIRT_LIBS,
+ extra_linker_flags => "-L" . $LIBVIRT_LIBDIR . $LIBVIRT_LIBS ,
build_requires => {
'ExtUtils::CBuilder' => 0,
'Sys::Hostname' => 0,
6 years, 5 months
[libvirt] [dbus PATCH] AUTHORS: Avoid duplicated entries
by Andrea Bolognani
Instead of simply dumping the list of authors as obtained
from git, we can be a bit smarter and filter out maintainers
so that their names don't appear twice.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
AUTHORS.in | 2 +-
Makefile.am | 18 +++++++++++++-----
2 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/AUTHORS.in b/AUTHORS.in
index 12e66e1..52202ea 100644
--- a/AUTHORS.in
+++ b/AUTHORS.in
@@ -13,4 +13,4 @@ The primary maintainers of libvirt-dbus are:
Patches have been received from:
-#authorslist#
+#contributorslist#
diff --git a/Makefile.am b/Makefile.am
index 92eebcb..2c9e588 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -28,9 +28,17 @@ dist-hook: gen-AUTHORS
# and insert it into the directory we're about to use to create a tarball.
.PHONY: gen-AUTHORS
gen-AUTHORS:
- $(AM_V_GEN)if test -d $(srcdir)/.git; then \
- out="`cd $(srcdir) && git log --pretty=format:' %aN <%aE>' | sort -u`" && \
- perl -p -e "s/#authorslist#// and print '$$out'" \
- < $(srcdir)/AUTHORS.in > $(distdir)/AUTHORS-tmp && \
- mv -f $(distdir)/AUTHORS-tmp $(distdir)/AUTHORS ; \
+ $(AM_V_GEN)\
+ if test -d $(srcdir)/.git; then \
+ ( \
+ cd $(srcdir) && \
+ git log --pretty=format:' %aN <%aE>' | sort -u \
+ ) > all.list && \
+ sort -u $(srcdir)/AUTHORS.in > maint.list && \
+ comm -23 all.list maint.list > contrib.list && \
+ contrib="`cat contrib.list`" && \
+ perl -p -e "s/#contributorslist#// and print '$$contrib'" \
+ < $(srcdir)/AUTHORS.in > $(distdir)/AUTHORS-tmp && \
+ mv -f $(distdir)/AUTHORS-tmp $(distdir)/AUTHORS && \
+ rm -f all.list maint.list contrib.list; \
fi
--
2.17.1
6 years, 5 months
[libvirt] [PATCH] qemu: hotplug: Don't access srcPriv when it's not allocated
by Peter Krempa
The private data of a virStorageSource which is backing an iSCSI hostdev
may be NULL if no authentication is present. The code handling the
hotplug would attempt to extract the authentication info stored in
'secinfo' without checking if it is allocated which resulted in a crash.
Here we opt the easy way to check if srcPriv is not NULL so that we
don't duplicate all the logic which selects whether the disk source has
a secret.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1597550
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
src/qemu/qemu_hotplug.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index fcd8eb0ffa..075f2fb72e 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -2240,7 +2240,8 @@ qemuDomainAttachHostSCSIDevice(virQEMUDriverPtr driver,
if (scsisrc->protocol == VIR_DOMAIN_HOSTDEV_SCSI_PROTOCOL_TYPE_ISCSI) {
qemuDomainStorageSourcePrivatePtr srcPriv =
QEMU_DOMAIN_STORAGE_SOURCE_PRIVATE(scsisrc->u.iscsi.src);
- secinfo = srcPriv->secinfo;
+ if (srcPriv)
+ secinfo = srcPriv->secinfo;
}
if (secinfo && secinfo->type == VIR_DOMAIN_SECRET_INFO_TYPE_AES) {
--
2.16.2
6 years, 5 months
[libvirt] [dbus PATCH] AUTHORS: Update maintainers and original authors
by Pavel Hrdina
Create section for authors that started the project and add Katerina
into the list of primary maintainers.
Suggested-by: Andrea Bolognani <abologna(a)redhat.com>
Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com>
---
AUTHORS.in | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/AUTHORS.in b/AUTHORS.in
index 988dd6a..4dcd915 100644
--- a/AUTHORS.in
+++ b/AUTHORS.in
@@ -1,11 +1,16 @@
libvirt-dbus Authors
====================
-The primary maintainers of libvirt-dbus are:
+The libvirt-dbus project was initiated by:
Lars Karlitski <lars(a)karlitski.net>
Pavel Hrdina <phrdina(a)redhat.com>
+The primary maintainers of libvirt-dbus are:
+
+ Katerina Koukiou <kkoukiou(a)redhat.com>
+ Pavel Hrdina <phrdina(a)redhat.com>
+
Patches have been received from:
#authorslist#
--
2.17.1
6 years, 5 months
[libvirt] [PATCH -v2 0/2] esx: use coccinelle to avoid code duplication
by Marcos Paulo de Souza
Hi guys,
in this second version I address the comments of Michal and Matthias. Changes from v1 are placed in each patch.
Please let me know if you have more suggestions for the approach taken.
Thanks,
Marcos Paulo de Souza (2):
esx_util.h: Add ESX_VI_CHECK_ARG_LIST macro
esx: Use ESX_VI_CHECK_ARG_LIST macro to avoid code duplication
src/esx/esx_driver.c | 5 +-
src/esx/esx_network_driver.c | 10 +--
src/esx/esx_util.c | 5 +-
src/esx/esx_util.h | 8 ++
src/esx/esx_vi.c | 165 +++++++----------------------------
src/esx/esx_vi_methods.c | 10 +--
src/esx/esx_vi_types.c | 51 +++--------
7 files changed, 57 insertions(+), 197 deletions(-)
--
2.17.1
6 years, 5 months
