June 2018 - Devel - libvirt List Archives

[libvirt] [PATCH v2] qemu: Fixing uninitialised variable inside virQEMUDriverConfigLoadFile.
by Julio Faracco 12 Jun '18

12 Jun '18

Since virConfGetValueBool() can return earlier, the parameter 'value' might be not initialised properly inside this method. Another proof: Valgrind is returning this error during the libvirtd daemon startup: ==16199== Conditional jump or move depends on uninitialised value(s) ==16199== at 0x27FFFEF4: virQEMUDriverConfigLoadFile (qemu_conf.c:809) ==16199== by 0x2807665C: qemuStateInitialize (qemu_driver.c:654) ==16199== by 0x5535428: virStateInitialize (libvirt.c:662) ==16199== by 0x12AED8: daemonRunStateInit (remote_daemon.c:802) ==16199== by 0x536DE18: virThreadHelper (virthread.c:206) ==16199== by 0x6CB36DA: start_thread (pthread_create.c:463) ==16199== by 0x6FEC88E: clone (clone.S:95) Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- src/qemu/qemu_conf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index f079ae3221..a4f545ef92 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -804,9 +804,9 @@ int virQEMUDriverConfigLoadFile(virQEMUDriverConfigPtr cfg, goto cleanup; if (virConfGetValueBool(conf, "clear_emulator_capabilities", &cfg->clearEmulatorCapabilities) < 0) goto cleanup; - if (virConfGetValueBool(conf, "allow_disk_format_probing", &tmp) < 0) + if ((rv = virConfGetValueBool(conf, "allow_disk_format_probing", &tmp)) < 0) goto cleanup; - if (tmp) { + if (rv == 1 && tmp) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("allow_disk_format_probing is no longer supported")); goto cleanup; -- 2.17.1

2 1

[libvirt] [jenkins-ci PATCH] guests: Drop Ubuntu 14.04 support
by Andrea Bolognani 12 Jun '18

12 Jun '18

We were only keeping it around so that we could generate package lists to use on Travis CI, so now that (with commit 01c0179fbec0) libvirt has switched to building on newer Ubuntu releases through Docker, we can finally drop it. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/host_vars/libvirt-ubuntu-14/install.yml | 3 --- guests/host_vars/libvirt-ubuntu-14/main.yml | 10 ---------- guests/vars/mappings.yml | 11 +---------- 3 files changed, 1 insertion(+), 23 deletions(-) delete mode 100644 guests/host_vars/libvirt-ubuntu-14/install.yml delete mode 100644 guests/host_vars/libvirt-ubuntu-14/main.yml diff --git a/guests/host_vars/libvirt-ubuntu-14/install.yml b/guests/host_vars/libvirt-ubuntu-14/install.yml deleted file mode 100644 index d7862a5..0000000 --- a/guests/host_vars/libvirt-ubuntu-14/install.yml +++ /dev/null @@ -1,3 +0,0 @@ ---- -install_url: http://archive.ubuntu.com/ubuntu/dists/trusty/main/installer-amd64/ -install_config: preseed.cfg diff --git a/guests/host_vars/libvirt-ubuntu-14/main.yml b/guests/host_vars/libvirt-ubuntu-14/main.yml deleted file mode 100644 index 839c668..0000000 --- a/guests/host_vars/libvirt-ubuntu-14/main.yml +++ /dev/null @@ -1,10 +0,0 @@ ---- -projects: - - libosinfo - - libvirt - - libvirt-perl - - libvirt-python - - libvirt-tck - - osinfo-db - - osinfo-db-tools - - virt-viewer diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index af026e1..ad19c30 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -9,7 +9,7 @@ # - default # - package format (deb, pkg, rpm) # - OS name (CentOS, Debian, Fedora, FreeBSD, Ubuntu) -# - OS version (CentOS6, Debian9, FedoraRawhide, Ubuntu14 and so on) +# - OS version (CentOS6, Debian9, FedoraRawhide, Ubuntu18 and so on) # # So something like # @@ -140,13 +140,11 @@ mappings: deb: libgnutls28-dev pkg: gnutls rpm: gnutls-devel - Ubuntu14: libgnutls-dev go: default: golang FreeBSD: go CentOS6: - Ubuntu14: gobject-introspection: deb: libgirepository1.0-dev @@ -167,7 +165,6 @@ mappings: gtk-update-icon-cache: default: gtk-update-icon-cache Debian8: libgtk2.0-bin - Ubuntu14: libgtk2.0-bin Ubuntu16: libgtk2.0-bin gtk-vnc2: @@ -306,7 +303,6 @@ mappings: libtool: default: libtool deb: libtool-bin - Ubuntu14: libtool libtoolize: default: libtool @@ -499,7 +495,6 @@ mappings: default: numad FreeBSD: Debian8: - Ubuntu14: openwsman: rpm: libwsman-devel @@ -547,7 +542,6 @@ mappings: pkg: p5-Digest-MD5 rpm: perl-Digest-MD5 CentOS6: - Ubuntu14: perl-File-Slurp: deb: libfile-slurp-perl @@ -611,7 +605,6 @@ mappings: deb: libtime-hr-perl pkg: p5-Time-HiRes rpm: perl-Time-HiRes - Ubuntu14: perl perl-XML-Twig: deb: libxml-twig-perl @@ -686,7 +679,6 @@ mappings: FreeBSD: py36-libxml2 CentOS: Debian8: - Ubuntu14: Ubuntu16: python3-lxml: @@ -784,7 +776,6 @@ mappings: deb: wireshark-dev Fedora: wireshark-devel Debian8: - Ubuntu14: xen: deb: libxen-dev -- 2.17.1

2 1

[libvirt] [PATCH v1.1 0/2] cmdDomblkinfo: introduce --all to show all
by Chen Hanxiao 11 Jun '18

11 Jun '18

This series introduce --all to cmdDomblkinfo to show all block devices info in one cmd. Likes a combination of domblklist and domblkinfo. v1.1: fix a self test Chen Hanxiao (2): cmdDomblkinfo: introduce --all to show all block devices info news: add cmdDomblkinfo --all option docs/news.xml | 8 ++++ tools/virsh-domain-monitor.c | 84 +++++++++++++++++++++++++++--------- tools/virsh.pod | 5 ++- 3 files changed, 76 insertions(+), 21 deletions(-) -- 2.17.1

2 4

[libvirt] ANNOUNCE: Libvirt TCK release v1.0.0
by Daniel P. Berrangé 11 Jun '18

11 Jun '18

It has been 9 years since the first release of Libvirt TCK, so I'm happy to annonunce a second ever release, with countless accumulated bug fixes and features, is now available from https://libvirt.org/sources/tck/Sys-Virt-TCK-v1.0.0.tar.gz The GPG signature: https://libvirt.org/sources/tck/Sys-Virt-TCK-v1.0.0.tar.gz.asc Is created with my key with a fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF (4096R) All historical releases are available from: https://libvirt.org/sources/tck/ Changes in this release are: - So many that it is not useful to list them all, please see the GIT history. It is expected to have a 100% pass rate when used with the QEMU driver from current libvirt GIT master, and with 4.4.0 release it should pass everything except some nwfilter tests. The state of the tests wrt other hypervisor drivers is currently an unknown. The intention is that it would work with other drivers, but it has not been tested anytime in recent history. Thanks to everyone who contributed to this new release. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|

1 0

[libvirt] [PATCH 0/3] conf: Refactor formatting of <disk>
by Peter Krempa 11 Jun '18

11 Jun '18

Split out various bits from the overly-long functions. Peter Krempa (3): conf: Use virXMLFormatElement to format disk IO tuning conf: Use virXMLFormatElement to format disk 'driver' element conf: Extract formatting of 'mirror' disk sub-element src/conf/domain_conf.c | 321 ++++++++++++++++++++++++++----------------------- 1 file changed, 169 insertions(+), 152 deletions(-) -- 2.16.2

2 6

[libvirt] [PATCH 0/2] Fix a couple of virtio-scsi iothread issues
by John Ferlan 11 Jun '18

11 Jun '18

See the patches for details John Ferlan (2): qemu: Fix error for attach controller config for live guest qemu: Allow no address to be defined for virtio-scsi iothrad attach src/qemu/qemu_domain.c | 7 ++++--- src/qemu/qemu_driver.c | 5 +++-- 2 files changed, 7 insertions(+), 5 deletions(-) -- 2.14.4

3 5

[libvirt] [PATCH 0/2] Share cgroup code that is duplicated between QEMU and LXC
by Fabiano Fidêncio 11 Jun '18

11 Jun '18

virLXCCgroupSetupBlkioTune() and qemuSetupBlkioCgroup() and virLXCCgroupSetupCpuTune() and qemuSetupCpuCgroup() are the most similar functions between QEMU and LXC code. Let's move their common code to virCgroup. Fabiano Fidêncio (2): vircgroup: Add virCgroupSetupBlkiotune() vircgroup: Add virCgroupSetupMemtune() src/libvirt_private.syms | 2 ++ src/lxc/lxc_cgroup.c | 69 ++------------------------------------------ src/qemu/qemu_cgroup.c | 61 ++------------------------------------- src/util/vircgroup.c | 74 ++++++++++++++++++++++++++++++++++++++++++++++++ src/util/vircgroup.h | 4 +++ 5 files changed, 85 insertions(+), 125 deletions(-) -- 2.14.3

3 5

[libvirt] [PATCH] virstring: fix a typo
by Chen Hanxiao 11 Jun '18

11 Jun '18

From: Chen Hanxiao <chenhanxiao(a)gmail.com> s/glibc's_asprintf/glibc's asprintf Signed-off-by: Chen Hanxiao <chenhanxiao(a)gmail.com> --- src/util/virstring.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virstring.h b/src/util/virstring.h index fa2ec1df4d..607ae66e99 100644 --- a/src/util/virstring.h +++ b/src/util/virstring.h @@ -248,7 +248,7 @@ size_t virStringListLength(const char * const *strings); * @strp: variable to hold result (char **) * @fmt: printf format * - * Like glibc's_asprintf but makes sure *strp == NULL on failure, in which case + * Like glibc's asprintf but makes sure *strp == NULL on failure, in which case * the OOM error is reported too. * * Returns -1 on failure (with OOM error reported), number of bytes printed @@ -264,7 +264,7 @@ size_t virStringListLength(const char * const *strings); * @strp: variable to hold result (char **) * @fmt: printf format * - * Like glibc's_asprintf but makes sure *strp == NULL on failure. + * Like glibc's asprintf but makes sure *strp == NULL on failure. * * Returns -1 on failure, number of bytes printed on success. */ -- 2.17.1

2 1

[libvirt] [jenkins-ci PATCH] guests: Install ip and tc for libvirt
by Andrea Bolognani 11 Jun '18

11 Jun '18

They're both pretty much guaranteed to be dragged in by other packages already, but since we're being explicit in the spec file might as well be explicit here too. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/vars/mappings.yml | 10 ++++++++++ guests/vars/projects/libvirt.yml | 2 ++ 2 files changed, 12 insertions(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index af026e1..570e8fb 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -186,6 +186,10 @@ mappings: intltool: default: intltool + ip: + deb: iproute2 + rpm: iproute + iscsiadm: deb: open-iscsi rpm: iscsi-initiator-utils @@ -761,6 +765,12 @@ mappings: sudo: default: sudo + tc: + deb: iproute2 + rpm: iproute-tc + CentOS6: iproute + CentOS7: iproute + unzip: default: unzip FreeBSD: diff --git a/guests/vars/projects/libvirt.yml b/guests/vars/projects/libvirt.yml index ad42fd5..248a64e 100644 --- a/guests/vars/projects/libvirt.yml +++ b/guests/vars/projects/libvirt.yml @@ -13,6 +13,7 @@ packages: - glusterfs - gnutls - hal + - ip - iscsiadm - libacl - libattr @@ -49,6 +50,7 @@ packages: - scrub - sheepdog - showmount + - tc - wireshark - xen - xmllint -- 2.17.1

2 1

[libvirt] [PATCHv3 0/7] Finish the conversion to virConfGetValue* functions
by Fabiano Fidêncio 11 Jun '18

11 Jun '18

This patchset finishes the conversion to virConfGetValue* functions, started by Daniel Berrange a few months ago. Please, mind that although we could make virConfGetValue* functions more generic in order to support numbers and booleans as strings, that doesn't seem the safest path to take. The side-effect of this is that we will have to live with some specific code doing that as part of vmx and xen_common. Once this patchset gets merged, https://wiki.libvirt.org/page/BiteSizedTasks#Finish_conversion_to_virConfGe… can be removed. - Changes since v1: All the "values" from virConfGetValueString() are freed - Changes since v2: All comments from Ján Tomko have been addressed; A few leaks were (possibly) found and they're addressed in the last patch of the series; Fabiano Fidêncio (7): xen_xm: Split the per-disk logic from xenParseXMDisk() xen_vm: convert to typesafe virConf accessors vmx: convert to typesafe virConf accessors xen_common: Split per-PCI logic from xenParsePCI() xen_common: Split per-Vfi logic from xenParseVif() xen_common: convert to typesafe virConf acessors xen_common: Fix a few memory leaks src/vmx/vmx.c | 194 +++++-------- src/xenconfig/xen_common.c | 701 +++++++++++++++++++++++---------------------- src/xenconfig/xen_xm.c | 306 ++++++++++---------- 3 files changed, 595 insertions(+), 606 deletions(-) -- 2.14.3

2 15