March 2018 - Devel - libvirt List Archives

[libvirt] [PATCH] rpm: depend on python2, not bare python
by Daniel P. Berrangé 15 Mar '18

15 Mar '18

Fedora requires packages to depend on "python2" RPM, not the unversioned "python" name. Fortunately even though RHEL-6 ships a "python" RPM, it has a virtual Provides for the "python2" name, so we don't need to conditionalize this. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- libvirt.spec.in | 2 +- mingw-libvirt.spec.in | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 8e9836ebbd..bc8257f34b 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -305,7 +305,7 @@ BuildRequires: perl-interpreter %else BuildRequires: perl %endif -BuildRequires: python +BuildRequires: python2 %if %{with_systemd} BuildRequires: systemd-units %endif diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in index dc18d055ba..5e12bb1cae 100644 --- a/mingw-libvirt.spec.in +++ b/mingw-libvirt.spec.in @@ -61,7 +61,7 @@ BuildRequires: pkgconfig # Need native version for msgfmt BuildRequires: gettext BuildRequires: libxslt -BuildRequires: python +BuildRequires: python2 %if 0%{?fedora} >= 27 BuildRequires: perl-interpreter %else -- 2.14.3

2 1

[libvirt] [PATCH 0/2] travis: fix macOS build
by Daniel P. Berrangé 15 Mar '18

15 Mar '18

You can see the "working" build here: https://travis-ci.org/berrange/libvirt/builds/353816421 Yeah it still failed, but it got past the brew bit that was failing before, and now fails for genuine code problems :-) Daniel P. Berrangé (2): travis: move macOS before_install tasks into osx matrix entry travis: unlink python package before upgrading brew packages .travis.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) -- 2.14.3

2 5

[libvirt] [PATCH] conf: nodedev: Update capabilities from within virNodeDeviceObjHasCap
by Erik Skultety 15 Mar '18

15 Mar '18

Commit d18feadc0c put this into virNodeDeviceMatch, but this should have rather been part of virNodeDeviceObjHasCap from the beginning, since virNodeDeviceObjHasCap is the last helper to be called (in the calltree) whereas virNodeDeviceMatch is called from a single place only - virNodeDeviceObjListExportCallback. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- src/conf/virnodedeviceobj.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/conf/virnodedeviceobj.c b/src/conf/virnodedeviceobj.c index ad0f27ee4..0417664ad 100644 --- a/src/conf/virnodedeviceobj.c +++ b/src/conf/virnodedeviceobj.c @@ -644,6 +644,10 @@ virNodeDeviceObjHasCap(const virNodeDeviceObj *obj, { virNodeDevCapsDefPtr cap = NULL; + /* Refresh the capabilities first, e.g. due to a driver change */ + if (virNodeDeviceUpdateCaps(obj->def) < 0) + return false; + for (cap = obj->def->caps; cap; cap = cap->next) { if (type == cap->data.type) return true; @@ -811,10 +815,6 @@ static bool virNodeDeviceMatch(virNodeDeviceObjPtr obj, unsigned int flags) { - /* Refresh the capabilities first, e.g. due to a driver change */ - if (virNodeDeviceUpdateCaps(obj->def) < 0) - return false; - /* filter by cap type */ if (flags & VIR_CONNECT_LIST_NODE_DEVICES_FILTERS_CAP) { if (!(MATCH(SYSTEM) || -- 2.13.6

2 3

[libvirt] [PATCH] travis: Temporarily disable 'brew upgrade'
by Andrea Bolognani 15 Mar '18

15 Mar '18

There are a lot of changes happening in the homebrew ecosystem around Python, and as a consequence 'brew upgrade' hasn't been able to complete successfully for several days. Temporarily disable upgrading the system before building: this will need to be reverted once the upgrade issues have been sorted out. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 79f30f3090..c891ef419c 100644 --- a/.travis.yml +++ b/.travis.yml @@ -100,7 +100,7 @@ env: - VIR_TEST_DEBUG=1 before_install: - - if [ "$TRAVIS_OS_NAME" == "osx" ]; then brew update && brew upgrade && brew install rpcgen yajl xz && brew link --force python@2; fi + - if [ "$TRAVIS_OS_NAME" == "osx" ]; then brew update && brew install rpcgen yajl xz && brew link --force python@2; fi before_script: - ./autogen.sh --prefix=$(pwd)/install-root -- 2.14.3

2 1

[libvirt] libvirt build failure with --disable-shared
by Rahul Sharma 15 Mar '18

15 Mar '18

Hi, I am facing an error with libvirt build where it fails if I try to disable shared libraries. Though I opened up the issue on gitlab, not sure if that was the right place to open one. Kindly do let me know if this should be opened up at some other place. Build failure with libvirt-4.1.0 using the command: CFLAGS="-fPIC" ./configure --enable-static --disable-shared --prefix=/home/ubuntu/libvirt-4.1.0/out https://gitlab.com/libvirt/libvirt/issues/1 - Rahul

3 2

[libvirt] [jenkins-ci PATCH] guests: Stop installing polkit-devel
by Andrea Bolognani 15 Mar '18

15 Mar '18

As of libvirt commit 9cd42e725f42 only the runtime package is needed, even during build. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/vars/mappings.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index e3781b9..190013e 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -546,9 +546,8 @@ mappings: Ubuntu12: pkg-config polkit: + default: polkit deb: policykit-1 - pkg: polkit - rpm: polkit-devel python2: default: python -- 2.14.3

2 1

[libvirt] [PATCH v2] spec: Drop polkit-devel from BuildRequires
by Andrea Bolognani 15 Mar '18

15 Mar '18

As of 2499d1a09508 we don't link against libpolkit anymore, so we only need the polkit package to be available during build. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- libvirt.spec.in | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 5e05d706f8..8e9836ebbd 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -358,11 +358,9 @@ BuildRequires: ebtables BuildRequires: module-init-tools BuildRequires: cyrus-sasl-devel %if 0%{?fedora} || 0%{?rhel} >= 7 -# F22 polkit-devel doesn't pull in polkit anymore, which we need for pkcheck BuildRequires: polkit >= 0.112 -BuildRequires: polkit-devel >= 0.112 %else -BuildRequires: polkit-devel >= 0.93 +BuildRequires: polkit >= 0.93 %endif # For mount/umount in FS driver BuildRequires: util-linux -- 2.14.3

2 1

[libvirt] [PATCH] spec: Drop polkit from {,Build}Requires:
by Andrea Bolognani 15 Mar '18

15 Mar '18

As of 2499d1a09508 we don't link against libpolkit or look for the pkcheck command anymore, so these package relationships are no longer necessary and can be safely dropped. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- libvirt.spec.in | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 5e05d706f8..e70cc02dc8 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -357,13 +357,6 @@ BuildRequires: radvd BuildRequires: ebtables BuildRequires: module-init-tools BuildRequires: cyrus-sasl-devel -%if 0%{?fedora} || 0%{?rhel} >= 7 -# F22 polkit-devel doesn't pull in polkit anymore, which we need for pkcheck -BuildRequires: polkit >= 0.112 -BuildRequires: polkit-devel >= 0.112 -%else -BuildRequires: polkit-devel >= 0.93 -%endif # For mount/umount in FS driver BuildRequires: util-linux %if %{with_qemu} @@ -489,11 +482,6 @@ Requires: module-init-tools # for /sbin/ip & /sbin/tc Requires: iproute Requires: avahi-libs -%if 0%{?fedora} || 0%{?rhel} >= 7 -Requires: polkit >= 0.112 -%else -Requires: polkit >= 0.93 -%endif %if %{with_cgconfig} Requires: libcgroup %endif -- 2.14.3

2 3

[libvirt] [PATCH v2] qemu: hotplug: Clean up memory backing files after failed memory hotplug
by Peter Krempa 15 Mar '18

15 Mar '18

Libvirt provides full path to the backing file since commit fec8f9c49afb479f6. This made qemu create the backend object but did not delete it. This was fixed for unplug case in 4d83a6722f but not in case of failure to hotplug the frontend. We'd leave the files behind which would make memory unusable in case of hugepages. https://bugzilla.redhat.com/show_bug.cgi?id=1553085 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- Differences to v1: - dropped mostly unhelpful comment - moved the call slightly earlier so that the error of the original hotplug operation is preserved src/qemu/qemu_hotplug.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index e0a5300f08..49af4d4ff0 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -2212,6 +2212,10 @@ qemuDomainAttachMemory(virQEMUDriverPtr driver, ignore_value(qemuMonitorDelObject(priv->mon, objalias)); if (qemuDomainObjExitMonitor(driver, vm) < 0) mem = NULL; + + if (objAdded && mem) + ignore_value(qemuProcessDestroyMemoryBackingPath(driver, vm, mem)); + virErrorRestore(&orig_err); if (!mem) goto audit; -- 2.16.2

2 1

[libvirt] [PATCH 0/3] Couple of user alias fixes
by Michal Privoznik 15 Mar '18

15 Mar '18

The deeper into the rabbit hole we go the more I think it was a mistake to let users specify device aliases. Michal Privoznik (3): virDomainDeviceValidateAliasForHotplug: Use correct domain defintion conf: Check for user aliases duplicates only qemu: Forbid user aliases for USB controllers src/conf/domain_conf.c | 6 +++--- src/qemu/qemu_domain.c | 20 +++++++++++++++++++- tests/qemuxml2argvdata/user-aliases-usb.xml | 19 +++++++++++++++++++ tests/qemuxml2argvdata/user-aliases.xml | 1 - tests/qemuxml2argvtest.c | 1 + 5 files changed, 42 insertions(+), 5 deletions(-) create mode 100644 tests/qemuxml2argvdata/user-aliases-usb.xml -- 2.16.1

2 8