October 2018 - Devel - libvirt List Archives

[libvirt] RFC: "Determine if the domain has been updated."?
by Philipp Hahn 30 Oct '18

30 Oct '18

Hello, <https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainIsUpdated> states: > int virDomainIsUpdated (virDomainPtr dom) > > Determine if the domain has been updated. > > dom: pointer to the domain object > Returns: 1 if updated, 0 if not, -1 on error Not very enlightening :-( So what's the meaning of "updated" here: "inactive XML got changed but the currently running VM was started from a different XML"? Only very few drivers seem to mention it at all and they seem to mean different things. Any nobody seems to update the variable, only 4 readers: > $ git grep -ne '->updated' > libxl/libxl_driver.c:4844: ret = vm->updated; > lxc/lxc_driver.c:343: ret = obj->updated; > qemu/qemu_driver.c:1628: ret = obj->updated; > uml/uml_driver.c:1456: ret = obj->updated; Thank you for the clarification. Philipp -- Philipp Hahn Open Source Software Engineer Univention GmbH be open. Mary-Somerville-Str. 1 D-28359 Bremen Tel.: +49 421 22232-0 Fax : +49 421 22232-99 hahn(a)univention.de http://www.univention.de/ Geschäftsführer: Peter H. Ganten HRB 20755 Amtsgericht Bremen Steuer-Nr.: 71-597-02876

1 0

Re: [libvirt] [PATCH v3 0/3] Deprecate QMP & HMP `cpu-add`; document vCPU hotplug
by Kashyap Chamarthy 30 Oct '18

30 Oct '18

[Cc: libvir-list] On Tue, Oct 30, 2018 at 01:35:23PM +0100, Kashyap Chamarthy wrote: > The first patch deprecates the QMP `cpu-add`, the second its HMP > equivalent, and the third documents vCPU hotplug procedure using QMP > `device_add` et al. > > v2: https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg03191.html > > Kashyap Chamarthy (3): > Deprecate QMP `cpu-add` > Deprecate HMP `cpu-add` > docs: Document vCPU hotplug procedure > > docs/cpu-hotplug.rst | 142 +++++++++++++++++++++++++++++++++++++++++++ > hmp-commands.hx | 6 +- > hmp.c | 2 + > qapi/misc.json | 8 ++- > qemu-deprecated.texi | 5 ++ > 5 files changed, 160 insertions(+), 3 deletions(-) > create mode 100644 docs/cpu-hotplug.rst > > -- > 2.17.1 > -- /kashyap

2 1

[libvirt] [PATCH 0/2] Fix compatibility with MTTCG
by Daniel P. Berrangé 30 Oct '18

30 Oct '18

QEMU is using MTTCG by default on an increasingly large set of host/guest combinations. This allows us to use the normal vCPU pinning support we already have for KVM. We just need to stop throwing away the PID info, and stop artificially blocking pinning APIs. Daniel P. Berrangé (2): qemu: fix recording of vCPU pids for MTTCG Revert "qemu: Forbid pinning vCPUs for TCG domain" src/qemu/qemu_domain.c | 81 ++++++++++++++++++++++++++---------------- src/qemu/qemu_driver.c | 7 ---- 2 files changed, 51 insertions(+), 37 deletions(-) -- 2.17.2

3 8

[libvirt] [PATCH 0/2] Augment access denied error message and adjust polkit docs
by John Ferlan 30 Oct '18

30 Oct '18

Details in the patches John Ferlan (2): access: Modify the VIR_ERR_ACCESS_DENIED to include driverName docs: Enhance polkit documentation to describe secondary connection docs/aclpolkit.html.in | 117 ++++++++++++++++++++++++++++++++++ docs/libvirt.css | 1 + src/access/viraccessmanager.c | 25 ++++---- src/rpc/gendispatch.pl | 2 +- src/util/virerror.c | 4 +- 5 files changed, 134 insertions(+), 15 deletions(-) -- 2.17.2

2 4

[libvirt] [snmp PATCH 00/20] Misc cleanups and improvements
by Michal Privoznik 29 Oct '18

29 Oct '18

These are not pushed. I'll wait couple of moments if there is somebody who has opinion. If not I will push them. Michal Privoznik (20): libvirtGuestTable.c: Free duplicated domain name libvirtSnmp.c: Retab and realign configure: Drop support for libvirt older than 0.9.0 configure.ac: Drop useless "-lvirt" in LIBVIRT_LIBS showError: Switch to less ancient error reporting libvirtSnmp: Modernize libvirtSnmpLoadGuests libvirtSnmp: Modernize insertGuest libvirtSnmp: Rewrite some functions src: Fix header file defines src: Fix includes in header files libvirtRegisterEvents: Drop pthread_attr_init libvirtSnmp: turn showError() into printf-like function libvirtSnmpError: Drop 'extern' for printLibvirtError() libvirtSnmp: Drop 'extern' from function headers libvirtSnmp: s/showError/printLibvirtError/ libvirtSnmpError: Introduce and use printSystemError libvirtSnmp: Fix type of libvirtUnregisterEvents() libvirtSnmp: Report libvirt errors if no domain is found libvirtSnmpInit: Don't report errors from libvirtRegisterEvents() .gitignore: Ignore tags file .gitignore | 1 + configure.ac | 31 +- src/Makefile.am | 18 - src/event_poll.c | 724 ------------------------------------- src/event_poll.h | 132 ------- src/ignore-value.h | 64 ---- src/internal.h | 138 ------- src/libvirtGuestTable.c | 4 +- src/libvirtNotifications.h | 8 +- src/libvirtSnmp.c | 436 ++++++++-------------- src/libvirtSnmp.h | 30 +- src/libvirtSnmpError.c | 83 ++++- src/libvirtSnmpError.h | 23 +- src/memory.c | 313 ---------------- src/memory.h | 212 ----------- src/threads.c | 251 ------------- src/threads.h | 101 ------ src/util.c | 105 ------ src/util.h | 38 -- 19 files changed, 261 insertions(+), 2451 deletions(-) delete mode 100644 src/event_poll.c delete mode 100644 src/event_poll.h delete mode 100644 src/ignore-value.h delete mode 100644 src/internal.h delete mode 100644 src/memory.c delete mode 100644 src/memory.h delete mode 100644 src/threads.c delete mode 100644 src/threads.h delete mode 100644 src/util.c delete mode 100644 src/util.h -- 2.18.1

3 25

[libvirt] [PATCH] qemu: Introduce caching whether /dev/kvm is accessible
by Marc Hartmayer 29 Oct '18

29 Oct '18

Introduce caching whether /dev/kvm is usable as the QEMU user:QEMU group. This reduces the overhead of the QEMU capabilities cache lookup. Before this patch there were many fork() calls used for checking whether /dev/kvm is accessible. Now we store the result whether /dev/kvm is accessible or not and we only need to re-run the virFileAccessibleAs check if the ctime of /dev/kvm has changed. Suggested-by: Daniel P. Berrangé <berrange(a)redhat.com> Signed-off-by: Marc Hartmayer <mhartmay(a)linux.ibm.com> --- src/qemu/qemu_capabilities.c | 56 ++++++++++++++++++++++++++++++++++-- 1 file changed, 54 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index e228f52ec0bb..ea95915f0f71 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -3238,6 +3238,10 @@ struct _virQEMUCapsCachePriv { virArch hostArch; unsigned int microcodeVersion; char *kernelVersion; + + /* cache whether /dev/kvm is usable as runUid:runGuid */ + virTristateBool kvmUsable; + time_t kvmCtime; }; typedef struct _virQEMUCapsCachePriv virQEMUCapsCachePriv; typedef virQEMUCapsCachePriv *virQEMUCapsCachePrivPtr; @@ -3824,6 +3828,54 @@ virQEMUCapsSaveFile(void *data, } +/* Determine whether '/dev/kvm' is usable as QEMU user:QEMU group. */ +static bool +virQEMUCapsKVMUsable(virQEMUCapsCachePrivPtr priv) +{ + struct stat sb; + static const char *kvm_device = "/dev/kvm"; + virTristateBool value; + virTristateBool cached_value = priv->kvmUsable; + time_t kvm_ctime; + time_t cached_kvm_ctime = priv->kvmCtime; + + if (stat(kvm_device, &sb) < 0) { + virReportSystemError(errno, + _("Failed to stat %s"), kvm_device); + return false; + } + kvm_ctime = sb.st_ctime; + + if (cached_value != VIR_TRISTATE_BOOL_ABSENT) { + if (kvm_ctime != cached_kvm_ctime) { + VIR_DEBUG("%s has changed (%lld vs %lld)", kvm_device, + (long long)kvm_ctime, (long long)cached_kvm_ctime); + goto update; + } + + return cached_value == VIR_TRISTATE_BOOL_YES; + } + + update: + if (virFileAccessibleAs(kvm_device, R_OK | W_OK, + priv->runUid, priv->runGid) == 0) { + value = VIR_TRISTATE_BOOL_YES; + } else { + value = VIR_TRISTATE_BOOL_NO; + } + + /* There is a race window between 'stat' and + * 'virFileAccessibleAs'. However, since we're only interested in + * detecting changes *after* the virFileAccessibleAs check, we can + * neglect this here. + */ + priv->kvmCtime = kvm_ctime; + priv->kvmUsable = value; + + return value == VIR_TRISTATE_BOOL_YES; +} + + static bool virQEMUCapsIsValid(void *data, void *privData) @@ -3872,8 +3924,7 @@ virQEMUCapsIsValid(void *data, return true; } - kvmUsable = virFileAccessibleAs("/dev/kvm", R_OK | W_OK, - priv->runUid, priv->runGid) == 0; + kvmUsable = virQEMUCapsKVMUsable(priv); if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_KVM) && kvmUsable) { @@ -4684,6 +4735,7 @@ virQEMUCapsCacheNew(const char *libDir, priv->runUid = runUid; priv->runGid = runGid; priv->microcodeVersion = microcodeVersion; + priv->kvmUsable = VIR_TRISTATE_BOOL_ABSENT; if (uname(&uts) == 0 && virAsprintf(&priv->kernelVersion, "%s %s", uts.release, uts.version) < 0) -- 2.17.0

2 1

[libvirt] Plan for next release
by Daniel Veillard 29 Oct '18

29 Oct '18

I'm afraid I'm a bit behind. I suggest to enter freeze tomorrow morning then pushing rc2 on Thursday and if everything goes well push the GA during the w.e., a bit late but not too late. I hope this works for everybody, thanks, Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] number of graphic device in vm xml is limited to only 1
by Huangyong 29 Oct '18

29 Oct '18

Hello, In qemu_command, vnc graphic device can’t be more than 1, as the following code show in qemuBuildCommandLineValidate(): If（sdl > 1 || vnc > 1 || spice > 1） { virReportError(….); return -1; } This check originally introduced by commit: 6fe9025eb. Qemu: Error on unsupported graphics config qemu can support multi-vnc-configuration in qemu process, but libvirt limit vnc graphics in only 1. Is there any considerations in libvirt? can remove this restriction? ------------------------------------------------------------------------------------------------------------------------------------- 本邮件及其附件含有新华三集团的保密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制、或散发）本邮件中的信息。如果您错收了本邮件，请您立即电话或邮件通知发件人并删除本邮件！ This e-mail and its attachments contain confidential information from New H3C, which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!

2 1

[libvirt] [PATCH v2 0/2] nwfilter: don't reinstantiate rules if there is no need to
by Nikolay Shirokovskiy 29 Oct '18

29 Oct '18

Applied on top of [1] that restores reinstantiating filters on daemon reload. Note the fragile issue mentioned in ebiptablesDumpIstalledRules in respect to list of firewall tables we are using. I wonder can we instead of caching instantiate rules faster in the end? There is iptables-restore if we instantiate directly. And in case of firewalld mode why we instantiate filters via firewalld dbus interface after all? We use passthrough interface so looks like firewalld don't account our rules in any way. May be all we need is reloading rules on firewalld reload and always instantiate thru binaries? Then we can do things fast. Diff from v1 [2]: ------------ Approach is changed. Instead of checking whether applied filters changed or not (so we can miss firewall changes from outside) let's check that don't change both - rules we are going to apply and rules in firewall in comparion to previous instantiation. [1] [PATCH] nwfilter: intantiate filters on loading driver https://www.redhat.com/archives/libvir-list/2018-October/msg00787.html [2] [PATCH RFC 0/4] nwfilter: don't reinstantiate filters if they are not changed https://www.redhat.com/archives/libvir-list/2018-October/msg00904.html [3] [RFC] Faster libvirtd restart with nwfilter rules https://www.redhat.com/archives/libvir-list/2018-September/msg01206.html which continues in https://www.redhat.com/archives/libvir-list/2018-October/msg00657.html Nikolay Shirokovskiy (2): firewall: add dump function nwfilter: don't reinstantiate rules if there is no need to src/libvirt_private.syms | 1 + src/nwfilter/nwfilter_ebiptables_driver.c | 387 +++++++++++++++++++++++++++++- src/util/virfirewall.c | 111 +++++++++ src/util/virfirewall.h | 3 + 4 files changed, 500 insertions(+), 2 deletions(-) -- 1.8.3.1

1 2

[libvirt] [PATCH] conf: More clear error msg for incomplete coalesce xml
by Han Han 29 Oct '18

29 Oct '18

https://bugzilla.redhat.com/show_bug.cgi?id=1535930 Report more clear err msg instead of unknown error when coalesce settings is incomplete. Signed-off-by: Han Han <hhan(a)redhat.com> --- src/conf/domain_conf.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9911d56130..e755f45d3d 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -7804,8 +7804,12 @@ virDomainNetDefCoalesceParseXML(xmlNodePtr node, ctxt->node = node; str = virXPathString("string(./rx/frames/@max)", ctxt); - if (!str) + if (!str) { + virReportError(VIR_ERR_XML_DETAIL, + "%s", + _("incomplete coalesce settings in interface xml")); goto cleanup; + } if (VIR_ALLOC(ret) < 0) goto cleanup; -- 2.19.1

3 5