[libvirt] [RFC PATCH] lxc: Up back the veth interfaces by default
by Benjamin Cama
Upping an interface without configuring it is not a “cardinal sin” but a
sensible way to achieve auto-configuration, e.g. with IPv6 SLAAC (RFC
4862). If NetworkManager has troube with interfaces having only a
link-local address, this is a bug in NetworkManager, not in libvirt; it
should listen for router advertisements to decide if some interface has
global connectivity or not.
With network interfaces up by default, stateless containers can be
easily auto-configured through the network with SLAAC, without any
specific configuration from the host system.
This reverts commit c3cf3c43a0bb2e0e4909c32821e20f607635ec85.
Signed-off-by: Benjamin Cama <b.cama(a)kerlink.fr>
---
Hi,
The patch that I propose to revert basically broke my workflow for light
stateless containers, where they could be auto-configured on IPv6-only network
through SLAAC. Of course, fully-fledged containers can bring up the interface
themselves, but this behavior had previously been the default for quite some
time, and is even indicated as default in src/conf/domain_conf.h ("Default link
state (up)").
I cannot find any real justification for the patch I am reverting, and the
bugzilla looks private so I can not comment on the NetworkManager behavior,
which looks very buggy to me.
Please tell me if you think this is wrong. Also, please Cc me, I am not
subscribed.
Regards.
.mailmap | 1 +
src/lxc/lxc_container.c | 7 +------
src/lxc/lxc_native.c | 10 ++++++----
3 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/.mailmap b/.mailmap
index 2f0fc901e..9dc3bff85 100644
--- a/.mailmap
+++ b/.mailmap
@@ -36,6 +36,7 @@
<gerd(a)egidy.de> <lists(a)egidy.de>
<gerd(a)egidy.de> <gerd.von.egidy(a)intra2net.com>
<benoar(a)dolka.fr> <benjamin.cama(a)telecom-bretagne.eu>
+<benoar(a)dolka.fr> <b.cama(a)kerlink.fr>
<zhlcindy(a)linux.vnet.ibm.com> <zhlcindy(a)gmail.com>
<serge.hallyn(a)canonical.com> <serue(a)us.ibm.com>
<pritesh.kothari(a)sun.com> <Pritesh.Kothari(a)Sun.COM>
diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c
index 96fceaf1b..e546f0aaf 100644
--- a/src/lxc/lxc_container.c
+++ b/src/lxc/lxc_container.c
@@ -517,12 +517,7 @@ lxcContainerRenameAndEnableInterfaces(virDomainDefPtr vmDef,
if (virNetDevSetName(veths[i], newname) < 0)
goto cleanup;
- /* Only enable this device if there is a reason to do so (either
- * at least one IP was specified, or link state was set to up in
- * the config)
- */
- if (netDef->guestIP.nips ||
- netDef->linkstate == VIR_DOMAIN_NET_INTERFACE_LINK_STATE_UP) {
+ if (netDef->linkstate != VIR_DOMAIN_NET_INTERFACE_LINK_STATE_DOWN) {
VIR_DEBUG("Enabling %s", newname);
if (virNetDevSetOnline(newname, true) < 0)
goto cleanup;
diff --git a/src/lxc/lxc_native.c b/src/lxc/lxc_native.c
index fdc03a57e..f77a2a910 100644
--- a/src/lxc/lxc_native.c
+++ b/src/lxc/lxc_native.c
@@ -349,10 +349,12 @@ lxcCreateNetDef(const char *type,
if (VIR_ALLOC(net) < 0)
goto error;
- if (STREQ_NULLABLE(flag, "up"))
- net->linkstate = VIR_DOMAIN_NET_INTERFACE_LINK_STATE_UP;
- else
- net->linkstate = VIR_DOMAIN_NET_INTERFACE_LINK_STATE_DOWN;
+ if (flag) {
+ if (STREQ(flag, "up"))
+ net->linkstate = VIR_DOMAIN_NET_INTERFACE_LINK_STATE_UP;
+ else
+ net->linkstate = VIR_DOMAIN_NET_INTERFACE_LINK_STATE_DOWN;
+ }
if (VIR_STRDUP(net->ifname_guest, name) < 0)
goto error;
--
2.11.0
6 years, 11 months
[libvirt] [BUG] virsh list didn,t clean vm when qemu destroy failed
by wang.guang55＠zte.com.cn
U3RlcHMgdG8gcmVwcm9kdWNlIA0KDQoNCjEgdmlyc2ggY3JlYXRlICB0ZXN0dm0gICANCg0KDQoy
IGdkYiBhdHRjaCBxZW11LGFuZCBub3QgY29udGludWUNCg0KDQozICB2aXJzaCBkZXN0cm95ICB0
ZXN0dm0gICDvvIx0aGVuIGRlc3RvcnkgZmFpbGVk44CCDQoNCg0KNCBnZGIgcWVtdSBjb250aW51
ZSBhbmQgZXhpdCx0aGVuIHFlbXUgZXhpdC4NCg0KDQoNCg0KDQoNCltyb290QGhvc3QtMTIwLTUx
IGhvbWVdIyBwcyAtYXV4IHxncmVwIHFlbXUNCg0KDQpyb290ICAgICAgMjgxNCAgMC4wICAwLjAg
MTEyNjQ0ICAgOTU2IHB0cy8zICAgIFMrICAgMTE6NDAgICAwOjAwIGdyZXAgLS1jb2xvcj1hdXRv
IHFlbXUNCg0KW3Jvb3RAaG9zdC0xMjAtNTEgaG9tZV0jIHZpcnNoIGxpc3QNCg0KIElkICAgIE5h
bWUgICAgICAgICAgICAgICAgICAgICAgICAgICBTdGF0ZQ0KDQotLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tDQoNCiAzICAgIHRlc3R2bSAgICAgICAg
ICAgICAgICAgICAgICAgcnVubmluZw0KDQoNCg0KDQoNCg0KDQoNCg0KDQpjYW4gd2UgdHJpZ2dl
ciBxZW11UHJvY2Vzc0hhbmRsZU1vbml0b3JFT0YgYWdhaW4gdG8gcmVtb3ZlIHZtPz8=
6 years, 11 months
[libvirt] [PATCH v2] treat host models as case-insensitive strings
by Scott Garfinkle
Qemu now allows case-insensitive specification of CPU models. This fixes the
resulting problems on (at least) POWER arch machines.
Patch V2: Change only the internal interface. This solves the actual problem at
hand of reporting unsupported models now that qemu allows case-insensitive
strings (e.g. "Power8" instead of "POWER8").
Signed-off-by: Scott Garfinkle <scottgar(a)linux.vnet.ibm.com>
---
src/conf/domain_capabilities.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/domain_capabilities.c b/src/conf/domain_capabilities.c
index e7323a8..f7d9be5 100644
--- a/src/conf/domain_capabilities.c
+++ b/src/conf/domain_capabilities.c
@@ -271,7 +271,7 @@ virDomainCapsCPUModelsGet(virDomainCapsCPUModelsPtr cpuModels,
return NULL;
for (i = 0; i < cpuModels->nmodels; i++) {
- if (STREQ(cpuModels->models[i].name, name))
+ if (STRCASEEQ(cpuModels->models[i].name, name))
return cpuModels->models + i;
}
--
1.8.3.1
6 years, 11 months
[libvirt] [PATCH] vsh: add a necessary assertion
by Marc Hartmayer
This fixes the compilation error (compiled with the compiler option
'-03').
In file included from ../../tools/vsh.c:28:0:
../../tools/vsh.c: In function 'vshCommandOptStringQuiet':
../../tools/vsh.c:838:30: error: potential null pointer dereference [-Werror=null-dereference]
assert(!needData || valid->type != VSH_OT_BOOL);
Signed-off-by: Marc Hartmayer <mhartmay(a)linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com>
---
tools/vsh.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/vsh.c b/tools/vsh.c
index e878119b988f..677eb9db3e41 100644
--- a/tools/vsh.c
+++ b/tools/vsh.c
@@ -816,8 +816,8 @@ vshCommandFree(vshCmd *cmd)
* to the option if found, 0 with *OPT set to NULL if the name is
* valid and the option is not required, -1 with *OPT set to NULL if
* the option is required but not present, and assert if NAME is not
- * valid (which indicates a programming error). No error messages are
- * issued if a value is returned.
+ * valid or the option was not found (which indicates a programming
+ * error). No error messages are issued if a value is returned.
*/
static int
vshCommandOpt(const vshCmd *cmd, const char *name, vshCmdOpt **opt,
@@ -835,6 +835,8 @@ vshCommandOpt(const vshCmd *cmd, const char *name, vshCmdOpt **opt,
break;
valid++;
}
+ assert(valid);
+
assert(!needData || valid->type != VSH_OT_BOOL);
if (valid->flags & VSH_OFLAG_REQ)
ret = -1;
--
2.13.4
6 years, 11 months
[libvirt] [PATCH] docs: Add missing encryption type
by John Ferlan
Update the text to include "luks" as a possible value.
Signed-off-by: John Ferlan <jferlan(a)redhat.com>
---
Pushed as trivial.
docs/formatstorageencryption.html.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/docs/formatstorageencryption.html.in b/docs/formatstorageencryption.html.in
index c4b209527..23efbf932 100644
--- a/docs/formatstorageencryption.html.in
+++ b/docs/formatstorageencryption.html.in
@@ -17,7 +17,8 @@
The top-level tag of volume encryption specification
is <code>encryption</code>, with a mandatory
attribute <code>format</code>. Currently defined values
- of <code>format</code> are <code>default</code> and <code>qcow</code>.
+ of <code>format</code> are <code>default</code>, <code>qcow</code>,
+ and <code>luks</code>.
Each value of <code>format</code> implies some expectations about the
content of the <code>encryption</code> tag. Other format values may be
defined in the future.
--
2.13.6
6 years, 11 months
[libvirt] [PATCH] tests: Break symlink loop
by Andrea Bolognani
distcheck, and possibly more stuff, breaks because of it.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu0/node0 | 1 -
tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu1/node0 | 1 -
tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu2/node0 | 1 -
tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu3/node0 | 1 -
tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu4/node0 | 1 -
tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu5/node0 | 1 -
tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu6/node0 | 1 -
tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu7/node0 | 1 -
8 files changed, 8 deletions(-)
delete mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu0/node0
delete mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu1/node0
delete mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu2/node0
delete mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu3/node0
delete mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu4/node0
delete mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu5/node0
delete mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu6/node0
delete mode 120000 tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu7/node0
diff --git a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu0/node0 b/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu0/node0
deleted file mode 120000
index 222b6af32..000000000
--- a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu0/node0
+++ /dev/null
@@ -1 +0,0 @@
-../../node/node0
\ No newline at end of file
diff --git a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu1/node0 b/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu1/node0
deleted file mode 120000
index 222b6af32..000000000
--- a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu1/node0
+++ /dev/null
@@ -1 +0,0 @@
-../../node/node0
\ No newline at end of file
diff --git a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu2/node0 b/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu2/node0
deleted file mode 120000
index 222b6af32..000000000
--- a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu2/node0
+++ /dev/null
@@ -1 +0,0 @@
-../../node/node0
\ No newline at end of file
diff --git a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu3/node0 b/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu3/node0
deleted file mode 120000
index 222b6af32..000000000
--- a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu3/node0
+++ /dev/null
@@ -1 +0,0 @@
-../../node/node0
\ No newline at end of file
diff --git a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu4/node0 b/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu4/node0
deleted file mode 120000
index 222b6af32..000000000
--- a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu4/node0
+++ /dev/null
@@ -1 +0,0 @@
-../../node/node0
\ No newline at end of file
diff --git a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu5/node0 b/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu5/node0
deleted file mode 120000
index 222b6af32..000000000
--- a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu5/node0
+++ /dev/null
@@ -1 +0,0 @@
-../../node/node0
\ No newline at end of file
diff --git a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu6/node0 b/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu6/node0
deleted file mode 120000
index 222b6af32..000000000
--- a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu6/node0
+++ /dev/null
@@ -1 +0,0 @@
-../../node/node0
\ No newline at end of file
diff --git a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu7/node0 b/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu7/node0
deleted file mode 120000
index 222b6af32..000000000
--- a/tests/virhostcpudata/linux-rhel74-moonshot/cpu/cpu7/node0
+++ /dev/null
@@ -1 +0,0 @@
-../../node/node0
\ No newline at end of file
--
2.14.3
6 years, 11 months
[libvirt] [PATCH 0/5] Proof of concept for libvirt_qemu shim process
by Daniel P. Berrange
This patch series provides a proof of concept impl of the libvirt_qemu
shim process I previously suggested here:
https://www.redhat.com/archives/libvir-list/2017-November/msg00526.html
The end goal is that we'll be able to fully isolate managemen to each
QEMU process. ie all the virDomain* APIs would be executed inside the
libvirt_qemu shim process. The QEMU driver in libvirtd would merely
deal with aggregating the views / tracking central resource allocations.
This series, however, does *not* do that. It is a very much smaller
proof of concept, principally to:
- Learn about pros/cons of different approaches for the long term
goal
- Provide a working PoC that can be used by the KubeVirt project
such that they can spawn QEMU in a separate docker container
than libvirtd is in, and inherit namespaces & cgroup placement, etc
So, in this series, libvirtd functionality remains essentially
unchanged. All I have done is provide a new binary 'libvirt_qemu'
that accepts an XML file as input, launches the QEMU process
directly, and then calls a new virDomainQemuReconnect() API to
make libvirtd aware of its existance. At this point libvirtd
can deal with it normally (some caveats listed in last patch).
Usage is pretty simple - start libvirtd normally, then to launch
a guest just use
$ libvirt_qemu /path/to/xml/file
It'll be associated with whatever libvirtd instance is running
with the same user account. ie if you launch libvirt_qemu as
root, it'll associate with qemu:///system.
By default it will still place VMs in a dedicated cgroup. To
inherit the cgroup of the caller, use <resource register="none"/>
in the XML schema to turn off cgroup setup in libvirt_qemu.
Having written this PoC, however, I'm less convinced that a bottom
up, minimal impl which incrementally picks certain subsets of QEMU
driver APIs to call is the right way to attack this problem. ie I
was intending to have this minimal shim, then gradually move
functionality into it from libvirtd. This feels like it is going
to create alot of busy-work, delaying the end goal.
I think instead a different approach might be better in the short
term. Take the existing libvirtd code as a starting point, clone
it to a libvirt_qemu and just start cutting out existing code to
make a lighter weight binary that can only run a single guest,
whose XML is passed in. We would still ultimately need to deal
with much of the same issues, like getting VMs reported to the
central libvirtd, but I think that might get to the end result,
where all APIs run inside the shim, quicker. The key difference
is that we could sooner focus on the harder problems of dealing
with shared resource allocation tracking, instead of doing lots
of code rewiring for API execution.
Daniel P. Berrange (5):
conf: allow different resource registration modes
conf: expose APIs to let drivers load individual config / status files
qemu: add a public API to trigger QEMU driver to connect to running
guest
qemu: implement the new virDomainQemuReconnect method
qemu: implement the 'libvirt_qemu' shim for launching guests
externally
include/libvirt/libvirt-qemu.h | 4 +
po/POTFILES.in | 1 +
src/Makefile.am | 49 ++++
src/conf/domain_conf.c | 42 +++-
src/conf/domain_conf.h | 12 +
src/conf/virdomainobjlist.c | 98 +++++---
src/conf/virdomainobjlist.h | 17 ++
src/driver-hypervisor.h | 5 +
src/libvirt-qemu.c | 48 ++++
src/libvirt_private.syms | 4 +
src/libvirt_qemu.syms | 5 +
src/lxc/lxc_cgroup.c | 34 +++
src/lxc/lxc_cgroup.h | 3 +
src/lxc/lxc_process.c | 11 +-
src/qemu/qemu_cgroup.c | 69 +++++-
src/qemu/qemu_conf.h | 2 +-
src/qemu/qemu_controller.c | 551 +++++++++++++++++++++++++++++++++++++++++
src/qemu/qemu_domain.c | 2 +-
src/qemu/qemu_driver.c | 59 ++++-
src/qemu/qemu_process.c | 31 ++-
src/qemu/qemu_process.h | 1 +
src/remote/qemu_protocol.x | 18 +-
src/remote/remote_driver.c | 1 +
src/util/vircgroup.c | 55 ++--
src/util/vircgroup.h | 10 +-
25 files changed, 1046 insertions(+), 86 deletions(-)
create mode 100644 src/qemu/qemu_controller.c
--
2.14.3
6 years, 11 months
[libvirt] [PATCH 0/3] processor frequency information on S390
by Bjoern Walk
Since kernel version 4.7, processor frequency information is available
on S390. This patch series extends the parser for both node information
and system information, respectively.
Let's also add a testcase to the test suite for a S390 CPU configuration
running kernel version 4.14 on LPAR.
This goes on top of Andrea's changes in here:
https://www.redhat.com/archives/libvir-list/2017-December/msg00519.html
Bjoern Walk (3):
util: virhostcpu: parse frequency information on S390
tests: virhostcputest: testcase for S390 system
util: virsysinfo: parse frequency information on S390
src/util/virhostcpu.c | 2 +
src/util/virsysinfo.c | 31 +++++++++++++
.../linux-s390x-with-frequency.cpuinfo | 52 ++++++++++++++++++++++
.../linux-s390x-with-frequency.expected | 1 +
.../linux-with-frequency/cpu/cpu0/online | 1 +
.../linux-with-frequency/cpu/cpu0/topology/book_id | 1 +
.../cpu/cpu0/topology/book_siblings | 1 +
.../cpu/cpu0/topology/book_siblings_list | 1 +
.../linux-with-frequency/cpu/cpu0/topology/core_id | 1 +
.../cpu/cpu0/topology/core_siblings | 1 +
.../cpu/cpu0/topology/core_siblings_list | 1 +
.../cpu/cpu0/topology/drawer_id | 1 +
.../cpu/cpu0/topology/drawer_siblings | 1 +
.../cpu/cpu0/topology/drawer_siblings_list | 1 +
.../cpu/cpu0/topology/physical_package_id | 1 +
.../cpu/cpu0/topology/thread_siblings | 1 +
.../cpu/cpu0/topology/thread_siblings_list | 1 +
.../linux-with-frequency/cpu/cpu1/online | 1 +
.../linux-with-frequency/cpu/cpu1/topology/book_id | 1 +
.../cpu/cpu1/topology/book_siblings | 1 +
.../cpu/cpu1/topology/book_siblings_list | 1 +
.../linux-with-frequency/cpu/cpu1/topology/core_id | 1 +
.../cpu/cpu1/topology/core_siblings | 1 +
.../cpu/cpu1/topology/core_siblings_list | 1 +
.../cpu/cpu1/topology/drawer_id | 1 +
.../cpu/cpu1/topology/drawer_siblings | 1 +
.../cpu/cpu1/topology/drawer_siblings_list | 1 +
.../cpu/cpu1/topology/physical_package_id | 1 +
.../cpu/cpu1/topology/thread_siblings | 1 +
.../cpu/cpu1/topology/thread_siblings_list | 1 +
.../linux-with-frequency/cpu/cpu2/online | 1 +
.../linux-with-frequency/cpu/cpu2/topology/book_id | 1 +
.../cpu/cpu2/topology/book_siblings | 1 +
.../cpu/cpu2/topology/book_siblings_list | 1 +
.../linux-with-frequency/cpu/cpu2/topology/core_id | 1 +
.../cpu/cpu2/topology/core_siblings | 1 +
.../cpu/cpu2/topology/core_siblings_list | 1 +
.../cpu/cpu2/topology/drawer_id | 1 +
.../cpu/cpu2/topology/drawer_siblings | 1 +
.../cpu/cpu2/topology/drawer_siblings_list | 1 +
.../cpu/cpu2/topology/physical_package_id | 1 +
.../cpu/cpu2/topology/thread_siblings | 1 +
.../cpu/cpu2/topology/thread_siblings_list | 1 +
.../linux-with-frequency/cpu/cpu3/online | 1 +
.../linux-with-frequency/cpu/cpu3/topology/book_id | 1 +
.../cpu/cpu3/topology/book_siblings | 1 +
.../cpu/cpu3/topology/book_siblings_list | 1 +
.../linux-with-frequency/cpu/cpu3/topology/core_id | 1 +
.../cpu/cpu3/topology/core_siblings | 1 +
.../cpu/cpu3/topology/core_siblings_list | 1 +
.../cpu/cpu3/topology/drawer_id | 1 +
.../cpu/cpu3/topology/drawer_siblings | 1 +
.../cpu/cpu3/topology/drawer_siblings_list | 1 +
.../cpu/cpu3/topology/physical_package_id | 1 +
.../cpu/cpu3/topology/thread_siblings | 1 +
.../cpu/cpu3/topology/thread_siblings_list | 1 +
.../linux-with-frequency/cpu/cpu4/online | 1 +
.../linux-with-frequency/cpu/cpu4/topology/book_id | 1 +
.../cpu/cpu4/topology/book_siblings | 1 +
.../cpu/cpu4/topology/book_siblings_list | 1 +
.../linux-with-frequency/cpu/cpu4/topology/core_id | 1 +
.../cpu/cpu4/topology/core_siblings | 1 +
.../cpu/cpu4/topology/core_siblings_list | 1 +
.../cpu/cpu4/topology/drawer_id | 1 +
.../cpu/cpu4/topology/drawer_siblings | 1 +
.../cpu/cpu4/topology/drawer_siblings_list | 1 +
.../cpu/cpu4/topology/physical_package_id | 1 +
.../cpu/cpu4/topology/thread_siblings | 1 +
.../cpu/cpu4/topology/thread_siblings_list | 1 +
.../linux-with-frequency/cpu/cpu5/online | 1 +
.../linux-with-frequency/cpu/cpu5/topology/book_id | 1 +
.../cpu/cpu5/topology/book_siblings | 1 +
.../cpu/cpu5/topology/book_siblings_list | 1 +
.../linux-with-frequency/cpu/cpu5/topology/core_id | 1 +
.../cpu/cpu5/topology/core_siblings | 1 +
.../cpu/cpu5/topology/core_siblings_list | 1 +
.../cpu/cpu5/topology/drawer_id | 1 +
.../cpu/cpu5/topology/drawer_siblings | 1 +
.../cpu/cpu5/topology/drawer_siblings_list | 1 +
.../cpu/cpu5/topology/physical_package_id | 1 +
.../cpu/cpu5/topology/thread_siblings | 1 +
.../cpu/cpu5/topology/thread_siblings_list | 1 +
.../linux-with-frequency/cpu/cpu6/online | 1 +
.../linux-with-frequency/cpu/cpu6/topology/book_id | 1 +
.../cpu/cpu6/topology/book_siblings | 1 +
.../cpu/cpu6/topology/book_siblings_list | 1 +
.../linux-with-frequency/cpu/cpu6/topology/core_id | 1 +
.../cpu/cpu6/topology/core_siblings | 1 +
.../cpu/cpu6/topology/core_siblings_list | 1 +
.../cpu/cpu6/topology/drawer_id | 1 +
.../cpu/cpu6/topology/drawer_siblings | 1 +
.../cpu/cpu6/topology/drawer_siblings_list | 1 +
.../cpu/cpu6/topology/physical_package_id | 1 +
.../cpu/cpu6/topology/thread_siblings | 1 +
.../cpu/cpu6/topology/thread_siblings_list | 1 +
.../linux-with-frequency/cpu/cpu7/online | 1 +
.../linux-with-frequency/cpu/cpu7/topology/book_id | 1 +
.../cpu/cpu7/topology/book_siblings | 1 +
.../cpu/cpu7/topology/book_siblings_list | 1 +
.../linux-with-frequency/cpu/cpu7/topology/core_id | 1 +
.../cpu/cpu7/topology/core_siblings | 1 +
.../cpu/cpu7/topology/core_siblings_list | 1 +
.../cpu/cpu7/topology/drawer_id | 1 +
.../cpu/cpu7/topology/drawer_siblings | 1 +
.../cpu/cpu7/topology/drawer_siblings_list | 1 +
.../cpu/cpu7/topology/physical_package_id | 1 +
.../cpu/cpu7/topology/thread_siblings | 1 +
.../cpu/cpu7/topology/thread_siblings_list | 1 +
.../virhostcpudata/linux-with-frequency/cpu/online | 1 +
.../linux-with-frequency/cpu/present | 1 +
tests/virhostcputest.c | 1 +
111 files changed, 193 insertions(+)
create mode 100644 tests/virhostcpudata/linux-s390x-with-frequency.cpuinfo
create mode 100644 tests/virhostcpudata/linux-s390x-with-frequency.expected
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu0/online
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu0/topology/book_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu0/topology/book_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu0/topology/book_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu0/topology/core_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu0/topology/core_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu0/topology/core_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu0/topology/drawer_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu0/topology/drawer_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu0/topology/drawer_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu0/topology/physical_package_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu0/topology/thread_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu0/topology/thread_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu1/online
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu1/topology/book_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu1/topology/book_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu1/topology/book_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu1/topology/core_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu1/topology/core_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu1/topology/core_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu1/topology/drawer_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu1/topology/drawer_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu1/topology/drawer_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu1/topology/physical_package_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu1/topology/thread_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu1/topology/thread_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu2/online
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu2/topology/book_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu2/topology/book_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu2/topology/book_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu2/topology/core_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu2/topology/core_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu2/topology/core_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu2/topology/drawer_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu2/topology/drawer_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu2/topology/drawer_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu2/topology/physical_package_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu2/topology/thread_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu2/topology/thread_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu3/online
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu3/topology/book_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu3/topology/book_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu3/topology/book_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu3/topology/core_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu3/topology/core_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu3/topology/core_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu3/topology/drawer_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu3/topology/drawer_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu3/topology/drawer_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu3/topology/physical_package_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu3/topology/thread_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu3/topology/thread_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu4/online
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu4/topology/book_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu4/topology/book_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu4/topology/book_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu4/topology/core_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu4/topology/core_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu4/topology/core_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu4/topology/drawer_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu4/topology/drawer_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu4/topology/drawer_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu4/topology/physical_package_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu4/topology/thread_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu4/topology/thread_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu5/online
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu5/topology/book_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu5/topology/book_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu5/topology/book_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu5/topology/core_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu5/topology/core_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu5/topology/core_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu5/topology/drawer_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu5/topology/drawer_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu5/topology/drawer_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu5/topology/physical_package_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu5/topology/thread_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu5/topology/thread_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu6/online
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu6/topology/book_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu6/topology/book_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu6/topology/book_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu6/topology/core_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu6/topology/core_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu6/topology/core_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu6/topology/drawer_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu6/topology/drawer_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu6/topology/drawer_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu6/topology/physical_package_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu6/topology/thread_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu6/topology/thread_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu7/online
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu7/topology/book_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu7/topology/book_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu7/topology/book_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu7/topology/core_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu7/topology/core_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu7/topology/core_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu7/topology/drawer_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu7/topology/drawer_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu7/topology/drawer_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu7/topology/physical_package_id
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu7/topology/thread_siblings
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/cpu7/topology/thread_siblings_list
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/online
create mode 100644 tests/virhostcpudata/linux-with-frequency/cpu/present
--
2.13.4
6 years, 11 months
[libvirt] [PATCH] tests: Remove trailing whitespace
by John Ferlan
Commit/push resulted in following error:
remote: tests/virhostcpudata/linux-s390x-with-frequency.cpuinfo:5: trailing whitespace.
remote: +features : esan3 zarch stfle msa ldisp eimm dfp edat etf3eh highgprs te vx sie
remote: error: hook declined to update refs/heads/master
Just removed the trailing whitespace.
Signed-off-by: John Ferlan <jferlan(a)redhat.com>
---
Missed this during 'git am' processing and the syntax-check didn't find it
either, but the push hook did. Just update the file to remove the trailing
whitespace (built and tested just fine).
tests/virhostcpudata/linux-s390x-with-frequency.cpuinfo | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/virhostcpudata/linux-s390x-with-frequency.cpuinfo b/tests/virhostcpudata/linux-s390x-with-frequency.cpuinfo
index 0edc371dd..b50aa18c3 100644
--- a/tests/virhostcpudata/linux-s390x-with-frequency.cpuinfo
+++ b/tests/virhostcpudata/linux-s390x-with-frequency.cpuinfo
@@ -2,7 +2,7 @@ vendor_id : IBM/S390
# processors : 8
bogomips per cpu: 20325.00
max thread id : 1
-features : esan3 zarch stfle msa ldisp eimm dfp edat etf3eh highgprs te vx sie
+features : esan3 zarch stfle msa ldisp eimm dfp edat etf3eh highgprs te vx sie
facilities : 0 1 2 3 4 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 30 31 32 33 34 35 36 37 40 41 42 43 44 45 46 47 48 49 50 51 52 53 55 57 64 65 66 67 68 69 70 71 72 73 75 76 77 78 80 128 129 131 132 142 143
cache0 : level=1 type=Data scope=Private size=128K line_size=256 associativity=8
cache1 : level=1 type=Instruction scope=Private size=96K line_size=256 associativity=6
--
2.13.6
6 years, 11 months
