April 2017 - Devel - libvirt List Archives

[libvirt] [PATCH v2 0/2] libvirt-python: libvirtaio
by Wojtek Porczyk 05 Apr '17

05 Apr '17

Hello, libvirt-list, This is second attempt at merging libvirtaio, an event loop implementation which dispatches the callbacks via asyncio's event loop. The first patch fixes the bug around freeing opaque objects [1][2], and the second one is the actual implementation. Since v1 series, as per Daniel Berrange's notes, the second patch has licence comment changed to LGPL-2.1+ and there is no import into main libvirt module. The first patch is unchanged. [1] https://www.redhat.com/archives/libvir-list/2017-January/msg00863.html [2] https://bugzilla.redhat.com/show_bug.cgi?id=1433028 Wojtek Porczyk (2): Allow for ff callbacks to be called by custom event implementations Add asyncio event loop implementation libvirt-override.c | 36 ++--- libvirt-override.py | 39 +++++ libvirt-python.spec.in | 1 + libvirtaio.py | 401 +++++++++++++++++++++++++++++++++++++++++++++++++ sanitytest.py | 5 +- setup.py | 12 ++ 6 files changed, 468 insertions(+), 26 deletions(-) create mode 100644 libvirtaio.py -- pozdrawiam / best regards _.-._ Wojtek Porczyk .-^' '^-. Invisible Things Lab |'-.-^-.-'| | | | | I do not fear computers, | '-.-' | I fear lack of them. '-._ : ,-' -- Isaac Asimov `^-^-_>

2 7

[libvirt] [PATCH v3.2-maint 0/2] Maintenance branch details
by Martin Kletzander 04 Apr '17

04 Apr '17

So I just created v3.2-maint with one rather important back-port. This is what I would've pushed with it, but I'd rather know the opinions on whether one or both ideas are stupid. Thanks. Martin Kletzander (2): Maintenance branch version bump docs: Add vz driver typo fix to news.xml configure.ac | 2 +- docs/news.xml | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) -- 2.12.2

2 4

[libvirt] [PATCH] libvirt_public.syms: Fix virDomainSetBlockThreshold placement
by Michal Privoznik 04 Apr '17

04 Apr '17

The symbol was introduced in the 3.2.0 release (bb09798fbeb5f) and not 3.1.0 release as its current placement in the file suggests. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/libvirt_public.syms | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/libvirt_public.syms b/src/libvirt_public.syms index 428cf2e..37a8a18 100644 --- a/src/libvirt_public.syms +++ b/src/libvirt_public.syms @@ -755,8 +755,12 @@ LIBVIRT_3.0.0 { LIBVIRT_3.1.0 { global: - virDomainSetBlockThreshold; virDomainSetVcpu; } LIBVIRT_3.0.0; +LIBVIRT_3.2.0 { + global: + virDomainSetBlockThreshold; +} LIBVIRT_3.1.0; + # .... define new API here using predicted next version number .... -- 2.10.2

3 6

[libvirt] [PATCH] vz: fix typo that breaks build
by Nikolay Shirokovskiy 04 Apr '17

04 Apr '17

--- I guess it should be back ported to 3.2.0 release too. Sorry that we missed this during freeze period. src/vz/vz_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index bb1afd0..da83a8f 100644 --- a/src/vz/vz_driver.c +++ b/src/vz/vz_driver.c @@ -121,7 +121,7 @@ vzBuildCapabilities(void) verify(ARRAY_CARDINALITY(archs) == ARRAY_CARDINALITY(emulators)); - for (i = 0; i < ARRAY_CARDINALITY(os_types); i++) + for (i = 0; i < ARRAY_CARDINALITY(ostypes); i++) for (j = 0; j < ARRAY_CARDINALITY(archs); j++) for (k = 0; k < ARRAY_CARDINALITY(emulators); k++) if (vzCapsAddGuestDomain(caps, ostypes[i], archs[j], -- 1.8.3.1

2 2

[libvirt] [PATCH] qemu: Break endless loop if qemuMigrationResetTLS fails
by Jiri Denemark 04 Apr '17

04 Apr '17

Jumping to "endjob" label from a code after this label is not a very good idea. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_migration.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 87d7dcd0c..7f00a3d93 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -5351,9 +5351,7 @@ qemuMigrationFinish(virQEMUDriverPtr driver, QEMU_ASYNC_JOB_MIGRATION_IN); } - if (qemuMigrationResetTLS(driver, vm, QEMU_ASYNC_JOB_MIGRATION_IN, - NULL, NULL) < 0) - goto endjob; + qemuMigrationResetTLS(driver, vm, QEMU_ASYNC_JOB_MIGRATION_IN, NULL, NULL); qemuMigrationJobFinish(driver, vm); if (!virDomainObjIsActive(vm)) -- 2.12.2

3 4

[libvirt] [PATCH 0/2] More clang-inspired fixes
by Ján Tomko 04 Apr '17

04 Apr '17

Hopefully, the split of library/non-library code will let us tighten the frame limit in the future. Ján Tomko (2): util: ignore -Wcast-align in virNetlinkDumpCommand Split out -Wframe-larger-than warning from WARN_CLFAGS daemon/Makefile.am | 3 +++ m4/virt-compile-warnings.m4 | 4 ++-- src/Makefile.am | 1 + src/util/virnetlink.c | 3 ++- tests/Makefile.am | 2 ++ tools/Makefile.am | 6 ++++++ 6 files changed, 16 insertions(+), 3 deletions(-) -- 2.10.2

3 5

[libvirt] [PATCH v2 0/5] Fix gluster pool lookup issues
by Peter Krempa 04 Apr '17

04 Apr '17

Peter Krempa (5): storage: util: Add boolean differentiating between gluster lookup type storage: util: Split out the gluster volume extraction code into new function test: Introduce testing of virStorageUtilGlusterExtractPoolSources storage: Fix XPath for looking up gluster volume name storage: gluster: Use volume name as "<name>" field in the XML src/storage/storage_backend_fs.c | 5 +- src/storage/storage_backend_gluster.c | 3 +- src/storage/storage_util.c | 110 ++++++++++++-------- src/storage/storage_util.h | 6 +- tests/Makefile.am | 15 ++- .../gluster-parse-basic-native.xml | 7 ++ .../gluster-parse-basic-netfs.xml | 7 ++ .../virstorageutildata/gluster-parse-basic-src.xml | 47 +++++++++ .../gluster-parse-multivol-native.xml | 17 +++ .../gluster-parse-multivol-netfs.xml | 17 +++ .../gluster-parse-multivol-src.xml | 32 ++++++ tests/virstorageutiltest.c | 114 +++++++++++++++++++++ 12 files changed, 330 insertions(+), 50 deletions(-) create mode 100644 tests/virstorageutildata/gluster-parse-basic-native.xml create mode 100644 tests/virstorageutildata/gluster-parse-basic-netfs.xml create mode 100644 tests/virstorageutildata/gluster-parse-basic-src.xml create mode 100644 tests/virstorageutildata/gluster-parse-multivol-native.xml create mode 100644 tests/virstorageutildata/gluster-parse-multivol-netfs.xml create mode 100644 tests/virstorageutildata/gluster-parse-multivol-src.xml create mode 100644 tests/virstorageutiltest.c -- 2.12.1

2 14

[libvirt] [PATCH] news.rng: work around a bug in old libxml2
by Ján Tomko 04 Apr '17

04 Apr '17

Similar to commit c3c2cc6, use a literal newsline instead of \n inside the brackets. --- Pushed as a build fix. docs/schemas/news.rng | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/schemas/news.rng b/docs/schemas/news.rng index ec4313f..a633e22 100644 --- a/docs/schemas/news.rng +++ b/docs/schemas/news.rng @@ -45,7 +45,9 @@ <element name="change"> <element name="summary"> <data type="string"> - <param name="pattern">\n[^\n]+\n +</param> +  + <param name="pattern">\n[^ +]+\n +</param> </data> </element> <optional> -- 2.10.2

3 3

[libvirt] [PATCH 0/2] news: Further improvements
by Andrea Bolognani 04 Apr '17

04 Apr '17

This applies on top of Peter's series[1], which has already been ACKed. [1] https://www.redhat.com/archives/libvir-list/2017-March/msg01478.html Andrea Bolognani (2): news: Remove handling of random HTML tags news: Allow empty <section> elements docs/news-html.xsl | 20 +++++++++----------- docs/news.xml | 9 --------- docs/schemas/news.rng | 17 ++++++++--------- 3 files changed, 17 insertions(+), 29 deletions(-) -- 2.7.4

3 5

[libvirt] [PATCH 0/3] A couple of Coverity found issues
by John Ferlan 04 Apr '17

04 Apr '17

There's more, but many are false positives and there's also a couple more that I have to think more deeply about... John Ferlan (3): tests: Pass BlockIOThrottle arguments by reference not value qemu: Initialize 'data' argument qemu: Fix resource leak in qemuDomainAddChardevTLSObjects error path src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_migration.c | 11 ++++++++--- tests/qemumonitorjsontest.c | 38 +++++++++++++++++++------------------- 3 files changed, 28 insertions(+), 23 deletions(-) -- 2.9.3

2 4