June 2016 - Devel - libvirt List Archives

[libvirt] [PATCH 1/1] cpu_map.xml: add cmt/mbm feature to x86
by Qiaowei Ren 24 Jun '16

24 Jun '16

Some Intel processor families (e.g. the Intel Xeon processor E5 v3 family) introduced some PQos (Platform Qos) features, including CMT (Cache Monitoring echnology) and MBM (Memory Bandwidth Monitoring), to monitor or control shared resource. This patch add them into x86 part of cpu_map.xml to be used for applications (like OpenStack) based on libvirt to get cpu capabilities. Signed-off-by: Qiaowei Ren <qiaowei.ren(a)intel.com> --- src/cpu/cpu_map.xml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml index 08aded2..2e2cb4f 100644 --- a/src/cpu/cpu_map.xml +++ b/src/cpu/cpu_map.xml @@ -320,6 +320,9 @@ <feature name='rtm'> <cpuid function='0x00000007' ebx='0x00000800'/> </feature> + <feature name='cmt'> + <cpuid function='0x00000007' ebx='0x00001000'/> + </feature> <feature name='mpx'> <cpuid function='0x00000007' ebx='0x00004000'/> </feature> @@ -353,6 +356,14 @@ <cpuid function='0x80000007' edx='0x00000100'/> </feature> +  + <feature name='mbm_total'>  + <cpuid function='0x0000000f' edx='0x00000002'/> + </feature> + <feature name='mbm_local'>  + <cpuid function='0x0000000f' edx='0x00000004'/> + </feature> +  <model name='486'> <feature name='fpu'/> -- 1.9.1

4 6

[libvirt] [PATCH 0/2] Warn users with weird thread/memory alignment
by Martin Kletzander 24 Jun '16

24 Jun '16

People are doing weird things. Let's let them do what they want but gently warn them in case they did not want that exact behaviour and are looking for some possible problems. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1254402 Martin Kletzander (2): qemu: Add qemuProcessSetupPid() qemu: Check for thread <=> memory alignment src/qemu/qemu_driver.c | 4 +- src/qemu/qemu_process.c | 375 ++++++++++++++++++++++-------------------------- src/qemu/qemu_process.h | 6 +- 3 files changed, 181 insertions(+), 204 deletions(-) -- 2.9.0

3 9

[libvirt] [PATCH] Don't allow raneming domains to empty strings
by Martin Kletzander 24 Jun '16

24 Jun '16

It may cause unwanted behaviour (of course, is there any wanted one for that case?) so we should rather disable the possibility of doing so. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1320893 Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- src/libvirt-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 508520efd6c5..89a2d7efe972 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -8790,7 +8790,7 @@ virDomainRename(virDomainPtr dom, virResetLastError(); virCheckDomainReturn(dom, -1); - virCheckNonNullArgGoto(new_name, error); + virCheckNonEmptyStringArgGoto(new_name, error); virCheckReadOnlyGoto(dom->conn->flags, error); if (dom->conn->driver->domainRename) { -- 2.9.0

4 5

[libvirt] [PATCH 0/3] Add hotplug/unplug for RBD disk with AES secret
by John Ferlan 24 Jun '16

24 Jun '16

Since AES secrets were setup for RBD during qemuDomainSecretDiskPrepare, the secret object needs to be added to the command line when hotplugging. Additionally, when unplugging, if there's an AES secret, we need to remove it. John Ferlan (3): qemu: Remove type from qemuBuildSecretInfoProps qemu: Make qemuBuildSecretInfoProps global qemu: Add secinfo for hotplug virtio disk src/qemu/qemu_command.c | 11 +++-------- src/qemu/qemu_command.h | 4 ++++ src/qemu/qemu_hotplug.c | 44 ++++++++++++++++++++++++++++++++++++++------ 3 files changed, 45 insertions(+), 14 deletions(-) -- 2.5.5

2 6

[libvirt] [libvirt-test-API] Plans for code update
by Ruifeng Bian 24 Jun '16

24 Jun '16

I am not sure how many of you keep an eye on this project. The project is for testing libvirt-python APIs, but many test cases are not fully implemented until now. We want to keep this project updated in the future, the following aspects will be considered to update the code: 1. Code style - Use inspekt to check code style. 2. Pythonizing the code - Replace all shell scripts with python. 3. Bug fixing - Some code bugs need to be fixed. 4. New features - Add more API test cases. Any feedback or suggestion is welcome. Let's work together to contribute to this project. Thanks, Ruifeng Bian

2 4

[libvirt] [PATCH 0/4] Add architecture checks to qemuDomainMachineIs*()
by Andrea Bolognani 24 Jun '16

24 Jun '16

The pseries machine type is only available on ppc64/ppc64le, and in the same way the virt machine type is only available on armv7l/aarch64. Until either machine type is introduced on another architecture, we can perform the architecture checks in a single location instead of repeating them all over the place. Andrea Bolognani (4): qemu: Remove redundant arguments to qemuBuildSerialChrDeviceStr() qemu: Add architecture checks to qemuDomainMachineIsVirt() qemu: Introduce qemuDomainMachineIsPSeries() qemu: Use stricter checks in virQEMUCapsFillDomainDeviceDiskCaps() src/qemu/qemu_capabilities.c | 18 +++++++++--------- src/qemu/qemu_command.c | 25 ++++++++----------------- src/qemu/qemu_domain.c | 31 +++++++++++++++++++++++++------ src/qemu/qemu_domain.h | 1 + src/qemu/qemu_domain_address.c | 9 +++------ src/qemu/qemu_parse_command.c | 12 ++++-------- 6 files changed, 50 insertions(+), 46 deletions(-) -- 2.7.4

2 10

[libvirt] [PATCH] openvz: split single-line if
by Ján Tomko 24 Jun '16

24 Jun '16

Put the 'continue' statement on a separate line. --- src/openvz/openvz_conf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Pushed as trivial. diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index ff5e5b8..aa04bc4 100644 --- a/src/openvz/openvz_conf.c +++ b/src/openvz/openvz_conf.c @@ -741,7 +741,8 @@ openvzReadConfigParam(const char *conf_file, const char *param, char **value) continue; sf = line + strlen(param); - if (*sf++ != '=') continue; + if (*sf++ != '=') + continue; saveptr = NULL; if ((token = strtok_r(sf, "\"\t\n", &saveptr)) != NULL) { -- 2.7.3

1 0

[libvirt] [RFC PATCH] build: increase xz compression level
by Ján Tomko 24 Jun '16

24 Jun '16

Increase the default compression level to 9 from 6. This also increases decompression memory requirements from 9 MB to 65 MB. --- The resulting tarball is 880 kB smaller [10.5 MB] Level 8 requires 33 MB and saves 520 kB [10.8 MB] Level 7 requires 17 MB and saves 170 kB [11.2 MB] Compression time is not much different since we're already using --extreme. The Linux kernel also uses -9, but the tarball is 8x our size. cfg.mk | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cfg.mk b/cfg.mk index e93114c..ebafb0f 100644 --- a/cfg.mk +++ b/cfg.mk @@ -16,6 +16,9 @@ # along with this program. If not, see # <http://www.gnu.org/licenses/>. +XZ_OPT ?= -9e +export XZ_OPT + # Use alpha.gnu.org for alpha and beta releases. # Use ftp.gnu.org for major releases. gnu_ftp_host-alpha = alpha.gnu.org -- 2.7.3

2 1

[libvirt] [PATCH 0/7] *** Add VirtualBox 5 support to libvirt ***
by Martin Pietsch 24 Jun '16

24 Jun '16

*** BLURB HERE *** Martin Pietsch (7): add VirtualBox 5 C API to libvirt add VirtualBox 5 support to vbox_tmpl.c add VirtualBox5 support to vbox_uniformed_api.h add vbox_V5_0.c for libvirt support of VirtualBox 5 append vbox_V5_0.c and vbox_CAPI_v5_0.h to src/Makefile.am add VirtualBox 5 support to vbox_common.h add VirtualBox 5 support to vbox_storage.c src/Makefile.am | 1 + src/vbox/vbox_CAPI_v5_0.h | 25550 ++++++++++++++++++++++++++++++++++++++++ src/vbox/vbox_V5_0.c | 13 + src/vbox/vbox_common.h | 2 + src/vbox/vbox_storage.c | 2 + src/vbox/vbox_tmpl.c | 84 +- src/vbox/vbox_uniformed_api.h | 1 + 7 files changed, 25647 insertions(+), 6 deletions(-) create mode 100644 src/vbox/vbox_CAPI_v5_0.h create mode 100644 src/vbox/vbox_V5_0.c -- 2.7.4

2 1

[libvirt] [PATCH] storage: Fix coverity warning
by Cole Robinson 24 Jun '16

24 Jun '16

After commit e808d3f227 cbdata is always available here, so the check is pointless --- src/storage/storage_driver.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 4b5419d..d75c5aa 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -2442,12 +2442,10 @@ storageVolUpload(virStorageVolPtr obj, /* Add cleanup callback - call after uploadVol since the stream * is then fully set up */ - if (cbdata) { - virFDStreamSetInternalCloseCb(stream, - virStorageVolFDStreamCloseCb, - cbdata, NULL); - cbdata = NULL; - } + virFDStreamSetInternalCloseCb(stream, + virStorageVolFDStreamCloseCb, + cbdata, NULL); + cbdata = NULL; cleanup: virStoragePoolObjUnlock(pool); -- 2.7.4

2 1