[libvirt] [PATCH 0/2] Warn users with weird thread/memory alignment
by Martin Kletzander
People are doing weird things. Let's let them do what they want but
gently warn them in case they did not want that exact behaviour and
are looking for some possible problems.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1254402
Martin Kletzander (2):
qemu: Add qemuProcessSetupPid()
qemu: Check for thread <=> memory alignment
src/qemu/qemu_driver.c | 4 +-
src/qemu/qemu_process.c | 375 ++++++++++++++++++++++--------------------------
src/qemu/qemu_process.h | 6 +-
3 files changed, 181 insertions(+), 204 deletions(-)
--
2.9.0
8 years, 6 months
[libvirt] [PATCH] Don't allow raneming domains to empty strings
by Martin Kletzander
It may cause unwanted behaviour (of course, is there any wanted one for
that case?) so we should rather disable the possibility of doing so.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1320893
Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
---
src/libvirt-domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 508520efd6c5..89a2d7efe972 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -8790,7 +8790,7 @@ virDomainRename(virDomainPtr dom,
virResetLastError();
virCheckDomainReturn(dom, -1);
- virCheckNonNullArgGoto(new_name, error);
+ virCheckNonEmptyStringArgGoto(new_name, error);
virCheckReadOnlyGoto(dom->conn->flags, error);
if (dom->conn->driver->domainRename) {
--
2.9.0
8 years, 6 months
[libvirt] [PATCH 0/3] Add hotplug/unplug for RBD disk with AES secret
by John Ferlan
Since AES secrets were setup for RBD during qemuDomainSecretDiskPrepare,
the secret object needs to be added to the command line when hotplugging.
Additionally, when unplugging, if there's an AES secret, we need to remove it.
John Ferlan (3):
qemu: Remove type from qemuBuildSecretInfoProps
qemu: Make qemuBuildSecretInfoProps global
qemu: Add secinfo for hotplug virtio disk
src/qemu/qemu_command.c | 11 +++--------
src/qemu/qemu_command.h | 4 ++++
src/qemu/qemu_hotplug.c | 44 ++++++++++++++++++++++++++++++++++++++------
3 files changed, 45 insertions(+), 14 deletions(-)
--
2.5.5
8 years, 6 months
[libvirt] [libvirt-test-API] Plans for code update
by Ruifeng Bian
I am not sure how many of you keep an eye on this project. The project is for
testing libvirt-python APIs, but many test cases are not fully implemented until
now. We want to keep this project updated in the future, the following aspects
will be considered to update the code:
1. Code style - Use inspekt to check code style.
2. Pythonizing the code - Replace all shell scripts with python.
3. Bug fixing - Some code bugs need to be fixed.
4. New features - Add more API test cases.
Any feedback or suggestion is welcome. Let's work together to contribute
to this project.
Thanks,
Ruifeng Bian
8 years, 6 months
[libvirt] [PATCH 0/4] Add architecture checks to qemuDomainMachineIs*()
by Andrea Bolognani
The pseries machine type is only available on ppc64/ppc64le,
and in the same way the virt machine type is only available
on armv7l/aarch64.
Until either machine type is introduced on another
architecture, we can perform the architecture checks in a
single location instead of repeating them all over the place.
Andrea Bolognani (4):
qemu: Remove redundant arguments to qemuBuildSerialChrDeviceStr()
qemu: Add architecture checks to qemuDomainMachineIsVirt()
qemu: Introduce qemuDomainMachineIsPSeries()
qemu: Use stricter checks in virQEMUCapsFillDomainDeviceDiskCaps()
src/qemu/qemu_capabilities.c | 18 +++++++++---------
src/qemu/qemu_command.c | 25 ++++++++-----------------
src/qemu/qemu_domain.c | 31 +++++++++++++++++++++++++------
src/qemu/qemu_domain.h | 1 +
src/qemu/qemu_domain_address.c | 9 +++------
src/qemu/qemu_parse_command.c | 12 ++++--------
6 files changed, 50 insertions(+), 46 deletions(-)
--
2.7.4
8 years, 6 months
[libvirt] [PATCH] openvz: split single-line if
by Ján Tomko
Put the 'continue' statement on a separate line.
---
src/openvz/openvz_conf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Pushed as trivial.
diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c
index ff5e5b8..aa04bc4 100644
--- a/src/openvz/openvz_conf.c
+++ b/src/openvz/openvz_conf.c
@@ -741,7 +741,8 @@ openvzReadConfigParam(const char *conf_file, const char *param, char **value)
continue;
sf = line + strlen(param);
- if (*sf++ != '=') continue;
+ if (*sf++ != '=')
+ continue;
saveptr = NULL;
if ((token = strtok_r(sf, "\"\t\n", &saveptr)) != NULL) {
--
2.7.3
8 years, 6 months
[libvirt] [RFC PATCH] build: increase xz compression level
by Ján Tomko
Increase the default compression level to 9 from 6.
This also increases decompression memory requirements
from 9 MB to 65 MB.
---
The resulting tarball is 880 kB smaller [10.5 MB]
Level 8 requires 33 MB and saves 520 kB [10.8 MB]
Level 7 requires 17 MB and saves 170 kB [11.2 MB]
Compression time is not much different since we're already using --extreme.
The Linux kernel also uses -9, but the tarball is 8x our size.
cfg.mk | 3 +++
1 file changed, 3 insertions(+)
diff --git a/cfg.mk b/cfg.mk
index e93114c..ebafb0f 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -16,6 +16,9 @@
# along with this program. If not, see
# <http://www.gnu.org/licenses/>.
+XZ_OPT ?= -9e
+export XZ_OPT
+
# Use alpha.gnu.org for alpha and beta releases.
# Use ftp.gnu.org for major releases.
gnu_ftp_host-alpha = alpha.gnu.org
--
2.7.3
8 years, 6 months
[libvirt] [PATCH 0/7] *** Add VirtualBox 5 support to libvirt ***
by Martin Pietsch
*** BLURB HERE ***
Martin Pietsch (7):
add VirtualBox 5 C API to libvirt
add VirtualBox 5 support to vbox_tmpl.c
add VirtualBox5 support to vbox_uniformed_api.h
add vbox_V5_0.c for libvirt support of VirtualBox 5
append vbox_V5_0.c and vbox_CAPI_v5_0.h to src/Makefile.am
add VirtualBox 5 support to vbox_common.h
add VirtualBox 5 support to vbox_storage.c
src/Makefile.am | 1 +
src/vbox/vbox_CAPI_v5_0.h | 25550 ++++++++++++++++++++++++++++++++++++++++
src/vbox/vbox_V5_0.c | 13 +
src/vbox/vbox_common.h | 2 +
src/vbox/vbox_storage.c | 2 +
src/vbox/vbox_tmpl.c | 84 +-
src/vbox/vbox_uniformed_api.h | 1 +
7 files changed, 25647 insertions(+), 6 deletions(-)
create mode 100644 src/vbox/vbox_CAPI_v5_0.h
create mode 100644 src/vbox/vbox_V5_0.c
--
2.7.4
8 years, 6 months
[libvirt] [PATCH] storage: Fix coverity warning
by Cole Robinson
After commit e808d3f227 cbdata is always available here, so the
check is pointless
---
src/storage/storage_driver.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c
index 4b5419d..d75c5aa 100644
--- a/src/storage/storage_driver.c
+++ b/src/storage/storage_driver.c
@@ -2442,12 +2442,10 @@ storageVolUpload(virStorageVolPtr obj,
/* Add cleanup callback - call after uploadVol since the stream
* is then fully set up
*/
- if (cbdata) {
- virFDStreamSetInternalCloseCb(stream,
- virStorageVolFDStreamCloseCb,
- cbdata, NULL);
- cbdata = NULL;
- }
+ virFDStreamSetInternalCloseCb(stream,
+ virStorageVolFDStreamCloseCb,
+ cbdata, NULL);
+ cbdata = NULL;
cleanup:
virStoragePoolObjUnlock(pool);
--
2.7.4
8 years, 6 months
[libvirt] [PATCH] Rename virNetClient*AddrString
by Ján Tomko
Add SASL at the end to make the format obvious.
---
src/libvirt_remote.syms | 4 ++--
src/remote/remote_driver.c | 4 ++--
src/rpc/virnetclient.c | 4 ++--
src/rpc/virnetclient.h | 4 ++--
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/libvirt_remote.syms b/src/libvirt_remote.syms
index a6192ef..ca1f3ac 100644
--- a/src/libvirt_remote.syms
+++ b/src/libvirt_remote.syms
@@ -17,7 +17,7 @@ virNetClientIsOpen;
virNetClientKeepAliveIsSupported;
virNetClientKeepAliveStart;
virNetClientKeepAliveStop;
-virNetClientLocalAddrString;
+virNetClientLocalAddrStringSASL;
virNetClientNewExternal;
virNetClientNewLibSSH2;
virNetClientNewSSH;
@@ -25,7 +25,7 @@ virNetClientNewTCP;
virNetClientNewUNIX;
virNetClientRegisterAsyncIO;
virNetClientRegisterKeepAlive;
-virNetClientRemoteAddrString;
+virNetClientRemoteAddrStringSASL;
virNetClientRemoveStream;
virNetClientSendNonBlock;
virNetClientSendNoReply;
diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index b11bfe0..1f81f03 100644
--- a/src/remote/remote_driver.c
+++ b/src/remote/remote_driver.c
@@ -3831,8 +3831,8 @@ remoteAuthSASL(virConnectPtr conn, struct private_data *priv,
if (!(sasl = virNetSASLSessionNewClient(saslCtxt,
"libvirt",
priv->hostname,
- virNetClientLocalAddrString(priv->client),
- virNetClientRemoteAddrString(priv->client),
+ virNetClientLocalAddrStringSASL(priv->client),
+ virNetClientRemoteAddrStringSASL(priv->client),
saslcb)))
goto cleanup;
/* saslcb is now owned by sasl */
diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c
index c43cd08..361dc1a 100644
--- a/src/rpc/virnetclient.c
+++ b/src/rpc/virnetclient.c
@@ -944,12 +944,12 @@ void virNetClientRemoveStream(virNetClientPtr client,
}
-const char *virNetClientLocalAddrString(virNetClientPtr client)
+const char *virNetClientLocalAddrStringSASL(virNetClientPtr client)
{
return virNetSocketLocalAddrStringSASL(client->sock);
}
-const char *virNetClientRemoteAddrString(virNetClientPtr client)
+const char *virNetClientRemoteAddrStringSASL(virNetClientPtr client)
{
return virNetSocketRemoteAddrStringSASL(client->sock);
}
diff --git a/src/rpc/virnetclient.h b/src/rpc/virnetclient.h
index 38f929c..c772d0b 100644
--- a/src/rpc/virnetclient.h
+++ b/src/rpc/virnetclient.h
@@ -121,8 +121,8 @@ int virNetClientSetTLSSession(virNetClientPtr client,
bool virNetClientIsEncrypted(virNetClientPtr client);
bool virNetClientIsOpen(virNetClientPtr client);
-const char *virNetClientLocalAddrString(virNetClientPtr client);
-const char *virNetClientRemoteAddrString(virNetClientPtr client);
+const char *virNetClientLocalAddrStringSASL(virNetClientPtr client);
+const char *virNetClientRemoteAddrStringSASL(virNetClientPtr client);
# ifdef WITH_GNUTLS
int virNetClientGetTLSKeySize(virNetClientPtr client);
--
2.7.3
8 years, 6 months
