June 2016 - Devel - Libvirt List Archives

[libvirt] [PATCH 0/3] A few more cleanups

by Ján Tomko

Ján Tomko (3): Replace some uses STREQLEN with STRPREFIX Fix error detection in virStorageBackendISCSIGetHostNumber openvz: do not open-code STRSKIP src/openvz/openvz_conf.c | 3 +-- src/qemu/qemu_command.c | 2 +- src/storage/storage_backend_iscsi.c | 42 ++++++++++++++++++------------------- src/storage/storage_backend_scsi.c | 2 +- src/xen/xen_hypervisor.c | 4 ++-- 5 files changed, 26 insertions(+), 27 deletions(-) -- 2.7.3

8 years, 6 months

3
5
0 / 0

[libvirt] [PATCH] conf: Allow disks with identical WWN or serial

by Peter Krempa

Disallowing them broke a use case of testing multipath configurations for storage. The original intent was added as it made it impossible to use certain /dev/disk-by... links. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1349895 --- src/conf/domain_conf.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9443281..68e89ed 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -24906,20 +24906,6 @@ virDomainDiskDefCheckDuplicateInfo(const virDomainDiskDef *a, return -1; } - if (a->wwn && b->wwn && STREQ(a->wwn, b->wwn)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("Disks '%s' and '%s' have identical WWN"), - a->dst, b->dst); - return -1; - } - - if (a->serial && b->serial && STREQ(a->serial, b->serial)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("Disks '%s' and '%s' have identical serial"), - a->dst, b->dst); - return -1; - } - return 0; } -- 2.9.0

8 years, 6 months

2
3
0 / 0

[libvirt] [PATCH 0/4] Fix the domain capabilities wrt maxvcpus

by Shivaprasad G Bhat

This series addresses the comments to my patch in http://www.redhat.com/archives/libvir-list/2016-May/msg00218.html The v2 got quite a lot of criticism to not to change the virConnectGetMaxVCPUS() instead document to use the virConnectGetDomainCapabilities(). The virConnectGetDomainCapabilities() is extended to check for the host limits and the NR_CPUs are also returned. I am planning to follow up this series with possible fixes to maxvcpus command once this merged. --- Shivaprasad G Bhat (4): Document to not rely on virConnectGetMaxVcpus API Rename and move kvmGetMaxVCPUs to utils and extend it Check for VFIO too where the Legacy passthrough is checked Check the kvm host cpu max limits in virConnectGetDomainCapabilities() docs/formatdomaincaps.html.in | 4 +-- src/conf/domain_capabilities.c | 10 +++++-- src/conf/domain_capabilities.h | 1 + src/libvirt-host.c | 6 ++++ src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 13 +++++++-- src/qemu/qemu_capabilities.h | 3 +- src/qemu/qemu_driver.c | 57 +++------------------------------------- src/util/virhostcpu.c | 37 ++++++++++++++++++++++++++ src/util/virhostcpu.h | 7 +++++ tests/domaincapstest.c | 3 +- 11 files changed, 78 insertions(+), 64 deletions(-) -- Signature

8 years, 6 months

2
12
0 / 0

[libvirt] [PATCH] docs: Fix whitespace in output

by John Ferlan

Many moons ago, commit id '8d7800a55' adjusted the format of the output to add a space on the HEADER and the DATA... the docs weren't updated to reflect that... This makes that adjustment. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Pushed as trivial, but noted as a result of reviews done on LUKS series docs/formatsecret.html.in | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/formatsecret.html.in b/docs/formatsecret.html.in index 599cb38..c39d2a7 100644 --- a/docs/formatsecret.html.in +++ b/docs/formatsecret.html.in @@ -123,9 +123,9 @@ Secret 1b40a534-8301-45d5-b1aa-11894ebb1735 created # # virsh secret-list - UUID Usage + UUID Usage ----------------------------------------------------------- - 1b40a534-8301-45d5-b1aa-11894ebb1735 cephx ceph_example + 1b40a534-8301-45d5-b1aa-11894ebb1735 cephx ceph_example # # CEPHPHRASE=`printf %s "pass phrase" | base64` # virsh secret-set-value 1b40a534-8301-45d5-b1aa-11894ebb1735 $CEPHPHRASE @@ -209,9 +209,9 @@ Secret c4dbe20b-b1a3-4ac1-b6e6-2ac97852ebb6 created # virsh secret-list - UUID Usage + UUID Usage ----------------------------------------------------------- - c4dbe20b-b1a3-4ac1-b6e6-2ac97852ebb6 iscsi libvirtiscsi + c4dbe20b-b1a3-4ac1-b6e6-2ac97852ebb6 iscsi libvirtiscsi # MYSECRET=`printf %s "mysecret" | base64` # virsh secret-set-value c4dbe20b-b1a3-4ac1-b6e6-2ac97852ebb6 $MYSECRET -- 2.5.5

8 years, 6 months

1
0
0 / 0

[libvirt] [PATCH 0/6] storage: fix issues with pool state cleanup

by Cole Robinson

This series fixes several issues with pool shutdown cleanup regarding transient pool removal, newDef assignment, and stateFile removal. Cole Robinson (6): storage: Break out storageDriverAutostartPool storage: Add storagePoolSetInactive storage: Handle transient pool removal in driver startup storage: delete: Don't unlink stateFile storage: Unlink stateFile in storagePoolSetInactive conf: sync error reporting for object configFile unlinking src/conf/domain_conf.c | 7 +- src/conf/network_conf.c | 6 +- src/conf/nwfilter_conf.c | 6 +- src/conf/storage_conf.c | 7 +- src/conf/virsecretobj.c | 2 +- src/storage/storage_driver.c | 198 ++++++++++++++++++++++--------------------- 6 files changed, 113 insertions(+), 113 deletions(-) -- 2.7.4

8 years, 6 months

2
15
0 / 0

[libvirt] [PATCHv2] build: increase xz compression level

by Ján Tomko

Increase the default compression level to 9 from 6. This also increases decompression memory requirements from 9 MB to 65 MB. Also turn on verbosity. --- Makefile.am | 3 +++ 1 file changed, 3 insertions(+) v2: also use -v move the setting to Makefile.am diff --git a/Makefile.am b/Makefile.am index 4b4aad3..ef88067 100644 --- a/Makefile.am +++ b/Makefile.am @@ -22,6 +22,9 @@ GENHTML = genhtml SUBDIRS = . gnulib/lib include/libvirt src daemon tools docs gnulib/tests \ tests po examples +XZ_OPT ?= -9ev +export XZ_OPT + ACLOCAL_AMFLAGS = -I m4 EXTRA_DIST = \ -- 2.7.3

8 years, 6 months

2
3
0 / 0

[libvirt] [PATCH v2 0/5] bhyve: virConnectDomainXMLFromNative

by Fabian Freyer

Aaand I'm reposting this series again, in the hope that this time it will consistently send to the mailing list. Again, very sorry for the noise. Differences to v1: - use gnulib's reentrant getopt implementation. This is necessary for thread safety. - config-post.h: __GNUC_PREREQ is defined here, since using gnulib's getopt pulls in other gnulib headers, which rely on __GNUC_PREREQ, which doesn't exist on FreeBSD. This approach is open for discussion: I chose config-post.h as this would likely always be the first header pulled in (through config.h). Link to v1: https://www.redhat.com/archives/libvir-list/2016-June/msg00001.html Fabian Freyer (5): config-post.h: define __GNUC_PREREQ if not defined gnulib: add getopt module bhyve: implement virConnectDomainXMLFromNative bhyve: implement bhyve argument parser bhyve: implement argument parser for loader bootstrap.conf | 1 + config-post.h | 11 + m4/virt-driver-bhyve.m4 | 3 + po/POTFILES.in | 1 + src/Makefile.am | 2 + src/bhyve/bhyve_driver.c | 42 ++ src/bhyve/bhyve_parse_command.c | 875 ++++++++++++++++++++++++++++++++++++++++ src/bhyve/bhyve_parse_command.h | 30 ++ 8 files changed, 965 insertions(+) create mode 100644 src/bhyve/bhyve_parse_command.c create mode 100644 src/bhyve/bhyve_parse_command.h -- 2.7.0

8 years, 6 months

2
12
0 / 0

[libvirt] [PATCH] virStorageBackendISCSIGetHostNumber: correctly use virDirOpen

by Ján Tomko

Incorrect conflict resolution in my commit e81de04c1 broke this. --- src/storage/storage_backend_iscsi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) Pushed under the build-breaker rule. diff --git a/src/storage/storage_backend_iscsi.c b/src/storage/storage_backend_iscsi.c index 4a16d2b..98d1141 100644 --- a/src/storage/storage_backend_iscsi.c +++ b/src/storage/storage_backend_iscsi.c @@ -100,9 +100,7 @@ virStorageBackendISCSIGetHostNumber(const char *sysfs_path, virFileWaitForDevices(); - if (virDirOpen(&sysdir, sysfs_path) < 0) - virReportSystemError(errno, - _("Failed to opendir path '%s'"), sysfs_path); + if (virDirOpen(&sysdir, sysfs_path) < 0) { retval = -1; goto out; } -- 2.7.3

8 years, 6 months

1
0
0 / 0

[libvirt] [PATCH 00/18] Allow domains to start with a dot

by Ján Tomko

Also introduce virDirOpen* and VIR_DIR_CLOSE helpers. https://bugzilla.redhat.com/show_bug.cgi?id=1333248 Ján Tomko (18): Do not save errno in virUSBDeviceSearch Fix error detection in virStorageBackendISCSIGetHostNumber Do not check the return value of closedir Introduce VIR_DIR_CLOSE Introduce virDirOpen Use virDirOpen Add virDirOpenIfExists Use virDirOpenIfExists Introduce virDirOpenQuiet Use virDirOpenQuiet Prohibit opendir in syntax-check Skip '.' and '..' in virDirRead Do not check for '.' and '..' after virDirRead Fix comment in virStorageBackendFileSystemRefresh Do not ignore hidden files in /sys and /proc Do not skip hidden entries when looking for a stable path Allow configs to start with a dot Do not skip files starting with a dot in leases directory cfg.mk | 7 +- src/conf/network_conf.c | 31 +++------ src/conf/nwfilter_conf.c | 15 ++--- src/conf/storage_conf.c | 30 +++------ src/conf/virdomainobjlist.c | 16 ++--- src/conf/virsecretobj.c | 14 ++-- src/libvirt_private.syms | 4 ++ src/network/bridge_driver.c | 17 ++--- src/openvz/openvz_conf.c | 5 +- src/qemu/qemu_driver.c | 14 +--- src/qemu/qemu_hostdev.c | 10 +-- src/storage/storage_backend.c | 11 ++-- src/storage/storage_backend_fs.c | 14 ++-- src/storage/storage_backend_iscsi.c | 47 +++++++------- src/storage/storage_backend_scsi.c | 30 ++------- src/util/vircgroup.c | 43 ++++--------- src/util/virfile.c | 124 ++++++++++++++++++++++++++---------- src/util/virfile.h | 9 +++ src/util/virhostcpu.c | 19 ++---- src/util/virnetdev.c | 10 +-- src/util/virnetdevtap.c | 9 +-- src/util/virnuma.c | 17 ++--- src/util/virpci.c | 36 +++-------- src/util/virprocess.c | 9 +-- src/util/virscsi.c | 22 ++----- src/util/virusb.c | 16 +---- src/util/virutil.c | 32 ++-------- src/xen/xen_inotify.c | 13 ++-- src/xen/xm_internal.c | 10 +-- tests/virschematest.c | 8 +-- tools/nss/libvirt_nss.c | 13 +--- 31 files changed, 245 insertions(+), 410 deletions(-) -- 2.7.3

8 years, 6 months

2
27
0 / 0

[libvirt] [PATCH 1/1] cpu_map.xml: add cmt/mbm feature to x86

by Qiaowei Ren

Some Intel processor families (e.g. the Intel Xeon processor E5 v3 family) introduced some PQos (Platform Qos) features, including CMT (Cache Monitoring echnology) and MBM (Memory Bandwidth Monitoring), to monitor or control shared resource. This patch add them into x86 part of cpu_map.xml to be used for applications (like OpenStack) based on libvirt to get cpu capabilities. Signed-off-by: Qiaowei Ren <qiaowei.ren(a)intel.com> --- src/cpu/cpu_map.xml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml index 08aded2..2e2cb4f 100644 --- a/src/cpu/cpu_map.xml +++ b/src/cpu/cpu_map.xml @@ -320,6 +320,9 @@ <feature name='rtm'> <cpuid function='0x00000007' ebx='0x00000800'/> </feature> + <feature name='cmt'> + <cpuid function='0x00000007' ebx='0x00001000'/> + </feature> <feature name='mpx'> <cpuid function='0x00000007' ebx='0x00004000'/> </feature> @@ -353,6 +356,14 @@ <cpuid function='0x80000007' edx='0x00000100'/> </feature> +  + <feature name='mbm_total'>  + <cpuid function='0x0000000f' edx='0x00000002'/> + </feature> + <feature name='mbm_local'>  + <cpuid function='0x0000000f' edx='0x00000004'/> + </feature> +  <model name='486'> <feature name='fpu'/> -- 1.9.1

8 years, 6 months

4
6
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Devel June 2016