February 2016 - Devel - libvirt List Archives

[libvirt] [PATCH RFC 0/8] Sparse streams
by Michal Privoznik 08 Feb '16

08 Feb '16

** NOT TO BE MERGED UPSTREAM ** This is merely an RFC. What's the problem? We have APIs for transferring disk images from/to host. Problem is, disk images can be sparse files. Our code is, however, unaware of that fact so if for instance the disk is one big hole of 8GB all those bytes have to: a) be read b) come through our event loop. This is obviously very inefficient way. How to deal with it? The way I propose (and this is actually what I like you to comment on) is to invent set of new API. We need to make read from and write to a stream sparseness aware. The new APIs are as follows: int virStreamSendOffset(virStreamPtr stream, unsigned long long offset, const char *data, size_t nbytes); int virStreamRecvOffset(virStreamPtr stream, unsigned long long *offset, char *data, size_t nbytes); The SendOffset() is fairly simple. It is given an offset to write @data from so it basically lseek() to @offset and write() data. The RecvOffset() has slightly complicated design - it has to be aware of the fact that @offset it is required to read from fall into a hole. If that's the case it sets @offset to new location where data starts. Are there other ways possible? Sure! If you have any specific in mind I am happy to discuss it. For instance one idea I've heard (from Martin) was instead of SendOffset() and RecvOffset() we may just invent our variant of lseek(). What's left to be done? Basically, I still don't have RPC implementation. But before I dive into that I thought of sharing my approach with you - because it may turn out that a different approach is going to be needed and thus my work would render useless. Is there any bug attached? You can bet! https://bugzilla.redhat.com/show_bug.cgi?id=1282859 Michal Privoznik (8): fdstream: Realign Introduce virStream{Recv,Send}Offset Introduce VIR_STREAM_SPARSE flag fdstream: Implement virStreamSendOffset fdstream: Implement virStreamRecvOffset fdstreamtest: switch from boolean array to @flags fdstreamtest: Test virStreamRecvOffset fdstreamtest: test virStreamSendOffset include/libvirt/libvirt-stream.h | 9 +++ src/driver-stream.h | 13 ++++ src/fdstream.c | 150 +++++++++++++++++++++++++++++++++++---- src/internal.h | 20 ++++++ src/libvirt-stream.c | 119 +++++++++++++++++++++++++++++++ src/libvirt_public.syms | 6 ++ tests/fdstreamtest.c | 116 ++++++++++++++++++++++++------ 7 files changed, 397 insertions(+), 36 deletions(-) -- 2.4.10

4 14

[libvirt] route seems to be not affecting the network behavior
by pichon 08 Feb '16

08 Feb '16

Hello, I’m trying to set a default gateway on an isolated lan (because one of my VM get access to an other lan). I’m trying to use the option <route > but this doesn’t affect the default route on my VMs. Here is the network xml <network> <name>prd-private-lan</name> <uuid>2222222222222222222222</uuid> <bridge name='virbr3' stp='off' delay='0'/> <mac address='52:54:00:08:1e:d8'/> <domain name=‘pre' /> <dns> <forwarder addr='8.8.4.4'/> <forwarder addr='8.8.8.8'/> </dns> <ip address='10.10.0.1' netmask='255.255.255.0'> <dhcp> <range start='10.10.0.128' end='10.10.0.254’/> <host mac=‘xxxxxx' name=‘finternet.pret' ip='10.10.0.7'/> </dhcp> </ip> <route address='10.10.0.0' netmask='255.255.255.0' gateway='10.10.0.7'/> </network> And here is what I get on the guest VM connected to the pre-private-lan route Kernel IP routing table Destination Gateway Genmask Flags Metric Ref Use Iface 10.10.0.0 0.0.0.0 255.255.255.0 U 100 0 0 ens4 Can someone help me or tell me what to do ? What I’m a bit surprise is the file //var/lib/libvirt/dnsmasq/prd-private-lan.conf doesn’t contain any clause defining the new gateway. Something like ‘dhcp-option=3,10.10.0.7' strict-order no-resolv server=8.8.4.4 server=8.8.8.8 domain=prd.pipiche.net expand-hosts pid-file=/var/run/libvirt/network/prd-private-lan.pid except-interface=lo bind-dynamic interface=virbr3 dhcp-option=3 no-resolv dhcp-range=10.10.0.128,10.10.0.254 dhcp-no-override dhcp-lease-max=127 dhcp-hostsfile=/var/lib/libvirt/dnsmasq/prd-private-lan.hostsfile addn-hosts=/var/lib/libvirt/dnsmasq/prd-private-lan.addnhosts Of course I can add an explicit route on the guest - so did I - but for maintenance purposes I would like to avoid and have all configuration in the network XML Thanks in advance Patrick

1 0

[libvirt] [PATCH v2 0/7] storage:dir: ploop volumes support
by Olga Krishtal 08 Feb '16

08 Feb '16

In-Reply-To: v2: - fixed memory leak - chenged the return value of all helper functions to 0/-1. Now check for success is smth like that: vir****Ploop() < 0 - fixed some identation issues.

2 16

[libvirt] [PATCH 00/13] vbox: more error checking
by Ján Tomko 08 Feb '16

08 Feb '16

Check for return values of libvirt's internal APIs in vboxDumpVideo and vboxDumpDisplay. Patch 10/13 should fix a complaint by Coverity (untested). Lots of whitespace changes, -b is your friend. Ján Tomko (13): Check return value of vboxDumpVideo vboxDumpDisplay: reduce indentation level vboxDumpDisplay: more indentation reducing vboxDumpDisplay: add addDesktop bool vboxDumpDisplay: remove extra virReportOOMError vboxDumpDisplay: split out def->graphics allocation vboxDumpDisplay: allocate the graphics structure upfront vboxDumpDisplay: fill out the graphics structure earlier vboxDumpDisplay: clean up VIR_STRDUP usage vboxDumpDisplay: check return of virDomainGraphicsListenSetAddress vboxDumpDisplay: use VIR_APPEND_ELEMENT vboxDumpDisplay: reuse the keyUtf16 variable vboxDumpDisplay: remove suspicious strlen src/vbox/vbox_common.c | 249 ++++++++++++++++++++++--------------------------- 1 file changed, 113 insertions(+), 136 deletions(-) -- 2.4.10

2 15

[libvirt] [PATCH v4 0/4] vcpu info storage refactors - part 2
by Peter Krempa 08 Feb '16

08 Feb '16

Yet another version since I've changed a few places other than requested in the review. Peter Krempa (4): qemu: vcpu: Aggregate code to set vCPU tuning qemu: vcpu: Reuse qemuProcessSetupVcpu in vcpu hotplug qemu: iothread: Aggregate code to set IOThread tuning qemu: iothread: Reuse qemuProcessSetupIOThread in iothread hotplug src/qemu/qemu_cgroup.c | 188 ------------------------ src/qemu/qemu_cgroup.h | 2 - src/qemu/qemu_driver.c | 136 +----------------- src/qemu/qemu_process.c | 376 +++++++++++++++++++++++++++++++++--------------- src/qemu/qemu_process.h | 6 + 5 files changed, 266 insertions(+), 442 deletions(-) -- 2.6.2

2 6

[libvirt] [PATCH] vircgroup: Update virCgroupGetPercpuStats stump
by Michal Privoznik 08 Feb '16

08 Feb '16

In the commit 7938b533 we've changed the function signature, however forgot to update stump that's used on systems without CGroups causing a build failure. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed under trivial and build breaker rules. src/util/vircgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index f625cbc..6ce208e 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -4945,7 +4945,7 @@ virCgroupGetPercpuStats(virCgroupPtr group ATTRIBUTE_UNUSED, unsigned int nparams ATTRIBUTE_UNUSED, int start_cpu ATTRIBUTE_UNUSED, unsigned int ncpus ATTRIBUTE_UNUSED, - unsigned int nvcpupids ATTRIBUTE_UNUSED) + virBitmapPtr guestvcpus ATTRIBUTE_UNUSED) { virReportSystemError(ENOSYS, "%s", _("Control groups not supported on this platform")); -- 2.4.10

1 0

[libvirt] [PATCH 0/7] storage:dir: ploop volumes support
by Olga Krishtal 08 Feb '16

08 Feb '16

This series of patches is aimed to support ploop volumes directory storage pools. Ploop is a disk loopback block device, not unlike loop but with many features like dynamic resize, snapshots, backups etc. Container images will be stored in ploop volumes, that can be manipulated via virsh api.

2 12

[libvirt] How to check if 'Per-node memory binding' is supported in this libvirt version?
by Valeriy Solovyov 08 Feb '16

08 Feb '16

Hi All, *How to check if 'Per-node memory binding' is supported in this libvirt version?* PS: I have the #virsh version: Compiled against library: libvirt 1.2.*9* Using library: libvirt 1.2.9 Using API: QEMU 1.2.9 Running hypervisor: QEMU 2.0.0 on host # uname -a Linux nfv 3.13.0-40-generic #69-Ubuntu SMP Thu Nov 13 17:53:56 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux # lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 14.04.1 LTS Release: 14.04 Codename: trusty #virsh start SomeOSOS-30-5-0-0_rls_743 error: Failed to start domain AlteonOS-30-5-0-0_rls_743 error: unsupported configuration: Per-node memory binding is not supported with this QEMU #virsh dumpxml SomeOSOS-30-5-0-0_rls_743 <domain type='kvm'> <name>SomeOSOS-30-5-0-0_rls_743</name> <uuid>c0eac6f0-e519-459d-978d-bd5b2da0be45</uuid> <memory unit='KiB'>33554432</memory> <currentMemory unit='KiB'>33554432</currentMemory> <vcpu placement='static'>8</vcpu> <cputune> <vcpupin vcpu='0' cpuset='0'/> <vcpupin vcpu='1' cpuset='2'/> <vcpupin vcpu='2' cpuset='4'/> <vcpupin vcpu='3' cpuset='6'/> <vcpupin vcpu='4' cpuset='1'/> <vcpupin vcpu='5' cpuset='3'/> <vcpupin vcpu='6' cpuset='5'/> <vcpupin vcpu='7' cpuset='7'/> </cputune> <numatune> <memory mode='strict' nodeset='0-1'/> <memnode cellid='0' mode='strict' nodeset='0'/> <memnode cellid='1' mode='strict' nodeset='1'/> </numatune> <os> <type arch='x86_64' machine='pc-i440fx-trusty'>hvm</type> <boot dev='hd'/> </os> <features> <acpi/> <apic/> <pae/> </features> <cpu mode='custom' match='exact'> <model fallback='allow'>Westmere</model> <feature policy='require' name='pdpe1gb'/> <numa> <cell id='0' cpus='0,1,2,3' memory='16777216'/> <cell id='1' cpus='4,5,6,7' memory='16777216'/> </numa> </cpu> <clock offset='utc'/> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>restart</on_crash> <devices> <emulator>/usr/bin/qemu-system-x86_64</emulator> <disk type='file' device='disk'> <driver name='qemu' type='qcow2' cache='none'/> <source file='/var/lib/libvirt/images/SomeOSOS-30-5-0-0_rls_743.qcow2'/> <target dev='vda' bus='virtio'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/> </disk> <controller type='ide' index='0'> <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/> </controller> <controller type='usb' index='0'> <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x2'/> </controller> <controller type='pci' index='0' model='pci-root'/> <interface type='bridge'> <mac address='52:54:00:4b:e8:9b'/> <source bridge='mgmt'/> <model type='e1000'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/> </interface> <serial type='pty'> <target port='0'/> </serial> <console type='pty'> <target type='serial' port='0'/> </console> <input type='mouse' bus='ps2'/> <input type='keyboard' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes'/> <video> <model type='cirrus' vram='9216' heads='1'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/> </video> <hostdev mode='subsystem' type='pci' managed='yes'> <source> <address domain='0x0000' bus='0x05' slot='0x00' function='0x0'/> </source> <rom bar='off'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x06' function='0x0'/> </hostdev> <hostdev mode='subsystem' type='pci' managed='yes'> <source> <address domain='0x0000' bus='0x42' slot='0x00' function='0x0'/> </source> <rom bar='off'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x07' function='0x0'/> </hostdev> <memballoon model='virtio'> <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> </memballoon> </devices> </domain> Regards.

1 0

[libvirt] [PATCH 00/11] Fix disk dst/wwn/serial checks in hotplug case
by Peter Krempa 08 Feb '16

08 Feb '16

Peter Krempa (11): qemu: hotplug: Use typecasted switch qemu: hotplug: Remove unnecessary variable qemu: hotplug: Break up if/else statement into switch qemu: hotplug: Use more common 'cleanup' label in qemuDomainAttachDeviceDiskLive qemu: hotplug: Extract common code to qemuDomainAttachDeviceDiskLive conf: Extract code that checks disk serial/wwn conflict qemu: hotplug: Check duplicate disk serial/wwn on hotplug too qemu: process: Reorder operations on early VM startup qemu: process: Extract pre-start checks into a function tests: Integrate startup checks to qemuxml2argvtest conf: Move and optimize disk target duplicity checking src/conf/domain_conf.c | 82 +++++++++++++++++++-------------------------- src/conf/domain_conf.h | 4 ++- src/libvirt_private.syms | 2 +- src/qemu/qemu_command.c | 3 -- src/qemu/qemu_hotplug.c | 85 +++++++++++++++++++++-------------------------- src/qemu/qemu_migration.c | 2 +- src/qemu/qemu_process.c | 57 +++++++++++++++++++++---------- src/qemu/qemu_process.h | 9 ++++- tests/qemuxml2argvtest.c | 13 ++++++-- 9 files changed, 136 insertions(+), 121 deletions(-) -- 2.6.2

2 16

[libvirt] [PATCH 0/2] Avoid infinite loop if vCPUs can't be resumed in qemu snapshot code
by Peter Krempa 08 Feb '16

08 Feb '16

Messed up refactor :(. Bunny ears of shame were applied. Peter Krempa (2): qemu: snapshot: Don't overwrite existing errors when thawing filesystems qemu: snapshot: Avoid infinite loop if vCPUs can't be resumed src/qemu/qemu_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.6.2

2 4