[libvirt] [PATCH] vz: Fix build after recent commit
by Peter Krempa
Function prlsdkGetStatsParam was missing a prototype or the static
keyword. I went with static since it built successfully.
Pushed as a build breaker fix.
---
src/vz/vz_sdk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
index fb88ca0..f27098c 100644
--- a/src/vz/vz_sdk.c
+++ b/src/vz/vz_sdk.c
@@ -3677,7 +3677,7 @@ prlsdkExtractStatsParam(PRL_HANDLE sdkstats, const char *name, long long *val)
#define PARALLELS_STATISTICS_TIMEOUT (60 * 1000)
-int
+static int
prlsdkGetStatsParam(virDomainObjPtr dom, const char *name, long long *val)
{
vzDomObjPtr privdom = dom->privateData;
--
2.4.1
9 years, 2 months
[libvirt] [libvirt-php][PATCH 0/8] Build rpms again
by Michal Privoznik
There's is a spec file within the sources, but it's outdated and
doesn't work. However, in order to fix it, couple of other places
need fixing too.
Michal Privoznik (8):
configure: Prefer /bin/echo before printf
Distribute the spec file too
configure: Fix build with --prefix
Makefile: Introduce 'rpm' target
libvirt-php.spec: Don't run configure twice
libvirt-php.spec.in: Drop spaces at EOL
libvirt-php.spec.in: Cleanup
Require newer libvirt
Makefile.am | 5 +-
configure.ac | 15 +++++-
libvirt-php.spec.in | 27 ++++++-----
src/libvirt-php.c | 128 ----------------------------------------------------
src/libvirt-php.h | 4 --
5 files changed, 30 insertions(+), 149 deletions(-)
--
2.3.6
9 years, 2 months
[libvirt] Gathering CPUID data for x86 CPUs
by Jiri Denemark
Hi all,
I'm working on improving our host CPU detection logic and I'd like to
gather test data for various CPUs and include them in the libvirt's CPU
unit test to make sure I don't introduce regressions.
If you are willing to help me, please, send me the output of the
following command:
grep 'model name' /proc/cpuinfo | head -n1; cpuid -1r
on various i686/x86_64 hosts you might own? Older or unusual CPUs are
more than welcome.
The cpuid tool can be usually found in a package called "cpuid". If your
distro does not provide such package and you are still willing to help,
you can find the sources or binary packages at
http://www.etallen.com/cpuid.html
Private replies are preferred to reduce unnecessary mailing list
traffic.
Thanks a lot for your help,
Jirka
9 years, 2 months
[libvirt] Plans for next release
by Daniel Veillard
Sorry I nearly forgot, but we should enter freeze soon to try to
hit the end of the month target. I see that Martin's APIs for admin support
has been merged in so that would be libvirt-1.3.0.
Plan is to enter freeze this w.e. and try to release by the end of the week,
I hope this works for everyone,
thanks,
Daniel
--
Daniel Veillard | Open Source and Standards, Red Hat
veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | virtualization library http://libvirt.org/
9 years, 2 months
[libvirt] [PATCH v2] docs: Properly mark acl.html dependencies
by Michal Privoznik
The acl.html file includes aclperms.htmlinc which is generated.
However, acl.html is generated too from acl.html.tmp. And in fact,
this is the place where the aclperms file is needed. Fix the
dependency in Makefile.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
diff to v1:
- Fix the origin of the error
docs/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/Makefile.am b/docs/Makefile.am
index b7b49cb..13dddf8 100644
--- a/docs/Makefile.am
+++ b/docs/Makefile.am
@@ -163,7 +163,7 @@ EXTRA_DIST= \
sitemap.html.in aclperms.htmlinc \
todo.pl hvsupport.pl todo.cfg-example
-acl.html:: $(srcdir)/aclperms.htmlinc
+acl.html.tmp: $(srcdir)/aclperms.htmlinc
$(srcdir)/aclperms.htmlinc: $(top_srcdir)/src/access/viraccessperm.h \
$(srcdir)/genaclperms.pl Makefile.am
--
2.3.6
9 years, 2 months
[libvirt] [PATCH v2 0/3] vz: add statistics
by Nikolay Shirokovskiy
Add vz statistics for network, cpu and memory.
src/vz/vz_driver.c | 133 +++++++++++++++++++++++++++++++++++++++++++++++++++-
src/vz/vz_sdk.c | 69 ++++++++++++++++++++++++++-
src/vz/vz_sdk.h | 4 ++
Changes from v1.
subject prefix changed from 'parallels' to 'vz'
9 years, 2 months
[libvirt] [libvirt-php][PATCH v1] fix installation prefix
by Vasiliy Tolstov
when prefix present all stuff installed to /usr/usr/
Signed-off-by: Vasiliy Tolstov <v.tolstov(a)selfip.ru>
---
src/Makefile.am | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index cab0456..8e6a800 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -6,10 +6,10 @@ WL=@WL@
SHLIB_FLAGS=@SHLIB_FLAGS@
install-exec-local:
- $(MKDIR_P) $(DESTDIR)$(prefix)$(PHPEDIR)
- $(MKDIR_P) $(DESTDIR)$(prefix)$(PHPCDIR)
- $(INSTALL) -m 644 -D .libs/$(PACKAGE).so $(DESTDIR)$(prefix)$(PHPEDIR)/$(PACKAGE).so
- $(INSTALL) -m 755 -d $(DESTDIR)$(prefix)$(PHPCDIR)
+ $(MKDIR_P) $(DESTDIR)$(PHPEDIR)
+ $(MKDIR_P) $(DESTDIR)$(PHPCDIR)
+ $(INSTALL) -m 644 -D .libs/$(PACKAGE).so $(DESTDIR)$(PHPEDIR)/$(PACKAGE).so
+ $(INSTALL) -m 755 -d $(DESTDIR)$(PHPCDIR)
$(ECHO) "extension=$(PACKAGE).so" > libvirt-php.ini
$(ECHO) >> libvirt-php.ini
$(ECHO) "[libvirt]" >> libvirt-php.ini
@@ -19,11 +19,11 @@ install-exec-local:
$(ECHO) "libvirt.image_path=/var/lib/libvirt/images" >> libvirt-php.ini
$(ECHO) "; Limit maximum number of libvirt connections" >> libvirt-php.ini
$(ECHO) "libvirt.max_connections=5" >> libvirt-php.ini
- $(INSTALL) -m 644 -D libvirt-php.ini $(DESTDIR)$(prefix)$(PHPCDIR)/$(PACKAGE).ini
+ $(INSTALL) -m 644 -D libvirt-php.ini $(DESTDIR)$(PHPCDIR)/$(PACKAGE).ini
uninstall-local:
- $(RM) -f $(DESTDIR)$(prefix)$(PHPCDIR)/$(PACKAGE).ini
- $(RM) -f $(DESTDIR)$(prefix)$(PHPEDIR)/$(PACKAGE).so
+ $(RM) -f $(DESTDIR)$(PHPCDIR)/$(PACKAGE).ini
+ $(RM) -f $(DESTDIR)$(PHPEDIR)/$(PACKAGE).so
AM_CFLAGS = \
$(PHPINC) $(LIBXML_CFLAGS) \
--
2.3.3
9 years, 2 months
[libvirt] [PATCH 0/2] qemuBuildMemoryBackendStr: Couple of fixes
by Michal Privoznik
The first one fixes a bug we have for a long time.
The second one is not that ancient but still worth fixing.
Michal Privoznik (2):
qemuBuildMemoryBackendStr: Fix hugepages lookup process
qemuBuildMemoryBackendStr: Honour passed @pagesize
src/qemu/qemu_command.c | 57 +++++-----
.../qemuxml2argv-hugepages-numa.args | 49 +++++++++
.../qemuxml2argv-hugepages-numa.xml | 118 +++++++++++++++++++++
.../qemuxml2argv-memory-hotplug-dimm-addr.args | 4 +-
.../qemuxml2argv-memory-hotplug-dimm-addr.xml | 2 +-
.../qemuxml2argv-memory-hotplug-dimm.args | 4 +-
.../qemuxml2argv-memory-hotplug-dimm.xml | 2 +-
tests/qemuxml2argvtest.c | 14 ++-
8 files changed, 217 insertions(+), 33 deletions(-)
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hugepages-numa.args
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hugepages-numa.xml
--
2.3.6
9 years, 2 months
[libvirt] [PATCH] conf: fix not format priority when it is zero
by Luyao Huang
https://bugzilla.redhat.com/show_bug.cgi?id=1235116
We do not format the priority if it is 0, but this will
be a broken settings in guest. Change the condition of
format priority element to always format priority if
scheduler is 'fifo' or 'rr'.
Signed-off-by: Luyao Huang <lhuang(a)redhat.com>
---
I haven't intorduce a new bool parameter to mark if we
set the priority value just like the other place we avoid
this issue, because i think this looks unnecessary in this
place.
src/conf/domain_conf.c | 6 ++--
...xml2argv-cputune-iothreadsched-zeropriority.xml | 38 ++++++++++++++++++++++
tests/qemuxml2xmltest.c | 1 +
3 files changed, 43 insertions(+), 2 deletions(-)
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cputune-iothreadsched-zeropriority.xml
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 183e66c..0c766a1 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -21424,7 +21424,8 @@ virDomainDefFormatInternal(virDomainDefPtr def,
ids, virProcessSchedPolicyTypeToString(sp->policy));
VIR_FREE(ids);
- if (sp->priority)
+ if (sp->policy == VIR_PROC_POLICY_FIFO ||
+ sp->policy == VIR_PROC_POLICY_RR)
virBufferAsprintf(buf, " priority='%d'", sp->priority);
virBufferAddLit(buf, "/>\n");
}
@@ -21439,7 +21440,8 @@ virDomainDefFormatInternal(virDomainDefPtr def,
ids, virProcessSchedPolicyTypeToString(sp->policy));
VIR_FREE(ids);
- if (sp->priority)
+ if (sp->policy == VIR_PROC_POLICY_FIFO ||
+ sp->policy == VIR_PROC_POLICY_RR)
virBufferAsprintf(buf, " priority='%d'", sp->priority);
virBufferAddLit(buf, "/>\n");
}
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-cputune-iothreadsched-zeropriority.xml b/tests/qemuxml2argvdata/qemuxml2argv-cputune-iothreadsched-zeropriority.xml
new file mode 100644
index 0000000..0996723
--- /dev/null
+++ b/tests/qemuxml2argvdata/qemuxml2argv-cputune-iothreadsched-zeropriority.xml
@@ -0,0 +1,38 @@
+<domain type='qemu'>
+ <name>QEMUGuest1</name>
+ <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
+ <memory unit='KiB'>219136</memory>
+ <currentMemory unit='KiB'>219136</currentMemory>
+ <vcpu placement='static'>2</vcpu>
+ <iothreads>4</iothreads>
+ <cputune>
+ <shares>2048</shares>
+ <period>1000000</period>
+ <quota>-1</quota>
+ <vcpupin vcpu='0' cpuset='0'/>
+ <vcpupin vcpu='1' cpuset='1'/>
+ <emulatorpin cpuset='1'/>
+ <vcpusched vcpus='0-1' scheduler='fifo' priority='0'/>
+ <iothreadsched iothreads='1-3' scheduler='rr' priority='0'/>
+ </cputune>
+ <os>
+ <type arch='i686' machine='pc'>hvm</type>
+ <boot dev='hd'/>
+ </os>
+ <clock offset='utc'/>
+ <on_poweroff>destroy</on_poweroff>
+ <on_reboot>restart</on_reboot>
+ <on_crash>destroy</on_crash>
+ <devices>
+ <emulator>/usr/bin/qemu</emulator>
+ <disk type='block' device='disk'>
+ <source dev='/dev/HostVG/QEMUGuest1'/>
+ <target dev='hda' bus='ide'/>
+ <address type='drive' controller='0' bus='0' target='0' unit='0'/>
+ </disk>
+ <controller type='usb' index='0'/>
+ <controller type='ide' index='0'/>
+ <controller type='pci' index='0' model='pci-root'/>
+ <memballoon model='virtio'/>
+ </devices>
+</domain>
diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
index 711827d..7a41a18 100644
--- a/tests/qemuxml2xmltest.c
+++ b/tests/qemuxml2xmltest.c
@@ -492,6 +492,7 @@ mymain(void)
DO_TEST("cputune");
DO_TEST("cputune-zero-shares");
DO_TEST_DIFFERENT("cputune-iothreadsched");
+ DO_TEST("cputune-iothreadsched-zeropriority");
DO_TEST("cputune-numatune");
DO_TEST("vcpu-placement-static");
--
1.8.3.1
9 years, 2 months
[libvirt] [PATCH] Added hook for network modification event
by Anton Khramov
I've added hook for network modification event
Anton Khramov (1):
Added hook for network modification event
src/network/bridge_driver.c | 5 +++++
src/util/virhook.c | 3 ++-
src/util/virhook.h | 1 +
3 files changed, 8 insertions(+), 1 deletion(-)
--
1.9.1
9 years, 2 months
