October 2014 - Devel - libvirt List Archives

[libvirt] [PATCH] qemu: Improve domainSetTime error info report
by Shanzhi Yu 03 Oct '14

03 Oct '14

check domain's status before call virQEMUCapsGet to report a accurate error when domain is shut off Resolve: https://bugzilla.redhat.com/show_bug.cgi?id=1147847 Signed-off-by: Shanzhi Yu <shyu(a)redhat.com> --- src/qemu/qemu_driver.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e873d45..da492d7 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -17360,13 +17360,6 @@ qemuDomainSetTime(virDomainPtr dom, priv = vm->privateData; - if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_RTC_RESET_REINJECTION)) { - virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", - _("cannot set time: qemu doesn't support " - "rtc-reset-reinjection command")); - goto cleanup; - } - if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_MODIFY) < 0) goto cleanup; @@ -17376,6 +17369,13 @@ qemuDomainSetTime(virDomainPtr dom, goto endjob; } + if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_RTC_RESET_REINJECTION)) { + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", + _("cannot set time: qemu doesn't support " + "rtc-reset-reinjection command")); + goto endjob; + } + if (!qemuDomainAgentAvailable(priv, true)) goto endjob; -- 1.9.3

2 1

[libvirt] [PATCHv2 0/2] Fix updating domain live XML
by Erik Skultety 03 Oct '14

03 Oct '14

Erik Skultety (2): qemu: Fix updating bandwidth limits in live XML qemu: Fix updating balloon period in live XML src/qemu/qemu_driver.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) -- 1.9.3

2 3

[libvirt] [PATCH] snapshot: conf: Forbid using same file as external snapshot for disks and external snapshot for memory
by Shanzhi Yu 03 Oct '14

03 Oct '14

When create external system checkpoint snapshot, snapshot file for disks should not be same with snapshot file for memory Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1148932 Signed-off-by: Shanzhi Yu <shyu(a)redhat.com> --- src/conf/snapshot_conf.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c index 1f83b2c..25af914 100644 --- a/src/conf/snapshot_conf.c +++ b/src/conf/snapshot_conf.c @@ -221,6 +221,7 @@ virDomainSnapshotDefParse(xmlXPathContextPtr ctxt, char *tmp; char *memorySnapshot = NULL; char *memoryFile = NULL; + char *diskFile = NULL; bool offline = !!(flags & VIR_DOMAIN_SNAPSHOT_PARSE_OFFLINE); if (VIR_ALLOC(def) < 0) @@ -299,6 +300,7 @@ virDomainSnapshotDefParse(xmlXPathContextPtr ctxt, memorySnapshot = virXPathString("string(./memory/@snapshot)", ctxt); memoryFile = virXPathString("string(./memory/@file)", ctxt); + diskFile = virXPathString("string(./disks/disk/source/@file)", ctxt); if (memorySnapshot) { def->memory = virDomainSnapshotLocationTypeFromString(memorySnapshot); if (def->memory <= 0) { @@ -322,6 +324,12 @@ virDomainSnapshotDefParse(xmlXPathContextPtr ctxt, } } else if (memoryFile) { def->memory = VIR_DOMAIN_SNAPSHOT_LOCATION_EXTERNAL; + if (diskFile != NULL && STREQ(memoryFile,diskFile)){ + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("external snapshot file for disks should not be same" + " with external snapshot file for memory")); + goto cleanup; + } } else if (flags & VIR_DOMAIN_SNAPSHOT_PARSE_REDEFINE) { def->memory = (offline ? VIR_DOMAIN_SNAPSHOT_LOCATION_NONE : @@ -336,6 +344,7 @@ virDomainSnapshotDefParse(xmlXPathContextPtr ctxt, } def->file = memoryFile; memoryFile = NULL; + diskFile = NULL; /* verify that memory path is absolute */ if (def->file && def->file[0] != '/') { @@ -379,6 +388,7 @@ virDomainSnapshotDefParse(xmlXPathContextPtr ctxt, VIR_FREE(nodes); VIR_FREE(memorySnapshot); VIR_FREE(memoryFile); + VIR_FREE(diskFile); if (ret == NULL) virDomainSnapshotDefFree(def); -- 1.9.3

2 1

[libvirt] [PATCH 0/6] handle NIC_RX_FILTER_CHANGED events from qemu
by Laine Stump 03 Oct '14

03 Oct '14

These patches set up an event handler for qemu's NIC_RX_FILTER_CHANGED event, which is sent whenever a guest makes a change to a network device's unicast/multicast filter, vlan table, or MAC address. The handler checks if it is appropriate to respond to the NIC_RX_FILTER_CHANGED event (based on device type and configuration) and takes appropriate action. Currently it checks if the guest interface has been configured with trustGuestRxFilters='yes' (defaults to 'no' for security reasons), and if the host side device is macvtap. If so, and the MAC address on the guest has changed, the MAC address of the macvtap device is changed to match. The result of this is that networking from the guest will continue to work if the mac address of a macvtap-connected network device is changed from within the guest, as long as trustGuestRxFilters='yes' (previously changing the MAC address in the guest would break networking). I still need to add code to compare the old and new unicast and multicast lists and program the filters in the macvtap to match the guest, and to check for a non-empty vlan table and handle that (currently that means just setting promiscuous mode on the macvtap), but that can come in a followup series. Laine Stump (6): conf: add trustGuestRxFilters attribute to network and domain interface network: set interface actual trustGuestRxFilters from network/portgroup util: define virNetDevRxFilter and basic utility functions qemu: qemuMonitorQueryRxFilter - retrieve guest netdev rx-filter qemu: setup infrastructure to handle NIC_RX_FILTER_CHANGED event qemu: change macvtap device MAC address in response to NIC_RX_FILTER_CHANGED docs/formatdomain.html.in | 38 +++- docs/formatnetwork.html.in | 28 ++- docs/schemas/domaincommon.rng | 5 + docs/schemas/network.rng | 10 + src/conf/domain_conf.c | 42 ++++ src/conf/domain_conf.h | 3 + src/conf/network_conf.c | 35 ++++ src/conf/network_conf.h | 2 + src/libvirt_private.syms | 9 + src/network/bridge_driver.c | 11 + src/qemu/qemu_domain.h | 1 + src/qemu/qemu_driver.c | 105 ++++++++++ src/qemu/qemu_monitor.c | 39 ++++ src/qemu/qemu_monitor.h | 11 + src/qemu/qemu_monitor_json.c | 232 +++++++++++++++++++++ src/qemu/qemu_monitor_json.h | 3 + src/qemu/qemu_process.c | 42 ++++ src/util/virnetdev.c | 40 ++++ src/util/virnetdev.h | 57 ++++- tests/Makefile.am | 3 + tests/networkxml2xmlin/vepa-net.xml | 4 +- tests/networkxml2xmlout/vepa-net.xml | 4 +- .../qemuxml2argv-net-virtio-network-portgroup.xml | 4 +- 23 files changed, 711 insertions(+), 17 deletions(-) -- 1.9.3

4 28

[libvirt] [PATCH] Fix typo s/EMULATORIN/EMULATORPIN/
by Daniel P. Berrange 02 Oct '14

02 Oct '14

Fix the typo in VIR_DOMAIN_TUNABLE_CPU_EMULATORIN Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- include/libvirt/libvirt.h.in | 4 ++-- src/qemu/qemu_driver.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) Pushed under trivial rule diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index 2ff5204..5217ab3 100644 --- a/include/libvirt/libvirt.h.in +++ b/include/libvirt/libvirt.h.in @@ -5213,12 +5213,12 @@ typedef void (*virConnectDomainEventDeviceRemovedCallback)(virConnectPtr conn, #define VIR_DOMAIN_TUNABLE_CPU_VCPUPIN "cputune.vcpupin%u" /** - * VIR_DOMAIN_TUNABLE_CPU_EMULATORIN: + * VIR_DOMAIN_TUNABLE_CPU_EMULATORPIN: * * Macro represents formatted pinning for emulator process, * as VIR_TYPED_PARAM_STRING. */ -#define VIR_DOMAIN_TUNABLE_CPU_EMULATORIN "cputune.emulatorpin" +#define VIR_DOMAIN_TUNABLE_CPU_EMULATORPIN "cputune.emulatorpin" /** * VIR_DOMAIN_TUNABLE_CPU_CPU_SHARES: diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 54119f5..6606154 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -4940,7 +4940,7 @@ qemuDomainPinEmulator(virDomainPtr dom, str = virBitmapFormat(pcpumap); if (virTypedParamsAddString(&eventParams, &eventNparams, &eventMaxparams, - VIR_DOMAIN_TUNABLE_CPU_EMULATORIN, + VIR_DOMAIN_TUNABLE_CPU_EMULATORPIN, str) < 0) goto cleanup; -- 1.9.3

2 3

[libvirt] [libvirt-python PATCH] Post-release version bump for new dev cycle
by Pavel Hrdina 02 Oct '14

02 Oct '14

Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- Pushed under trivial rule setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 167f568..0c34ae1 100755 --- a/setup.py +++ b/setup.py @@ -309,7 +309,7 @@ class my_clean(clean): _c_modules, _py_modules = get_module_lists() setup(name = 'libvirt-python', - version = '1.2.9', + version = '1.2.10', url = 'http://www.libvirt.org', maintainer = 'Libvirt Maintainers', maintainer_email = 'libvir-list(a)redhat.com', -- 2.0.4

1 0

[libvirt] [PATCH 0/2] Fix updating domain live XML
by Erik Skultety 02 Oct '14

02 Oct '14

Erik Skultety (2): qemu: Fix updating bandwidth limits in live XML qemu: Fix updating balloon period in live XML src/qemu/qemu_driver.c | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) -- 1.9.3

2 9

Re: [libvirt] ANNOUNCE: Perl binding Sys-Virt release 1.2.9
by Daniel P. Berrange 02 Oct '14

02 Oct '14

I am pleased to announce that release 1.2.9 of Sys-Virt, the libvirt Perl API binding, is now available for download: http://search.cpan.org/CPAN/authors/id/D/DA/DANBERR/Sys-Virt-1.2.9.tar.gz Changed in the 1.2.9 release: - Add VIR_DOMAIN_*_BANDWIDTH_BYTES constants - Add VIR_DOMAIN_BLOCK_REBASE_COPY_DEV constant - Add VIR_DOMAIN_JOB_STATS_COMPLETED constant - Add VIR_DOMAIN_UNDEFINE_NVRAM constant - Add VIR_FROM_POLKIT constant - Add more VIR_DOMAIN_STATS_* constants - Add more VIR_DOMAIN_JOB_* constants - Add virConnectDomainEventTunable event callback & constants - Add virNodeAllocPages API & constants - Add VIR_MIGRATE_RDMA_PIN_ALL constant Further information, including online API documentation & previous release archives, is available from the CPAN home page http://search.cpan.org/dist/Sys-Virt/ Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

1 0

[libvirt] [PATCH] Add virCgroupTerminateMachine stub
by Ján Tomko 02 Oct '14

02 Oct '14

Fix the build on FreeBSD, broken by commit 4882618. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed under the build breaker rule. src/util/vircgroup.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index d69f71b..9bbe694 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -4029,6 +4029,17 @@ virCgroupNewDetectMachine(const char *name ATTRIBUTE_UNUSED, return -1; } + +int virCgroupTerminateMachine(const char *name ATTRIBUTE_UNUSED, + const char *drivername ATTRIBUTE_UNUSED, + bool privileged ATTRIBUTE_UNUSED) +{ + virReportSystemError(ENXIO, "%s", + _("Control groups not supported on this platform")); + return -1; +} + + int virCgroupNewMachine(const char *name ATTRIBUTE_UNUSED, const char *drivername ATTRIBUTE_UNUSED, -- 2.0.4

1 0

[libvirt] [PATCH] build: fix build on non-Linux
by Eric Blake 02 Oct '14

02 Oct '14

A cygwin build of 1.2.9 fails with: util/virprocess.c:87:27: fatal error: sys/syscall.h: No such file or directory # include <sys/syscall.h> But in reality, the ONLY user of setns() is lxc, which is Linux-only. It's easiest to just limit the setns workarounds to Linux. * src/util/virprocess.c (setns): Limit definition to Linux. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- Pushing under the build-breaker rule. src/util/virprocess.c | 44 ++++++++++++++++++++++++-------------------- 1 file changed, 24 insertions(+), 20 deletions(-) diff --git a/src/util/virprocess.c b/src/util/virprocess.c index 806e7f9..486123a 100644 --- a/src/util/virprocess.c +++ b/src/util/virprocess.c @@ -61,44 +61,48 @@ VIR_LOG_INIT("util.process"); +#ifdef __linux__ /* * Workaround older glibc. While kernel may support the setns * syscall, the glibc wrapper might not exist. If that's the * case, use our own. */ -#ifndef __NR_setns -# if defined(__x86_64__) -# define __NR_setns 308 -# elif defined(__i386__) -# define __NR_setns 346 -# elif defined(__arm__) -# define __NR_setns 375 -# elif defined(__aarch64__) -# define __NR_setns 375 -# elif defined(__powerpc__) -# define __NR_setns 350 -# elif defined(__s390__) -# define __NR_setns 339 +# ifndef __NR_setns +# if defined(__x86_64__) +# define __NR_setns 308 +# elif defined(__i386__) +# define __NR_setns 346 +# elif defined(__arm__) +# define __NR_setns 375 +# elif defined(__aarch64__) +# define __NR_setns 375 +# elif defined(__powerpc__) +# define __NR_setns 350 +# elif defined(__s390__) +# define __NR_setns 339 +# endif # endif -#endif -#ifndef HAVE_SETNS -# if defined(__NR_setns) && !defined(WIN32) -# include <sys/syscall.h> +# ifndef HAVE_SETNS +# if defined(__NR_setns) +# include <sys/syscall.h> static inline int setns(int fd, int nstype) { return syscall(__NR_setns, fd, nstype); } -# else /* __NR_setns && !WIN32 */ +# else /* !__NR_setns */ +# error Please determine the syscall number for setns on your architecture +# endif +# endif +#else /* !__linux__ */ static inline int setns(int fd ATTRIBUTE_UNUSED, int nstype ATTRIBUTE_UNUSED) { virReportSystemError(ENOSYS, "%s", _("Namespaces are not supported on this platform.")); return -1; } -# endif /* __NR_setns && !WIN32 */ -#endif /* HAVE_SETNS */ +#endif /** * virProcessTranslateStatus: -- 1.9.3

1 0