[libvirt] [PATCH 0/4] Resolve some recent Valgrind errors
by John Ferlan
Ran Valgrind today and found, investigated, and resolved the errors seen.
John Ferlan (4):
Resolve valgrind error in virNetDevVlanParse()
Resolve valgrind error in virStorageBackendCreateQemuImgCmd()
Resolve valgrind error in remoteConfigGetStringList()
Resolve valgrind errors for nodedev cap parsing
daemon/libvirtd-config.c | 6 ++++++
src/conf/netdev_vlan_conf.c | 24 +++++++++++++-----------
src/conf/node_device_conf.c | 3 +++
src/storage/storage_backend.c | 4 +++-
4 files changed, 25 insertions(+), 12 deletions(-)
--
1.8.1.4
11 years, 11 months
[libvirt] [PATCH] doc: Fix reference to #elementsUSB
by Philipp Hahn
aae0fc2a922b3e31dae7648c547fca2ac2587625 removed the #elementsUSB anchor
but did not update the links to point to the new section #elementsHostDev.
Signed-off-by: Philipp Hahn <hahn(a)univention.de>
---
docs/formatdomain.html.in | 2 +-
docs/formatnode.html.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index d651816..cc4c5ea 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -146,7 +146,7 @@
configure in the desired way, which is why per-device boot elements
(see <a href="#elementsDisks">disks</a>,
<a href="#elementsNICS">network interfaces</a>, and
- <a href="#elementsUSB">USB and PCI devices</a> sections below) were
+ <a href="#elementsHostDev">USB and PCI devices</a> sections below) were
introduced and they are the preferred way providing full control over
booting order. The <code>boot</code> element and per-device boot
elements are mutually exclusive. <span class="since">Since 0.1.3,
diff --git a/docs/formatnode.html.in b/docs/formatnode.html.in
index ad05a70..5f57a5a 100644
--- a/docs/formatnode.html.in
+++ b/docs/formatnode.html.in
@@ -13,7 +13,7 @@
prefix <code>virNodeDevice</code>, which deal with management of
host devices that can be handed to guests via passthrough as
<hostdev> elements
- in <a href="formatdomain.html#elementsUSB">the domain XML</a>.
+ in <a href="formatdomain.html#elementsHostDev">the domain XML</a>.
These devices are represented as a hierarchy, where a device on
a bus has a parent of the bus controller device; the root of the
hierarchy is the node named "computer".
--
1.7.10.4
11 years, 11 months
[libvirt] Entering freeze for libvirt-1.1.0
by Daniel Veillard
Since Dan pushed the fine grained ACL control patches, this release
really ought to be 1.1.0, I just tagged it in git and pushed tarball
and rpms to the server:
ftp://libvirt.org/libvirt/
I know that Laine has still a patch set to push, now it seems they all
got ACK'ed so better get them in for rc2, which I will probably push on
thursday. Then if everything looks fine we can have the final release on
Monday.
I gave it my usual user test, on Fedora, seems to work fine from my
limited perspective. I just had to push the attached patch as a build
breaker otherwise make rpm would wail because the polkit API definitions
would not be packaged. Probably worth a double checking by Dan for
correctness.
Thanks in advance for feedback on the candidate release,
Daniel
--
Daniel Veillard | Open Source and Standards, Red Hat
veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | virtualization library http://libvirt.org/
11 years, 11 months
[libvirt] [PATCH] add support for libssh2 password from auth file
by David Maciejak
Hi,
I was discussing with Daniel about the best way to pass the ssh password
when using such kind of uri: 'xen+libssh2://
root(a)192.168.0.10?sshauth=password'
As it seems passing the password in the uri is not a good option, maybe we
can grab it from auth conf ? it seems it's not the case as now (tell me if
i am wrong).
So enclosed a patch to add this feature.
As you can see in virnetclient.c there is no virAuthGetPassword call, so
the authfile is never used.
The patch enclosed is modifying the function prototype to add virConnectPtr
parameter (so remote_driver.c virNetClientNewLibSSH2 call has to be updated
too and the corresponding .h too).
Once we have access to virConnectPtr, as you will see in the patch we
can check if authMethods is set to 'password' and grab the password from
auth file by calling virAuthGetPassword.
regards,
david
11 years, 11 months
[libvirt] [PATCH] Replace use of 'in_addr_t' with 'struct in_addr'
by Daniel P. Berrange
From: "Daniel P. Berrange" <berrange(a)redhat.com>
The 'in_addr_t' typedef is not present in Mingw64 headers.
Instead we can use the more portable 'struct in_addr' and
then access its 's_addr' field.
Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
---
src/util/virsocketaddr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c
index 2666574..80b5c0b 100644
--- a/src/util/virsocketaddr.c
+++ b/src/util/virsocketaddr.c
@@ -235,10 +235,10 @@ virSocketAddrIsPrivate(const virSocketAddrPtr addr)
bool
virSocketAddrIsWildcard(const virSocketAddrPtr addr)
{
- in_addr_t tmp = INADDR_ANY;
+ struct in_addr tmp = { .s_addr = INADDR_ANY };
switch (addr->data.stor.ss_family) {
case AF_INET:
- return memcmp(&addr->data.inet4.sin_addr.s_addr, &tmp,
+ return memcmp(&addr->data.inet4.sin_addr.s_addr, &tmp.s_addr,
sizeof(addr->data.inet4.sin_addr.s_addr)) == 0;
case AF_INET6:
return IN6_IS_ADDR_UNSPECIFIED(&addr->data.inet6.sin6_addr);
--
1.8.2.1
11 years, 11 months
[libvirt] [PATCH] Allow RO connections to interface udev backend
by Doug Goldstein
The udev based interface backend did not allow querying data over a
read-only connection which is different than how the netcf backend
operates. This brings the behavior inline with the default, netcf
backend.
---
src/interface/interface_backend_udev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/interface/interface_backend_udev.c b/src/interface/interface_backend_udev.c
index 68e1e2f..95034bf 100644
--- a/src/interface/interface_backend_udev.c
+++ b/src/interface/interface_backend_udev.c
@@ -139,7 +139,7 @@ udevInterfaceOpen(virConnectPtr conn,
{
struct udev_iface_driver *driverState = NULL;
- virCheckFlags(0, VIR_DRV_OPEN_ERROR);
+ virCheckFlags(VIR_CONNECT_RO, VIR_DRV_OPEN_ERROR);
if (VIR_ALLOC(driverState) < 0) {
virReportOOMError();
--
1.8.1.5
11 years, 11 months
[libvirt] [PATCHv2 0/2] Swap order of AddImplicitControllers and DomainDefPostParse
by Viktor Mihajlovski
Implicit controllers may be dependent on device definitions altered
in a post-parse callback. E.g., if a console device is
defined without the target type, the type will be set in QEMU's
callback. In the case of s390, this is virtio, which requires
an implicit virtio-serial controller.
By moving the implicit controller definition after the post-parse
procssing this can be fixed. As Martin pointed out, implicit controllers
should not need post-parsing, so the rearranging should not hurt.
Probably this is only affecting the S390 virtio console anyway.
V2 Changes:
- Promoted from RFC to Patch Series
- Added an qemuxml2xml testcase highlighting the issue: applying the first
patch only will fail make check as the implicit controller is missing.
Viktor Mihajlovski (2):
S390: Testcase for console default target type (virtio)
conf: Swap order of AddImplicitControllers and DomainDefPostParse
src/conf/domain_conf.c | 8 +++----
.../qemuxml2argv-s390-defaultconsole.xml | 20 ++++++++++++++++
.../qemuxml2xmlout-balloon-device-auto.xml | 2 +-
.../qemuxml2xmlout-channel-virtio-auto.xml | 2 +-
.../qemuxml2xmlout-console-virtio.xml | 2 +-
.../qemuxml2xmlout-disk-scsi-device-auto.xml | 2 +-
.../qemuxml2xmlout-s390-defaultconsole.xml | 24 ++++++++++++++++++++
tests/qemuxml2xmltest.c | 2 ++
8 files changed, 54 insertions(+), 8 deletions(-)
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-s390-defaultconsole.xml
create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-s390-defaultconsole.xml
--
1.7.9.5
11 years, 11 months
[libvirt] [PATCH] build: Fix VPATH build for access/*
by Viktor Mihajlovski
VPATH build failed for the generated access driver files.
Signed-off-by: Viktor Mihajlovski <mihajlov(a)linux.vnet.ibm.com>
---
src/Makefile.am | 23 +++++++++++++----------
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index e6b1927..4cf999d 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -808,9 +808,12 @@ SECURITY_DRIVER_APPARMOR_SOURCES = \
security/security_apparmor.h security/security_apparmor.c
ACCESS_DRIVER_GENERATED = \
- access/viraccessapicheck.h access/viraccessapicheck.c \
- access/viraccessapicheckqemu.h access/viraccessapicheckqemu.c \
- access/viraccessapichecklxc.h access/viraccessapichecklxc.c
+ $(srcdir)/access/viraccessapicheck.h \
+ $(srcdir)/access/viraccessapicheck.c \
+ $(srcdir)/access/viraccessapicheckqemu.h \
+ $(srcdir)/access/viraccessapicheckqemu.c \
+ $(srcdir)/access/viraccessapichecklxc.h \
+ $(srcdir)/access/viraccessapichecklxc.c
ACCESS_DRIVER_SYMFILES = \
libvirt_access.syms \
@@ -828,7 +831,7 @@ ACCESS_DRIVER_POLKIT_SOURCES = \
access/viraccessdriverpolkit.h access/viraccessdriverpolkit.c
ACCESS_DRIVER_POLKIT_POLICY = \
- access/org.libvirt.api.policy
+ $(srcdir)/access/org.libvirt.api.policy
NODE_DEVICE_DRIVER_SOURCES = \
@@ -1488,29 +1491,29 @@ libvirt_access_lxc.syms: $(srcdir)/rpc/gendispatch.pl \
$(AM_V_GEN)$(PERL) -w $(srcdir)/rpc/gendispatch.pl --mode=aclsym \
lxc LXC $(LXC_PROTOCOL) > $@
-access/viraccessapicheck.h: $(srcdir)/rpc/gendispatch.pl \
+$(srcdir)/access/viraccessapicheck.h: $(srcdir)/rpc/gendispatch.pl \
$(REMOTE_PROTOCOL) Makefile.am
$(AM_V_GEN)$(PERL) -w $(srcdir)/rpc/gendispatch.pl --mode=aclheader \
remote REMOTE $(REMOTE_PROTOCOL) > $@
-access/viraccessapicheck.c: $(srcdir)/rpc/gendispatch.pl \
+$(srcdir)/access/viraccessapicheck.c: $(srcdir)/rpc/gendispatch.pl \
$(REMOTE_PROTOCOL) Makefile.am
$(AM_V_GEN)$(PERL) -w $(srcdir)/rpc/gendispatch.pl --mode=aclbody \
remote REMOTE $(REMOTE_PROTOCOL) access/viraccessapicheck.h > $@
-access/viraccessapicheckqemu.h: $(srcdir)/rpc/gendispatch.pl \
+$(srcdir)/access/viraccessapicheckqemu.h: $(srcdir)/rpc/gendispatch.pl \
$(QEMU_PROTOCOL) Makefile.am
$(AM_V_GEN)$(PERL) -w $(srcdir)/rpc/gendispatch.pl --mode=aclheader \
qemu QEMU $(QEMU_PROTOCOL) > $@
-access/viraccessapicheckqemu.c: $(srcdir)/rpc/gendispatch.pl \
+$(srcdir)/access/viraccessapicheckqemu.c: $(srcdir)/rpc/gendispatch.pl \
$(QEMU_PROTOCOL) Makefile.am
$(AM_V_GEN)$(PERL) -w $(srcdir)/rpc/gendispatch.pl --mode=aclbody \
qemu QEMU $(QEMU_PROTOCOL) access/viraccessapicheckqemu.h > $@
-access/viraccessapichecklxc.h: $(srcdir)/rpc/gendispatch.pl \
+$(srcdir)/access/viraccessapichecklxc.h: $(srcdir)/rpc/gendispatch.pl \
$(LXC_PROTOCOL) Makefile.am
$(AM_V_GEN)$(PERL) -w $(srcdir)/rpc/gendispatch.pl --mode=aclheader \
lxc LXC $(LXC_PROTOCOL) > $@
-access/viraccessapichecklxc.c: $(srcdir)/rpc/gendispatch.pl \
+$(srcdir)/access/viraccessapichecklxc.c: $(srcdir)/rpc/gendispatch.pl \
$(LXC_PROTOCOL) Makefile.am
$(AM_V_GEN)$(PERL) -w $(srcdir)/rpc/gendispatch.pl --mode=aclbody \
lxc LXC $(LXC_PROTOCOL) access/viraccessapichecklxc.h > $@
--
1.7.9.5
11 years, 11 months
[libvirt] [PATCH]Fix vPort Manage of FC vHBA creation
by Dennis Chen
When create a virtual FC HBA with virsh/libvirt API, an error message will be returned:"error: Node device not found",
also the 'nodedev-dumpxml' shows wrong information of wwpn & wwnn for the new created device.
Signed-off-by:xschen@tnsoft.com.cn
---
src/util/virutil.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/util/virutil.c b/src/util/virutil.c
index 6fa0212e..569d035 100644
--- a/src/util/virutil.c
+++ b/src/util/virutil.c
@@ -1792,8 +1792,8 @@ virManageVport(const int parent_host,
if (virAsprintf(&vport_name,
"%s:%s",
- wwnn,
- wwpn) < 0) {
+ wwpn,
+ wwnn) < 0) {
virReportOOMError();
goto cleanup;
}
11 years, 11 months
