June 2013 - Devel - libvirt List Archives

[libvirt] Schedule for next release 1.0.7 ?
by Daniel Veillard 19 Jun '13

19 Jun '13

If we want to release at the end of the month as usual, we should probably enter freeze next Monday or Tuesday. There is however some patch set needing review, e.g. the 'Guest Panicked' one or the big fine grained ACL feature. Dan do you think this can reasonably be merged in by next Monday ? If we get fine grained ACLs in then I would suggest to bump the release number to 1.1.0 as this is a major improvement whose possible impact at the application level is worth inticating as part of the release medium number. If not I guess we're in for 1.0.7, Opinions ? Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

2 1

[libvirt] ANNOUNCE: virt-manager 0.10.0 released
by Cole Robinson 19 Jun '13

19 Jun '13

I'm happy to announce the release of virt-manager 0.10.0! virt-manager is a desktop application for managing KVM and Xen virtual machines via libvirt. The release can be downloaded from: http://virt-manager.org/download.html The direct download links are: http://virt-manager.org/download/sources/virt-manager/virt-manager-0.10.0.t… This release includes: - Merged code with python-virtinst. virtinst is no longer public - Port from GTK2 to GTK3 (Daniel Berrange, Cole Robinson) - Port from gconf to gsettings - Port from autotools to python distutils - Remove virt-manager-tui - Remove HAL support - IPv6 and static route virtual network support (Gene Czarcinski) - virt-install: Add --cpu host-passthrough (Ken ICHIKAWA, Hu Tao) To elaborate a bit on the first two: * python-virtinst has been merged with virt-manager, and the virtinst library is no longer public. This shouldn't be a surprise to anyone following development over the last year. virt-manager now distributes the virtinst tools virt-install, virt-clone, virt-image, and virt-convert. * virt-manager has been ported to GTK3 and several other modern gnome libraries. The newest version that have been tested are what is shipped with Fedora 18, so nothing less than a year old. This version may not work correctly on an older distro. Thanks to everyone who has contributed to this release through testing, bug reporting, submitting patches, and otherwise sending in feedback! Thanks, Cole

1 0

[libvirt] [PATCH for v1.0.4-maint 0/2] Resolve issues seen with schedinfo
by John Ferlan 19 Jun '13

19 Jun '13

This is a backport of: https://www.redhat.com/archives/libvir-list/2013-June/msg00453.html submitted upstread as commit id 'b2375453' and '38ada092' John Ferlan (2): qemu: Resolve issue with GetScheduler APIs for non running domain lxc: Resolve issue with GetScheduler APIs for non running domain src/lxc/lxc_driver.c | 19 ++++++++++++++++++- src/qemu/qemu_driver.c | 19 ++++++++++++++++++- 2 files changed, 36 insertions(+), 2 deletions(-) -- 1.8.1.4

1 2

[libvirt] [PATCH v2 0/2] Resolve issues seen with schedinfo
by John Ferlan 19 Jun '13

19 Jun '13

These patches resolve an issue seen using 'virsh schedinfo <domain>' on a non running domain that have been present since 1.0.4 as a result of the cgroup infrastructure changes: https://www.redhat.com/archives/libvir-list/2013-April/msg00783.html The exact commit id that caused the issue is listed in each of the commit messages. I used git bisect to determine, although it was tricky because the TPM changes were made around the same time and required commit '8b934a5c' to be applied in order to actually see domains on my host. Prior to the changes the "CFS Bandwidth" data was obtained since the driver cgroup was mounted as opposed to the changes from the above set which mount cgroups when the domain is running. The result for 'virsh schedinfo <domain>' for a non running guest is to return the configuration data for default, --config, and --current options. The --live option reports a failure. For a running guest, default, --live, and --current report values from cgroup, while --config reports only the configuration values. This issue also affects the libvirt-cim code in how it defines QEMU domains. Fortunately it only looks for the "cpu_shares" value. Difference to v1: - In the [qemu|lxc]DomainGetSchedulerType() API's, rather than check for priv->cgroup, check if the domain is running and return defaults if not - In the [qemu|lxc]DomainGetSchedulerParametersFlags() API's, if we're only returning configuration data, then don't gate the result returned on the CFS bandwidth data cgroup availability. qemu: Resolve issue with GetScheduler APIs for non running domain lxc: Resolve issue with GetScheduler APIs for non running domain src/lxc/lxc_driver.c | 11 ++++++++++- src/qemu/qemu_driver.c | 11 ++++++++++- 2 files changed, 20 insertions(+), 2 deletions(-) -- 1.8.1.4

3 6

[libvirt] [PATCH v4 0/7] Add qcow2 extensions support
by Ján Tomko 19 Jun '13

19 Jun '13

Since QEMU 1.1 qcow2 supports a features bitfield, allowing to implement additional features without breaking compatibility with older QEMU versions. The version header on-disk is bumped to 3, however the format name is still 'qcow2', not 'qcow3' (which is what I used in v2). v4: rebased v3: https://www.redhat.com/archives/libvir-list/2013-May/msg01179.html v2: https://www.redhat.com/archives/libvir-list/2013-February/msg00212.html qcow2 vs. qcow3 discussion: https://www.redhat.com/archives/libvir-list/2013-March/msg00094.html Ján Tomko (7): storage: rework qemu-img command line generation util: add support for qcow2v3 image detection conf: add features to volume target XML storage: add support for creating qcow2 images with extensions conf: split out snapshot disk XML formatting Add qcow2 features support to snapshots qemu: add qcow2 extension support to inactive external snapshots docs/formatsnapshot.html.in | 5 + docs/formatstorage.html.in | 19 +++ docs/schemas/Makefile.am | 1 + docs/schemas/domainsnapshot.rng | 7 + docs/schemas/storagefilefeatures.rng | 24 ++++ docs/schemas/storagevol.rng | 7 + libvirt.spec.in | 1 + mingw-libvirt.spec.in | 2 + src/conf/snapshot_conf.c | 127 ++++++++++++++---- src/conf/snapshot_conf.h | 2 + src/conf/storage_conf.c | 74 ++++++++++ src/conf/storage_conf.h | 7 +- src/libvirt_private.syms | 2 + src/qemu/qemu_driver.c | 72 +++++++--- src/storage/storage_backend.c | 143 +++++++++++++------- src/storage/storage_backend_fs.c | 10 ++ src/util/virstoragefile.c | 164 ++++++++++++++++++----- src/util/virstoragefile.h | 12 ++ tests/domainsnapshotxml2xmlin/disk_snapshot.xml | 5 + tests/domainsnapshotxml2xmlout/disk_snapshot.xml | 4 + tests/storagevolxml2argvdata/qcow2-1.1.argv | 1 + tests/storagevolxml2argvdata/qcow2-lazy.argv | 1 + tests/storagevolxml2argvdata/vol-qcow2-1.1.xml | 32 +++++ tests/storagevolxml2argvdata/vol-qcow2-lazy.xml | 35 +++++ tests/storagevolxml2argvtest.c | 2 + tests/storagevolxml2xmlin/vol-qcow2-1.1.xml | 32 +++++ tests/storagevolxml2xmlin/vol-qcow2-lazy.xml | 35 +++++ tests/storagevolxml2xmlout/vol-qcow2-1.1.xml | 33 +++++ tests/storagevolxml2xmlout/vol-qcow2-lazy.xml | 35 +++++ tests/storagevolxml2xmltest.c | 2 + 30 files changed, 766 insertions(+), 130 deletions(-) create mode 100644 docs/schemas/storagefilefeatures.rng create mode 100644 tests/storagevolxml2argvdata/qcow2-1.1.argv create mode 100644 tests/storagevolxml2argvdata/qcow2-lazy.argv create mode 100644 tests/storagevolxml2argvdata/vol-qcow2-1.1.xml create mode 100644 tests/storagevolxml2argvdata/vol-qcow2-lazy.xml create mode 100644 tests/storagevolxml2xmlin/vol-qcow2-1.1.xml create mode 100644 tests/storagevolxml2xmlin/vol-qcow2-lazy.xml create mode 100644 tests/storagevolxml2xmlout/vol-qcow2-1.1.xml create mode 100644 tests/storagevolxml2xmlout/vol-qcow2-lazy.xml -- 1.8.1.5

2 14

[libvirt] [PATCH] util: switch virBufferTrim to void
by Ján Tomko 19 Jun '13

19 Jun '13

We don't care whether the trim was succesful or not anywhere except the tests. Switch it to void and set the buffer error on wrong usage. --- Patch that tried to shut Coverity up by checking the return values anyway: https://www.redhat.com/archives/libvir-list/2013-June/msg00650.html src/util/virbuffer.c | 19 ++++++++++--------- src/util/virbuffer.h | 2 +- tests/virbuftest.c | 43 ++++++++++++++++--------------------------- tools/virsh.c | 9 +++------ 4 files changed, 30 insertions(+), 43 deletions(-) diff --git a/src/util/virbuffer.c b/src/util/virbuffer.c index 693e4b2..4969497 100644 --- a/src/util/virbuffer.c +++ b/src/util/virbuffer.c @@ -660,27 +660,28 @@ virBufferStrcat(virBufferPtr buf, ...) * further limits how much of the tail is trimmed. If @str is NULL, then * @len must be non-negative. * - * Returns -1 if @buf has previously encountered an error or if @len is - * invalid, 0 if there was nothing to trim (@buf was too short or @str - * didn't match), and 1 if the trim was successful. + * Sets error to -1 (usage) if str is NULL and len is less than zero. */ -int +void virBufferTrim(virBufferPtr buf, const char *str, int len) { size_t len2 = 0; - if (!buf || buf->error || (!str && len < 0)) - return -1; + if (!buf || buf->error) + return; + if (!str && len < 0) { + virBufferSetError(buf, -1); + return; + } if (len > 0 && len > buf->use) - return 0; + return; if (str) { len2 = strlen(str); if (len2 > buf->use || memcmp(&buf->content[buf->use - len2], str, len2) != 0) - return 0; + return; } buf->use -= len < 0 ? len2 : len; buf->content[buf->use] = '\0'; - return 1; } diff --git a/src/util/virbuffer.h b/src/util/virbuffer.h index 7b69c0e..e0b77ab 100644 --- a/src/util/virbuffer.h +++ b/src/util/virbuffer.h @@ -77,6 +77,6 @@ void virBufferURIEncodeString(virBufferPtr buf, const char *str); void virBufferAdjustIndent(virBufferPtr buf, int indent); int virBufferGetIndent(const virBufferPtr buf, bool dynamic); -int virBufferTrim(virBufferPtr buf, const char *trim, int len); +void virBufferTrim(virBufferPtr buf, const char *trim, int len); #endif /* __VIR_BUFFER_H__ */ diff --git a/tests/virbuftest.c b/tests/virbuftest.c index c7a504b..3938f0d 100644 --- a/tests/virbuftest.c +++ b/tests/virbuftest.c @@ -148,38 +148,21 @@ static int testBufTrim(const void *data ATTRIBUTE_UNUSED) char *result = NULL; const char *expected = "a,b"; int ret = -1; - int i = 1; - -#define ACT(str, len, result) \ - do { \ - if (virBufferTrim(buf, str, len) != result) { \ - TEST_ERROR("trim %d failed", i); \ - goto cleanup; \ - } \ - i++; \ - } while (0); - - if (virBufferTrim(buf, "", 0) != -1) { - TEST_ERROR("Wrong failure detection 1"); - goto cleanup; - } + + virBufferTrim(buf, "", 0); buf = &bufinit; - if (virBufferTrim(buf, NULL, -1) != -1) { - TEST_ERROR("Wrong failure detection 2"); - goto cleanup; - } virBufferAddLit(buf, "a;"); - ACT("", 0, 1); - ACT("", -1, 1); - ACT(NULL, 1, 1); - ACT(NULL, 5, 0); - ACT("a", 2, 0); + virBufferTrim(buf, "", 0); + virBufferTrim(buf, "", -1); + virBufferTrim(buf, NULL, 1); + virBufferTrim(buf, NULL, 5); + virBufferTrim(buf, "a", 2); virBufferAddLit(buf, ",b,,"); - ACT("b", -1, 0); - ACT("b,,", 1, 1); - ACT(",", -1, 1); + virBufferTrim(buf, "b", -1); + virBufferTrim(buf, "b,,", 1); + virBufferTrim(buf, ",", -1); result = virBufferContentAndReset(buf); if (!result || STRNEQ(result, expected)) { @@ -187,6 +170,12 @@ static int testBufTrim(const void *data ATTRIBUTE_UNUSED) goto cleanup; } + virBufferTrim(buf, NULL, -1); + if (virBufferError(buf) != -1) { + TEST_ERROR("Usage error not flagged"); + goto cleanup; + } + ret = 0; cleanup: diff --git a/tools/virsh.c b/tools/virsh.c index 26d37c6..af2bb76 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -632,18 +632,15 @@ vshTreePrintInternal(vshControl *ctl, false, indent) < 0) goto cleanup; } - if (virBufferTrim(indent, " ", -1) < 0) - goto cleanup; + virBufferTrim(indent, " ", -1); /* If there was no child device, and we're the last in * a list of devices, then print another blank line */ if (nextlastdev == -1 && devid == lastdev) vshPrint(ctl, "%s\n", virBufferCurrentContent(indent)); - if (!root) { - if (virBufferTrim(indent, NULL, 2) < 0) - goto cleanup; - } + if (!root) + virBufferTrim(indent, NULL, 2); ret = 0; cleanup: return ret; -- 1.8.1.5

2 2

[libvirt] [PATCH] qemu: set QEMU_CAPS_DEVICE_VIDEO_PRIMARY cap flag in QMP detection
by Guannan Ren 18 Jun '13

18 Jun '13

When qemu >= 1.20, it is safe to use -device for primary video device as described in 4c993d8ab. So, we are missing the cap flag in QMP capabilities detection, this flag can be initialized safely in virQEMUCapsInitQMPBasic. --- src/qemu/qemu_capabilities.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 1091a07..406dca9 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -2418,6 +2418,7 @@ virQEMUCapsInitQMPBasic(virQEMUCapsPtr qemuCaps) virQEMUCapsSet(qemuCaps, QEMU_CAPS_MACHINE_OPT); virQEMUCapsSet(qemuCaps, QEMU_CAPS_DUMP_GUEST_CORE); virQEMUCapsSet(qemuCaps, QEMU_CAPS_VNC_SHARE_POLICY); + virQEMUCapsSet(qemuCaps, QEMU_CAPS_DEVICE_VIDEO_PRIMARY); } /* Capabilities that are architecture depending -- 1.8.1.4

2 2

[libvirt] [PATCH] check return values of virBufferTrim
by Ján Tomko 18 Jun '13

18 Jun '13

Just to silence Coverity: Event check_return: Calling function "virBufferTrim(virBufferPtr, char const *, int)" without checking return value (as is done elsewhere 5 out of 6 times). --- src/node_device/node_device_udev.c | 5 ++--- src/rpc/virnetsshsession.c | 3 +-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c index bb58415..a37989a 100644 --- a/src/node_device/node_device_udev.c +++ b/src/node_device/node_device_udev.c @@ -370,9 +370,8 @@ udevLogFunction(struct udev *udev ATTRIBUTE_UNUSED, const char *format = NULL; virBufferAdd(&buf, fmt, -1); - virBufferTrim(&buf, "\n", -1); - - format = virBufferContentAndReset(&buf); + if (virBufferTrim(&buf, "\n", -1) >= 0) + format = virBufferContentAndReset(&buf); virLogVMessage(VIR_LOG_FROM_LIBRARY, virLogPriorityFromSyslog(priority), diff --git a/src/rpc/virnetsshsession.c b/src/rpc/virnetsshsession.c index b6aedc8..2299871 100644 --- a/src/rpc/virnetsshsession.c +++ b/src/rpc/virnetsshsession.c @@ -362,9 +362,8 @@ virNetSSHCheckHostKey(virNetSSHSessionPtr sess) * we have to use a *MAGIC* constant. */ for (i = 0; i < 16; i++) virBufferAsprintf(&buff, "%02hhX:", keyhash[i]); - virBufferTrim(&buff, ":", 1); - if (virBufferError(&buff) != 0) { + if (virBufferTrim(&buff, ":", 1) < 0) { virReportOOMError(); return -1; } -- 1.8.1.5

3 4

[libvirt] Not able to open Xen Connection using libvirt
by varun bhatnagar 18 Jun '13

18 Jun '13

Hi, I am trying to create virtual machine through libvirt using xen hypervisor. I was able to install xen successfully but when I tried connecting to the hypervisor it gave an error. And while installing libvirt (libvirt-1.0.1) I installed it with xen support. I am pasting the snapshot of the error below: [image: Inline image 1] Can anyone tell me why I am getting this error? // Varun

1 0

[libvirt] [PATCH 0/2] Don't always fail migrations on I/O errors
by Peter Krempa 18 Jun '13

18 Jun '13

Recently I've added code that aborts migration in case of I/O error. This may not be desirable as qemu does actually support such migration. This series adds a flag that enables this option that will be now disabled by default. Peter Krempa (2): migration: Make erroring out on I/O error controllable by flag migration: Don't propagate VIR_MIGRATE_ABORT_ON_ERROR include/libvirt/libvirt.h.in | 1 + src/libvirt.c | 17 +++++++++++------ src/qemu/qemu_driver.c | 4 ++-- src/qemu/qemu_migration.c | 39 ++++++++++++++++++++++++--------------- src/qemu/qemu_migration.h | 6 ++++-- tools/virsh-domain.c | 7 +++++++ tools/virsh.pod | 6 ++++-- 7 files changed, 53 insertions(+), 27 deletions(-) -- 1.8.2.1

3 4