[libvirt] [Ruby] Next release?
by Hiroshi Miura
Hi Chris,
I'm waiting a next release of ruby-libvitrt in 4 month.
Recent development git snapshot works well with
vagnrant-kvm that I worked.
thank you for hard work.
Hiroshi
10 years, 10 months
[libvirt] [PATCHv5 0/4] Implement RBD storage pool support
by Adam Walters
Here are updated patches that implement RBD storage pool support in libvirt.
By and large, my changes are confined to qemu_conf.c, but I did need a couple
of changes in domain_conf.c in order to get things working. I've tested these
patches on my equipment, and they worked there, but they could probably use
testing by others if anyone else has Ceph configured.
The last patch in this series isn't needed in order to have RBD volumes work
for domains, but it is needed if you don't want to have to kill the domain to
get it back under the control of libvirt.
Adam Walters (4):
qemu: conf: Add qemuAddRBDPoolSourceHost helper function
qemu: conf: Implement RBD storage pool support
domain: conf: Bypass virDomainDiskDefForeachPath for network volumes
domain: conf: Resolve bug related to network volume types
src/conf/domain_conf.c | 6 +++--
src/qemu/qemu_conf.c | 62 +++++++++++++++++++++++++++++++++++++++++++++++++-
2 files changed, 65 insertions(+), 3 deletions(-)
--
1.8.4.2
10 years, 10 months
[libvirt] [PATCH 0/6] Various spec file enhancements
by Jim Fehlig
This series moves some driver-specific files from the main libvirt-daemon
package to the respective libvirt-daemon-driver-* package when building with
driver modules.
This was originally all one patch that I found difficult to review, so I tried
to logically break it up in hopes to make it easier to review.
Jim Fehlig (6):
spec: Conditionally add /etc/libvirt/nwfilter
spec: Only add libvirt-daemon pre install script if building with qemu spec: Fix files list when building without driver modules
spec: Conditionally specify some hypervisor-specific files
spec: Define hypervisor-specific files together
spec: move driver-specific files to driver subpackages
libvirt.spec.in | 199 +++++++++++++++++++++++++++++++++-----------------------
1 file changed, 117 insertions(+), 82 deletions(-)
--
1.8.0.1
10 years, 10 months
[libvirt] [PATCHv4 0/2] Implement RBD volumes support
by Peter Krempa
Version 4 incorporates changes from my review feedback. Re-sending as I don't
have the opportunity to test the code.
Adam Walters (2):
qemu: conf: Add qemuAddRBDPoolSourceHost helper function
qemu: conf: Implement RBD storage pool support
src/qemu/qemu_conf.c | 60 +++++++++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 59 insertions(+), 1 deletion(-)
--
1.8.4.3
10 years, 10 months
[libvirt] [PATCH] lxc: return the right value if failed to make path
by Chen Hanxiao
From: Chen Hanxiao <chenhanxiao(a)cn.fujitsu.com>
If we failed to make path for pts,
lxcContainerMountFSDevPTS will return the value
virAsprintf returned rather than -1.
Signed-off-by: Chen Hanxiao <chenhanxiao(a)cn.fujitsu.com>
---
src/lxc/lxc_container.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c
index b1b63fb..2835463 100644
--- a/src/lxc/lxc_container.c
+++ b/src/lxc/lxc_container.c
@@ -952,7 +952,7 @@ static int lxcContainerMountFSDevPTS(virDomainDefPtr def,
def->name)) < 0)
return ret;
- if (virFileMakePath("/dev/pts") < 0) {
+ if ((ret = virFileMakePath("/dev/pts")) < 0) {
virReportSystemError(errno, "%s",
_("Cannot create /dev/pts"));
goto cleanup;
--
1.8.2.1
10 years, 10 months
[libvirt] [PATCH] Cgroup: Replace 'newpath' with 'newPath'
by Wangyufei (James)
>From be1ce1c794b05a27aa85d037500a821b8c514d12 Mon Sep 17 00:00:00 2001
From: Zhou Yimin <zhouyimin(a)huawei.com>
Date: Fri, 6 Dec 2013 11:38:14 +0800
Subject: [PATCH] Cgroup: Replace 'newpath' with 'newPath'
Unifying codding style, replace 'newpath' with 'newPath'.
From: Zhou Yimin <zhouyimin(a)huawei.com>
---
src/util/vircgroup.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index 5c43e10..9674328 100644
--- a/src/util/vircgroup.c
+++ b/src/util/vircgroup.c
@@ -1246,7 +1246,7 @@ virCgroupNewPartition(const char *path,
int ret = -1;
char *parentPath = NULL;
virCgroupPtr parent = NULL;
- char *newpath = NULL;
+ char *newPath = NULL;
VIR_DEBUG("path=%s create=%d controllers=%x",
path, create, controllers);
@@ -1257,15 +1257,15 @@ virCgroupNewPartition(const char *path,
return -1;
}
- if (virCgroupSetPartitionSuffix(path, &newpath) < 0)
+ if (virCgroupSetPartitionSuffix(path, &newPath) < 0)
goto cleanup;
- if (virCgroupNew(-1, newpath, NULL, controllers, group) < 0)
+ if (virCgroupNew(-1, newPath, NULL, controllers, group) < 0)
goto cleanup;
- if (STRNEQ(newpath, "/")) {
+ if (STRNEQ(newPath, "/")) {
char *tmp;
- if (VIR_STRDUP(parentPath, newpath) < 0)
+ if (VIR_STRDUP(parentPath, newPath) < 0)
goto cleanup;
tmp = strrchr(parentPath, '/');
@@ -1287,7 +1287,7 @@ cleanup:
virCgroupFree(group);
virCgroupFree(&parent);
VIR_FREE(parentPath);
- VIR_FREE(newpath);
+ VIR_FREE(newPath);
return ret;
}
--
1.7.3.1.msysgit.0
Best Regards,
-WangYufei
10 years, 10 months
[libvirt] [PATCH 0/3] Support more snapshot disk configs
by Peter Krempa
A newly finished part of the large gluster snapshot series.
These patches allow to parse and format definitions of snapshot
disks including block, dir and network backing.
Peter Krempa (3):
snapshot: schema: Split out snapshot disk driver definition
snapshot: Add support for specifying snapshot disk backing type
snapshots: Test snapshot disk type specification
docs/schemas/domainsnapshot.rng | 94 +++++++++++++++++++-----
src/conf/snapshot_conf.c | 25 ++++++-
src/conf/snapshot_conf.h | 15 ++--
src/qemu/qemu_driver.c | 59 ++++++++++-----
tests/domainsnapshotxml2xmlin/disk_snapshot.xml | 18 +++++
tests/domainsnapshotxml2xmlout/disk_snapshot.xml | 18 +++++
6 files changed, 181 insertions(+), 48 deletions(-)
--
1.8.4.3
10 years, 10 months
[libvirt] [PATCH] Add qxl ram size to ABI stability check
by Ján Tomko
55bfd02 added a 'ram' attribute for qxl video devices
but didn't update the ABI check.
https://bugzilla.redhat.com/show_bug.cgi?id=1035123
---
src/conf/domain_conf.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 0268847..b76cf26 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -13191,6 +13191,13 @@ virDomainVideoDefCheckABIStability(virDomainVideoDefPtr src,
return false;
}
+ if (src->ram != dst->ram) {
+ virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+ _("Target video card ram %u does not match source %u"),
+ dst->ram, src->ram);
+ return false;
+ }
+
if (src->vram != dst->vram) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
_("Target video card vram %u does not match source %u"),
--
1.8.3.2
10 years, 10 months
[libvirt] [PATCH] qemu: Improve error when setting invalid count of vcpus via agent
by Peter Krempa
https://bugzilla.redhat.com/show_bug.cgi?id=1035108
When attempting to enable more vCPUs in the guest than is currently
enabled in the guest but less than the maximum count for the VM we
currently reported an unhelpful message:
error: internal error: guest agent reports less cpu than requested
This patch changes it to:
error: invalid argument: requested vcpu count is greater than the count
of enabled vcpus in the domain: 3 > 2
---
src/qemu/qemu_driver.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index e2d4e97..66f2a0e 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -4201,6 +4201,14 @@ qemuDomainSetVcpusFlags(virDomainPtr dom, unsigned int nvcpus,
goto endjob;
}
+ if (nvcpus > vm->def->vcpus) {
+ virReportError(VIR_ERR_INVALID_ARG,
+ _("requested vcpu count is greater than the count "
+ "of enabled vcpus in the domain: %d > %d"),
+ nvcpus, vm->def->vcpus);
+ goto endjob;
+ }
+
qemuDomainObjEnterAgent(vm);
ncpuinfo = qemuAgentGetVCPUs(priv->agent, &cpuinfo);
qemuDomainObjExitAgent(vm);
--
1.8.4.3
10 years, 10 months
