[libvirt] [PATCH v2] Build breaker securityselinuxhelper.c
by John Ferlan
v2: syntax-check - need space on # include
Commit 907a39e7 missed adding the WITH_ATTR around #include <attr/xattr.h>
resulting in a build failure:
CC libsecurityselinuxhelper_la-securityselinuxhelper.lo
securityselinuxhelper.c:27:24: fatal error: attr/xattr.h: No such file or directory
compilation terminated.
make[2]: *** [libsecurityselinuxhelper_la-securityselinuxhelper.lo] Error 1
make[2]: Leaving directory `/home/jferlan/libvirt.work/tests'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/jferlan/libvirt.work'
make: *** [all] Error 2
---
tests/securityselinuxhelper.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/securityselinuxhelper.c b/tests/securityselinuxhelper.c
index daad7dd..a9656a8 100644
--- a/tests/securityselinuxhelper.c
+++ b/tests/securityselinuxhelper.c
@@ -24,7 +24,9 @@
#include <string.h>
#include <unistd.h>
#include <errno.h>
-#include <attr/xattr.h>
+#if WITH_ATTR
+# include <attr/xattr.h>
+#endif
/*
--
1.7.11.7
12 years, 4 months
[libvirt] [PATCH] Don't try to include xattr.h if not available
by Guido Günther
---
tests/securityselinuxhelper.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/securityselinuxhelper.c b/tests/securityselinuxhelper.c
index abe4d7c..bd5ea87 100644
--- a/tests/securityselinuxhelper.c
+++ b/tests/securityselinuxhelper.c
@@ -24,7 +24,9 @@
#include <string.h>
#include <unistd.h>
#include <errno.h>
-#include <attr/xattr.h>
+#ifdef WITH_ATTR
+# include <attr/xattr.h>
+#endif
/*
--
1.7.10.4
12 years, 4 months
[libvirt] [ANNOUNCE] libvirt-glib 0.1.5 release
by Daniel P. Berrange
I am pleased to announce that a new release of the libvirt-glib package,
version 0.1.5, is now available from
ftp://libvirt.org/libvirt/glib/
The packages are GPG signed with
Key fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF (4096R)
New in this release:
- Add support for bridge interface types in guest XML
- Add API to open a read-only connection
- Add support for smartcard devices in guest XML
- Remove storage volume from pool list after deleting it
libvirt-glib comprises three distinct libraries:
- libvirt-glib - Integrate with the GLib event loop and error handling
- libvirt-gconfig - Representation of libvirt XML documents as GObjects
- libvirt-gobject - Mapping of libvirt APIs into the GObject type system
NB: While libvirt aims to be API/ABI stable forever, with libvirt-glib
we are not yet guaranteeing that libvirt-glib libraries are API/ABI
permanently stable. As of the 0.0.8 release, we have tentatively frozen
the API/ABI with the intent of being longterm stable hereafter, but
there is still a small chance we might find flaws requiring an API/ABI
change. The likelihood of this is low, however, and we will strive to
avoid it.
Follow up comments about libvirt-glib should be directed to the regular
libvir-list(a)redhat.com development list.
Thanks to all the people involved in contributing to this release.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
12 years, 4 months
[libvirt] [PATCH] Build breaker securityselinuxhelper.c
by John Ferlan
Commit 907a39e7 missed adding the WITH_ATTR around #include <attr/xattr.h>
resulting in a build failure:
CC libsecurityselinuxhelper_la-securityselinuxhelper.lo
securityselinuxhelper.c:27:24: fatal error: attr/xattr.h: No such file or directory
compilation terminated.
make[2]: *** [libsecurityselinuxhelper_la-securityselinuxhelper.lo] Error 1
make[2]: Leaving directory `/home/jferlan/libvirt.work/tests'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/jferlan/libvirt.work'
make: *** [all] Error 2
---
tests/securityselinuxhelper.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/securityselinuxhelper.c b/tests/securityselinuxhelper.c
index daad7dd..206d936 100644
--- a/tests/securityselinuxhelper.c
+++ b/tests/securityselinuxhelper.c
@@ -24,7 +24,9 @@
#include <string.h>
#include <unistd.h>
#include <errno.h>
+#if WITH_ATTR
#include <attr/xattr.h>
+#endif
/*
--
1.7.11.7
12 years, 4 months
[libvirt] [PATCH] build: work around broken kernel header
by Eric Blake
I got this scary warning during ./configure on rawhide:
checking linux/if_bridge.h usability... no
checking linux/if_bridge.h presence... yes
configure: WARNING: linux/if_bridge.h: present but cannot be compiled
configure: WARNING: linux/if_bridge.h: check for missing prerequisite headers?
configure: WARNING: linux/if_bridge.h: see the Autoconf documentation
configure: WARNING: linux/if_bridge.h: section "Present But Cannot Be Compiled"
configure: WARNING: linux/if_bridge.h: proceeding with the compiler's result
configure: WARNING: ## ------------------------------------- ##
configure: WARNING: ## Report this to libvir-list(a)redhat.com ##
configure: WARNING: ## ------------------------------------- ##
checking for linux/if_bridge.h... no
* configure.ac (AC_CHECK_HEADERS): Provide struct in6_addr, since
linux/if_bridge.h uses it without declaring it.
---
Pushing under the build-breaker rule. I also plan on opening a
BZ against the kernel headers.
configure.ac | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/configure.ac b/configure.ac
index 753916c..31e7f80 100644
--- a/configure.ac
+++ b/configure.ac
@@ -978,7 +978,9 @@ dnl
if test "$with_linux" = "yes"; then
if test "$with_qemu" = "yes" || test "$with_lxc" = "yes" ; then
AC_CHECK_HEADERS([linux/param.h linux/sockios.h linux/if_bridge.h linux/if_tun.h],,
- AC_MSG_ERROR([You must install kernel-headers in order to compile libvirt with QEMU or LXC support]))
+ [AC_MSG_ERROR([You must install kernel-headers in order to compile libvirt with QEMU or LXC support])],
+ [[#include <netinet/ip6.h>
+ ]])
fi
fi
--
1.7.1
12 years, 4 months
[libvirt] [PATCH] maint: typo fix
by Eric Blake
I noticed this typo while configuring on a freshly-installed machine.
* m4/virt-udev.m4: Correct pciaccess name.
---
Pushing under the trivial rule.
m4/virt-udev.m4 | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/m4/virt-udev.m4 b/m4/virt-udev.m4
index bf4623d..55673bf 100644
--- a/m4/virt-udev.m4
+++ b/m4/virt-udev.m4
@@ -22,7 +22,7 @@ AC_DEFUN([LIBVIRT_CHECK_UDEV],[
LIBVIRT_CHECK_PKG([UDEV], [libudev], [145])
if test "$with_udev" = "yes" && test "$with_pciaccess" != "yes" ; then
- AC_MSG_ERROR([You must install the pciaccesss module to build with udev])
+ AC_MSG_ERROR([You must install the pciaccess module to build with udev])
fi
])
--
1.7.1
12 years, 4 months
[libvirt] [PATCH] docs: generate links from plain text documentation
by Claudio Bley
There are two forms used throughout libvirt code comments, which
are both supported by this patch.
* plain links like e.g. http://www.libvirt.org/
* links enclosed in <> characters, e.g. <http://www.libvirt.org/>
Signed-off-by: Claudio Bley <cbley(a)av-test.de>
---
docs/newapi.xsl | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/docs/newapi.xsl b/docs/newapi.xsl
index 24831ee..6d20358 100644
--- a/docs/newapi.xsl
+++ b/docs/newapi.xsl
@@ -62,6 +62,19 @@
<a href="libvirt-{$ref/@file}.html#{$ref/(a)name}"><xsl:value-of select="$stem"/></a>
<xsl:value-of select="substring-after($token, $stem)"/>
</xsl:when>
+ <xsl:when test="starts-with($token, 'http://')">
+ <a href="{$token}">
+ <xsl:value-of select="$token"/>
+ </a>
+ </xsl:when>
+ <xsl:when test="starts-with($token, '<http://') and contains($token, '>')">
+ <xsl:variable name="link"
+ select="substring(substring-before($token, '>'), 2)"/>
+ <a href="{$link}">
+ <xsl:value-of select="$link"/>
+ </a>
+ <xsl:value-of select="substring-after($token, '>')"/>
+ </xsl:when>
<xsl:otherwise>
<xsl:value-of select="$token"/>
</xsl:otherwise>
@@ -547,7 +560,11 @@
<h2 style="font-weight:bold;color:red;text-align:center">This module is deprecated</h2>
</xsl:if>
<xsl:if test="description">
- <p><xsl:value-of select="description"/></p>
+ <p>
+ <xsl:call-template name="dumptext">
+ <xsl:with-param name="text" select="description"/>
+ </xsl:call-template>
+ </p>
</xsl:if>
</xsl:template>
--
1.7.9.5
12 years, 4 months
[libvirt] [test-API][PATCH] Update activate pool case
by Wayne Sun
* delete the unused function
* fix column length and some other nits
Signed-off-by: Wayne Sun <gsun(a)redhat.com>
---
repos/storage/activate_pool.py | 45 +++++++++++++++++----------------------
1 files changed, 20 insertions(+), 25 deletions(-)
diff --git a/repos/storage/activate_pool.py b/repos/storage/activate_pool.py
index 064f356..d3adef8 100644
--- a/repos/storage/activate_pool.py
+++ b/repos/storage/activate_pool.py
@@ -1,8 +1,5 @@
#!/usr/bin/env python
-import os
-import re
-import sys
import time
import libvirt
@@ -13,42 +10,40 @@ from src import sharedmod
required_params = ('poolname',)
optional_params = {}
-def display_pool_info(stg, logger):
- """Display current storage pool information"""
- logger.debug("current defined storage pool: %s" % \
- stg.defstorage_pool_list())
- logger.debug("current active storage pool: %s" % stg.storage_pool_list())
-
def activate_pool(params):
- """Undefine a storage pool that's been defined and inactive"""
+ """activate a storage pool that's been defined
+ and inactive
+ """
logger = params['logger']
poolname = params['poolname']
conn = sharedmod.libvirtobj['conn']
- pool_names = conn.listDefinedStoragePools()
- pool_names += conn.listStoragePools()
+ try:
+ pool_names = conn.listDefinedStoragePools()
+ pool_names += conn.listStoragePools()
- if poolname in pool_names:
- poolobj = conn.storagePoolLookupByName(poolname)
- else:
- logger.error("%s not found\n" % poolname);
- return 1
+ if poolname in pool_names:
+ poolobj = conn.storagePoolLookupByName(poolname)
+ else:
+ logger.error("%s not found\n" % poolname);
+ return 1
- if poolobj.isActive():
- logger.error("%s is active already" % poolname)
- return 1
+ if poolobj.isActive():
+ logger.error("%s is active already" % poolname)
+ return 1
- try:
poolobj.create(0)
time.sleep(5)
if poolobj.isActive():
- logger.info("activating %s storage pool is SUCCESSFUL!!!" % poolname)
+ logger.info("activating %s storage pool is SUCCESSFUL!!!" %
+ poolname)
else:
- logger.info("activating %s storage pool is UNSUCCESSFUL!!!" % poolname)
+ logger.info("activating %s storage pool is UNSUCCESSFUL!!!" %
+ poolname)
return 1
+
except libvirtError, e:
- logger.error("API error message: %s, error code is %s" \
- % (e.message, e.get_error_code()))
+ logger.error("libvirt call failed: " + str(e))
return 1
return 0
--
1.7.1
12 years, 4 months
[libvirt] [PATCH] qemu: Fix grouping of capabilities strings
by Peter Krempa
Commit f8d478b6dfc46a0ad2459844b96937599dec06e1 broke the grouping by
five items.
---
Pushed under the trivial rule.
---
src/qemu/qemu_capabilities.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 25e8951..b166dd6 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -200,7 +200,8 @@ VIR_ENUM_IMPL(qemuCaps, QEMU_CAPS_LAST,
"vmware-svga",
"device-video-primary",
"s390-sclp",
- "usb-serial",
+
+ "usb-serial", /* 125 */
"usb-net",
);
--
1.8.1
12 years, 4 months
