May 2009 - Devel - libvirt List Archives

[libvirt] [PATCH v2] Don't throw away QEMU startup errors when migrating.
by Cole Robinson 05 May '09

05 May '09

The attached patch removes the error message squashing that can take place in the qemu driver when launching a new VM via restore or migrate. Thanks, Cole

2 2

[libvirt] [PATCH] Test driver VolCreate cleanups
by Cole Robinson 05 May '09

05 May '09

The attached patch fixes some small issues with VolCreateXML implementation in the test driver. Thanks, Cole

2 2

[libvirt] [PATCH] Remove some old debugging code
by Cole Robinson 05 May '09

05 May '09

The attached patch removes some debugging code accidentally applied with my async vol creation patches. Thanks, Cole

2 2

[libvirt] [PATCH] Use correct error code in public VolCreateXML
by Cole Robinson 05 May '09

05 May '09

The attached patch fixes a use of an incorrect error code in libvirt.c VolCreateXML. Thanks, Cole

2 2

[libvirt] [PATCH 0/1] NPIV node device backend
by David Allan 05 May '09

05 May '09

Here is an initial implementation of the NPIV support backend using the node device API. It only implements create. Destroy should be fairly straightforward, but I want to get the patch out to the list for comment while I continue to work. The code currently requires the device name and host number to be specified in the XML, but it does not use those values. I will clean that up. The user will not be able to specify either of those values, as they are created by the system when it discovers the newly created device. <device> <name>foo</name> <parent>pci_10df_fe00_scsi_host_0</parent> <capability type='scsi_host'> <host>99999</host> <capability type='fc_host'> <wwnn>c0001b0000000018</wwnn> <wwpn>c0001b1000000018</wwpn> </capability> </capability> </device>

2 2

[libvirt] Patch: Fix build with -Werror=format-security cflag
by Frederik Himpe 05 May '09

05 May '09

This patch is needed to build libvirt with -Werror=format-security gcc cflag, which is used by default on Mandriva diff -ur libvirt-0.6.3.orig/src/virsh.c libvirt-0.6.3/src/virsh.c --- libvirt-0.6.3.orig/src/virsh.c 2009-04-15 21:43:26.000000000 +0200 +++ libvirt-0.6.3/src/virsh.c 2009-05-02 13:56:11.000000000 +0200 @@ -4463,7 +4463,7 @@ } /* Print this device */ - vshPrint(ctl, indentBuf); + vshPrint(ctl, "%s", indentBuf); vshPrint(ctl, "%s\n", devices[devid]); @@ -4487,7 +4487,7 @@ /* If there is a child device, then print another blank line */ if (nextlastdev != -1) { - vshPrint(ctl, indentBuf); + vshPrint(ctl, "%s", indentBuf); vshPrint(ctl, " |\n"); } @@ -4511,7 +4511,7 @@ /* If there was no child device, and we're the last in * a list of devices, then print another blank line */ if (nextlastdev == -1 && devid == lastdev) { - vshPrint(ctl, indentBuf); + vshPrint(ctl, "%s", indentBuf); vshPrint(ctl, "\n"); } }

2 1

[libvirt] [PATCH 0/7] Improve QEMU process startup error reporting
by Cole Robinson 04 May '09

04 May '09

Error reporting for failed QEMU processes isn't too great at the moment. A couple cases I have hit: - Trying to start a VM with a cdrom pointing to a nonexistent file. The svirt hook function choked on this and indicated as much in the domain log, but I still had to wait for the pidfile timeout (10 seconds), and the only error reported was 'Domain did not show up'. - QEMU dies quickly at startup. Happened with the pulse audio issue, or if we build cli args incorrectly. The reporting here varies: if QEMU dies before writing out the pidfile, the above case applies. If the pidfile is written, we timeout in ReadLogOutput, and it's hit or miss whether we even report the logfile output to the user. The following patches improve the above cases by ensuring we never have to wait for a timeout, and that the logfile output is always reported in the error message. Cole Robinson (7): Add documentation for __virExec and virExec virExec: Delay daemonizing as long as possible. Add helper function virExecDaemonize Report qemu log data if we fail to daemonize the process. Add pidfile argument to __virExec Check that QEMU is still alive while reading startup output. Don't throw away QEMU startup errors when migrating. src/libvirt_private.syms | 2 +- src/proxy_internal.c | 16 +-- src/qemu_conf.c | 7 - src/qemu_driver.c | 105 +++++++---- src/remote_internal.c | 15 +-- src/uml_driver.c | 11 +- src/util.c | 186 +++++++++++++++----- src/util.h | 15 ++- .../qemuxml2argvdata/qemuxml2argv-boot-cdrom.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-boot-floppy.args | 2 +- .../qemuxml2argv-boot-network.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-bootloader.args | 2 +- .../qemuxml2argv-clock-localtime.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-clock-utc.args | 2 +- .../qemuxml2argv-console-compat.args | 2 +- .../qemuxml2argv-disk-cdrom-empty.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-disk-cdrom.args | 2 +- .../qemuxml2argv-disk-drive-boot-cdrom.args | 2 +- .../qemuxml2argv-disk-drive-boot-disk.args | 2 +- .../qemuxml2argv-disk-drive-cache-v1-none.args | 2 +- .../qemuxml2argv-disk-drive-cache-v1-wb.args | 2 +- .../qemuxml2argv-disk-drive-cache-v1-wt.args | 2 +- .../qemuxml2argv-disk-drive-cache-v2-none.args | 2 +- .../qemuxml2argv-disk-drive-cache-v2-wb.args | 2 +- .../qemuxml2argv-disk-drive-cache-v2-wt.args | 2 +- .../qemuxml2argv-disk-drive-fmt-qcow.args | 2 +- .../qemuxml2argv-disk-drive-shared.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-disk-floppy.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-many.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-usb.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-disk-virtio.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-disk-xenvbd.args | 2 +- .../qemuxml2argv-graphics-sdl-fullscreen.args | 2 +- .../qemuxml2argv-graphics-sdl.args | 2 +- .../qemuxml2argv-graphics-vnc-sasl.args | 2 +- .../qemuxml2argv-graphics-vnc-tls.args | 2 +- .../qemuxml2argv-graphics-vnc.args | 2 +- .../qemuxml2argv-hostdev-pci-address.args | 2 +- .../qemuxml2argv-hostdev-usb-address.args | 2 +- .../qemuxml2argv-hostdev-usb-product.args | 2 +- .../qemuxml2argv-input-usbmouse.args | 2 +- .../qemuxml2argv-input-usbtablet.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-input-xen.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-migrate.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-minimal.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-misc-acpi.args | 2 +- .../qemuxml2argv-misc-no-reboot.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-misc-uuid.args | 2 +- .../qemuxml2argv-net-eth-ifname.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-net-eth.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-net-user.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-net-virtio.args | 2 +- .../qemuxml2argv-parallel-tcp.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-restore-v1.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-restore-v2.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-serial-dev.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-serial-file.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-serial-many.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-serial-pty.args | 2 +- .../qemuxml2argv-serial-tcp-telnet.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-serial-tcp.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-serial-udp.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-serial-unix.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-serial-vc.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-sound.args | 2 +- 65 files changed, 288 insertions(+), 183 deletions(-)

2 18

[libvirt] Virtio Disk Drivers and Windows
by Aaron Clausen 04 May '09

04 May '09

I've imported a Windows Server 2003 as a guest using the IDE drivers. When I try to use the virtio drivers instead, Windows just blue screens. Am I stuck with the IDE drivers under Windows? -- Aaron Clausen mightymartianca(a)gmail.com

1 1

[libvirt] [PATCH] Fix a comment typo in storage_backend_fs.c
by Cole Robinson 04 May '09

04 May '09

This comment hid from my attempt to 'grep FILE_BOCHS', which is the actual name of the constant. Thanks, Cole

2 2