February 2009 - Devel - libvirt List Archives

[libvirt] [PATCH] libvirt.spec patch to fix some rpmlint warnings/errors
by Richard W.M. Jones 14 Feb '09

14 Feb '09

With this patch we remove some of the easier rpmlint warnings and errors. It is by no means rpmlint clean after applying this patch, but the remaining warnings and errors can be ignored. FWIW this is for the libvirt merge review: https://bugzilla.redhat.com/show_bug.cgi?id=226055 I'm not sure about the patch to libvirt.init.in, but rpmlint is quite insistent that we need this, or else we shouldn't start libvirtd by default. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v

2 6

[libvirt] [PATCH 0/3] Fix aliasing rules warnings with gcc-4.4
by Mark McLoughlin 14 Feb '09

14 Feb '09

Hi, It seems gcc's strict aliasing rules got stricter with gcc-4.4. The basic rule is that two pointers of different types can't be used to reference the same address in memory. One exception is using a char* and another is when different types are members of a union. I've used unions to fix all the warnings I see with current CVS HEAD. I can't say I like the solution all that much, so if anyone has better ideas ... Cheers, Mark.

2 7

[libvirt] [PATCH] avoid two test failures induced by today's error-reporting changes
by Jim Meyering 14 Feb '09

14 Feb '09

I'm applying these fixes to avoid "make check" failures: >From f41517a4250db0961482e097813eb39da5bea963 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Mon, 9 Feb 2009 16:25:36 +0100 Subject: [PATCH] avoid two test failures induced by today's error-reporting changes * tests/cpuset: Adjust expected diagnostic to match new behavior. * tests/undefine: Likewise. --- tests/cpuset | 4 ++-- tests/undefine | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/cpuset b/tests/cpuset index 75303e3..eeb0ee2 100755 --- a/tests/cpuset +++ b/tests/cpuset @@ -1,7 +1,7 @@ #!/bin/sh # ensure that defining with an invalid vCPU cpuset elicits a diagnostic -# Copyright (C) 2008 Free Software Foundation, Inc. +# Copyright (C) 2008-2009 Free Software Foundation, Inc. # This program is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -36,8 +36,8 @@ sed "s/vcpu>/vcpu cpuset='aaa'>/" xml > xml-invalid || fail=1 # Require failure and a diagnostic. virsh --connect test:///default define xml-invalid > out 2>&1 && fail=1 cat <<\EOF > exp || fail=1 -libvir: Domain Config error : failed Xen syscall topology cpuset syntax error error: Failed to define domain from xml-invalid +error: failed Xen syscall topology cpuset syntax error EOF compare exp out || fail=1 diff --git a/tests/undefine b/tests/undefine index 48e8356..fafdae7 100755 --- a/tests/undefine +++ b/tests/undefine @@ -1,7 +1,7 @@ #!/bin/sh # exercise virsh's "undefine" command -# Copyright (C) 2008 Free Software Foundation, Inc. +# Copyright (C) 2008-2009 Free Software Foundation, Inc. # This program is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -29,8 +29,8 @@ fail=0 virsh -q -c test:///default undefine test > out 2>&1 test $? = 1 || fail=1 cat <<\EOF > exp || fail=1 -libvir: Test error : internal error Domain 'test' is still running error: Failed to undefine domain test +error: internal error Domain 'test' is still running EOF compare exp out || fail=1 -- 1.6.2.rc0.173.g5e148

3 2

[libvirt] Domain comment/description string?
by Jan Kasprzak 13 Feb '09

13 Feb '09

Hello, I use KVM+qemu for testing various distributions and playing with different versions of software. Now I would like to migrate my virtual machines to libvirt. One of the problems is that I would like to have some sort of comment or description of the machine, which would be displayed in "virsh list" or in virt-manager together with the machine hostname. Example: <name>rei</name> <comment>Fedora rawhide/32bit</comment> or <name>konata</name> <comment>Gentoo x86_64 with KDE 4</comment> Does the libvirt XML format support something like this? Embedding comment inside the <name>...</name> tag does not work. Does libvirt support something like that? Thanks, -Yenya -- | Jan "Yenya" Kasprzak <kas at {fi.muni.cz - work | yenya.net - private}> | | GPG: ID 1024/D3498839 Fingerprint 0D99A7FB206605D7 8B35FCDE05B18A5E | | http://www.fi.muni.cz/~kas/ Journal: http://www.fi.muni.cz/~kas/blog/ | >> If you find yourself arguing with Alan Cox, you’re _probably_ wrong. << >> --James Morris in "How and Why You Should Become a Kernel Hacker" <<

1 0

[libvirt] libvirtd and LVM snapshots
by Nick Moffitt 13 Feb '09

13 Feb '09

I'm working on an existing system that creates, manages, and destroys Xen guests on a pool of host systems, and I use LVM copy-on-write snapshots to keep creation rapid. http://libvirt.org/storage.html describes logical volume pools, for which you simply supply the name of a volume group and it allocates volumes from that. By my reading, it appears one can even provide a list of block devices and they will be carved into extents and pooled into a VG for you. Is there any interface to libvirtd that allows it to create volumes that are snapshots of existing volumes? If not, does anyone have advice for doing so manually in a way that plays smoothly with libvirt? -- Support your droogs! Nick Moffitt nick(a)zork.net

3 6

[libvirt] Getting error "libvir: QEMU error : Domain not found"
by M. Mohan Kumar 13 Feb '09

13 Feb '09

Hi, When I try to run vm-install on a OpenSuse 11.1 machine, vm-install displays the following message "libvir: QEMU error : Domain not found". How ever the functionality is not affected. I don't think its really an error. It could be just an warning/information message. Is there any plan to change this message as warning/information from error level? Note: I am not in the mailing list, so please cc me while replying. -- Regards, M. Mohan Kumar

2 2

[libvirt] [Patch] enable --checkpoint option in 'virsh save'
by Matt McCowan 12 Feb '09

12 Feb '09

Folks. I'm working on a scenario where I would like to provide my backup subsystems with a clean disk and ram state of any given VM, without necessitating shutting down the a VM. Xen's 'xm save' function with the '-c' (checkpoint) argument made sense in that I could checkpoint save the VM, take a snapshot of the LV containing the domain and its 'save' dump then resume the domain. Unfortunately out-of-the-box the Xen implementation did not pause the domain after the checkpoint, but resumed it automatically. Fastforward to using kvm ... Qemu/kvm with it's 'migrate' command by default left the domain paused after creating a state dump - just what I was looking for. A look at the libvirt code revealed that 'virsh save' carried out a migrate, then shut the domain down. So I have tried implementing a --checkpoint option into the save function using the --live option to the 'virsh migrate' function as a bit of a template. I'm a sysadmin, not a coder, so please forgive any oversights and all the other coding rules that may be broken. As mentioned before I did try to simply copy how the migrate --live option is used throughout. Patch (against 0.6.0) attached. I have also filed a feature request under bugzilla. If the additional feature is seen as warranted, please let me know what I can do to help implement it if the patch is not the way to go about it. Thankyou very much for Libvirt Regards Matt McCowan

1 0

[libvirt] [PATCH] set an error when the domain doesn't show up
by Guido Günther 12 Feb '09

12 Feb '09

Hi, attached patch makes sure we set a proper error status when the domain doesn't show up. O.k. to apply? Cheers, -- Guido

2 2

[libvirt] libvirt and the lowest common denominator
by John Levon 11 Feb '09

11 Feb '09

I wanted to bring this topic out of a patch review thread. Dan recently stated that only patches that use "upstream" facilities are acceptable, meaning the xend delivered by XenSource. I'd like to make a few points on this note: 1. I'd like to hear from the other core maintainers if they agree with this rule. 2. I'd like to hear a rationale for this rule. 3. The Sun repository *is* the upstream for xend on Solaris for a number of reasons: a. The 3.1.x series is only maintained by us, there is no other 3.1 upstream b. The XenSource upstream does not, and cannot, work on Solaris c. XenSource have no interest in xend at all and it's effectively unmaintained (with the exception of Novell I think). 4. I've seen stated a number of times that libvirt is designed to avoid becoming a lowest common denominator interface. I cannot reconcile that claim with this rule: all xend implementations must apparently be the same, and no enhancements are allowed. 5. This rule further restricts innovation in that XenSource must agree to any changes. This has a rather obvious chilling effect. The distro type/variant recording changes are a perfect example: this is essential information, and recording it in xend was pre-NAKed by XenSource a long time ago. 6. As a thought experiment: if someone re-wrote xend in C, what then? Is that upstream, or not? In case it's not clear, all of Sun's Xen changes are open source and easily available. 7. Any change that involves *incompatibility* is clearly different, and IMHO not acceptable. This is only about changes that in no way negatively affect behaviour with an upstream Linux xend. 8. I hope it's clear to everyone that I'm motivated to merge changes upstream wherever feasible. I'm not seeking some kind of get-out clause from being a responsible maintainer. 9. Practically, we will have to carry these changes in our libvirt no matter what. I'd rather not. 10. I would note that Red Hat own the upstream for the code they care about, thus this rule can only cause trouble for other people. My personal opinion, not Sun's. regards, john

3 6

[libvirt] saving virtual machine state when rebooting the server machine
by Itamar Reis Peixoto 11 Feb '09

11 Feb '09

is possible to save virtual machine state when rebooting the server machine ? https://help.ubuntu.com/8.04/serverguide/C/libvirt.html The state of virtual machines can be saved to a file in order to be restored later. The following will save the virtual machine state into a file named according to the date: virsh -c qemu:///system save web_devel web_devel-022708.state Once saved the virtual machine will no longer be running. A saved virtual machine can be restored using: virsh -c qemu:///system restore web_devel-022708.state -- ------------ Itamar Reis Peixoto e-mail/msn: itamar(a)ispbrasil.com.br sip: itamar(a)ispbrasil.com.br skype: itamarjp icq: 81053601 +55 11 4063 5033 +55 34 3221 8599

1 0