February 2008 - Devel - libvirt List Archives

Re: [Libvir] [patch 1/3] Move static function prototype from header
by Daniel Veillard 07 Feb '08

07 Feb '08

On Wed, Feb 06, 2008 at 11:07:53PM +0000, Mark McLoughlin wrote: > Fixes: > > xm_internal.h:64: error: 'xenXMDomainAttachDevice' declared 'static' but never defined > xm_internal.h:65: error: 'xenXMDomainDetachDevice' declared 'static' but never defined > > Signed-off-by: Mark McLoughlin <markmc(a)redhat.com> > > Index: libvirt/src/xm_internal.c > =================================================================== > --- libvirt.orig/src/xm_internal.c > +++ libvirt/src/xm_internal.c > @@ -77,6 +77,8 @@ static int xenXMAttachDisk(virDomainPtr > xmlNodePtr node, xenXMConfCachePtr entry); > static int xenXMAttachInterface(virDomainPtr domain, xmlXPathContextPtr ctxt, int hvm, > xmlNodePtr node, xenXMConfCachePtr entry); > +static int xenXMDomainAttachDevice(virDomainPtr domain, const char *xml); > +static int xenXMDomainDetachDevice(virDomainPtr domain, const char *xml); > > #define XM_REFRESH_INTERVAL 10 > > Index: libvirt/src/xm_internal.h > =================================================================== > --- libvirt.orig/src/xm_internal.h > +++ libvirt/src/xm_internal.h > @@ -61,9 +61,6 @@ int xenXMDomainUndefine(virDomainPtr dom > virConfPtr xenXMParseXMLToConfig(virConnectPtr conn, const char *xml); > char *xenXMDomainFormatXML(virConnectPtr conn, virConfPtr conf); > > -static int xenXMDomainAttachDevice(virDomainPtr domain, const char *xml); > -static int xenXMDomainDetachDevice(virDomainPtr domain, const char *xml); > - > #ifdef __cplusplus > } > #endif Yup noticed the warning on Tuesday, thanks for chasing it, +1 Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

1 0

[Libvir] python/libvir.c returning wrong value on error?
by Cole Robinson 07 Feb '08

07 Feb '08

Hi all, Looking at python/libvir.c, all the custom functions return VIR_PY_NONE on error. This unfortunately doesn't map well to some of the generated python bindings which expect an error val of -1. So if these commands fail, no exception will be thrown at the python level. (Ex. virDomainGetAutostart, virDomainGetVcpus and their python equiv.) I'm wondering where the fix should be: in python/libvir.c, changing these error return values, or in the generator somewhere? Thanks, Cole

3 3

[Libvir] bug in xen_unified.c
by Marcus Meissner 07 Feb '08

07 Feb '08

Hi, spotted by gcc 4.3, in libvirt 0.4.0, xen_unified.c:xenUnifiedDomainSuspend() if (priv->opened[i] && which should probably be: if (priv->opened[XEN_UNIFIED_HYPERVISOR_OFFSET] && because it is outside of the loop, and the other indices in that if (). --- src/xen_unified.c 2008/01/28 22:20:22 1.1 +++ src/xen_unified.c 2008/01/28 22:20:26 @@ -699,7 +699,7 @@ drivers[i]->domainDestroy (dom) == 0) return 0; - if (priv->opened[i] && + if (priv->opened[XEN_UNIFIED_HYPERVISOR_OFFSET] && drivers[XEN_UNIFIED_HYPERVISOR_OFFSET]->domainDestroy && drivers[XEN_UNIFIED_HYPERVISOR_OFFSET]->domainDestroy (dom) == 0) return 0; Ciao, Marcus -- Working, but not speaking, for the following german company: SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg)

3 3

[Libvir] Pthreads error in windows compilation
by Gabriel Kaufmann 07 Feb '08

07 Feb '08

Hi, I received the error In file included from libvirt.c:32: internal.h: At top level: internal.h:177: error: expected specifier-qualifier-list before 'pthread_mutex_t' In order to fix this problem, I installed the 'pthreads' package on my MinGW. Then added include pthread.h in src/internal.h Is this the right action? Best Regards, Gabriel Kaufmann Software Engineer Gabriel.Kaufmann(a)ericom.com<mailto:Gabriel.Kaufmann@ericom.com> Ericom Software Tel (Dir): +972 2 591 1700 Ext 754 Tel (Main): +972 2 591 1700 http://www.ericom.com Access Done Right Empower Enterprise-Wide Access to Microsoft(r) Terminal Server, Virtual Desktops and Legacy Applications

4 6

Re: [Libvir] [patch 0/3] Fix some gcc 4.3.0 warnings
by Jim Meyering 07 Feb '08

07 Feb '08

Mark McLoughlin <markmc(a)redhat.com> wrote: > With gcc-4.3.0 (from Fedora rawhide), some new warnings are > thrown up. > > The following three patches fixes them. The first two are > straightforward, I think, but perhaps people might prefer to remove > -Winline from our warning flags rather than apply the last patch. I have a slight preference to remove -Winline, but either way is ok.

1 0

Re: [Libvir] [patch 2/3] Fix subscript typo when calling hypervisor domainDestroy
by Jim Meyering 07 Feb '08

07 Feb '08

Mark McLoughlin <markmc(a)redhat.com> wrote: > Fixes: > > xen_unified.c: In function 'xenUnifiedDomainDestroy': > xen_unified.c:697: error: array subscript is above array bounds +1

1 0

Re: [Libvir] [patch 1/3] Move static function prototype from header
by Jim Meyering 07 Feb '08

07 Feb '08

Mark McLoughlin <markmc(a)redhat.com> wrote: > Fixes: > > xm_internal.h:64: error: 'xenXMDomainAttachDevice' declared 'static' but never defined > xm_internal.h:65: error: 'xenXMDomainDetachDevice' declared 'static' but never defined +1

1 0

Re: [Libvir] [patch 2/2] Dont crash if theres no /sys/hypervisor/capabilities
by Jim Meyering 07 Feb '08

07 Feb '08

Mark McLoughlin <markmc(a)redhat.com> wrote: > xenHypervisorMakeCapabilitiesXML() can be called with either > of it's FILE* paramaters NULL; don't crash when the capabilities > pointer is NULL. > > Signed-off-by: Mark McLoughlin <markmc(a)redhat.com> > Index: libvirt/src/xen_internal.c > =================================================================== > --- libvirt.orig/src/xen_internal.c 2008-02-06 22:38:06.000000000 +0000 > +++ libvirt/src/xen_internal.c 2008-02-06 23:38:54.000000000 +0000 > @@ -2233,7 +2233,7 @@ > */ > > /* Expecting one line in this file - ignore any more. */ > - if (fgets (line, sizeof line, capabilities)) { > + if (capabilities && fgets (line, sizeof line, capabilities)) { > /* Split the line into tokens. strtok_r is OK here because we "own" > * this buffer. Parse out the features from each token. > */ +1

1 0

[Libvir] [patch 2/2] Dont crash if theres no /sys/hypervisor/capabilities
by Mark McLoughlin 06 Feb '08

06 Feb '08

xenHypervisorMakeCapabilitiesXML() can be called with either of it's FILE* paramaters NULL; don't crash when the capabilities pointer is NULL. Signed-off-by: Mark McLoughlin <markmc(a)redhat.com> Index: libvirt/src/xen_internal.c =================================================================== --- libvirt.orig/src/xen_internal.c 2008-02-06 22:38:06.000000000 +0000 +++ libvirt/src/xen_internal.c 2008-02-06 23:38:54.000000000 +0000 @@ -2233,7 +2233,7 @@ */ /* Expecting one line in this file - ignore any more. */ - if (fgets (line, sizeof line, capabilities)) { + if (capabilities && fgets (line, sizeof line, capabilities)) { /* Split the line into tokens. strtok_r is OK here because we "own" * this buffer. Parse out the features from each token. */ --

1 0

[Libvir] [patch 1/2] Create directory for saving iptables rules
by Mark McLoughlin 06 Feb '08

06 Feb '08

The patch which reworked the iptables rules saving accidently dropped the call to virFileMakePath() resulting in: Failed to saves iptables rules to /var/lib/libvirt/iptables/filter/INPUT.chain : No such file or directory Re-instate the virFileMakePath() call. Signed-off-by: Mark McLoughlin <markmc(a)redhat.com> Index: libvirt/src/iptables.c =================================================================== --- libvirt.orig/src/iptables.c 2008-02-06 23:14:28.000000000 +0000 +++ libvirt/src/iptables.c 2008-02-06 23:15:33.000000000 +0000 @@ -238,6 +238,12 @@ #ifdef ENABLE_IPTABLES_LOKKIT int err; + if ((err = virFileMakePath(rules->dir))) { + qemudLog(QEMUD_WARN "Failed to create directory %s : %s", + rules->dir, strerror(err)); + return; + } + if ((err = writeRules(rules->path, rules->rules, rules->nrules))) { qemudLog(QEMUD_WARN, "Failed to saves iptables rules to %s : %s", rules->path, strerror(err)); --

1 0