January 2008 - Devel - libvirt List Archives

[Libvir] Re: libvirt on mingw
by Richard W.M. Jones 02 Jul '08

02 Jul '08

Brecht Sanders wrote: > Hi, > I saw on the following link: > http://www.mail-archive.com/libvir-list@redhat.com/msg04103.html > that you are also trying to compile libvirt on win32. > I'm also attempting to do this, and I guess I got stuck at the same > point your post was about. > Have you in the mean time found an XDR implementation that compiles on > MinGW and that implements xdr_u_quad_t? > If you did, can you please tell me where to find it? You'll find the answer to this question and more if you look through the libvir-list archives for the current month: https://www.redhat.com/archives/libvir-list/2008-January/thread.html Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

3 12

[Libvir] [PATCH] Fix USB device name mis-conversion from S-Expr to XML
by Hiroyuki Kaguchi 23 Jun '08

23 Jun '08

"tablet" and "mouse" are set as a value of the /local/domain/<domid>/image/hvm/usbdevice, but libvirt expects "usbdevice" and "usbmouse" as a value. This causes the following. If a USB device is attached by virt-manager, the USB device is not seen from virt-manager. This patch fixes expected value of libvirt Thanks, Hiroyuki Kaguchi Index: xend_internal.c =================================================================== RCS file: /data/cvs/libvirt/src/xend_internal.c,v retrieving revision 1.162 diff -u -r1.162 xend_internal.c --- xend_internal.c 21 Jan 2008 16:29:10 -0000 1.162 +++ xend_internal.c 23 Jan 2008 00:37:02 -0000 @@ -1743,11 +1743,9 @@ node = cur->u.s.car; if (sexpr_lookup(node, "usbdevice")) { tmp = sexpr_node(node, "usbdevice"); - if (tmp && *tmp) { - if (!strcmp(tmp, "usbtablet")) - virBufferAdd(&buf, " <input type='tablet' bus='usb'/>\n", 37); - else if (!strcmp(tmp, "usbmouse")) - virBufferAdd(&buf, " <input type='mouse' bus='usb'/>\n", 36); + if (!strcmp(tmp, "tablet") || + !strcmp(tmp, "mouse")) { + virBufferVSprintf(&buf, " <input type='%s' bus='usb'/>\n", tmp); } } }

3 4

[Libvir] java-libvirt on cvs:libvirt.org
by Daniel Schwager 15 Mar '08

15 Mar '08

Hallo list, i took the java-libvirt port from Tóth István (Thank you - great work !!) and added - the some features from libvirt 0.4.0 - integrate of xsd XML-description / validator - added auto generation of XML-beans related to the XSD file. - project build.xml file - integration of testng - remote building of JNI library - remote testing of junit/testing tests So, I want to publish to port to a public cvs-tree. Is there a little space on the libvirt website for this port ? regards Danny

4 3

[Libvir] RFC: Supporting serial & parallel ports for QEMU (and improving Xen)
by Daniel P. Berrange 26 Feb '08

26 Feb '08

One user's feature request for our QEMU driver is to support serial ports. Easy you might think... you'd be wrong :-) On Xen we have very simple approach. When creating a guest simply add <console/> And it'll cause a serial port to be setup with an autoallocated pty, so you get back <console pty='/dev/pts/5'/> In retrospect calling it 'console' was dumb, but hey we're stuck with that now and its only a tiny naming issue so I don't mind really. We can do the same thing with QEMU quite easily. QEMU, however, supports many many many more ways to hooking up the serial port to Dom0. Indeed so does Xen fullyvirt, but we don't expose this ability. Parallel ports have identical config syntax to serial ports so we might as well deal with both at once. So, here's a stripped down version of the QEMU docs: [quote http://fabrice.bellard.free.fr/qemu/qemu-doc.html#SEC10] `-serial dev' Redirect the virtual serial port to host character device dev. The default device is vc in graphical mode and stdio in non graphical mode. This option can be used several times to simulate up to 4 serials ports. Use -serial none to disable all serial ports. Available character devices are: vc Virtual console pty [Linux only] Pseudo TTY (a new PTY is automatically allocated) none No device is allocated. null void device /dev/XXX [Linux only] Use host tty, e.g. `/dev/ttyS0'. The host serial port parameters are set according to the emulated ones. /dev/parportN [Linux only, parallel port only] Use host parallel port N. Currently only SPP parallel port features can be used. file:filename Write output to filename. No character can be read. stdio [Unix only] standard input/output pipe:filename name pipe filename COMn [Windows only] Use host serial port n udp:[remote_host]:remote_port[@[src_ip]:src_port] This implements UDP Net Console. tcp:[host]:port[,server][,nowait][,nodelay] The TCP Net Console has two modes of operation. telnet:host:port[,server][,nowait][,nodelay] The telnet protocol is used instead of raw tcp sockets. unix:path[,server][,nowait] A unix domain socket is used instead of a tcp socket. [/quote] I don't see any reason to not support all/most of these options. The things I don't like here is that /dev/XXX, vs /dev/parportN, vs COMn differences for connecting guest <-> host passthrough of the devices. I figure it could be simpler if it was just represented as 'n' and we'd translate that to be /dev/ttyS[n] or /dev/parport[n] or COM[n] as needed. The question as ever is how to represent this in XML. For serial ports we'll stick with '<console>', while parallel ports we might as well use a better named '<parallel>'. Next up, I think should use a 'type' attribute on this element to determine the main way ot connecting the device, and then more type specific attributes or sub-elements as needed. If 'type' was not specified then use a default of 'pty', since that gives compatability with existing practice. As an illustrative example /* * Parse the XML definition for a character device * * Top level node will be <console> or <parallel>, but all attributes * and sub-elements are identical. * * type=vc|pty|null|host|file|pipe|udp|tcp|telnet, default is pty * * <console type='vc'/> * * <console type='pty' pty='/dev/pts/3'/> * * <console type='null'/> * * <console type='host' port='3'/> * * <console type='file' path='/some/file'/> * * <console type='pipe' path='/some/file'/> * * <console type='udp'> * <sendto port='12356'/> * </console> * * <console type='udp'> * <sendto addr='127.0.0.1' port='12356'/> * </console> * * <console type='udp'> * <sendto addr='127.0.0.1' port='12356'/> * <bind port='12356'/> * </console> * * <console type='udp'> * <sendto addr='127.0.0.1' port='12356'/> * <bind addr='127.0.0.1' port='12356'/> * </console> * * <console type='tcp'> * <listen port='12356'/> * </console> * * <console type='tcp'> * <listen addr='127.0.0.1' port='12356'> * <nowait/> * <nodelay/> * </listen> * </console> * * <console type='tcp'> * <connect addr='127.0.0.1' port='12356'> * <nodelay/> * </connect> * </console> * * <console type='telnet'> * <listen addr='127.0.0.1' port='12356'/> * </console> * * <console type='telnet'> * <connect addr='127.0.0.1' port='12356'/> * </console> * */ BTW, the udp, tcp, telnet options are only available on QEMU >= 0.9.0. We already have ability to detect / validate that for both Xen & QEMU drivers. NB, whereever there are IP addresses, hostnames can be used too, hence I call the attriute 'addr' instead of 'ip' Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

5 8

[Libvir] [PATCH] Fix the function that remove the element of the hash table.
by Hiroyuki Kaguchi 08 Feb '08

08 Feb '08

There are two logic error and a unnecessary else-statement in virHashRemoveSet function. This patch fix the following. (1/3) The logic error that use released memory area. (2/3) The logic error that doesn't remove elements. (3/3) Unnecessary else-statement. (1/3) The logic error that use released memory area. This bug causes the crash of virt-manager or virsh. If "virsh undefine" command is executed, "Segmentation Fault" is caused. The result of executing "valgrind virsh" command is: virsh # list --all ==3337== Invalid read of size 4 ==3337== at 0x4016A21: virHashRemoveSet (hash.c:562) ==3337== by 0x403ACF4: xenXMConfigCacheRefresh (xm_internal.c:458) ==3337== by 0x4040D58: xenXMNumOfDefinedDomains (xm_internal.c:2518) ==3337== by 0x40245C3: xenUnifiedNumOfDefinedDomains (xen_unified.c:1004) ==3337== by 0x4013730: virConnectNumOfDefinedDomains (libvirt.c:2446) ==3337== by 0x804AE81: cmdList (virsh.c:577) ==3337== by 0x8052E6E: vshCommandRun (virsh.c:4052) ==3337== by 0x8054E2D: main (virsh.c:5036) ==3337== Address 0x4282AB8 is 0 bytes inside a block of size 16 free'd ==3337== at 0x4004FDA: free (vg_replace_malloc.c:233) ==3337== by 0x40169A0: virHashRemoveSet (hash.c:545) ==3337== by 0x403ACF4: xenXMConfigCacheRefresh (xm_internal.c:458) ==3337== by 0x4040D58: xenXMNumOfDefinedDomains (xm_internal.c:2518) ==3337== by 0x40245C3: xenUnifiedNumOfDefinedDomains (xen_unified.c:1004) ==3337== by 0x4013730: virConnectNumOfDefinedDomains (libvirt.c:2446) ==3337== by 0x804AE81: cmdList (virsh.c:577) ==3337== by 0x8052E6E: vshCommandRun (virsh.c:4052) ==3337== by 0x8054E2D: main (virsh.c:5036) The current removing logic is: 1. search for node that be removed in the hash table. The removing cursor(pointer) point to "element-B". +-hash table---+ | +----------+ | +----------+ +----------+ | |element-A |-|-->|element-B |-->|element-C | | +----------+ | +----------+ +----------+ | |element-D | | | +----------+ | | . | | . | +--------------+ 2. free "element-B". The removing cursor point to invalid address +-hash table---+ | +----------+ | +----------+ | |element-A |-|-->|element-C | | +----------+ | +----------+ | |element-D | | | +----------+ | | . | | . | +--------------+ 3. try to move the removing cursor to next node. At this time, the error occurs. (2/3) The logic error that doesn't remove elements. The current removing logic is: 1. search for node that will be removed in the hash table. The removing cursor point to "element-A". +-hash table---+ | +----------+ | +----------+ +----------+ | |element-A |-|-->|element-B |-->|element-C | | +----------+ | +----------+ +----------+ | |element-D | | | +----------+ | | . | | . | +--------------+ 2. copy "element-B" to "element-A". +-hash table---+ | +----------+ | +----------+ +----------+ | |element-B'|-|-->|element-B |-->|element-C | | +----------+ | +----------+ +----------+ | |element-D | | | +----------+ | | . | | . | +--------------+ 3. remove "element-B" The removing cursor point to "element-D". "element-C" is skipped. +-hash table---+ | +----------+ | +----------+ | |element-B'|-|-->|element-C | | +----------+ | +----------+ | |element-D | | | +----------+ | | . | | . | +--------------+ (3/3) Unnecessary else-statement. There is else-statement that set NULL to the NULL pointer. Thanks, Hiroyuki Kaguchi Index: hash.c =================================================================== RCS file: /data/cvs/libvirt/src/hash.c,v retrieving revision 1.27 diff -u -r1.27 hash.c --- hash.c 21 Jan 2008 16:29:10 -0000 1.27 +++ hash.c 28 Jan 2008 06:48:09 -0000 @@ -543,6 +543,7 @@ if (prev) { prev->next = entry->next; free(entry); + entry = prev; } else { if (entry->next == NULL) { entry->valid = 0; @@ -553,6 +554,7 @@ sizeof(virHashEntry)); free(entry); entry = NULL; + i--; } } table->nbElems--; @@ -560,8 +562,6 @@ prev = entry; if (entry) { entry = entry->next; - } else { - entry = NULL; } } }

4 6

[Libvir] bug in xen_unified.c
by Marcus Meissner 07 Feb '08

07 Feb '08

Hi, spotted by gcc 4.3, in libvirt 0.4.0, xen_unified.c:xenUnifiedDomainSuspend() if (priv->opened[i] && which should probably be: if (priv->opened[XEN_UNIFIED_HYPERVISOR_OFFSET] && because it is outside of the loop, and the other indices in that if (). --- src/xen_unified.c 2008/01/28 22:20:22 1.1 +++ src/xen_unified.c 2008/01/28 22:20:26 @@ -699,7 +699,7 @@ drivers[i]->domainDestroy (dom) == 0) return 0; - if (priv->opened[i] && + if (priv->opened[XEN_UNIFIED_HYPERVISOR_OFFSET] && drivers[XEN_UNIFIED_HYPERVISOR_OFFSET]->domainDestroy && drivers[XEN_UNIFIED_HYPERVISOR_OFFSET]->domainDestroy (dom) == 0) return 0; Ciao, Marcus -- Working, but not speaking, for the following german company: SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg)

3 3

[Libvir] Pthreads error in windows compilation
by Gabriel Kaufmann 07 Feb '08

07 Feb '08

Hi, I received the error In file included from libvirt.c:32: internal.h: At top level: internal.h:177: error: expected specifier-qualifier-list before 'pthread_mutex_t' In order to fix this problem, I installed the 'pthreads' package on my MinGW. Then added include pthread.h in src/internal.h Is this the right action? Best Regards, Gabriel Kaufmann Software Engineer Gabriel.Kaufmann(a)ericom.com<mailto:Gabriel.Kaufmann@ericom.com> Ericom Software Tel (Dir): +972 2 591 1700 Ext 754 Tel (Main): +972 2 591 1700 http://www.ericom.com Access Done Right Empower Enterprise-Wide Access to Microsoft(r) Terminal Server, Virtual Desktops and Legacy Applications

4 6

[Libvir] [PATCH] change a Disk/Nic of inactive domain
by S.Sakamoto 07 Feb '08

07 Feb '08

Hi The libvirt on Xen-3.03 does not have the function that add/change/delete a Disk/NIC of inactive domain. So, I made a patch which enabled add/change/delete of Disk/NIC of inactive domain. This patch will be able to change "disk" or "vif" parameter in configuration file with "attach-disk","attach-interface", "attach-device", "detach-disk", "detach-interface" and "detach-device" command, like "setmem" or "setvcpus". Thanks, Shigeki Sakamoto.

5 9

[Libvir] virsh vncdisplay fix
by John Levon 04 Feb '08

04 Feb '08

I have an old HVM guest defined in 3.0.4, and now I'm running 3.1.2 and libvirt 0.4.0. The config looks like this: (domain (image (hvm (vnc 1) (vncdisplay 0) (device (vfb (location localhost:5900) (vncdisplay 0) (uuid ...) The libvirt code looks like this: 1757 /* Graphics device (HVM <= 3.0.4, or PV <= 3.0.3) vnc config */ 1758 if ((hvm && xendConfigVersion < 4) || 1759 (!hvm && xendConfigVersion < 3)) { 1760 tmp = sexpr_fmt_node(root, "domain/image/%s/vnc", hvm ? "hvm" : "linux"); So we don't see the 'vnc 1' at the top. But the code to parse device/vfb doesn't expect this config either: 1685 tmp = sexpr_node(node, "device/vfb/type"); The patch below replaces the later version check with something that copes correctly with the "upgrade" case. regards john 2008-01-15 John Levon <levon(a)movementarian.org> * src/xend_internal.c: fix VNC parsing of old Xen domains on newer Xen versions. diff -prauN libvirt-0.4.0/src/xend_internal.c libvirt-new/src/xend_internal.c --- libvirt-0.4.0/src/xend_internal.c 2007-12-17 15:05:27.000000000 -0800 +++ libvirt-new/src/xend_internal.c 2008-01-14 18:42:08.895060570 -0800 @@ -1371,6 +1371,7 @@ xend_parse_sexp_desc(virConnectPtr conn, unsigned char uuid[VIR_UUID_BUFLEN]; char uuidstr[VIR_UUID_STRING_BUFLEN]; int vif_index = 0; + int found_graphics = 0; if (root == NULL) { /* ERROR */ @@ -1683,6 +1684,7 @@ xend_parse_sexp_desc(virConnectPtr conn, if (tmp && !strcmp(tmp, "sdl")) { virBufferVSprintf(&buf, " <input type='mouse' bus='%s'/>\n", hvm ? "ps2": "xen"); virBufferAdd(&buf, " <graphics type='sdl'/>\n", 27); + found_graphics = 1; } else if (tmp && !strcmp(tmp, "vnc")) { int port = xenStoreDomainGetVNCPort(conn, domid); const char *listenAddr = sexpr_node(node, "device/vfb/vnclisten"); @@ -1700,6 +1702,7 @@ xend_parse_sexp_desc(virConnectPtr conn, if (keymap) virBufferVSprintf(&buf, " keymap='%s'", keymap); virBufferAdd(&buf, "/>\n", 3); + found_graphics = 1; } } } @@ -1751,8 +1754,7 @@ xend_parse_sexp_desc(virConnectPtr conn, } /* Graphics device (HVM <= 3.0.4, or PV <= 3.0.3) vnc config */ - if ((hvm && xendConfigVersion < 4) || - (!hvm && xendConfigVersion < 3)) { + if (!found_graphics) { tmp = sexpr_fmt_node(root, "domain/image/%s/vnc", hvm ? "hvm" : "linux"); if (tmp != NULL) { if (tmp[0] == '1') { @@ -1780,6 +1782,7 @@ xend_parse_sexp_desc(virConnectPtr conn, if (keymap) virBufferVSprintf(&buf, " keymap='%s'", keymap); virBufferAdd(&buf, "/>\n", 3); + found_graphics = 1; } } @@ -1789,6 +1792,7 @@ xend_parse_sexp_desc(virConnectPtr conn, if (tmp[0] == '1') { virBufferVSprintf(&buf, " <input type='mouse' bus='%s'/>\n", hvm ? "ps2" : "xen"); virBufferAdd(&buf, " <graphics type='sdl'/>\n", 27 ); + found_graphics = 1; } } }

2 5

[Libvir] [PATCH] Pull vc-list-files from gnulib, and update.
by Jim Meyering 02 Feb '08

02 Feb '08

Now that I've added the vc-list-files script to gnulib, this patch makes libvirt's bootstrap pull it from there. Changes from the previous version of the script: I reintroduced support for mercurial (only lightly tested), and rearranged the directory-existence tests so git is first. Here's the full patch, including a renaming in vasnprintf.c: ---------------- Pull vc-list-files from gnulib, and update. * bootstrap (gnulib_tool): Add the vc-list-files module. --- bootstrap | 3 ++- build-aux/vc-list-files | 19 +++++++++++++------ gnulib/lib/Makefile.am | 9 ++++++++- gnulib/lib/vasnprintf.c | 18 ++++++++++-------- gnulib/m4/gnulib-cache.m4 | 4 ++-- gnulib/m4/gnulib-comp.m4 | 1 + 6 files changed, 36 insertions(+), 18 deletions(-) diff --git a/bootstrap b/bootstrap index 751b244..1627086 100755 --- a/bootstrap +++ b/bootstrap @@ -77,7 +77,8 @@ $gnulib_tool \ --tests-base=gnulib/tests \ --import physmem getaddrinfo \ sys_stat vasprintf strndup \ - strsep poll gettext getpass + strsep poll gettext getpass \ + vc-list-files rm -f \ .gitignore \ diff --git a/build-aux/vc-list-files b/build-aux/vc-list-files index 72a6f54..1e158bb 100755 --- a/build-aux/vc-list-files +++ b/build-aux/vc-list-files @@ -1,7 +1,7 @@ #!/bin/sh -# List the specified version-controlled files. +# List version-controlled file names. -# Copyright (C) 2006, 2007 Free Software Foundation, Inc. +# Copyright (C) 2006-2008 Free Software Foundation, Inc. # This program is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -18,7 +18,8 @@ # List the specified version-controlled files. -# With no argument, list them all. +# With no argument, list them all. With a single DIRECTORY argument, +# list the version-controlled files in that directory. # This script must be run solely from the top of a $srcdir build directory. # If there's an argument, it must be a single, "."-relative directory name. @@ -28,12 +29,17 @@ dir= case $# in 0) ;; 1) dir=$1 ;; - *) echo "$0: too many arguments" 1>&2; exit 1 ;; + *) echo "$0: too many arguments" 1>&2 + echo "Usage: $0 [DIR]" 1>&2; exit 1;; esac test "x$dir" = x && dir=. -if test -d CVS; then +if test -d .git; then + exec git ls-files "$dir" +elif test -d .hg; then + exec hg locate "$dir/*" +elif test -d CVS; then if test -x build-aux/cvsu; then build-aux/cvsu --find --types=AFGM "$dir" else @@ -46,5 +52,6 @@ if test -d CVS; then $(find ${*-*} -name Entries -print) /dev/null; fi else - git-ls-files "$dir" + echo "$0: Failed to determine type of version control used in "`pwd` 1>&2 + exit 1 fi diff --git a/gnulib/lib/Makefile.am b/gnulib/lib/Makefile.am index 64fc398..8f545ca 100644 --- a/gnulib/lib/Makefile.am +++ b/gnulib/lib/Makefile.am @@ -9,7 +9,7 @@ # the same distribution terms as the rest of that program. # # Generated by gnulib-tool. -# Reproduce by: gnulib-tool --import --dir=. --lib=libgnu --source-base=gnulib/lib --m4-base=gnulib/m4 --doc-base=doc --aux-dir=build-aux --with-tests --lgpl=2 --libtool --macro-prefix=gl getaddrinfo getpass gettext physmem poll strndup strsep sys_stat vasprintf +# Reproduce by: gnulib-tool --import --dir=. --lib=libgnu --source-base=gnulib/lib --m4-base=gnulib/m4 --doc-base=doc --aux-dir=build-aux --with-tests --lgpl=2 --libtool --macro-prefix=gl getaddrinfo getpass gettext physmem poll strndup strsep sys_stat vasprintf vc-list-files AUTOMAKE_OPTIONS = 1.5 gnits @@ -719,6 +719,13 @@ EXTRA_libgnu_la_SOURCES += asprintf.c vasprintf.c ## end gnulib module vasprintf +## begin gnulib module vc-list-files + + +EXTRA_DIST += $(top_srcdir)/build-aux/vc-list-files + +## end gnulib module vc-list-files + ## begin gnulib module wchar BUILT_SOURCES += $(WCHAR_H) diff --git a/gnulib/lib/vasnprintf.c b/gnulib/lib/vasnprintf.c index 6c8d5dc..205a9bf 100644 --- a/gnulib/lib/vasnprintf.c +++ b/gnulib/lib/vasnprintf.c @@ -1,5 +1,5 @@ /* vsprintf with automatic memory allocation. - Copyright (C) 1999, 2002-2007 Free Software Foundation, Inc. + Copyright (C) 1999, 2002-2008 Free Software Foundation, Inc. This program is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by @@ -95,7 +95,7 @@ #if (NEED_PRINTF_DOUBLE || NEED_PRINTF_INFINITE_DOUBLE) && !defined IN_LIBINTL # include <math.h> -# include "isnan.h" +# include "isnand.h" #endif #if (NEED_PRINTF_LONG_DOUBLE || NEED_PRINTF_INFINITE_LONG_DOUBLE) && !defined IN_LIBINTL @@ -106,7 +106,7 @@ #if (NEED_PRINTF_DIRECTIVE_A || NEED_PRINTF_DOUBLE) && !defined IN_LIBINTL # include <math.h> -# include "isnan.h" +# include "isnand.h" # include "printf-frexp.h" #endif @@ -236,7 +236,7 @@ decimal_point_char () static int is_infinite_or_zero (double x) { - return isnan (x) || x + x == x; + return isnand (x) || x + x == x; } #endif @@ -2327,7 +2327,7 @@ VASNPRINTF (DCHAR_T *resultbuf, size_t *lengthp, # if NEED_PRINTF_DIRECTIVE_A || NEED_PRINTF_DOUBLE double arg = a.arg[dp->arg_index].a.a_double; - if (isnan (arg)) + if (isnand (arg)) { if (dp->conversion == 'A') { @@ -2676,7 +2676,7 @@ VASNPRINTF (DCHAR_T *resultbuf, size_t *lengthp, if (dp->conversion == 'f' || dp->conversion == 'F') { double arg = a.arg[dp->arg_index].a.a_double; - if (!(isnan (arg) || arg + arg == arg)) + if (!(isnand (arg) || arg + arg == arg)) { /* arg is finite and nonzero. */ int exponent = floorlog10 (arg < 0 ? -arg : arg); @@ -3080,7 +3080,7 @@ VASNPRINTF (DCHAR_T *resultbuf, size_t *lengthp, { double arg = a.arg[dp->arg_index].a.a_double; - if (isnan (arg)) + if (isnand (arg)) { if (dp->conversion >= 'A' && dp->conversion <= 'Z') { @@ -4327,7 +4327,7 @@ VASNPRINTF (DCHAR_T *resultbuf, size_t *lengthp, if (prec_ourselves) { /* Handle the precision. */ - TCHAR_T *prec_ptr = + TCHAR_T *prec_ptr = # if USE_SNPRINTF (TCHAR_T *) (result + length); # else @@ -4654,6 +4654,7 @@ VASNPRINTF (DCHAR_T *resultbuf, size_t *lengthp, not have this limitation. */ return result; +#if USE_SNPRINTF overflow: if (!(result == resultbuf || result == NULL)) free (result); @@ -4662,6 +4663,7 @@ VASNPRINTF (DCHAR_T *resultbuf, size_t *lengthp, CLEANUP (); errno = EOVERFLOW; return NULL; +#endif out_of_memory: if (!(result == resultbuf || result == NULL)) diff --git a/gnulib/m4/gnulib-cache.m4 b/gnulib/m4/gnulib-cache.m4 index d55e07a..357f170 100644 --- a/gnulib/m4/gnulib-cache.m4 +++ b/gnulib/m4/gnulib-cache.m4 @@ -15,11 +15,11 @@ # Specification in the form of a command-line invocation: -# gnulib-tool --import --dir=. --lib=libgnu --source-base=gnulib/lib --m4-base=gnulib/m4 --doc-base=doc --aux-dir=build-aux --with-tests --lgpl=2 --libtool --macro-prefix=gl getaddrinfo getpass gettext physmem poll strndup strsep sys_stat vasprintf +# gnulib-tool --import --dir=. --lib=libgnu --source-base=gnulib/lib --m4-base=gnulib/m4 --doc-base=doc --aux-dir=build-aux --with-tests --lgpl=2 --libtool --macro-prefix=gl getaddrinfo getpass gettext physmem poll strndup strsep sys_stat vasprintf vc-list-files # Specification in the form of a few gnulib-tool.m4 macro invocations: gl_LOCAL_DIR([]) -gl_MODULES([getaddrinfo getpass gettext physmem poll strndup strsep sys_stat vasprintf]) +gl_MODULES([getaddrinfo getpass gettext physmem poll strndup strsep sys_stat vasprintf vc-list-files]) gl_AVOID([]) gl_SOURCE_BASE([gnulib/lib]) gl_M4_BASE([gnulib/m4]) diff --git a/gnulib/m4/gnulib-comp.m4 b/gnulib/m4/gnulib-comp.m4 index 1b91a1e..8896a38 100644 --- a/gnulib/m4/gnulib-comp.m4 +++ b/gnulib/m4/gnulib-comp.m4 @@ -225,6 +225,7 @@ AC_DEFUN([gltests_LIBSOURCES], [ AC_DEFUN([gl_FILE_LIST], [ build-aux/config.rpath build-aux/link-warning.h + build-aux/vc-list-files lib/alloca.in.h lib/asnprintf.c lib/asprintf.c -- 1.5.4.rc5.1.g0fa73

3 4