I have just tagged v10.8.0-rc2 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue is more visible. If you have not done so yet, please update NEWS.rst to document any significant change you made since the last release. Thanks, Jirka

On 9/30/24 9:40 AM, Laine Stump wrote: FYI, the patch has been posted, gitlab CI has passed, and I've tested that both the original bug is still fixed, and the regression is also fixed. (there is still a corner case that doesn't work, but that also didn't work prior to any of these patches). If anyone agrees that this is safe enough to push and it's already past 10PM EST on Monday, please add the Reviewed-by: and push it for me, as I probably won't be awake before jdenemar cuts the release. I tried this and while "git revert" does work with only a trivial merge conflict, the revert is a much bigger change than the new patch I posted, and hasn't been tested. I think if the new patch I posted isn't pushed before release, then (2) is the safest course of action.