4:38 p.m.
It seems that raising of error messages associated with creation of
storage volumes contained copy'n'paste errors due to the code being
copied from network creation code.
Signed-off-by: Adam Spiers <aspiers(a)suse.com>
---
ext/libvirt/storage.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ext/libvirt/storage.c b/ext/libvirt/storage.c
index a01edbc..1703aaf 100644
--- a/ext/libvirt/storage.c
+++ b/ext/libvirt/storage.c
@@ -498,7 +498,7 @@ static VALUE libvirt_storage_pool_create_volume_xml(int argc, VALUE
*argv,
vol = virStorageVolCreateXML(pool_get(p), StringValueCStr(xml),
ruby_libvirt_value_to_uint(flags));
- ruby_libvirt_raise_error_if(vol == NULL, e_Error, "virNetworkCreateXML",
+ ruby_libvirt_raise_error_if(vol == NULL, e_Error,
"virStorageVolCreateXML",
ruby_libvirt_connect_get(p));
return vol_new(vol, ruby_libvirt_conn_attr(p));
@@ -525,7 +525,7 @@ static VALUE libvirt_storage_pool_create_volume_xml_from(int argc,
VALUE *argv,
vol_get(cloneval),
ruby_libvirt_value_to_uint(flags));
ruby_libvirt_raise_error_if(vol == NULL, e_Error,
- "virNetworkCreateXMLFrom",
+ "virStorageVolCreateXMLFrom",
ruby_libvirt_connect_get(p));
return vol_new(vol, ruby_libvirt_conn_attr(p));
--
2.1.2.330.g565301e
4:49 p.m.
Adam Spiers <aspiers(a)suse.com> wrote:
It seems that raising of error messages associated with creation of
storage volumes contained copy'n'paste errors due to the code being
copied from network creation code.
Signed-off-by: Adam Spiers <aspiers(a)suse.com>
---
ext/libvirt/storage.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[snipped]
Sorry, I forgot to say that this patch is for the ruby-libvirt tree.
I'm a total newbie to libvirt development, so apologies if I was
supposed to send this elsewhere.
5:32 p.m.
New subject: [libvirt] [libvirt-ruby] [PATCH] fix storage volume creation error messages
On 10/16/2014 03:49 PM, Adam Spiers wrote:
Adam Spiers <aspiers(a)suse.com> wrote:
> It seems that raising of error messages associated with creation of
> storage volumes contained copy'n'paste errors due to the code being
> copied from network creation code.
>
> Signed-off-by: Adam Spiers <aspiers(a)suse.com>
> ---
> ext/libvirt/storage.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
[snipped]
Sorry, I forgot to say that this patch is for the ruby-libvirt tree.
I'm a total newbie to libvirt development, so apologies if I was
supposed to send this elsewhere.
This is the right place, but it might get more attention from the right
people if you do 'git config format.subjectprefix "ruby PATCH"'.
Sadly,
I'm not a ruby user myself, so I won't be reviewing the patch.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
5:59 p.m.
New subject: [libvirt] [libvirt-ruby] [PATCH] fix storage volume creation error messages
Eric Blake <eblake(a)redhat.com> wrote:
On 10/16/2014 03:49 PM, Adam Spiers wrote:
> Adam Spiers <aspiers(a)suse.com> wrote:
>> It seems that raising of error messages associated with creation of
>> storage volumes contained copy'n'paste errors due to the code being
>> copied from network creation code.
>>
>> Signed-off-by: Adam Spiers <aspiers(a)suse.com>
>> ---
>> ext/libvirt/storage.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> [snipped]
>
> Sorry, I forgot to say that this patch is for the ruby-libvirt tree.
> I'm a total newbie to libvirt development, so apologies if I was
> supposed to send this elsewhere.
This is the right place, but it might get more attention from the right
people if you do 'git config format.subjectprefix "ruby PATCH"'.
OK thanks for the tip Eric - I've applied that setting for any future
submissions!
6:20 p.m.
New subject: [libvirt] [libvirt-ruby] [PATCH] fix storage volume creation error messages
Hi there,
On Thu, Oct 16, 2014 at 6:59 PM, Adam Spiers <aspiers(a)suse.com> wrote:
> > Sorry, I forgot to say that this patch is for the
ruby-libvirt tree.
> > I'm a total newbie to libvirt development, so apologies if I was
> > supposed to send this elsewhere.
>
> This is the right place, but it might get more attention from the right
> people if you do 'git config format.subjectprefix "ruby PATCH"'.
OK thanks for the tip Eric - I've applied that setting for any future
submissions!
Yep, exactly as Eric says; I'm the maintainer of ruby-libvirt, and
lurk here on the libvirt list. But I usually only look at things
specifically mentioning ruby-libvirt, so putting that in the subject
is helpful in the future.
In any case, you are right, and this was a silly copy-n-paste error.
I've now applied your patch; thanks!
Chris
3721
days inactive
3721
days old
4 comments
3 participants
participants (3)
-
Adam Spiers -
Chris Lalancette -
Eric Blake