5:46 p.m.
Inspired by Jan's comment from another review
https://www.redhat.com/archives/libvir-list/2016-March/msg00570.html
Jim Fehlig (2):
tests: add xlconfigdata to domainschematests
tests: add schema test for default cache mode
tests/domainschemadata/default-cache-mode.xml | 26 ++++++++++++++++++++++++++
tests/domainschematest | 1 +
2 files changed, 27 insertions(+)
create mode 100644 tests/domainschemadata/default-cache-mode.xml
--
2.1.4
5:46 p.m.
New subject: [libvirt] [PATCH 1/2] tests: add xlconfigdata to domainschematests
Include the XML files under tests/xlconfigdata in the domain
schema tests
Signed-off-by: Jim Fehlig <jfehlig(a)suse.com>
---
tests/domainschematest | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/domainschematest b/tests/domainschematest
index 68f7882..3271a28 100755
--- a/tests/domainschematest
+++ b/tests/domainschematest
@@ -9,6 +9,7 @@ DIRS="$DIRS domainschemadata qemuargv2xmldata qemuxml2argvdata
sexpr2xmldata"
DIRS="$DIRS xmconfigdata xml2sexprdata qemuxml2xmloutdata"
DIRS="$DIRS lxcxml2xmldata lxcxml2xmloutdata"
DIRS="$DIRS bhyvexml2argvdata genericxml2xmlindata genericxml2xmloutdata"
+DIRS="$DIRS xlconfigdata"
SCHEMA="domain.rng"
check_schema "$DIRS" "$SCHEMA"
--
2.1.4
5:46 p.m.
New subject: [libvirt] [PATCH 2/2] tests: add schema test for default cache mode
None of the existing domXML configs under tests/* specify a
default cache mode since default generally means "use the
hypervisor default" and is left unset by the various hypervisor
drivers. Add a config to tests/domainschemadata that specifies
cache='default'.
Signed-off-by: Jim Fehlig <jfehlig(a)suse.com>
---
tests/domainschemadata/default-cache-mode.xml | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/tests/domainschemadata/default-cache-mode.xml
b/tests/domainschemadata/default-cache-mode.xml
new file mode 100644
index 0000000..9880cda
--- /dev/null
+++ b/tests/domainschemadata/default-cache-mode.xml
@@ -0,0 +1,26 @@
+<domain type='qemu'>
+ <name>QEMUGuest1</name>
+ <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
+ <memory unit='KiB'>219200</memory>
+ <currentMemory unit='KiB'>219200</currentMemory>
+ <vcpu>1</vcpu>
+ <os>
+ <type arch='i686' machine='pc'>hvm</type>
+ <boot dev='hd'/>
+ </os>
+ <clock offset='utc'/>
+ <on_poweroff>destroy</on_poweroff>
+ <on_reboot>restart</on_reboot>
+ <on_crash>destroy</on_crash>
+ <devices>
+ <emulator>/usr/bin/qemu</emulator>
+ <disk type='file' device='disk'>
+ <driver name='qemu' type='raw' cache='default'/>
+ <source file='/var/lib/libvirt/images/QEMUGuest1'/>
+ <target dev='hda' bus='ide'/>
+ <address type='drive' controller='0' bus='0'
unit='0'/>
+ </disk>
+ <controller type='ide' index='0'/>
+ <memballoon model='virtio'/>
+ </devices>
+</domain>
--
2.1.4
4:07 p.m.
Any comments on the test additions? Thanks!
Regards,
Jim
On 03/14/2016 04:46 PM, Jim Fehlig wrote:
Inspired by Jan's comment from another review
https://www.redhat.com/archives/libvir-list/2016-March/msg00570.html
Jim Fehlig (2):
tests: add xlconfigdata to domainschematests
tests: add schema test for default cache mode
tests/domainschemadata/default-cache-mode.xml | 26 ++++++++++++++++++++++++++
tests/domainschematest | 1 +
2 files changed, 27 insertions(+)
create mode 100644 tests/domainschemadata/default-cache-mode.xml
6:56 a.m.
On Mon, Mar 14, 2016 at 04:46:29PM -0600, Jim Fehlig wrote:
Inspired by Jan's comment from another review
https://www.redhat.com/archives/libvir-list/2016-March/msg00570.html
Jim Fehlig (2):
tests: add xlconfigdata to domainschematests
tests: add schema test for default cache mode
tests/domainschemadata/default-cache-mode.xml | 26 ++++++++++++++++++++++++++
tests/domainschematest | 1 +
2 files changed, 27 insertions(+)
create mode 100644 tests/domainschemadata/default-cache-mode.xml
ACK series
Jan
10:10 a.m.
On 03/17/2016 05:56 AM, Ján Tomko wrote:
On Mon, Mar 14, 2016 at 04:46:29PM -0600, Jim Fehlig wrote:
> Inspired by Jan's comment from another review
>
> https://www.redhat.com/archives/libvir-list/2016-March/msg00570.html
>
> Jim Fehlig (2):
> tests: add xlconfigdata to domainschematests
> tests: add schema test for default cache mode
>
> tests/domainschemadata/default-cache-mode.xml | 26 ++++++++++++++++++++++++++
> tests/domainschematest | 1 +
> 2 files changed, 27 insertions(+)
> create mode 100644 tests/domainschemadata/default-cache-mode.xml
ACK series
Thanks, pushed.
Sorry to ask, but while I have your ear can you peek at a small series I've had
on the list for quite some time
https://www.redhat.com/archives/libvir-list/2016-March/msg00001.html
Joao has already {Reviewed,Tested}-by the series, but it would be nice to have
another set of eyes review the small schema addition.
Thanks a lot for your time!
Regards,
Jim
3173
days inactive
3177
days old
5 comments
2 participants
participants (2)
-
Jim Fehlig -
Ján Tomko