[libvirt] [PATCH] logrotate: don't rotate zero-length logfiles only
- First Post
- Replies
- Stats
-
Go to
- ----- 2024 -----
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2008 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2007 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2006 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2005 -----
- December
Hi.
In logrotate configuration files used by libvirt, there is an option
'minsize 100k',
which prevents logrotate from rotating small (< 100k) files into an archive.
But the target goal of the
http://www.mail-archive.com/libvir-list@redhat.com/msg17443.html
patch was to prevent logrotate from packing _empty_ files. This indeed could
be done more
accurately with the 'notifempty' option, see attached patch.
Attachments:
- libvirt-logrotate-notifempty.patch (text/x-patch — 943 bytes)
- attachment.html (text/html — 536 bytes)
On 04/18/2010 10:15 AM, Anton Protopopov wrote:
Hi.
In logrotate configuration files used by libvirt, there is an option
'minsize 100k',
which prevents logrotate from rotating small (< 100k) files into an archive.
But the target goal of the
http://www.mail-archive.com/libvir-list@redhat.com/msg17443.html
patch was to prevent logrotate from packing _empty_ files. This indeed could
be done more
accurately with the 'notifempty' option, see attached patch.
Is there any technical advantage to replacing 'minsize 100k' with
'notifempty'? That is, if the elapsed time has expired, and there is
data, but not yet 100k of data, am I correct that minsize would prevent
the rotation while notifempty would allow it?
I'm thinking this is a patch in the right direction, but am hoping
someone else will chime in since I don't have much personal experience
with logrotate.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
5330
days inactive
5332
days old
1 comments
2 participants
tags (0)
participants (2)
-
Anton Protopopov -
Eric Blake